This is an archive of the discontinued LLVM Phabricator instance.

DWARF v5: fix directory index in the line table
ClosedPublic

Authored by MaskRay on Apr 29 2019, 1:31 AM.

Diff Detail

Event Timeline

MaskRay created this revision.Apr 29 2019, 1:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 29 2019, 1:31 AM
labath accepted this revision.May 5 2019, 11:46 PM

I believe the changes here are correct. What I find unfortunate is that it is not able to test this without including a debug_info info section in the object file. Which is a bit ironic given that the purpose of these changes in DWARF5 was to have a fully-standalone .debug_line section.

This revision is now accepted and ready to land.May 5 2019, 11:46 PM

I believe the changes here are correct. What I find unfortunate is that it is not able to test this without including a debug_info info section in the object file. Which is a bit ironic given that the purpose of these changes in DWARF5 was to have a fully-standalone .debug_line section.

The .debug_info is used by llvm-symbolizer to locate the compile unit. Without it llvm-symbolizer doesn't bother reading .debug_line...

This revision was automatically updated to reflect the committed changes.

I believe the changes here are correct. What I find unfortunate is that it is not able to test this without including a debug_info info section in the object file. Which is a bit ironic given that the purpose of these changes in DWARF5 was to have a fully-standalone .debug_line section.

The .debug_info is used by llvm-symbolizer to locate the compile unit. Without it llvm-symbolizer doesn't bother reading .debug_line...

Right - Pavel's point is that DWARFv5 line tables can/should be readable without debug_info, so it's unfortunate that llvm-symbolizer still reads debug_info when parsing a DWARFv5 line table, when it shouldn't have to.