This is an archive of the discontinued LLVM Phabricator instance.

Differential D59159

[third-party] Update pexpect to 4.6.
ClosedPublic

Authored by davide on Mar 8 2019, 2:33 PM.

Details

Reviewers
labath
jfb
serge-sans-paille
JDevlieghere
friss
Commits
rG205fd03a27dc: [third-party] Update pexpect to 4.6.
rL355967: [third-party] Update pexpect to 4.6.
rLLDB355967: [third-party] Update pexpect to 4.6.
Summary

Diff Detail

Repository
rLLDB LLDB

Event Timeline

davide created this revision.Mar 8 2019, 2:33 PM
Herald added a reviewer: jfb. · View Herald TranscriptMar 8 2019, 2:33 PM
Herald added a reviewer: serge-sans-paille. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, jdoerfert, jfb and 4 others. · View Herald Transcript
Harbormaster completed remote builds in B28949: Diff 189940.Mar 8 2019, 2:34 PM
Herald added a subscriber: ormris. · View Herald TranscriptMar 8 2019, 2:34 PM
davide retitled this revision from [testsuite] Recommit the TestTerminal directory. to [third-party] Update pexpect to 4.6..Mar 8 2019, 2:34 PM
davide edited the summary of this revision. (Show Details)
davide removed reviewers: jfb, serge-sans-paille.
davide edited subscribers, added: Restricted Project, lldb-commits; removed: javed.absar, fedor.sergeev, dexonsmith and 4 others.
Herald added a reviewer: jfb. · View Herald TranscriptMar 8 2019, 2:34 PM
Herald added a reviewer: serge-sans-paille. · View Herald Transcript
davide added reviewers: JDevlieghere, friss.Mar 8 2019, 2:36 PM
JDevlieghere requested changes to this revision.EditedMar 8 2019, 2:37 PM

I don't think we should check in the 'test' or 'example' subdirectories.

This revision now requires changes to proceed.Mar 8 2019, 2:37 PM
ormris removed a subscriber: ormris.Mar 8 2019, 2:46 PM
labath accepted this revision.Mar 11 2019, 2:02 AM

Removing the tests directory and similar sounds like a good idea, though I would be fine with leaving it in too. Apart from that, this looks good to me.

JDevlieghere added a comment.Mar 11 2019, 9:16 AM
In D59159#1424250, @labath wrote:

Removing the tests directory and similar sounds like a good idea, though I would be fine with leaving it in too. Apart from that, this looks good to me.

There's a bunch of directories, like examples and docs. I'd prefer to have the minimum checked in. All this stuff is available online, and I see very little benefit for making the history bigger and a grep returning more results.

This revision was not accepted when it landed; it landed in state Needs Revision.Mar 12 2019, 1:42 PM
Closed by commit rLLDB355967: [third-party] Update pexpect to 4.6. (authored by davide). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 12 2019, 1:42 PM

Large Diff

This large diff affects 197 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents

PathSize
third_party/
Python/
module/
pexpect-2.4/
370 lines
370 lines
31 lines
21 lines
10 lines
45 lines
doc/
103 lines
135 lines
868 lines
868 lines
examples/
72 lines
85 lines
40 lines
339 lines
762 lines
132 lines
135 lines
139 lines
33 lines
98 lines
47 lines
472 lines
222 lines
95 lines
21 lines
1322 lines
115 lines
93 lines
76 lines
57 lines
106 lines
297 lines
58 lines
98 lines
1894 lines
367 lines
349 lines
36 lines
pexpect-4.6/
11 lines
31 lines
12 lines
20 lines
6 lines
55 lines
doc/
145 lines
153 lines
api/
20 lines
18 lines
115 lines
24 lines
34 lines
26 lines
103 lines
101 lines
250 lines
63 lines
338 lines
50 lines
20 lines
190 lines
266 lines
1 line
sphinxext/
155 lines
examples/
86 lines
99 lines
766 lines
148 lines
153 lines
157 lines
57 lines
73 lines
466 lines
229 lines
116 lines
49 lines
114 lines
105 lines
106 lines
299 lines
81 lines
notes/
89 lines
50 lines
233 lines
pexpect/
351 lines
334 lines
85 lines
87 lines
16 lines
35 lines
306 lines
148 lines
188 lines
833 lines
499 lines
122 lines
157 lines
431 lines
522 lines
187 lines
5 lines
5 lines
71 lines
tests/
108 lines
8 lines
8 lines
25 lines
36 lines
5 lines
417 lines
82 lines
15 lines
41 lines
24 lines
26 lines
fakessh/
34 lines
50 lines
690 lines
52 lines
2 lines
13 lines
69 lines
platform_checks/
CSIGNALTEST/
90 lines
2 lines
77 lines
44 lines
19 lines
60 lines
35 lines
67 lines
26 lines
50 lines
41 lines
26 lines
34 lines
228 lines
70 lines
40 lines
48 lines
125 lines
45 lines
84 lines
43 lines
93 lines
602 lines
72 lines
101 lines
125 lines
108 lines
373 lines
38 lines
113 lines
14 lines
139 lines
120 lines
114 lines
37 lines
191 lines
51 lines
287 lines
270 lines
92 lines
187 lines
291 lines
60 lines
3 lines
28 lines
61 lines
7 lines
tools/
41 lines
80 lines
24 lines
212 lines
27 lines
64 lines
ptyprocess-0.6.0/
7 lines
9 lines
16 lines
15 lines
docs/
177 lines
10 lines
266 lines
images/
759 lines
53 lines
ptyprocess/
4 lines
78 lines
836 lines
71 lines
24 lines
2 lines
tests/
36 lines
74 lines
58 lines
113 lines
32 lines

Diff 190322

third_party/Python/module/pexpect-2.4/ANSI.py

third_party/Python/module/pexpect-2.4/FSM.py

third_party/Python/module/pexpect-2.4/INSTALL

third_party/Python/module/pexpect-2.4/LICENSE

third_party/Python/module/pexpect-2.4/PKG-INFO

third_party/Python/module/pexpect-2.4/README

third_party/Python/module/pexpect-2.4/doc/clean.css

third_party/Python/module/pexpect-2.4/doc/email.png

third_party/Python/module/pexpect-2.4/doc/examples.html

third_party/Python/module/pexpect-2.4/doc/index.html

third_party/Python/module/pexpect-2.4/doc/index.template.html

third_party/Python/module/pexpect-2.4/examples/README

third_party/Python/module/pexpect-2.4/examples/astat.py

third_party/Python/module/pexpect-2.4/examples/bd_client.py

third_party/Python/module/pexpect-2.4/examples/bd_serv.py

third_party/Python/module/pexpect-2.4/examples/cgishell.cgi

third_party/Python/module/pexpect-2.4/examples/chess.py

third_party/Python/module/pexpect-2.4/examples/chess2.py

third_party/Python/module/pexpect-2.4/examples/chess3.py

third_party/Python/module/pexpect-2.4/examples/df.py

third_party/Python/module/pexpect-2.4/examples/fix_cvs_files.py

third_party/Python/module/pexpect-2.4/examples/ftp.py

third_party/Python/module/pexpect-2.4/examples/hive.py

third_party/Python/module/pexpect-2.4/examples/monitor.py

third_party/Python/module/pexpect-2.4/examples/passmass.py

third_party/Python/module/pexpect-2.4/examples/python.py

third_party/Python/module/pexpect-2.4/examples/rippy.py

third_party/Python/module/pexpect-2.4/examples/script.py

third_party/Python/module/pexpect-2.4/examples/ssh_session.py

third_party/Python/module/pexpect-2.4/examples/ssh_tunnel.py

third_party/Python/module/pexpect-2.4/examples/sshls.py

third_party/Python/module/pexpect-2.4/examples/table_test.html

third_party/Python/module/pexpect-2.4/examples/topip.py

third_party/Python/module/pexpect-2.4/examples/uptime.py

third_party/Python/module/pexpect-2.4/fdpexpect.py

third_party/Python/module/pexpect-2.4/pexpect.py

third_party/Python/module/pexpect-2.4/pxssh.py

third_party/Python/module/pexpect-2.4/screen.py

third_party/Python/module/pexpect-2.4/setup.py

third_party/Python/module/pexpect-4.6/.gitignore

third_party/Python/module/pexpect-4.6/.travis.yml

third_party/Python/module/pexpect-4.6/DEVELOPERS.rst

third_party/Python/module/pexpect-4.6/LICENSE

third_party/Python/module/pexpect-4.6/MANIFEST.in

third_party/Python/module/pexpect-4.6/README.rst

third_party/Python/module/pexpect-4.6/doc/FAQ.rst

third_party/Python/module/pexpect-4.6/doc/Makefile

third_party/Python/module/pexpect-4.6/doc/api/fdpexpect.rst

third_party/Python/module/pexpect-4.6/doc/api/index.rst

third_party/Python/module/pexpect-4.6/doc/api/pexpect.rst

third_party/Python/module/pexpect-4.6/doc/api/popen_spawn.rst

third_party/Python/module/pexpect-4.6/doc/api/pxssh.rst

third_party/Python/module/pexpect-4.6/doc/api/replwrap.rst

third_party/Python/module/pexpect-4.6/doc/clean.css

third_party/Python/module/pexpect-4.6/doc/commonissues.rst

third_party/Python/module/pexpect-4.6/doc/conf.py

third_party/Python/module/pexpect-4.6/doc/examples.rst

third_party/Python/module/pexpect-4.6/doc/history.rst

third_party/Python/module/pexpect-4.6/doc/index.rst

third_party/Python/module/pexpect-4.6/doc/install.rst

third_party/Python/module/pexpect-4.6/doc/make.bat

third_party/Python/module/pexpect-4.6/doc/overview.rst

third_party/Python/module/pexpect-4.6/doc/requirements.txt

third_party/Python/module/pexpect-4.6/doc/sphinxext/github.py

third_party/Python/module/pexpect-4.6/examples/README

third_party/Python/module/pexpect-4.6/examples/astat.py

third_party/Python/module/pexpect-4.6/examples/cgishell.cgi

third_party/Python/module/pexpect-4.6/examples/chess.py

third_party/Python/module/pexpect-4.6/examples/chess2.py

third_party/Python/module/pexpect-4.6/examples/chess3.py

third_party/Python/module/pexpect-4.6/examples/df.py

third_party/Python/module/pexpect-4.6/examples/ftp.py

third_party/Python/module/pexpect-4.6/examples/hive.py

third_party/Python/module/pexpect-4.6/examples/monitor.py

third_party/Python/module/pexpect-4.6/examples/passmass.py

third_party/Python/module/pexpect-4.6/examples/python.py

third_party/Python/module/pexpect-4.6/examples/script.py

third_party/Python/module/pexpect-4.6/examples/ssh_tunnel.py

third_party/Python/module/pexpect-4.6/examples/table_test.html

third_party/Python/module/pexpect-4.6/examples/topip.py

third_party/Python/module/pexpect-4.6/examples/uptime.py

third_party/Python/module/pexpect-4.6/notes/my_forkpty.py

third_party/Python/module/pexpect-4.6/notes/notes.txt

third_party/Python/module/pexpect-4.6/notes/posixmodule.c.diff

third_party/Python/module/pexpect-4.6/pexpect/ANSI.py

third_party/Python/module/pexpect-4.6/pexpect/FSM.py

third_party/Python/module/pexpect-4.6/pexpect/__init__.py

third_party/Python/module/pexpect-4.6/pexpect/_async.py

third_party/Python/module/pexpect-4.6/pexpect/bashrc.sh

third_party/Python/module/pexpect-4.6/pexpect/exceptions.py

third_party/Python/module/pexpect-4.6/pexpect/expect.py

third_party/Python/module/pexpect-4.6/pexpect/fdpexpect.py

third_party/Python/module/pexpect-4.6/pexpect/popen_spawn.py

third_party/Python/module/pexpect-4.6/pexpect/pty_spawn.py

third_party/Python/module/pexpect-4.6/pexpect/pxssh.py

third_party/Python/module/pexpect-4.6/pexpect/replwrap.py

third_party/Python/module/pexpect-4.6/pexpect/run.py

third_party/Python/module/pexpect-4.6/pexpect/screen.py

third_party/Python/module/pexpect-4.6/pexpect/spawnbase.py

third_party/Python/module/pexpect-4.6/pexpect/utils.py

third_party/Python/module/pexpect-4.6/requirements-testing.txt

third_party/Python/module/pexpect-4.6/setup.cfg

third_party/Python/module/pexpect-4.6/setup.py

third_party/Python/module/pexpect-4.6/tests/PexpectTestCase.py

third_party/Python/module/pexpect-4.6/tests/README

third_party/Python/module/pexpect-4.6/tests/TESTDATA.txt

third_party/Python/module/pexpect-4.6/tests/__init__.py

third_party/Python/module/pexpect-4.6/tests/adhoc.py

third_party/Python/module/pexpect-4.6/tests/alarm_die.py

third_party/Python/module/pexpect-4.6/tests/bambi.vt

third_party/Python/module/pexpect-4.6/tests/depricated_test_filedescriptor.py

third_party/Python/module/pexpect-4.6/tests/echo_w_prompt.py

third_party/Python/module/pexpect-4.6/tests/echo_wait.py

third_party/Python/module/pexpect-4.6/tests/exit1.py

third_party/Python/module/pexpect-4.6/tests/exit667.c

third_party/Python/module/pexpect-4.6/tests/fakessh/ssh

third_party/Python/module/pexpect-4.6/tests/getch.py

third_party/Python/module/pexpect-4.6/tests/globe.vt

third_party/Python/module/pexpect-4.6/tests/interact.py

third_party/Python/module/pexpect-4.6/tests/list100.py

third_party/Python/module/pexpect-4.6/tests/needs_kill.py

third_party/Python/module/pexpect-4.6/tests/pexpectTest.py

third_party/Python/module/pexpect-4.6/tests/platform_checks/CSIGNALTEST/test.c

third_party/Python/module/pexpect-4.6/tests/platform_checks/README

third_party/Python/module/pexpect-4.6/tests/platform_checks/check.py

third_party/Python/module/pexpect-4.6/tests/platform_checks/check2.py

third_party/Python/module/pexpect-4.6/tests/platform_checks/check_control_terminal.py

third_party/Python/module/pexpect-4.6/tests/platform_checks/check_handler.py

third_party/Python/module/pexpect-4.6/tests/platform_checks/check_read.py

third_party/Python/module/pexpect-4.6/tests/platform_checks/check_signals.py

third_party/Python/module/pexpect-4.6/tests/qa.py

third_party/Python/module/pexpect-4.6/tests/sigwinch_report.py

third_party/Python/module/pexpect-4.6/tests/sleep_for.py

third_party/Python/module/pexpect-4.6/tests/swapcase_echo.py

third_party/Python/module/pexpect-4.6/tests/test_FSM.py

third_party/Python/module/pexpect-4.6/tests/test_ansi.py

third_party/Python/module/pexpect-4.6/tests/test_async.py

third_party/Python/module/pexpect-4.6/tests/test_command_list_split.py

third_party/Python/module/pexpect-4.6/tests/test_constructor.py

third_party/Python/module/pexpect-4.6/tests/test_ctrl_chars.py

third_party/Python/module/pexpect-4.6/tests/test_delay.py

third_party/Python/module/pexpect-4.6/tests/test_destructor.py

third_party/Python/module/pexpect-4.6/tests/test_dotall.py

third_party/Python/module/pexpect-4.6/tests/test_env.py

third_party/Python/module/pexpect-4.6/tests/test_expect.py

third_party/Python/module/pexpect-4.6/tests/test_filedescriptor.py

third_party/Python/module/pexpect-4.6/tests/test_interact.py

third_party/Python/module/pexpect-4.6/tests/test_isalive.py

third_party/Python/module/pexpect-4.6/tests/test_log.py

third_party/Python/module/pexpect-4.6/tests/test_misc.py

third_party/Python/module/pexpect-4.6/tests/test_missing_command.py

third_party/Python/module/pexpect-4.6/tests/test_performance.py

third_party/Python/module/pexpect-4.6/tests/test_pickling.py

third_party/Python/module/pexpect-4.6/tests/test_popen_spawn.py

third_party/Python/module/pexpect-4.6/tests/test_pxssh.py

third_party/Python/module/pexpect-4.6/tests/test_replwrap.py

third_party/Python/module/pexpect-4.6/tests/test_repr.py

third_party/Python/module/pexpect-4.6/tests/test_run.py

third_party/Python/module/pexpect-4.6/tests/test_run_out_of_pty.py

third_party/Python/module/pexpect-4.6/tests/test_screen.py

third_party/Python/module/pexpect-4.6/tests/test_socket.py

third_party/Python/module/pexpect-4.6/tests/test_timeout_pattern.py

third_party/Python/module/pexpect-4.6/tests/test_unicode.py

third_party/Python/module/pexpect-4.6/tests/test_which.py

third_party/Python/module/pexpect-4.6/tests/test_winsize.py

third_party/Python/module/pexpect-4.6/tests/tetris.data

third_party/Python/module/pexpect-4.6/tests/ticker.py

third_party/Python/module/pexpect-4.6/tests/torturet.vt

third_party/Python/module/pexpect-4.6/tests/utils.py

third_party/Python/module/pexpect-4.6/tools/display-fpathconf.py

third_party/Python/module/pexpect-4.6/tools/display-maxcanon.py

third_party/Python/module/pexpect-4.6/tools/display-sighandlers.py

third_party/Python/module/pexpect-4.6/tools/display-terminalinfo.py

third_party/Python/module/pexpect-4.6/tools/teamcity-coverage-report.sh

third_party/Python/module/pexpect-4.6/tools/teamcity-runtests.sh

third_party/Python/module/ptyprocess-0.6.0/.gitignore

third_party/Python/module/ptyprocess-0.6.0/.travis.yml

third_party/Python/module/ptyprocess-0.6.0/LICENSE

third_party/Python/module/ptyprocess-0.6.0/README.rst

third_party/Python/module/ptyprocess-0.6.0/docs/Makefile

third_party/Python/module/ptyprocess-0.6.0/docs/api.rst

third_party/Python/module/ptyprocess-0.6.0/docs/conf.py

third_party/Python/module/ptyprocess-0.6.0/docs/images/pty_vs_popen.png

third_party/Python/module/ptyprocess-0.6.0/docs/images/pty_vs_popen.svg

third_party/Python/module/ptyprocess-0.6.0/docs/index.rst

third_party/Python/module/ptyprocess-0.6.0/ptyprocess/__init__.py

third_party/Python/module/ptyprocess-0.6.0/ptyprocess/_fork_pty.py

third_party/Python/module/ptyprocess-0.6.0/ptyprocess/ptyprocess.py

third_party/Python/module/ptyprocess-0.6.0/ptyprocess/util.py

third_party/Python/module/ptyprocess-0.6.0/pyproject.toml

third_party/Python/module/ptyprocess-0.6.0/readthedocs.yml

third_party/Python/module/ptyprocess-0.6.0/tests/__init__.py

third_party/Python/module/ptyprocess-0.6.0/tests/test_echo.py

third_party/Python/module/ptyprocess-0.6.0/tests/test_invalid_binary.py

third_party/Python/module/ptyprocess-0.6.0/tests/test_preexec_fn.py

third_party/Python/module/ptyprocess-0.6.0/tests/test_spawn.py

third_party/Python/module/ptyprocess-0.6.0/tests/test_wait.py