This is an archive of the discontinued LLVM Phabricator instance.

Differential D57911

[LLDB] Remove all abandoned LLDB bots
ClosedPublic

Authored by rnk on Feb 7 2019, 10:27 AM.

Details

Reviewers
gkistanova
labath
serge-sans-paille
stella.stamenova
srhines
zturner
Commits
rZORG6da42ff38cf7: [LLDB] Remove all abandoned LLDB bots
rL357721: [LLDB] Remove all abandoned LLDB bots
Summary

All of these bots have been broken for months -- in some cases years. Removing them from the waterfall.

Diff Detail

Event Timeline

zturner created this revision.Feb 7 2019, 10:27 AM
Herald added a reviewer: serge-sans-paille. · View Herald TranscriptFeb 7 2019, 10:27 AM
Herald added a subscriber: srhines. · View Herald Transcript
stella.stamenova accepted this revision.Feb 7 2019, 10:36 AM

There's another patch (https://reviews.llvm.org/D54386/) which is fixing the fedora bot. You might want to leave that one.

This revision is now accepted and ready to land.Feb 7 2019, 10:36 AM
jankratochvil added a subscriber: jankratochvil.Feb 7 2019, 10:50 AM
zturner updated this revision to Diff 185864.Feb 7 2019, 1:50 PM

I added the Fedora bot back and rebased this on top of Jan's patch from D54386.

srhines accepted this revision.Feb 7 2019, 3:44 PM

LGTM for removing the broken Android builders.

labath accepted this revision.Feb 8 2019, 1:56 AM
labath added a comment.Apr 1 2019, 4:42 AM

Zach, what's the status of this? I'm getting ready to add a new lldb bot, and it would be nice to remove the old ones first..

Herald added a subscriber: jdoerfert. · View Herald TranscriptApr 1 2019, 4:42 AM
zturner updated this revision to Diff 193582.Apr 3 2019, 1:23 PM

Rebased

stella.stamenova requested changes to this revision.Apr 3 2019, 1:37 PM
stella.stamenova added inline comments.
buildbot/osuosl/master/master.cfg
185

I think this means you can remove LLDBTriggerable.py as well

191

The lldb_scheduler should stay. @labath suggested that maybe it doesn't have to because the getSingleBranchSchedulers should cover the LLDB builders, but not all the LLDB builders are setup with depends_on_projects properties, so for some of them, getSingleBranchSchedulers will not work properly. You just need to update the builderNames list for the lldb_scheduler to no longer exclude the now-nonexistent lldb_android_builders

This revision now requires changes to proceed.Apr 3 2019, 1:37 PM
zturner updated this revision to Diff 193613.Apr 3 2019, 3:42 PM

Add the scheduler back but remove the android builder only.

zturner updated this revision to Diff 193614.Apr 3 2019, 3:44 PM

Also remove LLDBTriggerable.py

Herald added a subscriber: javed.absar. · View Herald TranscriptApr 3 2019, 3:44 PM
stella.stamenova accepted this revision.Apr 3 2019, 3:50 PM

Thanks!

This revision is now accepted and ready to land.Apr 3 2019, 3:50 PM
labath accepted this revision.Apr 4 2019, 1:51 AM
gkistanova accepted this revision.Apr 4 2019, 1:11 PM

Thanks for cleaning this!

rnk commandeered this revision.Apr 4 2019, 1:26 PM
rnk added a reviewer: zturner.
rnk added a subscriber: rnk.

Landing this for @zturner since he's busy with other tasks.

Closed by commit rL357721: [LLDB] Remove all abandoned LLDB bots (authored by rnk). · Explain WhyApr 4 2019, 1:28 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2019, 1:28 PM

Revision Contents

PathSize
buildbot/
osuosl/
master/
config/
61 lines
13 lines
14 lines
18 lines

Diff 185864

buildbot/osuosl/master/config/builders.py

Show First 20 Lines • Show All 931 Lines • ▼ Show 20 Lines return [
"-DLLVM_ENABLE_LIBCXX:BOOL=ON", "-DLLVM_ENABLE_LIBCXX:BOOL=ON",
"-DCMAKE_C_COMPILER:FILEPATH=/local/clang+llvm-6.0.1-x86_64-linux-gnu-ubuntu-14.04/bin/clang", "-DCMAKE_C_COMPILER:FILEPATH=/local/clang+llvm-6.0.1-x86_64-linux-gnu-ubuntu-14.04/bin/clang",
"-DCMAKE_CXX_COMPILER:FILEPATH=/local/clang+llvm-6.0.1-x86_64-linux-gnu-ubuntu-14.04/bin/clang++"])} "-DCMAKE_CXX_COMPILER:FILEPATH=/local/clang+llvm-6.0.1-x86_64-linux-gnu-ubuntu-14.04/bin/clang++"])}
] ]
# LLDB builders. # LLDB builders.
def _get_lldb_builders(): def _get_lldb_builders():
return [ return [
{'name': "lldb-x86-windows-msvc2015",
'slavenames': ["zturner-win2008"],
'builddir': "lldb-windows-x86",
'factory': LLDBBuilder.getLLDBCMakeBuildFactory(
test=False,
python_source_dir=r'C:/Python35',
vs=r"""%VS140COMNTOOLS%""")},
# Disable the builder till we fix the cmake configuration
#{'name': "lldb-x86-win7-msvc",
#'slavenames': ["hexagon-build-01"],
#'builddir': "builddir/lldb-win7-msvc",
#'factory': LLDBBuilder.getLLDBCMakeBuildFactory(
# config='Debug',
# python_source_dir=r'C:/Python35',
# vs=r"""%VS140COMNTOOLS%""")},
{'name': "lldb-x86_64-ubuntu-14.04-buildserver",
'slavenames': ["lldb-linux-android-buildserver"],
'builddir': "lldb-android-buildserver",
'category' : 'lldb',
'factory': LLDBBuilder.getLLDBScriptCommandsFactory(
downloadBinary=False,
buildAndroid=True,
runTest=False,
extra_cmake_args=['-DLLVM_ENABLE_ASSERTIONS=ON'])},
{'name': "lldb-x86_64-ubuntu-14.04-cmake",
'slavenames': ["lldb-build1-ubuntu-1404"],
'builddir': "buildWorkingDir",
'category' : 'lldb',
'factory': LLDBBuilder.getLLDBScriptCommandsFactory(
downloadBinary=False,
buildAndroid=False,
runTest=True,
extra_cmake_args=['-DLLVM_ENABLE_ASSERTIONS=ON'])},
{'name': "lldb-amd64-ninja-netbsd8", {'name': "lldb-amd64-ninja-netbsd8",
'slavenames': ["lldb-amd64-ninja-netbsd8"], 'slavenames': ["lldb-amd64-ninja-netbsd8"],
'builddir': "netbsd8", 'builddir': "netbsd8",
'category' : 'lldb', 'category' : 'lldb',
'factory': LLDBBuilder.getLLDBScriptCommandsFactory( 'factory': LLDBBuilder.getLLDBScriptCommandsFactory(
downloadBinary=False, downloadBinary=False,
runTest=True)}, runTest=True)},
{'name': "lldb-amd64-ninja-freebsd11", {'name': "lldb-amd64-ninja-freebsd11",
▲ Show 20 Lines • Show All 601 Lines • ▼ Show 20 Lines return [
gpu_devices=["GPU-af66efa4", # K40c(sm_35), gpu_devices=["GPU-af66efa4", # K40c(sm_35),
"GPU-44fe2444" # GTX1070(sm_61) "GPU-44fe2444" # GTX1070(sm_61)
], ],
cuda_jobs = 4, # Speeds up test execution time by ~2x. cuda_jobs = 4, # Speeds up test execution time by ~2x.
extra_ts_cmake_args=[], extra_ts_cmake_args=[],
enable_thrust_tests=False, enable_thrust_tests=False,
), ),
'category' : 'clang'}, 'category' : 'clang'},
# lldb builders
{'name': "lldb-x86_64-darwin-13.4",
'slavenames': ["lldb-x86_64-darwin-13.4"],
'builddir': "buildDir",
'category' : 'lldb',
'factory': LLDBBuilder.getLLDBScriptCommandsFactory(
downloadBinary=True,
buildAndroid=False,
runTest=True)},
{'name': "lldb-x86_64-ubuntu-14.04-android",
'slavenames': ["lldb-lab-linux01"],
'builddir': "lldb-cross-compile",
'category' : 'lldb',
'factory': LLDBBuilder.getLLDBScriptCommandsFactory(
downloadBinary=True,
buildAndroid=False,
runTest=True)},
{'name': "lldb-windows7-android",
'slavenames': ["lldb-lab-win01"],
'builddir': "lldb-win7-android",
'category': "lldb",
'factory': LLDBBuilder.getLLDBScriptCommandsFactory(
downloadBinary=True,
buildAndroid=False,
runTest=True,
scriptExt='.bat')},
] ]
# Builders responsible building Sphinix documentation # Builders responsible building Sphinix documentation
def _get_documentation_builders(): def _get_documentation_builders():
return [ return [
{ {
'name':"llvm-sphinx-docs", 'name':"llvm-sphinx-docs",
'slavenames':["gribozavr3"], 'slavenames':["gribozavr3"],
▲ Show 20 Lines • Show All 113 Lines • Show Last 20 Lines

buildbot/osuosl/master/config/slaves.py

Show First 20 Lines • Show All 183 Lines • ▼ Show 20 Lines return [
# Debian 9, Docker based build. See libcxx/utils/docker. # Debian 9, Docker based build. See libcxx/utils/docker.
create_slave('libcxx-cloud1', properties={'jobs': 64}, max_builds=1), create_slave('libcxx-cloud1', properties={'jobs': 64}, max_builds=1),
create_slave('libcxx-cloud2', properties={'jobs': 64}, max_builds=1), create_slave('libcxx-cloud2', properties={'jobs': 64}, max_builds=1),
create_slave('libcxx-cloud3', properties={'jobs': 64}, max_builds=1), create_slave('libcxx-cloud3', properties={'jobs': 64}, max_builds=1),
create_slave('libcxx-cloud4', properties={'jobs': 64}, max_builds=1), create_slave('libcxx-cloud4', properties={'jobs': 64}, max_builds=1),
create_slave('libcxx-cloud5', properties={'jobs': 64}, max_builds=1), create_slave('libcxx-cloud5', properties={'jobs': 64}, max_builds=1),
# Windows Server 2008 R2, Quad 2.6GHz Intel Xeon(R) 4GB RAM
create_slave("zturner-win2008", properties={'jobs': 4}, max_builds=1),
# Windows Server 2012 x86_64 16-core GCE instance # Windows Server 2012 x86_64 16-core GCE instance
create_slave("sanitizer-windows", properties={'jobs': 16}, max_builds=1), create_slave("sanitizer-windows", properties={'jobs': 16}, max_builds=1),
create_slave("windows-gcebot1", properties={'jobs': 8}, max_builds=1), create_slave("windows-gcebot1", properties={'jobs': 8}, max_builds=1),
# Windows Server 2012 x86_64 32-core GCE instance # Windows Server 2012 x86_64 32-core GCE instance
create_slave("windows-gcebot2", properties={'jobs': 32}, max_builds=1), create_slave("windows-gcebot2", properties={'jobs': 32}, max_builds=1),
# Windows Server 2016 x86_64 16-core GCE instance # Windows Server 2016 x86_64 16-core GCE instance
create_slave("windows-lld-thinlto-1", max_builds=1), create_slave("windows-lld-thinlto-1", max_builds=1),
# Ubuntu x86-64, 51GiB System memory Intel(R) Xeon(R) CPU @ 2.60GHz
create_slave("lldb-build1-ubuntu-1404", properties={'jobs': 32, 'loadaverage':32}, max_builds=1),
# Darwin 13.4.0, x86_64
create_slave("lldb-x86_64-darwin-13.4", properties={'jobs': 16, 'loadaverage':32}, max_builds=1),
# Ubuntu 14.04 x86_64, Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz
create_slave("lldb-lab-linux01", properties={'jobs': 40}, max_builds=1),
# Windows 7 x86_64
create_slave("lldb-lab-win01", properties={'jobs': 40}, max_builds=1),
# Ubuntu 14.04 x86_64
create_slave("lldb-linux-android-buildserver", properties={'jobs': 40}, max_builds=1),
# Ubuntu 14.04 x86_64, Intel(R) Xeon(R) CPU L5520 @ 2.27GHz # Ubuntu 14.04 x86_64, Intel(R) Xeon(R) CPU L5520 @ 2.27GHz
create_slave("bpf-build-slave01", properties={'jobs': 16}, max_builds=1), create_slave("bpf-build-slave01", properties={'jobs': 16}, max_builds=1),
# Ubuntu 14.04 x86_64-scei-ps4, 2 x Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz # Ubuntu 14.04 x86_64-scei-ps4, 2 x Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz
create_slave("ps4-buildslave1"), create_slave("ps4-buildslave1"),
create_slave("ps4-buildslave1a", properties={'jobs': 64}, max_builds=2), create_slave("ps4-buildslave1a", properties={'jobs': 64}, max_builds=2),
# Windows 10 Pro x86_64-scei-ps4, 2 x Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz # Windows 10 Pro x86_64-scei-ps4, 2 x Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz
▲ Show 20 Lines • Show All 214 Lines • Show Last 20 Lines

buildbot/osuosl/master/config/status.py

Show First 20 Lines • Show All 139 Lines • ▼ Show 20 Lines return [
subject="Build %(builder)s Failure", subject="Build %(builder)s Failure",
mode = "failing", mode = "failing",
builders = ["llgo-x86_64-linux"], builders = ["llgo-x86_64-linux"],
addLogs=False, addLogs=False,
num_lines = 15), num_lines = 15),
InformativeMailNotifier( InformativeMailNotifier(
fromaddr = "llvm.buildmaster@lab.llvm.org", fromaddr = "llvm.buildmaster@lab.llvm.org",
sendToInterestedUsers= False, sendToInterestedUsers= False,
extraRecipients = ["lldb-build-police-gmt@grotations.appspotmail.com",
"lldb-build-police-pst@grotations.appspotmail.com"],
subject="Build %(builder)s Failure",
mode = "failing",
builders = ["lldb-x86_64-ubuntu-14.04-cmake",
"lldb-x86_64-ubuntu-14.04-buildserver",
"lldb-windows7-android",
"lldb-x86_64-darwin-13.4",
"lldb-x86_64-ubuntu-14.04-android"],
addLogs=False,
num_lines = 15),
InformativeMailNotifier(
fromaddr = "llvm.buildmaster@lab.llvm.org",
sendToInterestedUsers= False,
extraRecipients = ["sunil_srivastava@playstation.sony.com", extraRecipients = ["sunil_srivastava@playstation.sony.com",
"warren_ristow@playstation.sony.com"], "warren_ristow@playstation.sony.com"],
subject="Build %(builder)s Failure", subject="Build %(builder)s Failure",
mode = "failing", mode = "failing",
builders = ["clang-x86_64-linux-abi-test"], builders = ["clang-x86_64-linux-abi-test"],
addLogs=False, addLogs=False,
num_lines = 15), num_lines = 15),
InformativeMailNotifier( InformativeMailNotifier(
▲ Show 20 Lines • Show All 114 Lines • Show Last 20 Lines

buildbot/osuosl/master/master.cfg

Show First 20 Lines • Show All 172 Lines • ▼ Show 20 Lines
# All other lld builders use auto-generated schedulers. # All other lld builders use auto-generated schedulers.
c['schedulers'].append(SingleBranchScheduler(name="lld_scheduler", c['schedulers'].append(SingleBranchScheduler(name="lld_scheduler",
treeStableTimer=2*60, treeStableTimer=2*60,
builderNames=["lld-sphinx-docs"], builderNames=["lld-sphinx-docs"],
change_filter=depends_on([ change_filter=depends_on([
"llvm", "llvm",
"lld"]))) "lld"])))
# lldb android builders will be triggered by completion of buildserver instead of by source change
lldb_android_builders=["lldb-x86_64-ubuntu-14.04-android",
"lldb-windows7-android",
"lldb-x86_64-darwin-13.4"]
from zorg.buildbot.schedulers.LLDBTriggerable import LLDBTriggerable
stella.stamenovaUnsubmitted
Not Done
ReplyInline Actions

I think this means you can remove LLDBTriggerable.py as well

stella.stamenova: I think this means you can remove LLDBTriggerable.py as well
c['schedulers'].append((LLDBTriggerable(
projects=['lldb', 'cfe', 'llvm'],
name="lldb_android_scheduler",
builderNames=lldb_android_builders)))
c['schedulers'].append(SingleBranchScheduler(name="lldb_scheduler",
stella.stamenovaUnsubmitted
Not Done
ReplyInline Actions

The lldb_scheduler should stay. @labath suggested that maybe it doesn't have to because the getSingleBranchSchedulers should cover the LLDB builders, but not all the LLDB builders are setup with depends_on_projects properties, so for some of them, getSingleBranchSchedulers will not work properly. You just need to update the builderNames list for the lldb_scheduler to no longer exclude the now-nonexistent lldb_android_builders

stella.stamenova: The lldb_scheduler should stay. @labath suggested that maybe it doesn't have to because the…
treeStableTimer=2*60,
builderNames=list(set(get_all_for("lldb"))-set(lldb_android_builders)),
change_filter=depends_on([
"llvm",
"cfe",
"lldb"])))
c['schedulers'].append(SingleBranchScheduler(name="sanitizer_scheduler", c['schedulers'].append(SingleBranchScheduler(name="sanitizer_scheduler",
treeStableTimer=2*60, treeStableTimer=2*60,
builderNames=get_all_for("sanitizer"), builderNames=get_all_for("sanitizer"),
change_filter=depends_on([ change_filter=depends_on([
"llvm", "llvm",
"cfe", "cfe",
"compiler-rt", "compiler-rt",
"libcxx", "libcxx",
▲ Show 20 Lines • Show All 52 Lines • Show Last 20 Lines