zturner (Zachary Turner)
User

Projects

User does not belong to any projects.
User Since
May 26 2014, 12:49 PM (147 w, 5 d)

Recent Activity

Wed, Mar 22

zturner committed rL298561: Delete some more dead includes..
Delete some more dead includes.
Wed, Mar 22, 4:46 PM
zturner added inline comments to D31267: [codeview] Move type index remapping logic to type merger.
Wed, Mar 22, 4:40 PM
zturner accepted D31267: [codeview] Move type index remapping logic to type merger.
Wed, Mar 22, 4:33 PM
zturner added a comment to D31263: Add option to control whether llvm-pdbdump outputs in color.

I think we need something before you commit, because as it is people will be specifying --color-output unnecessarily. Even if you say "default = on" or "default = best-effort"

Wed, Mar 22, 3:31 PM
zturner accepted D31263: Add option to control whether llvm-pdbdump outputs in color.
Wed, Mar 22, 2:58 PM
zturner accepted D30930: [clang-tidy-vs] Visual Studio plugin extended.

It's hard for me to review on correctness since I'm not familiar with these APIs (and I don't think anyone else is either) but from a functionality standpoint I think these are great changes and I don't see anything glaringly wrong, so lgtm unless someone else has objections.

Wed, Mar 22, 2:33 PM
zturner committed rL298541: Remove dead include from GoASTContext.cpp..
Remove dead include from GoASTContext.cpp.
Wed, Mar 22, 12:36 PM
zturner committed rL298536: Move FileSpec from Host -> Utility..
Move FileSpec from Host -> Utility.
Wed, Mar 22, 11:53 AM
zturner committed rL298535: [analyze deps] Show incoming and outgoing counts on island members..
[analyze deps] Show incoming and outgoing counts on island members.
Wed, Mar 22, 11:35 AM
zturner committed rL298530: [analyze deps] Also show cycle islands..
[analyze deps] Also show cycle islands.
Wed, Mar 22, 11:16 AM
zturner committed rL298526: Resubmit "Delete the remainder of platform specific code in FileSpec.".
Resubmit "Delete the remainder of platform specific code in FileSpec."
Wed, Mar 22, 10:45 AM
zturner committed rL298519: Delete TestLLVM.py.
Delete TestLLVM.py
Wed, Mar 22, 10:20 AM
zturner added a comment to D31246: Send ANSI color codes only to TTYs.

But we use this to send color codes to temporary files that capture output for build systems and such when -fcolor-diagnostics is explicitly provided? (As an example...)

Wed, Mar 22, 10:06 AM
zturner committed rL298514: Make the home_directory test a little more resilient..
Make the home_directory test a little more resilient.
Wed, Mar 22, 9:42 AM
zturner committed rL298513: Make home_directory look in the password database in addition to $HOME..
Make home_directory look in the password database in addition to $HOME.
Wed, Mar 22, 8:37 AM

Tue, Mar 21

zturner committed rL298466: Break the cycle between Host and PluginProcessUtility..
Break the cycle between Host and PluginProcessUtility.
Tue, Mar 21, 5:40 PM
zturner committed rL298465: Delete the remainder of platform specific code in FileSpec..
Delete the remainder of platform specific code in FileSpec.
Tue, Mar 21, 5:39 PM
zturner closed D31129: Remove remaining platform specific code from FileSpec by committing rL298465: Delete the remainder of platform specific code in FileSpec..
Tue, Mar 21, 5:39 PM
zturner committed rL298461: Resubmit "Improve StringMap iterator support.".
Resubmit "Improve StringMap iterator support."
Tue, Mar 21, 4:57 PM
zturner committed rL298455: [deps script] Sort cycles by the difficulty of breaking..
[deps script] Sort cycles by the difficulty of breaking.
Tue, Mar 21, 3:59 PM
zturner committed rL298440: Revert "Improve StringMap iterator support.".
Revert "Improve StringMap iterator support."
Tue, Mar 21, 2:36 PM
zturner committed rL298437: Fix clang errors caused by StringMap iterator changes..
Fix clang errors caused by StringMap iterator changes.
Tue, Mar 21, 1:54 PM
zturner committed rL298436: Improve StringMap iterator support..
Improve StringMap iterator support.
Tue, Mar 21, 1:40 PM
zturner closed D31171: Improve StringMap iterator support. by committing rL298436: Improve StringMap iterator support..
Tue, Mar 21, 1:40 PM
zturner committed rL298435: Remove eol-style:native from StringMap.h.
Remove eol-style:native from StringMap.h
Tue, Mar 21, 1:34 PM
zturner committed rL298427: [ADT] Add a version of llvm::join() that takes a range..
[ADT] Add a version of llvm::join() that takes a range.
Tue, Mar 21, 12:47 PM
zturner committed rL298419: Fix build broken by StringList move..
Fix build broken by StringList move.
Tue, Mar 21, 11:58 AM
zturner committed rL298415: Delete eol-style:native SVN property..
Delete eol-style:native SVN property.
Tue, Mar 21, 11:43 AM
zturner committed rL298412: Move StringList from Core -> Utility..
Move StringList from Core -> Utility.
Tue, Mar 21, 11:37 AM
zturner added inline comments to D31171: Improve StringMap iterator support..
Tue, Mar 21, 10:29 AM
zturner added a comment to D31172: Move stop info override callback code from ArchSpec into Process.

The architecture help change snuck in, I already removed it locally but didn't re-upload.

Tue, Mar 21, 10:25 AM
zturner updated the diff for D31171: Improve StringMap iterator support..
  1. Fixed issue with returning by value from operator*.
  2. Moved the test from Support to ADT, since there was already an existing StringMapTest class there that I hadn't noticed.
  3. Removed the join changes that had snuck in. I'll commit those separately.
Tue, Mar 21, 10:13 AM
zturner added inline comments to D31171: Improve StringMap iterator support..
Tue, Mar 21, 8:13 AM

Mon, Mar 20

zturner created D31172: Move stop info override callback code from ArchSpec into Process.
Mon, Mar 20, 11:51 PM
zturner committed rL298340: Resubmit r298334 after fixing OSX build errors..
Resubmit r298334 after fixing OSX build errors.
Mon, Mar 20, 11:00 PM
zturner created D31171: Improve StringMap iterator support..
Mon, Mar 20, 10:47 PM
zturner abandoned D31170: Improve StringMap iterator support.

Forgot to add llvm-commits, will need to re-create

Mon, Mar 20, 10:46 PM
zturner created D31170: Improve StringMap iterator support.
Mon, Mar 20, 10:46 PM
zturner committed rL298335: Delete some dead code in HostInfo..
Delete some dead code in HostInfo.
Mon, Mar 20, 9:14 PM
zturner committed rL298334: Delete various lldb FileSystem functions..
Delete various lldb FileSystem functions.
Mon, Mar 20, 9:13 PM
zturner closed D31111: Delete various FileSystem functions that are either dead or have direct LLVM equivalents. by committing rL298334: Delete various lldb FileSystem functions..
Mon, Mar 20, 9:13 PM
zturner committed rL298326: [Support] Fill the file_status struct with link count..
[Support] Fill the file_status struct with link count.
Mon, Mar 20, 5:07 PM
zturner closed D31110: [FileSystem] Make file_status store link count and add a file_status::getLinkCount() method. by committing rL298326: [Support] Fill the file_status struct with link count..
Mon, Mar 20, 5:07 PM
zturner committed rL298325: Delete LLDB's MD5 code. Use LLVM instead..
Delete LLDB's MD5 code. Use LLVM instead.
Mon, Mar 20, 5:07 PM
zturner closed D31108: Delete LLDB code for MD5'ing a file. Use LLVM instead by committing rL298325: Delete LLDB's MD5 code. Use LLVM instead..
Mon, Mar 20, 5:07 PM
zturner committed rL298324: [analyze-project-deps.py] Add the ability to list all cycles..
[analyze-project-deps.py] Add the ability to list all cycles.
Mon, Mar 20, 5:06 PM
zturner committed rL298322: Add a function to MD5 a file's contents..
Add a function to MD5 a file's contents.
Mon, Mar 20, 4:45 PM
zturner closed D31105: [Support] Add a function to MD5 a file's contents. by committing rL298322: Add a function to MD5 a file's contents..
Mon, Mar 20, 4:45 PM
zturner added a comment to D31105: [Support] Add a function to MD5 a file's contents..

How does it compare to the SHA1 API? Are these in sync? (If not any good reason they're not?)

Mon, Mar 20, 4:11 PM
zturner added a comment to D31105: [Support] Add a function to MD5 a file's contents..

ping

Mon, Mar 20, 4:02 PM
zturner committed rL298294: Explicitly add move constructor/assignment operators..
Explicitly add move constructor/assignment operators.
Mon, Mar 20, 1:09 PM
zturner updated the diff for D31129: Remove remaining platform specific code from FileSpec.

See what you think about this. I've created a folder called Mocks under Utility, and created a new target out of it. UtilityTests links against it, and so does InterpreterTests. To do this I had to add the lldb project root as an include directory, this way you can write #include "unittests/Utility/Mocks/MockTildeExpressionResolver.h". Another possibility would be to create lldb/unittests/Mocks/Mocks/Utility, and then add lldb/unittests/Mocks as an include folder. This way you could write #include "Mocks/Utility/MockTildeExpressionResolver.h". I don't have a strong preference either way.

Mon, Mar 20, 1:06 PM

Sun, Mar 19

zturner updated the diff for D31129: Remove remaining platform specific code from FileSpec.

Turns out ResolveUsername was only being called from one place outside of FileSpec and ResolvePartialUsername was dead code (since callers had already been updated to use TildeExpressionResolver. So I just deleted these two functions and replaced the calls to ResolveUsername with calls directly into TildeExpressionResolver.

Sun, Mar 19, 10:49 AM
zturner created D31129: Remove remaining platform specific code from FileSpec.
Sun, Mar 19, 10:22 AM

Sat, Mar 18

zturner committed rL298206: Fix syntax error when building with editline support..
Fix syntax error when building with editline support.
Sat, Mar 18, 11:12 PM
zturner committed rL298205: Remove FileSystem::Get/SetFilePermissions.
Remove FileSystem::Get/SetFilePermissions
Sat, Mar 18, 11:02 PM
zturner closed D31089: Remove FileSystem::GetFilePermissions and FileSystem::SetFilePermissions by committing rL298205: Remove FileSystem::Get/SetFilePermissions.
Sat, Mar 18, 11:02 PM
zturner committed rL298203: Remove FileSystem::MakeDirectory..
Remove FileSystem::MakeDirectory.
Sat, Mar 18, 11:01 PM
zturner closed D31086: Remove FileSystem::MakeDirectory by committing rL298203: Remove FileSystem::MakeDirectory..
Sat, Mar 18, 11:01 PM
zturner committed rL298202: Fix unit test compilation failure..
Fix unit test compilation failure.
Sat, Mar 18, 11:00 PM

Fri, Mar 17

zturner updated the diff for D31111: Delete various FileSystem functions that are either dead or have direct LLVM equivalents..

Forgot to remove Stat declaration from header file.

Fri, Mar 17, 5:14 PM
zturner created D31111: Delete various FileSystem functions that are either dead or have direct LLVM equivalents..
Fri, Mar 17, 5:09 PM
zturner created D31110: [FileSystem] Make file_status store link count and add a file_status::getLinkCount() method..
Fri, Mar 17, 5:08 PM
zturner created D31108: Delete LLDB code for MD5'ing a file. Use LLVM instead.
Fri, Mar 17, 4:15 PM
zturner created D31105: [Support] Add a function to MD5 a file's contents..
Fri, Mar 17, 2:18 PM
zturner added inline comments to D31089: Remove FileSystem::GetFilePermissions and FileSystem::SetFilePermissions .
Fri, Mar 17, 12:52 PM
zturner added inline comments to D31089: Remove FileSystem::GetFilePermissions and FileSystem::SetFilePermissions .
Fri, Mar 17, 12:47 PM
zturner added a comment to D31086: Remove FileSystem::MakeDirectory.

That one is calling a file static function MakeDirectory, not FileSystem::MakeDirectory, and the implementation of that function already calls llvm::sys::fs::create_directories() to create the whole tree, so it should be fine.

Fri, Mar 17, 12:37 PM
zturner created D31089: Remove FileSystem::GetFilePermissions and FileSystem::SetFilePermissions .
Fri, Mar 17, 10:48 AM
zturner abandoned D31088: Remove FileSystem::GetFilePermissions and SetFilePermissions.

Messed up reviewer / subscriber.

Fri, Mar 17, 10:44 AM
zturner created D31088: Remove FileSystem::GetFilePermissions and SetFilePermissions.
Fri, Mar 17, 10:44 AM
zturner created D31086: Remove FileSystem::MakeDirectory.
Fri, Mar 17, 10:28 AM
zturner accepted D31079: Replace std::ofstream with llvm::raw_fd_ostream.

In the places where you want to read from an ifstream and write to a socket, you might consider using llvm::sys::fs::copy_file, declared in Support/FileSystem.h. Currently it takes two paths, but all it does is call openFileForRead() on the first one and openFileForWrite() on the second one to get FDs. So you could probably add an overload that takes two FDs, and have the path version just call the FD version. Then you could call the FD version directly with an FD for your file and an FD for your socket.

Fri, Mar 17, 9:49 AM
zturner committed rL298100: CMake requires normalized paths when appending..
CMake requires normalized paths when appending.
Fri, Mar 17, 9:46 AM
zturner closed D30927: Normalize the LLVM cmake path before appending it to the module path by committing rL298100: CMake requires normalized paths when appending..
Fri, Mar 17, 9:45 AM · Restricted Project
zturner committed rL298099: Fix some signed/unsigned comparison warnings..
Fix some signed/unsigned comparison warnings.
Fri, Mar 17, 9:45 AM
zturner closed D30926: Fix MSVC signed/unsigned conversion and size_t conversion warnings in LLDB by committing rL298099: Fix some signed/unsigned comparison warnings..
Fri, Mar 17, 9:44 AM
zturner committed rL298098: [clang-cl] Fix cross-compilation with MSVC 2017..
[clang-cl] Fix cross-compilation with MSVC 2017.
Fri, Mar 17, 9:36 AM
zturner closed D30991: [Driver] Fix cross compiling with Visual Studio 2017 by committing rL298098: [clang-cl] Fix cross-compilation with MSVC 2017..
Fri, Mar 17, 9:36 AM

Thu, Mar 16

zturner committed rL298026: Revert "Make NativeExeSymbol a concrete subclass of NativeRawSymbol [PDB]".
Revert "Make NativeExeSymbol a concrete subclass of NativeRawSymbol [PDB]"
Thu, Mar 16, 5:59 PM
zturner committed rL298019: SmallString doesn't have implicit conversion from const char*..
SmallString doesn't have implicit conversion from const char*.
Thu, Mar 16, 5:40 PM
zturner committed rL298018: Don't rely on an implicit std::tuple constructor..
Don't rely on an implicit std::tuple constructor.
Thu, Mar 16, 5:28 PM
zturner committed rL298017: [pdb] Fix an uninitialized read, and add a test for it..
[pdb] Fix an uninitialized read, and add a test for it.
Thu, Mar 16, 5:28 PM
zturner committed rL298016: [PDB] It is not an error getting the "Invalid" Annotation opcode..
[PDB] It is not an error getting the "Invalid" Annotation opcode.
Thu, Mar 16, 5:27 PM
zturner created D31061: [pdb] Fix an uninitialized read, and add a test for it..
Thu, Mar 16, 5:10 PM
zturner committed rL298014: Fix unit test..
Fix unit test.
Thu, Mar 16, 4:31 PM
zturner added inline comments to D30959: [pdb] Add support for writing Module Info and module symbols.
Thu, Mar 16, 4:30 PM
zturner committed rL298007: Fix linux build..
Fix linux build.
Thu, Mar 16, 3:46 PM
zturner committed rL298004: [Support] Support both Windows and Posix paths on both platforms..
[Support] Support both Windows and Posix paths on both platforms.
Thu, Mar 16, 3:40 PM
zturner closed D30858: Teach llvm's path library to support both windows and posix paths at the same time. by committing rL298004: [Support] Support both Windows and Posix paths on both platforms..
Thu, Mar 16, 3:40 PM
zturner committed rL298002: Remove eol-style:native from Path.h.
Remove eol-style:native from Path.h
Thu, Mar 16, 3:36 PM
zturner accepted D31059: Make NativeExeSymbol a concrete subclass of NativeRawSymbol [PDB].
Thu, Mar 16, 3:24 PM
zturner accepted D30991: [Driver] Fix cross compiling with Visual Studio 2017.

lgtm, do you have commit access?

Thu, Mar 16, 2:23 PM
zturner committed rL297990: Silence -Wcovered-switch-default warning..
Silence -Wcovered-switch-default warning.
Thu, Mar 16, 1:57 PM
zturner committed rL297984: [PDB] Add support for parsing Flags from PDB Stream..
[PDB] Add support for parsing Flags from PDB Stream.
Thu, Mar 16, 1:31 PM
zturner committed rL297983: [llvm-pdbdump] Add support for diffing the PDB Stream..
[llvm-pdbdump] Add support for diffing the PDB Stream.
Thu, Mar 16, 1:30 PM
zturner committed rL297977: [llvm-pdbdump] clang-format Diff.cpp.
[llvm-pdbdump] clang-format Diff.cpp
Thu, Mar 16, 1:04 PM
zturner added a comment to D30991: [Driver] Fix cross compiling with Visual Studio 2017.

Looks good with one more suggested fix.

Thu, Mar 16, 11:44 AM
zturner added a comment to D30991: [Driver] Fix cross compiling with Visual Studio 2017.

When you say "cross-compiling", you mean targeting Windows while running on non-Windows, right? How do dlls get loaded there at all?

Also, when does clang invoke link.exe? Normally on Windows the linker is invoked directly, no through the compiler driver. Are you using clang.exe instead of clang-cl.exe?

I think he means "targeting x86 using an x64 toolchain", but yes, some clarification would be helpful. Also, which DLLs (specifically) are we talking about?

Thu, Mar 16, 11:19 AM
zturner added a comment to D30991: [Driver] Fix cross compiling with Visual Studio 2017.

When you say "cross-compiling", you mean targeting Windows while running on non-Windows, right? How do dlls get loaded there at all?

Also, when does clang invoke link.exe? Normally on Windows the linker is invoked directly, no through the compiler driver. Are you using clang.exe instead of clang-cl.exe?

Thu, Mar 16, 11:08 AM