zturner (Zachary Turner)
User

Projects

User does not belong to any projects.
User Since
May 26 2014, 12:49 PM (151 w, 5 d)

Recent Activity

Fri, Apr 21

zturner committed rL301038: Add a dependency from llvm/test to llvm-cvtres..
Add a dependency from llvm/test to llvm-cvtres.
Fri, Apr 21, 1:58 PM
zturner committed rL301033: Fixed a type conversion error in BitVector..
Fixed a type conversion error in BitVector.
Fri, Apr 21, 1:31 PM
zturner committed rL301031: [BitVector] Make BitVector store an ArrayRef..
[BitVector] Make BitVector store an ArrayRef.
Fri, Apr 21, 1:25 PM
zturner closed D32367: [BitVector] Hold the underlying storage as a MutableArrayRef. by committing rL301031: [BitVector] Make BitVector store an ArrayRef..
Fri, Apr 21, 1:25 PM
zturner created D32367: [BitVector] Hold the underlying storage as a MutableArrayRef..
Fri, Apr 21, 12:00 PM
zturner committed rL301014: [BitVector] Add find_last() and find_last_unset()..
[BitVector] Add find_last() and find_last_unset().
Fri, Apr 21, 11:20 AM
zturner closed D32302: [BitVector] Add find_last() and find_last_unset() by committing rL301014: [BitVector] Add find_last() and find_last_unset()..
Fri, Apr 21, 11:20 AM
zturner committed rL301006: Add llvm-cvtres to LLVMBuild.txt.
Add llvm-cvtres to LLVMBuild.txt
Fri, Apr 21, 10:50 AM
zturner committed rL301004: Add empty shell of llvm-cvtres..
Add empty shell of llvm-cvtres.
Fri, Apr 21, 10:43 AM
zturner closed D32095: Make empty shell of new cvtres tool. by committing rL301004: Add empty shell of llvm-cvtres..
Fri, Apr 21, 10:43 AM
zturner updated the diff for D32302: [BitVector] Add find_last() and find_last_unset().

Fix an inverted conditional / break statement.

Fri, Apr 21, 9:56 AM
zturner updated the diff for D32302: [BitVector] Add find_last() and find_last_unset().

Updated based on feedback from chandlerc.

Fri, Apr 21, 9:53 AM

Thu, Apr 20

zturner created D32302: [BitVector] Add find_last() and find_last_unset().
Thu, Apr 20, 10:53 AM
zturner committed rL300857: Resubmit "[BitVector] Add operator<<= and operator>>=.".
Resubmit "[BitVector] Add operator<<= and operator>>=."
Thu, Apr 20, 10:09 AM
zturner committed rL300852: Revert "[BitVector] Add operator<<= and operator>>=.".
Revert "[BitVector] Add operator<<= and operator>>=."
Thu, Apr 20, 9:52 AM
zturner committed rL300848: [BitVector] Add operator<<= and operator>>=..
[BitVector] Add operator<<= and operator>>=.
Thu, Apr 20, 9:16 AM
zturner closed D32244: [BitVector] Add << and >> operators by committing rL300848: [BitVector] Add operator<<= and operator>>=..
Thu, Apr 20, 9:15 AM
zturner added inline comments to D32244: [BitVector] Add << and >> operators.
Thu, Apr 20, 9:01 AM

Wed, Apr 19

zturner updated the diff for D32244: [BitVector] Add << and >> operators.

Reduced indentation level a little bit.

Wed, Apr 19, 4:04 PM
zturner updated the diff for D32244: [BitVector] Add << and >> operators.

Deleted some miscellaneous functions in MathExtras.h that I ended up not using, and added some comments to the implementation to clarify a few minor points.

Wed, Apr 19, 4:00 PM
zturner added inline comments to D32244: [BitVector] Add << and >> operators.
Wed, Apr 19, 3:43 PM
zturner added inline comments to D32244: [BitVector] Add << and >> operators.
Wed, Apr 19, 2:50 PM
zturner created D32244: [BitVector] Add << and >> operators.
Wed, Apr 19, 2:31 PM
zturner accepted D32095: Make empty shell of new cvtres tool..

lgtm, I can commit it for you later today.

Wed, Apr 19, 1:11 PM
zturner committed rL300711: Add an #include for <climits> for CHAR_BIT..
Add an #include for <climits> for CHAR_BIT.
Wed, Apr 19, 9:03 AM
zturner committed rL300710: [Support] Add some helpers to generate bitmasks..
[Support] Add some helpers to generate bitmasks.
Wed, Apr 19, 8:58 AM
zturner closed D32212: Create some helpers for generating bit masks by committing rL300710: [Support] Add some helpers to generate bitmasks..
Wed, Apr 19, 8:58 AM
zturner committed rL300709: Remove eol-style:native from MathExtras.h.
Remove eol-style:native from MathExtras.h
Wed, Apr 19, 8:56 AM
zturner accepted D32148: [Utility/StringLexer] Remove dead code..

No need to request review when removing dead code.

Wed, Apr 19, 8:43 AM
zturner added a comment to D32095: Make empty shell of new cvtres tool..

Did you run clang-format on the CL? (It looks clang-formatted to me, just want to make sure)

Wed, Apr 19, 8:43 AM

Tue, Apr 18

zturner created D32212: Create some helpers for generating bit masks.
Tue, Apr 18, 8:49 PM
zturner added a comment to D32095: Make empty shell of new cvtres tool..

Can you make the test run llvm-cvtres.exe /? and then have a FileCheck line that matches the first line of help text?

Tue, Apr 18, 2:57 PM

Fri, Apr 14

zturner committed rL300386: Fix crash when completing in the current directory..
Fix crash when completing in the current directory.
Fri, Apr 14, 7:57 PM

Thu, Apr 13

zturner committed rL300258: [llvm-pdbdump] Recursively dump class layout..
[llvm-pdbdump] Recursively dump class layout.
Thu, Apr 13, 2:23 PM

Wed, Apr 12

zturner committed rL300163: Remove some unused private fields..
Remove some unused private fields.
Wed, Apr 12, 7:41 PM
zturner committed rL300137: Fix initialization order of class members..
Fix initialization order of class members.
Wed, Apr 12, 4:40 PM
zturner committed rL300134: [llvm-pdbdump] Minor prepatory refactor of Class Def Dumper..
[llvm-pdbdump] Minor prepatory refactor of Class Def Dumper.
Wed, Apr 12, 4:31 PM
zturner committed rL300133: [llvm-pdbdump] More advanced class definition dumping..
[llvm-pdbdump] More advanced class definition dumping.
Wed, Apr 12, 4:31 PM
zturner committed rL300098: [Support] Add support for unique_ptr<> to Casting.h..
[Support] Add support for unique_ptr<> to Casting.h.
Wed, Apr 12, 1:12 PM
zturner closed D31890: Add support for unique_ptr<T> to dyn_cast<> by committing rL300098: [Support] Add support for unique_ptr<> to Casting.h..
Wed, Apr 12, 1:12 PM
zturner committed rL300096: Remove svnprop eol-style:native from Casting.h.
Remove svnprop eol-style:native from Casting.h
Wed, Apr 12, 1:05 PM

Tue, Apr 11

zturner added inline comments to D31823: Update LLDB Host to support IPv6 over TCP.
Tue, Apr 11, 10:52 PM
zturner added a comment to D31969: [CMake] Support generating Config.h.

How much would it complicate things to move the hand maintained files out of tree? If the Xcode build isn't really a thing we're officially supporting, perhaps we can take that aggressive approach in-tree as well?

Tue, Apr 11, 7:01 PM
zturner added a comment to D31410: llvm-lto2: Move the LTO::run() action behind a subcommand..

I guess what I mean is, if you just want to import every single top level option into the "run" subcommand, and the tool only works when the run subcommand is given (looking at the source code it just prints usage and exits if there is no run subcommand) why is the run subcommand even necessary? Isn't it equivalent to just not even having a subcommand and running llvm-lto2 -lto-use-new-pm ...?

Tue, Apr 11, 11:47 AM
zturner added a comment to D31410: llvm-lto2: Move the LTO::run() action behind a subcommand..

So currently if you were to run llvm-lto2 -help would you already see all the subcommands you want to import? It sounds like yes. If so, what's the difference between llvm-lto2 -lto-use-new-pm and llvm-lto2 run -lto-use-new-pm? Is there some reason you need to import them all rather than just use the existing top-level options?

Tue, Apr 11, 11:33 AM
zturner added a comment to D31410: llvm-lto2: Move the LTO::run() action behind a subcommand..

Actually perhaps better would be to make cl::redefine just another modifier. Maybe call it cl::template_opt or something. This way you would write:

Tue, Apr 11, 9:45 AM
zturner added a comment to D31410: llvm-lto2: Move the LTO::run() action behind a subcommand..

So if I understand correctly, these are existing options that are defined in some library somewhere, and you want to be able to use them in a subcommand of your own creation? Yea unfortunately I never considered that use case.

Tue, Apr 11, 9:41 AM
zturner accepted D31822: [NFC] Adding a new wrapper for getaddrinfo.
Tue, Apr 11, 9:11 AM
zturner accepted D31636: [PDB] Emit index/offset pairs for TPI and IPI streams.
Tue, Apr 11, 9:07 AM
zturner added a comment to D31823: Update LLDB Host to support IPv6 over TCP.

Networking isn't my area of domain expertise, so these are mostly just general comments.

Tue, Apr 11, 9:04 AM

Mon, Apr 10

zturner created D31917: Add unique_dyn_cast.
Mon, Apr 10, 5:56 PM
zturner updated the diff for D31890: Add support for unique_ptr<T> to dyn_cast<>.

Updated this so that isa<B>(const unique_ptr<A>&) works. Will commit tomorrow afternoon if nobody has objections.

Mon, Apr 10, 5:15 PM
zturner updated the diff for D31890: Add support for unique_ptr<T> to dyn_cast<>.

Discussed this with rsmith@ some, and we came to the conclusion that it's actually the other way around. We should support this only for cast, and not for dyn_cast. The reason being that you would need to declare the function as dyn_cast(unique_ptr<T> &&Value), and so to invoke it you would need to write dyn_cast<To>(std::move(From)). So even though you're writing this as an unconditional move, it's actually a conditional move, because if it's not actually convertible to To then you would want to return nullptr and leave the source unchanged. The code would still work, but it would just be confusing because std::move(From) sometimes doesn't actually move anything.

Mon, Apr 10, 2:53 PM
zturner committed rL299873: Fix signed / unsigned comparison warnings..
Fix signed / unsigned comparison warnings.
Mon, Apr 10, 1:14 PM
zturner committed rL299869: [llvm-pdbdump] Display padding bytes on record layout.
[llvm-pdbdump] Display padding bytes on record layout
Mon, Apr 10, 12:46 PM
zturner closed D31800: [llvm-pdbdump] Display padding bytes on record layout by committing rL299869: [llvm-pdbdump] Display padding bytes on record layout.
Mon, Apr 10, 12:46 PM
zturner committed rL299857: [Support] Add support for finding unset bits in a BitVector..
[Support] Add support for finding unset bits in a BitVector.
Mon, Apr 10, 10:31 AM
zturner closed D31802: Add methods to find the next *unset* bits in a bit vector by committing rL299857: [Support] Add support for finding unset bits in a BitVector..
Mon, Apr 10, 10:31 AM
zturner committed rL299856: Fix line endings..
Fix line endings.
Mon, Apr 10, 10:29 AM
zturner committed rL299855: Remove eol-style:native from BitVector.h.
Remove eol-style:native from BitVector.h
Mon, Apr 10, 10:27 AM
zturner created D31890: Add support for unique_ptr<T> to dyn_cast<>.
Mon, Apr 10, 10:14 AM
zturner accepted D31832: Improves pretty printing of variable types in llvm-pdbdump.

lgtm, only some minor nits.

Mon, Apr 10, 9:05 AM

Sun, Apr 9

zturner committed rL299832: Remove unused method..
Remove unused method.
Sun, Apr 9, 11:43 PM
zturner committed rL299831: General usability improvements to generic PDB library..
General usability improvements to generic PDB library.
Sun, Apr 9, 11:27 PM
zturner updated the diff for D31802: Add methods to find the next *unset* bits in a bit vector.

Factored the return statement into a small helper function.

Sun, Apr 9, 10:48 AM

Sat, Apr 8

zturner added inline comments to D31802: Add methods to find the next *unset* bits in a bit vector.
Sat, Apr 8, 9:23 PM
zturner updated the diff for D31802: Add methods to find the next *unset* bits in a bit vector.

Fixed an issue where find_first_unset() was returning BV.size() if all bits were set, and added a unit test for that case.

Sat, Apr 8, 9:15 PM

Thu, Apr 6

zturner updated the diff for D31800: [llvm-pdbdump] Display padding bytes on record layout.

Use a better method for detecting padding. This is less error prone and more efficient. It also allows us to analyze the padding one time up front, which allows us to filter record display based on whether or not the record has padding (e.g. only dump those records that have padding).

Thu, Apr 6, 10:33 PM
zturner created D31802: Add methods to find the next *unset* bits in a bit vector.
Thu, Apr 6, 9:29 PM
zturner created D31800: [llvm-pdbdump] Display padding bytes on record layout.
Thu, Apr 6, 6:42 PM
zturner added inline comments to D31636: [PDB] Emit index/offset pairs for TPI and IPI streams.
Thu, Apr 6, 5:22 PM
zturner committed rL299733: Allow specification of what kinds of class members to dump..
Allow specification of what kinds of class members to dump.
Thu, Apr 6, 4:56 PM
zturner closed D31794: Allow specification of what kinds of class members to dump by committing rL299733: Allow specification of what kinds of class members to dump..
Thu, Apr 6, 4:56 PM
zturner committed rL299732: [llvm-pdbdump] Allow pretty to only dump specific types of types..
[llvm-pdbdump] Allow pretty to only dump specific types of types.
Thu, Apr 6, 4:55 PM
zturner closed D31791: Allow llvm-pdbdump pretty mode to only dump certain types of types by committing rL299732: [llvm-pdbdump] Allow pretty to only dump specific types of types..
Thu, Apr 6, 4:55 PM
zturner updated the diff for D31794: Allow specification of what kinds of class members to dump.

Slightly better logic in layout mode. It was dumping constants and static members before which don't occupy any space in a record.

Thu, Apr 6, 4:41 PM
zturner created D31794: Allow specification of what kinds of class members to dump.
Thu, Apr 6, 4:09 PM
zturner committed rL299719: Try to fix FreeBSD build after IWYU changes..
Try to fix FreeBSD build after IWYU changes.
Thu, Apr 6, 3:31 PM
zturner created D31791: Allow llvm-pdbdump pretty mode to only dump certain types of types.
Thu, Apr 6, 3:18 PM
zturner committed rL299718: Fix build failure in unit test..
Fix build failure in unit test.
Thu, Apr 6, 3:10 PM
zturner committed rL299714: iwyu fixes for lldbCore..
iwyu fixes for lldbCore.
Thu, Apr 6, 2:41 PM
zturner committed rL299705: Try to fix FreeBSD build after iwyu changes..
Try to fix FreeBSD build after iwyu changes.
Thu, Apr 6, 2:04 PM
zturner committed rL299676: iwyu fixes on lldbUtility..
iwyu fixes on lldbUtility.
Thu, Apr 6, 11:25 AM
zturner added reviewers for D31696: Automatically add include-what-you-use for when building in tree: beanz, rnk, chandlerc.

Not really sure who to add as a reviewer here, so + a few random people.

Thu, Apr 6, 11:14 AM

Tue, Apr 4

zturner created D31697: Check for null before using TUScope.
Tue, Apr 4, 8:49 PM
zturner created D31696: Automatically add include-what-you-use for when building in tree.
Tue, Apr 4, 7:11 PM

Mon, Apr 3

zturner added a comment to D31636: [PDB] Emit index/offset pairs for TPI and IPI streams.

The 8KB thing is interesting, because sometimes it's not actually every 8KB. I don't know how important it is though, since it should just change the efficiency of the log(N) search. Run llvm-pdbdump analyze on a large PDB and then paste the results into Spreadsheets and compute differences to see what I mean.

Mon, Apr 3, 7:49 PM

Mar 22 2017

zturner committed rL298561: Delete some more dead includes..
Delete some more dead includes.
Mar 22 2017, 4:46 PM
zturner added inline comments to D31267: [codeview] Move type index remapping logic to type merger.
Mar 22 2017, 4:40 PM
zturner accepted D31267: [codeview] Move type index remapping logic to type merger.
Mar 22 2017, 4:33 PM
zturner added a comment to D31263: Add option to control whether llvm-pdbdump outputs in color.

I think we need something before you commit, because as it is people will be specifying --color-output unnecessarily. Even if you say "default = on" or "default = best-effort"

Mar 22 2017, 3:31 PM
zturner accepted D31263: Add option to control whether llvm-pdbdump outputs in color.
Mar 22 2017, 2:58 PM
zturner accepted D30930: [clang-tidy-vs] Visual Studio plugin extended.

It's hard for me to review on correctness since I'm not familiar with these APIs (and I don't think anyone else is either) but from a functionality standpoint I think these are great changes and I don't see anything glaringly wrong, so lgtm unless someone else has objections.

Mar 22 2017, 2:33 PM
zturner committed rL298541: Remove dead include from GoASTContext.cpp..
Remove dead include from GoASTContext.cpp.
Mar 22 2017, 12:36 PM
zturner committed rL298536: Move FileSpec from Host -> Utility..
Move FileSpec from Host -> Utility.
Mar 22 2017, 11:53 AM
zturner committed rL298535: [analyze deps] Show incoming and outgoing counts on island members..
[analyze deps] Show incoming and outgoing counts on island members.
Mar 22 2017, 11:35 AM
zturner committed rL298530: [analyze deps] Also show cycle islands..
[analyze deps] Also show cycle islands.
Mar 22 2017, 11:16 AM
zturner committed rL298526: Resubmit "Delete the remainder of platform specific code in FileSpec.".
Resubmit "Delete the remainder of platform specific code in FileSpec."
Mar 22 2017, 10:45 AM
zturner committed rL298519: Delete TestLLVM.py.
Delete TestLLVM.py
Mar 22 2017, 10:20 AM
zturner added a comment to D31246: Send ANSI color codes only to TTYs.

But we use this to send color codes to temporary files that capture output for build systems and such when -fcolor-diagnostics is explicitly provided? (As an example...)

Mar 22 2017, 10:06 AM