This is an archive of the discontinued LLVM Phabricator instance.

[clang-tidy] fix unit tests for dropped _Float16 support in X86
ClosedPublic

Authored by JonasToth on Jan 25 2019, 10:50 AM.

Event Timeline

JonasToth created this revision.Jan 25 2019, 10:50 AM
erichkeane accepted this revision.Jan 25 2019, 10:52 AM

LGTM, thanks for doing this!

This revision is now accepted and ready to land.Jan 25 2019, 10:52 AM
lebedev.ri added inline comments.Jan 25 2019, 10:52 AM
test/clang-tidy/readability-uppercase-literal-suffix-float16.cpp
3

Targets can be disabled in cmake
This needs something like // REQUIRES: aarch64.
And yes, the tests that hardcoded x86 should require x86 too.

  • add REQUIRES: <arch> for the readability unit-tests where necessary
  • Revert "add REQUIRES: <arch> for the readability unit-tests where necessary" as its not necessary because only the frontend is run
JonasToth marked an inline comment as done.
  • last nit, remove the disabled in hexadecimal
This revision was automatically updated to reflect the committed changes.

@JonasToth @erichkeane thank you for taking care of this.