This is an archive of the discontinued LLVM Phabricator instance.

[FileSystem] Move resolve logic out of FileSpec
ClosedPublic

Authored by JDevlieghere on Oct 30 2018, 5:24 PM.

Details

Diff Detail

Event Timeline

JDevlieghere created this revision.Oct 30 2018, 5:24 PM
labath accepted this revision.Oct 31 2018, 11:49 PM
This revision is now accepted and ready to land.Oct 31 2018, 11:49 PM
This revision was automatically updated to reflect the committed changes.

This commit breaks the Windows build.

It's ok, I was able to fix it myself. Here is the commit: r345956

Some of the file spec changes caused a bunch of failures on Windows. We know have a silent Buildbot that you can see the failures on as well:

http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/1128/steps/test/logs/stdio

Let me know if you need anything else. Once all the tests are green again we're going to make the Buildbot no longer silent, so this should be easier to catch.