Page MenuHomePhabricator

aleksandr.urakov (Aleksandr Urakov)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 4 2018, 3:35 AM (37 w, 2 d)

Recent Activity

Tue, Feb 12

aleksandr.urakov committed rGeaa0ad672e39: [NativePDB] Process virtual bases in the correct order (authored by aleksandr.urakov).
[NativePDB] Process virtual bases in the correct order
Tue, Feb 12, 12:19 AM
aleksandr.urakov committed rL353806: [NativePDB] Process virtual bases in the correct order.
[NativePDB] Process virtual bases in the correct order
Tue, Feb 12, 12:17 AM
aleksandr.urakov committed rLLDB353806: [NativePDB] Process virtual bases in the correct order.
[NativePDB] Process virtual bases in the correct order
Tue, Feb 12, 12:17 AM
aleksandr.urakov closed D56904: [NativePDB] Process virtual bases in the correct order.
Tue, Feb 12, 12:17 AM · Restricted Project

Mon, Feb 11

aleksandr.urakov added a comment to D56904: [NativePDB] Process virtual bases in the correct order.

Thanks for the help with the tests, it looks like they are ok now! So can we proceed with this patch?

Mon, Feb 11, 7:19 AM · Restricted Project
aleksandr.urakov committed rGeac19858e92f: [build.py] Add `-fms-compatibility-version=19` to `build.py` (authored by aleksandr.urakov).
[build.py] Add `-fms-compatibility-version=19` to `build.py`
Mon, Feb 11, 7:15 AM
aleksandr.urakov committed rLLDB353709: [build.py] Add `-fms-compatibility-version=19` to `build.py`.
[build.py] Add `-fms-compatibility-version=19` to `build.py`
Mon, Feb 11, 7:15 AM
aleksandr.urakov committed rL353709: [build.py] Add `-fms-compatibility-version=19` to `build.py`.
[build.py] Add `-fms-compatibility-version=19` to `build.py`
Mon, Feb 11, 7:15 AM
aleksandr.urakov closed D57809: [build.py] Add `VCINSTALLDIR` to default variables.
Mon, Feb 11, 7:15 AM · Restricted Project, Restricted Project
aleksandr.urakov added a comment to D57809: [build.py] Add `VCINSTALLDIR` to default variables.

Zachary, can you take a look? please?

Mon, Feb 11, 12:11 AM · Restricted Project, Restricted Project

Fri, Feb 8

aleksandr.urakov added a comment to D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME.

Fixed in r353503, thanks!

Fri, Feb 8, 12:51 AM · Restricted Project, Restricted Project
aleksandr.urakov committed rGee21a66a7b80: [NFC] Fix license headers after r352845 (authored by aleksandr.urakov).
[NFC] Fix license headers after r352845
Fri, Feb 8, 12:49 AM
aleksandr.urakov committed rL353503: [NFC] Fix license headers after r352845.
[NFC] Fix license headers after r352845
Fri, Feb 8, 12:48 AM
aleksandr.urakov committed rLLDB353503: [NFC] Fix license headers after r352845.
[NFC] Fix license headers after r352845
Fri, Feb 8, 12:48 AM

Wed, Feb 6

aleksandr.urakov updated the diff for D57809: [build.py] Add `VCINSTALLDIR` to default variables.

I've checked your solution, and it's worked for me too! I think that your solution is better because it is more straight-forward. Here is the updated patch.

Wed, Feb 6, 4:47 AM · Restricted Project, Restricted Project
aleksandr.urakov created D57809: [build.py] Add `VCINSTALLDIR` to default variables.
Wed, Feb 6, 1:07 AM · Restricted Project, Restricted Project
aleksandr.urakov committed rG823c66b617bf: [x64] Process the B field of the REX prefix correctly for the PUSH and POP… (authored by aleksandr.urakov).
[x64] Process the B field of the REX prefix correctly for the PUSH and POP…
Wed, Feb 6, 12:49 AM
aleksandr.urakov committed rL353281: [x64] Process the B field of the REX prefix correctly for the PUSH and POP.
[x64] Process the B field of the REX prefix correctly for the PUSH and POP
Wed, Feb 6, 12:48 AM
aleksandr.urakov committed rLLDB353281: [x64] Process the B field of the REX prefix correctly for the PUSH and POP.
[x64] Process the B field of the REX prefix correctly for the PUSH and POP
Wed, Feb 6, 12:48 AM
aleksandr.urakov closed D57745: [x64] Process the B field of the REX prefix correctly for the PUSH and POP instructions.
Wed, Feb 6, 12:48 AM · Restricted Project
aleksandr.urakov added a comment to D57745: [x64] Process the B field of the REX prefix correctly for the PUSH and POP instructions.

Thanks all for the review!

Wed, Feb 6, 12:46 AM · Restricted Project
aleksandr.urakov updated the diff for D57745: [x64] Process the B field of the REX prefix correctly for the PUSH and POP instructions.

Yes, sure, sorry about this, I occasionally have forgot to update the prefixes...

Wed, Feb 6, 12:45 AM · Restricted Project

Tue, Feb 5

aleksandr.urakov updated the diff for D57745: [x64] Process the B field of the REX prefix correctly for the PUSH and POP instructions.

Yes, you are right, thank you! I've updated the patch.

Tue, Feb 5, 6:25 AM · Restricted Project
aleksandr.urakov created D57745: [x64] Process the B field of the REX prefix correctly for the PUSH and POP instructions.
Tue, Feb 5, 4:28 AM · Restricted Project
aleksandr.urakov accepted D57742: [Expressions] Fix -Wreorder warning from r353149.

Oh, sorry for this, there was even no warning about that on my system. Thanks for catching that!

Tue, Feb 5, 3:32 AM · Restricted Project
aleksandr.urakov added a comment to D56904: [NativePDB] Process virtual bases in the correct order.

Thanks for the reply! It seems that after your hint I've figured it out. It's the environment variable VCINSTALLDIR. I've added it to the defaultenv list of the _get_visual_studio_environment function and the test passes now. What do you think about this solution?

Tue, Feb 5, 2:34 AM · Restricted Project
aleksandr.urakov added a comment to D55318: [Expressions] Add support of expressions evaluation in some object's context.

Thank you! I've updated the comments in the commit.

Tue, Feb 5, 1:15 AM · Restricted Project, Restricted Project
aleksandr.urakov committed rG40624a085c03: [Expressions] Add support of expressions evaluation in some object's context (authored by aleksandr.urakov).
[Expressions] Add support of expressions evaluation in some object's context
Tue, Feb 5, 1:15 AM
aleksandr.urakov committed rLLDB353149: [Expressions] Add support of expressions evaluation in some object's context.
[Expressions] Add support of expressions evaluation in some object's context
Tue, Feb 5, 1:15 AM
aleksandr.urakov committed rL353149: [Expressions] Add support of expressions evaluation in some object's context.
[Expressions] Add support of expressions evaluation in some object's context
Tue, Feb 5, 1:14 AM
aleksandr.urakov closed D55318: [Expressions] Add support of expressions evaluation in some object's context.
Tue, Feb 5, 1:14 AM · Restricted Project, Restricted Project

Mon, Feb 4

aleksandr.urakov added a comment to D56904: [NativePDB] Process virtual bases in the correct order.

Ping! What do you think about it?

Mon, Feb 4, 7:09 AM · Restricted Project
aleksandr.urakov added a comment to D55318: [Expressions] Add support of expressions evaluation in some object's context.

Ping! Can you take a look, please?

Mon, Feb 4, 7:09 AM · Restricted Project, Restricted Project

Fri, Feb 1

aleksandr.urakov committed rL352858: [PDB] Fix build after r352845.
[PDB] Fix build after r352845
Fri, Feb 1, 3:10 AM
aleksandr.urakov committed rLLDB352858: [PDB] Fix build after r352845.
[PDB] Fix build after r352845
Fri, Feb 1, 3:10 AM
aleksandr.urakov committed rLLDB352845: [PDB] Fix location retrieval for function local variables and arguments that are.
[PDB] Fix location retrieval for function local variables and arguments that are
Fri, Feb 1, 2:02 AM
aleksandr.urakov committed rL352845: [PDB] Fix location retrieval for function local variables and arguments that are.
[PDB] Fix location retrieval for function local variables and arguments that are
Fri, Feb 1, 2:01 AM
aleksandr.urakov closed D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME.
Fri, Feb 1, 2:01 AM · Restricted Project, Restricted Project

Wed, Jan 30

aleksandr.urakov committed rL352615: [NativePDB] Fix access to both old & new fpo data entries from dbi stream.
[NativePDB] Fix access to both old & new fpo data entries from dbi stream
Wed, Jan 30, 2:42 AM
aleksandr.urakov closed D56725: [NativePDB] Fix access to both old & new fpo data entries from dbi stream.
Wed, Jan 30, 2:42 AM

Tue, Jan 29

aleksandr.urakov added inline comments to D56904: [NativePDB] Process virtual bases in the correct order.
Tue, Jan 29, 5:16 AM · Restricted Project
aleksandr.urakov updated the diff for D56904: [NativePDB] Process virtual bases in the correct order.

Thanks for the comments, I think that they make sense. I've updated the patch.

Tue, Jan 29, 4:53 AM · Restricted Project
aleksandr.urakov committed rLLDB352478: [NativePDB] Fix lldb-x64-windows-ninja after r352464.
[NativePDB] Fix lldb-x64-windows-ninja after r352464
Tue, Jan 29, 2:46 AM
aleksandr.urakov committed rL352478: [NativePDB] Fix lldb-x64-windows-ninja after r352464.
[NativePDB] Fix lldb-x64-windows-ninja after r352464
Tue, Jan 29, 2:46 AM
aleksandr.urakov committed rLLDB352464: [NativePDB] Add basic support of methods recostruction in AST.
[NativePDB] Add basic support of methods recostruction in AST
Tue, Jan 29, 1:32 AM
aleksandr.urakov committed rL352464: [NativePDB] Add basic support of methods recostruction in AST.
[NativePDB] Add basic support of methods recostruction in AST
Tue, Jan 29, 1:32 AM
aleksandr.urakov closed D56126: [NativePDB] Add basic support of methods recostruction in AST.
Tue, Jan 29, 1:32 AM · Restricted Project
aleksandr.urakov added a comment to D56126: [NativePDB] Add basic support of methods recostruction in AST.

Thank you!

Tue, Jan 29, 1:31 AM · Restricted Project

Mon, Jan 28

aleksandr.urakov added a comment to D56126: [NativePDB] Add basic support of methods recostruction in AST.

Ping! Can you take a look, please?

Mon, Jan 28, 3:25 AM · Restricted Project
aleksandr.urakov added a comment to D56904: [NativePDB] Process virtual bases in the correct order.

Ping! Can you take a look, please?

Mon, Jan 28, 3:25 AM · Restricted Project
aleksandr.urakov updated the diff for D55318: [Expressions] Add support of expressions evaluation in some object's context.

Sorry for the long delay with reply. My colleague with a Mac (and Obj-C knowledge) have created the test for the Obj-C case. Can you take a look, please?

Mon, Jan 28, 3:22 AM · Restricted Project, Restricted Project

Jan 18 2019

aleksandr.urakov added inline comments to D56904: [NativePDB] Process virtual bases in the correct order.
Jan 18 2019, 2:58 AM · Restricted Project
aleksandr.urakov created D56904: [NativePDB] Process virtual bases in the correct order.
Jan 18 2019, 2:56 AM · Restricted Project

Jan 16 2019

aleksandr.urakov added a comment to D56725: [NativePDB] Fix access to both old & new fpo data entries from dbi stream.

LGTM except the comment. Let's also wait for what Zachary will say.

Jan 16 2019, 4:11 AM

Jan 14 2019

aleksandr.urakov updated the diff for D56126: [NativePDB] Add basic support of methods recostruction in AST.

@zturner Sorry for the long delay with this update. I've applied the changes we were talking about.

Jan 14 2019, 5:32 AM · Restricted Project
aleksandr.urakov committed rLLDB351065: [Core] Use the implementation method GetAddressOf in ValueObjectConstResultChild.
[Core] Use the implementation method GetAddressOf in ValueObjectConstResultChild
Jan 14 2019, 5:12 AM
aleksandr.urakov committed rL351065: [Core] Use the implementation method GetAddressOf in ValueObjectConstResultChild.
[Core] Use the implementation method GetAddressOf in ValueObjectConstResultChild
Jan 14 2019, 5:12 AM
aleksandr.urakov closed D56147: [Core] Use the implementation method `GetAddressOf` in `ValueObjectConstResultChild`.
Jan 14 2019, 5:12 AM · Restricted Project
Herald added a reviewer for D56147: [Core] Use the implementation method `GetAddressOf` in `ValueObjectConstResultChild`: serge-sans-paille.

Thanks!

Jan 14 2019, 5:07 AM · Restricted Project

Dec 29 2018

aleksandr.urakov added inline comments to D56126: [NativePDB] Add basic support of methods recostruction in AST.
Dec 29 2018, 9:12 PM · Restricted Project
aleksandr.urakov updated subscribers of D56147: [Core] Use the implementation method `GetAddressOf` in `ValueObjectConstResultChild`.
Dec 29 2018, 3:22 AM · Restricted Project
aleksandr.urakov created D56147: [Core] Use the implementation method `GetAddressOf` in `ValueObjectConstResultChild`.
Dec 29 2018, 3:21 AM · Restricted Project
aleksandr.urakov added a comment to D56126: [NativePDB] Add basic support of methods recostruction in AST.

I think it's probably best to skip this part for now and come back to it later. The only thing that will be missing is the ability to use member function templates in expressions. Of course we need this eventually, but probably there is more useful stuff to work on first.

Dec 29 2018, 1:13 AM · Restricted Project

Dec 28 2018

aleksandr.urakov committed rL350125: [CodeView] Extend the `MemberAttributes` interface with the `isStatic` method.
[CodeView] Extend the `MemberAttributes` interface with the `isStatic` method
Dec 28 2018, 9:07 AM
aleksandr.urakov closed D56127: [CodeView] Extend the `MemberAttributes` interface with the `isStatic` method.
Dec 28 2018, 9:07 AM
aleksandr.urakov added a comment to D56127: [CodeView] Extend the `MemberAttributes` interface with the `isStatic` method.

Thanks!

Dec 28 2018, 9:07 AM
aleksandr.urakov added a child revision for D56126: [NativePDB] Add basic support of methods recostruction in AST: D56127: [CodeView] Extend the `MemberAttributes` interface with the `isStatic` method.
Dec 28 2018, 5:36 AM · Restricted Project
aleksandr.urakov added a parent revision for D56127: [CodeView] Extend the `MemberAttributes` interface with the `isStatic` method: D56126: [NativePDB] Add basic support of methods recostruction in AST.
Dec 28 2018, 5:36 AM
aleksandr.urakov updated the diff for D56127: [CodeView] Extend the `MemberAttributes` interface with the `isStatic` method.

Fix a typo.

Dec 28 2018, 4:32 AM
aleksandr.urakov created D56127: [CodeView] Extend the `MemberAttributes` interface with the `isStatic` method.
Dec 28 2018, 4:30 AM
aleksandr.urakov created D56126: [NativePDB] Add basic support of methods recostruction in AST.
Dec 28 2018, 4:23 AM · Restricted Project

Dec 26 2018

aleksandr.urakov added a comment to D56084: Resubmit of rL345008 "Split MachinePipeliner code into header and cpp files".

I have no objections against the such approach, but I'm not sure if this acceptable by the LLVM development rules... Let's ask about it a more experienced participant?

Dec 26 2018, 11:17 PM

Dec 24 2018

aleksandr.urakov accepted D56010: [NativePDB] Fix setting breakpoint by file and line.

LGTM too!

Dec 24 2018, 4:10 AM

Dec 21 2018

aleksandr.urakov added a comment to D55318: [Expressions] Add support of expressions evaluation in some object's context.

Ping! What do you think about this?

Dec 21 2018, 3:37 AM · Restricted Project, Restricted Project

Dec 7 2018

aleksandr.urakov accepted D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info.

Now it looks more clear, thanks!

Dec 7 2018, 10:29 AM
aleksandr.urakov updated the diff for D55318: [Expressions] Add support of expressions evaluation in some object's context.

Thanks for the comments, I've updated the patch.

Dec 7 2018, 12:56 AM · Restricted Project, Restricted Project
aleksandr.urakov added inline comments to D55318: [Expressions] Add support of expressions evaluation in some object's context.
Dec 7 2018, 12:55 AM · Restricted Project, Restricted Project

Dec 6 2018

aleksandr.urakov accepted D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info.

LGTM!

Dec 6 2018, 10:39 PM
aleksandr.urakov updated the diff for D55318: [Expressions] Add support of expressions evaluation in some object's context.

Thanks for the interest to the feature! I've updated the patch due to the comments.

Dec 6 2018, 8:23 AM · Restricted Project, Restricted Project

Dec 5 2018

aleksandr.urakov updated subscribers of D54942: [PDB] Make PDB lit tests use the new builder.

The similar problem with typedefs.test is here: http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/1940/steps/test/logs/stdio

Dec 5 2018, 12:26 PM · Restricted Project
aleksandr.urakov added a comment to D54942: [PDB] Make PDB lit tests use the new builder.

It looks strange. The compiler can't open the object file. And in the next build it is ok - may be it was some server failure (e.g. full disk)?

Dec 5 2018, 10:57 AM · Restricted Project
aleksandr.urakov added a comment to D55318: [Expressions] Add support of expressions evaluation in some object's context.

Btw, it can be useful if there ever would be a declarative format for pretty printers in LLDB.

Dec 5 2018, 9:57 AM · Restricted Project, Restricted Project
aleksandr.urakov committed rLLDB348386: [PDB] Make PDB lit tests use the new builder.
[PDB] Make PDB lit tests use the new builder
Dec 5 2018, 9:39 AM
aleksandr.urakov committed rL348386: [PDB] Make PDB lit tests use the new builder.
[PDB] Make PDB lit tests use the new builder
Dec 5 2018, 9:38 AM
aleksandr.urakov closed D54942: [PDB] Make PDB lit tests use the new builder.
Dec 5 2018, 9:38 AM · Restricted Project
aleksandr.urakov added a comment to D54942: [PDB] Make PDB lit tests use the new builder.

It seems that all the reviews this one depends on are already in. Can we proceed with it?

Dec 5 2018, 6:06 AM · Restricted Project
aleksandr.urakov created D55318: [Expressions] Add support of expressions evaluation in some object's context.
Dec 5 2018, 5:55 AM · Restricted Project, Restricted Project

Dec 4 2018

aleksandr.urakov added a comment to D55230: [lit] Multiple build outputs and default target bitness.

Thanks! I've updated DIA PDB tests in D55230.

Dec 4 2018, 5:42 AM
aleksandr.urakov updated the diff for D54942: [PDB] Make PDB lit tests use the new builder.

Update tests due to D55230

Dec 4 2018, 5:41 AM · Restricted Project
aleksandr.urakov added a comment to D54843: [Expr] Check the language before ignoring Objective C keywords.

The test was broken after this commit. It seems that on MacOS X the process of the compiled test application always contains Objective C Runtime, so the part of the test, which assumes that there is no ObjC option enabled, fails. To fix it I've skip this part for Darwin here: https://reviews.llvm.org/rLLDB348250 Please, tell me if you have any objections on this.

Dec 4 2018, 3:31 AM · Restricted Project
aleksandr.urakov committed rLLDB348250: [Expr] Fix `TestExprOptions` after r348240 on MacOS X.
[Expr] Fix `TestExprOptions` after r348240 on MacOS X
Dec 4 2018, 3:11 AM
aleksandr.urakov committed rL348250: [Expr] Fix `TestExprOptions` after r348240 on MacOS X.
[Expr] Fix `TestExprOptions` after r348240 on MacOS X
Dec 4 2018, 3:11 AM
aleksandr.urakov abandoned D53086: [PDB] Fix flaky `variables-locations.test` after PR38857.

Abandon due to D55122.

Dec 4 2018, 1:58 AM · Restricted Project
aleksandr.urakov added a comment to D54843: [Expr] Check the language before ignoring Objective C keywords.

Ok, thank you!

Dec 4 2018, 1:54 AM · Restricted Project
aleksandr.urakov committed rLLDB348240: [Expr] Check the language before ignoring Objective C keywords.
[Expr] Check the language before ignoring Objective C keywords
Dec 4 2018, 1:54 AM
aleksandr.urakov committed rL348240: [Expr] Check the language before ignoring Objective C keywords.
[Expr] Check the language before ignoring Objective C keywords
Dec 4 2018, 1:54 AM
aleksandr.urakov closed D54843: [Expr] Check the language before ignoring Objective C keywords.
Dec 4 2018, 1:54 AM · Restricted Project

Dec 3 2018

aleksandr.urakov added a comment to D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME.

I can do it, but unfortunately not this week... I want to join the native plugin development some later, at the end of this month, after some current work.

Dec 3 2018, 8:39 AM · Restricted Project, Restricted Project
aleksandr.urakov added a comment to D54843: [Expr] Check the language before ignoring Objective C keywords.

Ping! Can you look at this, please?

Dec 3 2018, 6:06 AM · Restricted Project
aleksandr.urakov committed rLLDB348136: [PDB] Support PDB-backed expressions evaluation (+ fix stuck test).
[PDB] Support PDB-backed expressions evaluation (+ fix stuck test)
Dec 3 2018, 5:40 AM