Changes all uses of minnan/maxnan to minimum/maximum
globally. These names emphasize that the semantic difference between
these operations is more than just NaN-propagation.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
- I guess this should be marked as NFC
- Does this mean you'd like to match the semantics of the existing minnan/maxnan in the backend to match the new minimum/maximum intrinsics? Then are you planning to update ValueTracking optimizations for them as well?
lib/Target/AArch64/AArch64ISelLowering.cpp | ||
---|---|---|
389 ↗ | (On Diff #169102) | For Promote, I guess we can honor the existing indentation (even though clang-format does not like it) |
820 ↗ | (On Diff #169102) | I know it is pre-existing, but as we are modifying it anyway, we can clang-format I guess |
test/CodeGen/WebAssembly/simd-arith.ll | ||
804 ↗ | (On Diff #169102) | Why is the operand order changed? The same for three more changes below this |
Comment Actions
Done
- Does this mean you'd like to match the semantics of the existing minnan/maxnan in the backend to match the new minimum/maximum intrinsics? Then are you planning to update ValueTracking optimizations for them as well?
This semantic matching already happened when we merged the new intrinsics, since they already lower directly to these SD nodes. I was not planning on updating the ValueTracking optimizations, although I could look into it. The current optimizations are still correct because they are too conservative, if anything.