This is an archive of the discontinued LLVM Phabricator instance.

[InstCombine] InstCombine and InstSimplify for minimum and maximum
ClosedPublic

Authored by tlively on Oct 1 2018, 7:56 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

tlively created this revision.Oct 1 2018, 7:56 PM
aheejin added inline comments.Oct 4 2018, 7:19 AM
lib/Analysis/InstructionSimplify.cpp
4864 ↗(On Diff #167876)

Nit: No need to enclose within () I guess..?

lib/Analysis/ValueTracking.cpp
2904 ↗(On Diff #167876)

I->getOperand(1)?

tlively updated this revision to Diff 168375.Oct 4 2018, 2:06 PM
tlively marked 2 inline comments as done.
  • Address comments
aheejin accepted this revision.Oct 17 2018, 4:15 PM
This revision is now accepted and ready to land.Oct 17 2018, 4:15 PM
This revision was automatically updated to reflect the committed changes.