Given that the indexer binary is put directly into ./bin directory
when built, 'clangd-' prefix seems to provide better context to the
reader than 'global-'.
The new name is also shorter and easier to type.
Differential D51987
[clangd] Rename global-symbol-builder to clangd-indexer. ilya-biryukov on Sep 12 2018, 7:25 AM. Authored by
Details Given that the indexer binary is put directly into ./bin directory The new name is also shorter and easier to type.
Diff Detail
Event TimelineComment Actions We've used the new name internally before and now that we're testing this, we need to be consistent. Comment Actions You beat it to me, but I thought we didn't use indexer as it could be confused with the actual indexing? Comment Actions
Sorry. Not a big deal, can revert back if needed. What's the index you're referring to? Building data structures for faster search? Comment Actions My 2 cents: clangd-indexer looks great! Typing 3-token tool name is always sad for me :( It's also easier to remember/understand in the first place. Comment Actions Yes. The current symbol builder produces *symbol table*, which can be easily confused with an index. We might have a different tool that builds the symbol index structure (e.g. serialized dex), which might be a better candidate for the name "indexer". Comment Actions Part of the reason I like "indexer" here is I don't think it should be a separate tool - it'd be nice if this tool would spit out a RIFF file with Dex posting lists ready to be loaded. Comment Actions I wasn't aware that we are also expanding the scope of the symbol builder. If being short is not the only reason here, I have no problem. Comment Actions Thanks for the comments everyone! |