Thanks!

Hey, I just wanted to say thank you! This is a rust-analyzer feature I really like when writing Rust code but somehow never thought about bringing it to Clangd. This is a nice idea, huge thanks for implementing it!

I don't have a Windows machine to test this out but the change looks reasonable to me and the "fallback to COPY" should probably be enough in this case.

LGTM, thanks!

Good catch, thanks!

Resolve review comments.

Address comments, rebase on top of main.

Resolve post-LGTM comments.

Resolve review comments.

Add explicit CMake option.

Include Features.inc in Server.cpp.

Resolve review comments.

Add the variable to Features.inc.in and canonicalize.

Address review comments.

Address review comments.

Enabled server reflection in https://github.com/llvm/llvm-project/commit/8080ea4c4b8c456c72c617587cc32f174b3105c1

Use reflection, improve message format.

LGTM, thanks for implementing this and apologies for the review delay (was a tough week for me & my team).

Thanks! The code looks right, my comments are mostly for the comments around to validate my mental model of the code structure and behavior.

So, if my understanding is correct, this will make the whole bundle non-deprecated if at least one overload is not deprecated? This is probably an improvement over the existing behaviour. However, do we maybe want to split the bundles into deprecated and non-deprecated groups?

In D96975#2594147, @njames93 wrote:

Ping

Yeah this does indeed already work.

Address review comments

Address review comments.

Sorry for the delay.

@sammccall this is the argument renaming diff I was talking about during the standup.

Thanks!

Rebase on top of D96247, check for conflicts in specialization bodies.

Resolve review comment.

This likely needs some further thought on conflict detection. Assume we have

Implement constructors handling.

Fix comment formatting in the test.

Can't instantiate DynTypedNode with FunctionProtoTypeLoc, has to be just TypeLoc :(

Use FunctionProtoTypeLoc

Pass const ref to DynTypedNode in helper.

Fix a couple problems pointed out during the review.

@sammccall Ping, this is a real patch :)

Add comments.

Resolve most comments but one: some comments & examples in the code incoming in
the next diff.

Revert last change: leads to incomplete types.

Don't spell out DynTypedNodeList and don't include ParentMapContext.h

Save few LOCs by checking for nullptr in CheckDeclStmt.

Resolve review comments.

Thanks, LGTM with a couple of nits.

As mentioned offline, this is not the right fix :( The correct one is pushed to our CI.

Actually clean up rebase artifacts.