Page MenuHomePhabricator

kbobyrev (Kirill Bobyrev)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 19 2018, 7:14 AM (113 w, 2 d)

Recent Activity

Fri, Sep 18

kbobyrev added inline comments to D87831: [clang] Expose helper function to turn PP keywords spelling into PPKeywordKind.
Fri, Sep 18, 1:25 AM · Restricted Project

Thu, Sep 17

kbobyrev requested review of D87831: [clang] Expose helper function to turn PP keywords spelling into PPKeywordKind.
Thu, Sep 17, 7:24 AM · Restricted Project

Wed, Sep 16

kbobyrev committed rG3e5a4ef51a1d: Fix table formatting after D87686 (authored by kbobyrev).
Fix table formatting after D87686
Wed, Sep 16, 3:28 AM
kbobyrev committed rGa909a84ef2d9: [clang-tidy] Improve documentation on Clangd integration (authored by kbobyrev).
[clang-tidy] Improve documentation on Clangd integration
Wed, Sep 16, 3:10 AM
kbobyrev closed D87686: [clang-tidy] Improve documentation on Clangd integration.
Wed, Sep 16, 3:10 AM · Restricted Project
kbobyrev committed rG3a0a2a6347f5: [clangd] Implement hot index reloading for clangd-index-server (authored by kbobyrev).
[clangd] Implement hot index reloading for clangd-index-server
Wed, Sep 16, 2:12 AM
kbobyrev closed D87450: [clangd] Implement hot index reloading for clangd-index-server.
Wed, Sep 16, 2:12 AM · Restricted Project
kbobyrev updated the diff for D87686: [clang-tidy] Improve documentation on Clangd integration.

Address review comments.

Wed, Sep 16, 2:06 AM · Restricted Project
kbobyrev added inline comments to D87450: [clangd] Implement hot index reloading for clangd-index-server.
Wed, Sep 16, 1:54 AM · Restricted Project
kbobyrev updated the diff for D87450: [clangd] Implement hot index reloading for clangd-index-server.

Save last status to prevent redundant updates.

Wed, Sep 16, 1:54 AM · Restricted Project
kbobyrev updated the diff for D87450: [clangd] Implement hot index reloading for clangd-index-server.

Update comment.

Wed, Sep 16, 1:10 AM · Restricted Project
kbobyrev added inline comments to D87450: [clangd] Implement hot index reloading for clangd-index-server.
Wed, Sep 16, 1:08 AM · Restricted Project
kbobyrev updated the diff for D87450: [clangd] Implement hot index reloading for clangd-index-server.

Address another round of comments.

Wed, Sep 16, 1:07 AM · Restricted Project

Tue, Sep 15

kbobyrev requested review of D87686: [clang-tidy] Improve documentation on Clangd integration.
Tue, Sep 15, 4:51 AM · Restricted Project
kbobyrev updated the diff for D87450: [clangd] Implement hot index reloading for clangd-index-server.

Address a round of comments.

Tue, Sep 15, 3:52 AM · Restricted Project

Mon, Sep 14

kbobyrev updated the diff for D87450: [clangd] Implement hot index reloading for clangd-index-server.

Address remaining comments.

Mon, Sep 14, 2:45 AM · Restricted Project
kbobyrev added inline comments to D87450: [clangd] Implement hot index reloading for clangd-index-server.
Mon, Sep 14, 1:29 AM · Restricted Project
kbobyrev updated the diff for D87450: [clangd] Implement hot index reloading for clangd-index-server.

Address review comments.

Mon, Sep 14, 1:24 AM · Restricted Project

Thu, Sep 10

kbobyrev requested review of D87450: [clangd] Implement hot index reloading for clangd-index-server.
Thu, Sep 10, 5:58 AM · Restricted Project

Tue, Sep 8

kbobyrev planned changes to D85426: [clangd] Implement FileFilter for the indexer.

WIP. Need to get around background indexing tricks to make it work.

Tue, Sep 8, 4:59 AM · Restricted Project
kbobyrev edited reviewers for D85426: [clangd] Implement FileFilter for the indexer, added: kadircet; removed: sammccall.
Tue, Sep 8, 4:59 AM · Restricted Project
kbobyrev updated the diff for D85426: [clangd] Implement FileFilter for the indexer.

Also check if deinition comes from unwwanted file (e.g. omit forward declarations).

Tue, Sep 8, 4:58 AM · Restricted Project

Mon, Sep 7

kbobyrev updated the diff for D85426: [clangd] Implement FileFilter for the indexer.

"Fail" early.

Mon, Sep 7, 5:33 AM · Restricted Project

Wed, Aug 26

kbobyrev committed rG9d11e6789c47: [clangd] Use string[] for allCommitCharacters (authored by kbobyrev).
[clangd] Use string[] for allCommitCharacters
Wed, Aug 26, 8:08 AM
kbobyrev closed D86604: [clangd] Use string[] for allCommitCharacters.
Wed, Aug 26, 8:08 AM · Restricted Project
kbobyrev requested review of D86604: [clangd] Use string[] for allCommitCharacters.
Wed, Aug 26, 2:21 AM · Restricted Project

Aug 17 2020

kbobyrev accepted D86052: [clangd] Fix Windows build when remote index is enabled..

Looks good to me, thank you very much!

Aug 17 2020, 6:11 AM · Restricted Project

Aug 14 2020

kbobyrev committed rG9698deb25702: [clangd] Clarify comments regarding gRPC linking (authored by kbobyrev).
[clangd] Clarify comments regarding gRPC linking
Aug 14 2020, 2:03 AM
kbobyrev committed rG1786908f8cef: [clangd] Warn developers when trying to link system-installed gRPC statically (authored by kbobyrev).
[clangd] Warn developers when trying to link system-installed gRPC statically
Aug 14 2020, 1:22 AM
kbobyrev closed D85815: [clangd] Warn developers when trying to link system-installed gRPC statically.
Aug 14 2020, 1:22 AM · Restricted Project
kbobyrev updated the diff for D85815: [clangd] Warn developers when trying to link system-installed gRPC statically.

Address post-LGTM comments.

Aug 14 2020, 1:21 AM · Restricted Project
kbobyrev accepted D85958: [clangd] Fix find_program() result check when searching for gRPC.

Ah, good catch, thank you! Alternatively there seems to be Package_FOUND variable but what your propose is cleaner.

Aug 14 2020, 1:10 AM · Restricted Project

Aug 12 2020

kbobyrev requested review of D85815: [clangd] Warn developers when trying to link system-installed gRPC statically.
Aug 12 2020, 1:02 AM · Restricted Project
kbobyrev planned changes to D85715: [clangd] Attempt to allow gRPC & Proobuf static linking.

This is not an actual patch, so removing from reviews to reduce noise.

Aug 12 2020, 12:54 AM · Restricted Project

Aug 11 2020

kbobyrev added a comment to D85715: [clangd] Attempt to allow gRPC & Proobuf static linking.

This is a full reproducer of what would work with grpc++ built from source. Seems like the dependencies are pulled by CMake and this way it actually links correctly.

Aug 11 2020, 7:29 AM · Restricted Project
kbobyrev added a comment to D85715: [clangd] Attempt to allow gRPC & Proobuf static linking.

Aww, actually no only LibSSL. I'll have to link all the libraries libgrpc++.a is depending on which means I'll have to find all of them somehow: LibSSL, libcares, libcrypto, abseil... Seems like the easiest way is to check gRPC into LLVM or simply disallow static builds with system-installed libs :(

Aug 11 2020, 6:37 AM · Restricted Project
kbobyrev added a comment to D85715: [clangd] Attempt to allow gRPC & Proobuf static linking.

Easy way to play around some of the things:

Aug 11 2020, 5:48 AM · Restricted Project
kbobyrev committed rGbd1013a4825b: [clangd] Enforce trailing slash for remote index's project root (authored by kbobyrev).
[clangd] Enforce trailing slash for remote index's project root
Aug 11 2020, 4:25 AM
kbobyrev closed D85711: [clangd] Enforce trailing slash for remote index's project root.
Aug 11 2020, 4:25 AM · Restricted Project
kbobyrev updated the diff for D85711: [clangd] Enforce trailing slash for remote index's project root.

Rebase.

Aug 11 2020, 4:24 AM · Restricted Project
kbobyrev added a comment to D85715: [clangd] Attempt to allow gRPC & Proobuf static linking.

When I manually link /usr/lib/x86_64-linux-gnu/libgrpc++_reflection.a to clangdRemoteServer on Linux the following error persists:

Aug 11 2020, 4:16 AM · Restricted Project
kbobyrev added a comment to D85715: [clangd] Attempt to allow gRPC & Proobuf static linking.

This seems to be the related issue for macOS: https://github.com/tensorflow/tensorflow/issues/30117. The proposed solution is hardcoding -framework CoreFoundation :(

Aug 11 2020, 4:12 AM · Restricted Project
kbobyrev added a comment to D85715: [clangd] Attempt to allow gRPC & Proobuf static linking.

macOS error message:

Aug 11 2020, 4:08 AM · Restricted Project
kbobyrev added a comment to D85715: [clangd] Attempt to allow gRPC & Proobuf static linking.

Error log on Linux:

Aug 11 2020, 2:31 AM · Restricted Project
kbobyrev requested review of D85715: [clangd] Attempt to allow gRPC & Proobuf static linking.
Aug 11 2020, 2:24 AM · Restricted Project
kbobyrev abandoned D85285: [clangd] WIP experimentation with finding static grpc++ libraries.
Aug 11 2020, 1:56 AM · Restricted Project, Restricted Project
kbobyrev updated the diff for D85711: [clangd] Enforce trailing slash for remote index's project root.

Remove redundant .str() calls.

Aug 11 2020, 1:47 AM · Restricted Project
kbobyrev updated the diff for D85711: [clangd] Enforce trailing slash for remote index's project root.

Handle slash appending in Marshaller.

Aug 11 2020, 1:46 AM · Restricted Project
kbobyrev requested review of D85711: [clangd] Enforce trailing slash for remote index's project root.
Aug 11 2020, 12:57 AM · Restricted Project
kbobyrev committed rGc6d2078a35d5: [clangd] Improve diagnostics in dexp interface (authored by kbobyrev).
[clangd] Improve diagnostics in dexp interface
Aug 11 2020, 12:51 AM

Aug 10 2020

kbobyrev accepted D85637: [clangd] Fix the background index is not disabled when using remote-index..

Oh, thanks!

Aug 10 2020, 4:56 AM · Restricted Project

Aug 9 2020

kbobyrev committed rG836f937a1f11: [clangd] Add more error details on the remote index server side (authored by kbobyrev).
[clangd] Add more error details on the remote index server side
Aug 9 2020, 1:13 PM
kbobyrev closed D85502: [clangd] Add more error details on the remote index server side.
Aug 9 2020, 1:13 PM · Restricted Project
kbobyrev updated the diff for D85502: [clangd] Add more error details on the remote index server side.

Resolve post-LGTM comments.

Aug 9 2020, 1:05 PM · Restricted Project

Aug 7 2020

kbobyrev requested review of D85502: [clangd] Add more error details on the remote index server side.
Aug 7 2020, 12:02 AM · Restricted Project

Aug 6 2020

kbobyrev planned changes to D84811: [clangd] Add an option to exclude symbols outside of project root from index.

Even despite FileFilter not being fully implemented yet (an issue for a separate patch) I think this change should still be correct and is probably OK to land, WDYT @hokein?

Yes, personally no objection on landing this, but landing it doesn't seem to help much for your remote-index case (STL symbols are not filtered out)?

True, it doesn't filter _all_ of them, but it partially filters some symbols which is still a win I guess :) My rationale is probably that having this blocked on more implementation details would be more reasonable if there was no implementation at all but since it still filters out some symbols this should probably be fine.

It just reduces symptoms, not solving the problem. I think remote-index is also blocked the FileFiltering stuff (we can't launch remote-index without fixing this issue entirely).

As you may have noticed implementing FileFiltering is tricky, I think the indexer here is a good opportunity to test/verify your implementation (comparing the index data before vs after), so my preference would be to implement the FileFilter, test it with this patch together, then finally land this patch after making sure everything works.

Aug 6 2020, 8:49 AM · Restricted Project
kbobyrev added inline comments to D85426: [clangd] Implement FileFilter for the indexer.
Aug 6 2020, 7:59 AM · Restricted Project
kbobyrev planned changes to D85285: [clangd] WIP experimentation with finding static grpc++ libraries.

WIP, nothing important here.

Aug 6 2020, 7:57 AM · Restricted Project, Restricted Project
kbobyrev added a comment to D84811: [clangd] Add an option to exclude symbols outside of project root from index.

Even despite FileFilter not being fully implemented yet (an issue for a separate patch) I think this change should still be correct and is probably OK to land, WDYT @hokein?

Yes, personally no objection on landing this, but landing it doesn't seem to help much for your remote-index case (STL symbols are not filtered out)?

Aug 6 2020, 7:54 AM · Restricted Project
kbobyrev requested review of D84811: [clangd] Add an option to exclude symbols outside of project root from index.

Even despite FileFilter not being fully implemented yet (an issue for a separate patch) I think this change should still be correct and is probably OK to land, WDYT @hokein?

Aug 6 2020, 5:16 AM · Restricted Project
kbobyrev planned changes to D85426: [clangd] Implement FileFilter for the indexer.

@sammccall This is the change I was talking about during the standup: the code looks legit, but BackgroundIndexTests.IndexTwoFiles fails because with the following code path in Background.cpp's FileFilter:

Aug 6 2020, 5:12 AM · Restricted Project
kbobyrev requested review of D85426: [clangd] Implement FileFilter for the indexer.
Aug 6 2020, 5:08 AM · Restricted Project

Aug 5 2020

kbobyrev requested review of D85285: [clangd] WIP experimentation with finding static grpc++ libraries.
Aug 5 2020, 1:44 AM · Restricted Project, Restricted Project

Jul 31 2020

kbobyrev planned changes to D84811: [clangd] Add an option to exclude symbols outside of project root from index.

Need tot resolve FIXMEs around shouldIndexFile().

Jul 31 2020, 10:28 AM · Restricted Project
kbobyrev added inline comments to D84811: [clangd] Add an option to exclude symbols outside of project root from index.
Jul 31 2020, 10:27 AM · Restricted Project
kbobyrev committed rG2978b10aa164: [clangd] Fix remote index build on macOS (authored by kbobyrev).
[clangd] Fix remote index build on macOS
Jul 31 2020, 5:03 AM
kbobyrev closed D84928: [clangd] Fix remote index build on macOS.
Jul 31 2020, 5:03 AM · Restricted Project
kbobyrev committed rGfb5588b0ad59: [clangd] Propagate remote index errors via Expected (authored by kbobyrev).
[clangd] Propagate remote index errors via Expected
Jul 31 2020, 2:49 AM
kbobyrev closed D84939: [clangd] Propagate remote index errors via Expected.
Jul 31 2020, 2:49 AM · Restricted Project
kbobyrev added inline comments to D84939: [clangd] Propagate remote index errors via Expected.
Jul 31 2020, 2:48 AM · Restricted Project
kbobyrev updated the diff for D84939: [clangd] Propagate remote index errors via Expected.

Good points, thanks!

Jul 31 2020, 2:47 AM · Restricted Project
kbobyrev updated the summary of D84811: [clangd] Add an option to exclude symbols outside of project root from index.
Jul 31 2020, 12:25 AM · Restricted Project
kbobyrev updated the diff for D84811: [clangd] Add an option to exclude symbols outside of project root from index.

Switch to SymbolCollector::Options::FileFilter that is even more
straightforward.

Jul 31 2020, 12:24 AM · Restricted Project

Jul 30 2020

kbobyrev added a comment to D84928: [clangd] Fix remote index build on macOS.

Hmm, apparently link_libraries is not supposed to be used this way as it adds to linker search path _after_ it's called (from the docs) but this still worked for me on mac before. Hence I was relying on incorrect behaviour, my bad.

Jul 30 2020, 11:41 AM · Restricted Project
kbobyrev updated the summary of D84928: [clangd] Fix remote index build on macOS.
Jul 30 2020, 11:40 AM · Restricted Project
kbobyrev added a comment to D84232: [clangd] Set minimum gRPC version to 1.27.

This patch is not ready for review yet; planned changes: check if the version is between 1.25.0 and 1.26.0-4 and bail out in such cases.

Jul 30 2020, 8:46 AM · Restricted Project, Restricted Project
kbobyrev updated the summary of D84232: [clangd] Set minimum gRPC version to 1.27.
Jul 30 2020, 8:45 AM · Restricted Project, Restricted Project
kbobyrev added inline comments to D84939: [clangd] Propagate remote index errors via Expected.
Jul 30 2020, 8:44 AM · Restricted Project
kbobyrev updated the diff for D84939: [clangd] Propagate remote index errors via Expected.

Resolve most review comments.

Jul 30 2020, 8:42 AM · Restricted Project
kbobyrev added a comment to D84939: [clangd] Propagate remote index errors via Expected.

i think you might want to have an helper for creating stringerrors and use it in all places

Jul 30 2020, 8:13 AM · Restricted Project
kbobyrev committed rGc4b7bfdff65e: [clangd] NFC: Spell out types in index callback arguments (authored by kbobyrev).
[clangd] NFC: Spell out types in index callback arguments
Jul 30 2020, 8:13 AM
kbobyrev edited reviewers for D84928: [clangd] Fix remote index build on macOS, added: hokein; removed: sammccall.
Jul 30 2020, 8:03 AM · Restricted Project
kbobyrev updated the diff for D84939: [clangd] Propagate remote index errors via Expected.

Client: print debug string for the stream_result, not the ReplyT.

Jul 30 2020, 5:41 AM · Restricted Project
kbobyrev requested review of D84939: [clangd] Propagate remote index errors via Expected.
Jul 30 2020, 5:40 AM · Restricted Project
kbobyrev committed rGa262f0fea46c: [clangd] Implement Relations request for remote index (authored by kbobyrev).
[clangd] Implement Relations request for remote index
Jul 30 2020, 3:59 AM
kbobyrev closed D84894: [clangd] Implement Relations request for remote index.
Jul 30 2020, 3:58 AM · Restricted Project
kbobyrev updated the diff for D84894: [clangd] Implement Relations request for remote index.

Address post-LGTM comment.

Jul 30 2020, 3:56 AM · Restricted Project
kbobyrev updated the diff for D84894: [clangd] Implement Relations request for remote index.

Address all comments.

Jul 30 2020, 3:31 AM · Restricted Project
kbobyrev requested review of D84928: [clangd] Fix remote index build on macOS.
Jul 30 2020, 3:18 AM · Restricted Project
kbobyrev planned changes to D84811: [clangd] Add an option to exclude symbols outside of project root from index.
Jul 30 2020, 2:36 AM · Restricted Project

Jul 29 2020

kbobyrev updated the diff for D84894: [clangd] Implement Relations request for remote index.

Fix comment in proto file and rebase on top of master.

Jul 29 2020, 3:34 PM · Restricted Project
kbobyrev requested review of D84894: [clangd] Implement Relations request for remote index.
Jul 29 2020, 3:30 PM · Restricted Project
kbobyrev committed rG1603470e59a9: [clangd] Fix clangd-indexeer builds after D84697 (authored by kbobyrev).
[clangd] Fix clangd-indexeer builds after D84697
Jul 29 2020, 4:05 AM

Jul 28 2020

kbobyrev committed rGfb22678cd678: [clangd] Use elog instead of llvm::errs, log instead of llvm::outs (authored by kbobyrev).
[clangd] Use elog instead of llvm::errs, log instead of llvm::outs
Jul 28 2020, 4:48 PM
kbobyrev closed D84697: [clangd] Use elog instead of llvm::errs, log instead of llvm::outs.
Jul 28 2020, 4:48 PM · Restricted Project
kbobyrev updated the diff for D84697: [clangd] Use elog instead of llvm::errs, log instead of llvm::outs.

Resolve post-LGTM comments.

Jul 28 2020, 4:40 PM · Restricted Project
kbobyrev requested review of D84811: [clangd] Add an option to exclude symbols outside of project root from index.
Jul 28 2020, 4:38 PM · Restricted Project
kbobyrev accepted D84794: Mark override to a function which overrides a virtual one.

Thanks!

Jul 28 2020, 3:54 PM · Restricted Project, Restricted Project
kbobyrev updated the diff for D84697: [clangd] Use elog instead of llvm::errs, log instead of llvm::outs.

Use more conservative approach.

Jul 28 2020, 12:32 AM · Restricted Project

Jul 27 2020

kbobyrev updated the diff for D84697: [clangd] Use elog instead of llvm::errs, log instead of llvm::outs.

Don't use llvm::toString in elog

Jul 27 2020, 12:54 PM · Restricted Project