User Details
- User Since
- Jul 19 2018, 7:14 AM (143 w, 5 d)
Fri, Apr 9
Thanks!
Wed, Apr 7
Tue, Apr 6
Hey, I just wanted to say thank you! This is a rust-analyzer feature I really like when writing Rust code but somehow never thought about bringing it to Clangd. This is a nice idea, huge thanks for implementing it!
Tue, Mar 30
I don't have a Windows machine to test this out but the change looks reasonable to me and the "fallback to COPY" should probably be enough in this case.
LGTM, thanks!
Fri, Mar 26
Good catch, thanks!
Mar 16 2021
Resolve review comments.
Mar 15 2021
Address comments, rebase on top of main.
Resolve post-LGTM comments.
Resolve review comments.
Add explicit CMake option.
Include Features.inc in Server.cpp.
Resolve review comments.
Add the variable to Features.inc.in and canonicalize.
Mar 11 2021
Address review comments.
Address review comments.
Mar 10 2021
Enabled server reflection in https://github.com/llvm/llvm-project/commit/8080ea4c4b8c456c72c617587cc32f174b3105c1
Mar 9 2021
Use reflection, improve message format.
Mar 8 2021
LGTM, thanks for implementing this and apologies for the review delay (was a tough week for me & my team).
Mar 5 2021
Thanks! The code looks right, my comments are mostly for the comments around to validate my mental model of the code structure and behavior.
Mar 4 2021
So, if my understanding is correct, this will make the whole bundle non-deprecated if at least one overload is not deprecated? This is probably an improvement over the existing behaviour. However, do we maybe want to split the bundles into deprecated and non-deprecated groups?
Mar 1 2021
Feb 18 2021
Yeah this does indeed already work.
Address review comments
Feb 17 2021
Address review comments.
Feb 15 2021
Sorry for the delay.
Feb 10 2021
@sammccall this is the argument renaming diff I was talking about during the standup.
Feb 9 2021
Thanks!
Rebase on top of D96247, check for conflicts in specialization bodies.
Resolve review comment.
This likely needs some further thought on conflict detection. Assume we have
Implement constructors handling.
Feb 8 2021
Fix comment formatting in the test.
Feb 4 2021
Can't instantiate DynTypedNode with FunctionProtoTypeLoc, has to be just TypeLoc :(
Use FunctionProtoTypeLoc
Pass const ref to DynTypedNode in helper.
Fix a couple problems pointed out during the review.
Feb 3 2021
@sammccall Ping, this is a real patch :)
Add comments.
Resolve most comments but one: some comments & examples in the code incoming in
the next diff.
Revert last change: leads to incomplete types.
Don't spell out DynTypedNodeList and don't include ParentMapContext.h
Save few LOCs by checking for nullptr in CheckDeclStmt.
Resolve review comments.
Feb 2 2021
Jan 29 2021
Thanks, LGTM with a couple of nits.
Jan 25 2021
Jan 13 2021
As mentioned offline, this is not the right fix :( The correct one is pushed to our CI.
Jan 12 2021
Dec 16 2020
Dec 15 2020
Actually clean up rebase artifacts.