Adding support for a16 for gfx9. A16 bit replaces r128 bit for gfx9.
Change-Id: Ie8b881e4e6d2f023fb5e0150420893513e5f4841
Paths
| Differential D50575
[AMDGPU] Add support for a16 modifier for gfx9 ClosedPublic Authored by rtaylor on Aug 10 2018, 11:05 AM.
Details Summary Adding support for a16 for gfx9. A16 bit replaces r128 bit for gfx9. Change-Id: Ie8b881e4e6d2f023fb5e0150420893513e5f4841
Diff Detail
Event TimelineHerald added subscribers: llvm-commits, jfb, t-tye and 7 others. · View Herald TranscriptAug 10 2018, 11:05 AM rtaylor retitled this revision from [AMDGPU] Add support for a16 modifiear for gfx9 to [AMDGPU] Add support for a16 modifier for gfx9.
Comment Actions Made changes according to suggestions. Reduced redundancy and simplified code structure. Comment Actions The operand name / encoding bits in TableGen should really be changed as well to indicate the overload between R128 and A16.
Comment Actions Realized that I had updated clang-format runs of of SIISelLowering.h/.cpp and this caused a lot of re-formatting. Comment Actions Thanks for the changes. Sorry to be a stickler about this, but the formatting of the odd gradients check in lowerImage is still wrong, please adjust this according to clang-format-diff before you commit. No need to re-upload here, the rest of the changes looks good to me. This revision is now accepted and ready to land.Aug 28 2018, 3:10 AM Closed by commit rL340831: [AMDGPU] Add support for a16 modifiear for gfx9 (authored by rtayl). · Explain WhyAug 28 2018, 8:08 AM This revision was automatically updated to reflect the committed changes. Comment Actions
No problem, I understand. I thought I had copied from the previous clang-format but I had copied from an earlier version, thanks for catching it. It is interesting to note though that clang-format changed so much in this file. Comment Actions
Yes, there are unfortunately parts of LLVM that don't quite follow the coding convention. clang-format-diff is usually pretty good at limiting its changes to whatever you actually changed in the diff (I often use it as git diff | clang-format-diff -p1), but if your changes happen to be next to a large section that doesn't follow the coding convention, even that tool can be a bit overzealous in the changes it suggests.
Revision Contents
Diff 162294 lib/Target/AMDGPU/AMDGPU.td
lib/Target/AMDGPU/AMDGPUSubtarget.h
lib/Target/AMDGPU/AMDGPUSubtarget.cpp
lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
lib/Target/AMDGPU/InstPrinter/AMDGPUInstPrinter.h
lib/Target/AMDGPU/InstPrinter/AMDGPUInstPrinter.cpp
lib/Target/AMDGPU/MIMGInstructions.td
lib/Target/AMDGPU/SIISelLowering.h
lib/Target/AMDGPU/SIISelLowering.cpp
lib/Target/AMDGPU/SIInstrInfo.td
test/CodeGen/AMDGPU/llvm.amdgcn.image.gather4.a16.dim.ll
test/CodeGen/AMDGPU/llvm.amdgcn.image.sample.a16.dim.ll
test/MC/AMDGPU/mimg.s
|
Feature name doesn't match, r128-a16?