Page MenuHomePhabricator

rtaylor (Ryan Taylor)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 9 2018, 7:56 AM (129 w, 6 d)

Recent Activity

May 11 2020

rtaylor committed rG58cb88733f01: [mlir][rocdl] Add xdlops intrinsics to rocdl dialect (authored by rtaylor).
[mlir][rocdl] Add xdlops intrinsics to rocdl dialect
May 11 2020, 7:29 AM
rtaylor closed D79642: [mlir][rocdl] Add xdlops intrinsics to rocdl dialect.
May 11 2020, 7:29 AM · Restricted Project, Restricted Project

May 8 2020

rtaylor added a project to D79642: [mlir][rocdl] Add xdlops intrinsics to rocdl dialect: Restricted Project.
May 8 2020, 11:48 AM · Restricted Project, Restricted Project
rtaylor created D79642: [mlir][rocdl] Add xdlops intrinsics to rocdl dialect.
May 8 2020, 11:48 AM · Restricted Project, Restricted Project

Apr 2 2020

rtaylor accepted D77344: [AMDGPU] Propagate AGPR RC from PHI to its PHI operands.

LGTM

Apr 2 2020, 5:54 PM · Restricted Project

Jan 29 2020

rtaylor added a comment to D73482: [AMDGPU] Fix lowering a16 image intrinsics.

LGTM.

Jan 29 2020, 6:53 AM · Restricted Project
rtaylor added a reviewer for D73559: AMDGPU: Account for dmask when computing image mem size: dstuttard.
Jan 29 2020, 6:35 AM · Restricted Project
rtaylor added a comment to D73559: AMDGPU: Account for dmask when computing image mem size.

Adding David Stuttard as I think he worked on dmask originally.

Jan 29 2020, 6:35 AM · Restricted Project
rtaylor added a comment to D73558: AMDGPU: Correct memory size for image intrinsics.

Added David Stuttard as reviewer since this was originally his.

Jan 29 2020, 6:26 AM · Restricted Project
rtaylor added a reviewer for D73558: AMDGPU: Correct memory size for image intrinsics: dstuttard.
Jan 29 2020, 6:26 AM · Restricted Project
rtaylor added inline comments to D73482: [AMDGPU] Fix lowering a16 image intrinsics.
Jan 29 2020, 6:08 AM · Restricted Project

Jan 28 2020

rtaylor added inline comments to D73482: [AMDGPU] Fix lowering a16 image intrinsics.
Jan 28 2020, 6:41 AM · Restricted Project
rtaylor added inline comments to D73482: [AMDGPU] Fix lowering a16 image intrinsics.
Jan 28 2020, 6:41 AM · Restricted Project

Oct 22 2019

rtaylor abandoned D66666: [AMDGPU] Remove unnecessary movs for v_fmac operands.

https://reviews.llvm.org/D69287 covers this.

Oct 22 2019, 5:43 AM · Restricted Project

Sep 10 2019

rtaylor added a comment to D66666: [AMDGPU] Remove unnecessary movs for v_fmac operands.

Ping.

Sep 10 2019, 9:56 AM · Restricted Project

Sep 6 2019

rtaylor closed D64933: [AMDGPU] Adjust number of SGPRs available in Calling Convention.

Upstreamed.

Sep 6 2019, 2:22 PM · Restricted Project
rtaylor updated the diff for D66666: [AMDGPU] Remove unnecessary movs for v_fmac operands.

Added condition in foldOperands to allow tied subreg folding
for V_FMAC and V_MAC operations

Sep 6 2019, 2:22 PM · Restricted Project

Aug 29 2019

rtaylor added a comment to D58918: [AMDGPU] Add support for 64 bit buffer atomic artihmetic instructions.

Hi there,
Do you have the cmpswap fix somewhere?
Thanks

Aug 29 2019, 6:43 AM · Restricted Project

Aug 28 2019

rtaylor added inline comments to D66666: [AMDGPU] Remove unnecessary movs for v_fmac operands.
Aug 28 2019, 12:01 PM · Restricted Project
rtaylor added inline comments to D66666: [AMDGPU] Remove unnecessary movs for v_fmac operands.
Aug 28 2019, 10:53 AM · Restricted Project
rtaylor committed rG3b1459ed7c5e: [AMDGPU] Adjust number of SGPRs available in Calling Convention (authored by rtaylor).
[AMDGPU] Adjust number of SGPRs available in Calling Convention
Aug 28 2019, 8:03 AM

Aug 27 2019

rtaylor added a comment to D64933: [AMDGPU] Adjust number of SGPRs available in Calling Convention.

Ping.

Aug 27 2019, 2:22 PM · Restricted Project

Aug 23 2019

rtaylor updated the diff for D66666: [AMDGPU] Remove unnecessary movs for v_fmac operands.

Forgot to capitalize var name.

Aug 23 2019, 1:31 PM · Restricted Project
rtaylor updated the diff for D66666: [AMDGPU] Remove unnecessary movs for v_fmac operands.

Set bool in condition.

Aug 23 2019, 1:31 PM · Restricted Project
rtaylor added inline comments to D66666: [AMDGPU] Remove unnecessary movs for v_fmac operands.
Aug 23 2019, 1:31 PM · Restricted Project
rtaylor added inline comments to D66666: [AMDGPU] Remove unnecessary movs for v_fmac operands.
Aug 23 2019, 11:55 AM · Restricted Project
rtaylor updated the diff for D66666: [AMDGPU] Remove unnecessary movs for v_fmac operands.

Made some changes to code.

Aug 23 2019, 11:47 AM · Restricted Project
rtaylor updated the diff for D64933: [AMDGPU] Adjust number of SGPRs available in Calling Convention.

Updating.

Aug 23 2019, 11:27 AM · Restricted Project
rtaylor added reviewers for D66666: [AMDGPU] Remove unnecessary movs for v_fmac operands: arsenm, tpr, dstuttard, nhaehnle.
Aug 23 2019, 10:19 AM · Restricted Project
rtaylor updated the diff for D66666: [AMDGPU] Remove unnecessary movs for v_fmac operands.

Added test case

Aug 23 2019, 10:19 AM · Restricted Project
rtaylor created D66666: [AMDGPU] Remove unnecessary movs for v_fmac operands.
Aug 23 2019, 10:19 AM · Restricted Project

Aug 20 2019

rtaylor abandoned D60834: [AMDGPU] Uniform values being used outside loop marked non-divergent.

This has been copied over and extended on in https://reviews.llvm.org/D62802 so I'm abandoning this revision.

Aug 20 2019, 11:02 AM · Restricted Project

Jul 25 2019

rtaylor added a comment to D64933: [AMDGPU] Adjust number of SGPRs available in Calling Convention.

Hmm... looks like AMDGPUISelLowering.cpp has changed quite a bit in regards to the calling convention.

Jul 25 2019, 9:26 AM · Restricted Project
rtaylor added a comment to D64933: [AMDGPU] Adjust number of SGPRs available in Calling Convention.

ping

Jul 25 2019, 9:14 AM · Restricted Project

Jul 23 2019

rtaylor committed rG6f13637a3e13: [IR][Verifier] Allow IntToPtrInst to be !dereferenceable (authored by rtaylor).
[IR][Verifier] Allow IntToPtrInst to be !dereferenceable
Jul 23 2019, 10:20 AM
rtaylor updated the diff for D64954: [IR][Verifier] Allow IntToPtrInst to be !dereferenceable.

Remove underline to ref hyperlink from invariant.group

Jul 23 2019, 6:48 AM · Restricted Project
rtaylor updated the diff for D64954: [IR][Verifier] Allow IntToPtrInst to be !dereferenceable.

Removed preceding underline to ref hyperlink.

Jul 23 2019, 6:41 AM · Restricted Project

Jul 22 2019

rtaylor updated the diff for D64954: [IR][Verifier] Allow IntToPtrInst to be !dereferenceable.

Added hyperlinks to LangRef.rst

Jul 22 2019, 9:23 AM · Restricted Project
rtaylor updated the diff for D64954: [IR][Verifier] Allow IntToPtrInst to be !dereferenceable.

Changed LangRef.rst: Moved !dereferenceable and !dereferenceable_or_null to their
own section in Metadata and pointed inttoptr and load to that section.

Jul 22 2019, 8:44 AM · Restricted Project
rtaylor added inline comments to D64954: [IR][Verifier] Allow IntToPtrInst to be !dereferenceable.
Jul 22 2019, 7:57 AM · Restricted Project
rtaylor added inline comments to D64954: [IR][Verifier] Allow IntToPtrInst to be !dereferenceable.
Jul 22 2019, 7:34 AM · Restricted Project
rtaylor added inline comments to D64954: [IR][Verifier] Allow IntToPtrInst to be !dereferenceable.
Jul 22 2019, 7:26 AM · Restricted Project

Jul 20 2019

rtaylor updated the diff for D64954: [IR][Verifier] Allow IntToPtrInst to be !dereferenceable.

Added IntToPtrInst to case statement in Value::getPointerDereferenceableBytes

Jul 20 2019, 12:44 PM · Restricted Project
rtaylor updated the diff for D64954: [IR][Verifier] Allow IntToPtrInst to be !dereferenceable.

Changed LangRef.rst to reflect !dereferenceable is applicable to pointer types not
just load types.

Jul 20 2019, 12:31 PM · Restricted Project
rtaylor added inline comments to D64933: [AMDGPU] Adjust number of SGPRs available in Calling Convention.
Jul 20 2019, 10:36 AM · Restricted Project
rtaylor updated the diff for D64933: [AMDGPU] Adjust number of SGPRs available in Calling Convention.

Updated error comment and case error test

Jul 20 2019, 10:36 AM · Restricted Project

Jul 19 2019

rtaylor updated the diff for D64933: [AMDGPU] Adjust number of SGPRs available in Calling Convention.

Changed error message in AnalyzeFormalArguments to be more generic.
Added comments.

Jul 19 2019, 3:08 PM · Restricted Project
rtaylor added inline comments to D64933: [AMDGPU] Adjust number of SGPRs available in Calling Convention.
Jul 19 2019, 2:58 PM · Restricted Project
rtaylor added inline comments to D64933: [AMDGPU] Adjust number of SGPRs available in Calling Convention.
Jul 19 2019, 2:55 PM · Restricted Project
rtaylor updated the diff for D64954: [IR][Verifier] Allow IntToPtrInst to be !dereferenceable.

Fixed test to use llvm-as and to just check for passing.

Jul 19 2019, 2:55 PM · Restricted Project
rtaylor updated the diff for D64954: [IR][Verifier] Allow IntToPtrInst to be !dereferenceable.

Added !dereferenceable_or_null to syntax of inttoptr in LangRef

Jul 19 2019, 2:44 PM · Restricted Project
rtaylor updated the diff for D64954: [IR][Verifier] Allow IntToPtrInst to be !dereferenceable.

Added tests and updated LangRef

Jul 19 2019, 2:32 PM · Restricted Project
rtaylor updated the diff for D64933: [AMDGPU] Adjust number of SGPRs available in Calling Convention.

Added test case. Changed assert to report_fatal_error when checking
arguments and returns.

Jul 19 2019, 1:39 PM · Restricted Project

Jul 18 2019

rtaylor added reviewers for D64954: [IR][Verifier] Allow IntToPtrInst to be !dereferenceable: nhaehnle, dstuttard, arsenm, apilipenko.
Jul 18 2019, 3:45 PM · Restricted Project
rtaylor created D64954: [IR][Verifier] Allow IntToPtrInst to be !dereferenceable.
Jul 18 2019, 3:38 PM · Restricted Project
rtaylor added reviewers for D64933: [AMDGPU] Adjust number of SGPRs available in Calling Convention: arsenm, nhaehnle.
Jul 18 2019, 9:57 AM · Restricted Project
rtaylor created D64933: [AMDGPU] Adjust number of SGPRs available in Calling Convention.
Jul 18 2019, 9:56 AM · Restricted Project

Jun 26 2019

rtaylor committed rG9ab812d4752b: [AMDGPU] Fix for branch offset hardware workaround (authored by rtaylor).
[AMDGPU] Fix for branch offset hardware workaround
Jun 26 2019, 10:37 AM

Jun 22 2019

rtaylor updated the diff for D63494: [AMDGPU] Fix for branch offset hardware workaround.

Fixed suggestions

Jun 22 2019, 6:31 AM · Restricted Project

Jun 20 2019

rtaylor added inline comments to D63494: [AMDGPU] Fix for branch offset hardware workaround.
Jun 20 2019, 5:16 PM · Restricted Project
rtaylor added inline comments to D63494: [AMDGPU] Fix for branch offset hardware workaround.
Jun 20 2019, 4:52 PM · Restricted Project
rtaylor added inline comments to D63494: [AMDGPU] Fix for branch offset hardware workaround.
Jun 20 2019, 3:03 PM · Restricted Project
rtaylor updated the diff for D63494: [AMDGPU] Fix for branch offset hardware workaround.

Fixed idents.

Jun 20 2019, 3:03 PM · Restricted Project
rtaylor updated the diff for D63494: [AMDGPU] Fix for branch offset hardware workaround.

Suggested changes: Added InstrMapping. Three test files. Lower-cased suffixes for MI defs. Changed multiclass suffix.

Jun 20 2019, 1:10 PM · Restricted Project
rtaylor added inline comments to D63494: [AMDGPU] Fix for branch offset hardware workaround.
Jun 20 2019, 11:18 AM · Restricted Project
rtaylor added inline comments to D63494: [AMDGPU] Fix for branch offset hardware workaround.
Jun 20 2019, 5:48 AM · Restricted Project

Jun 19 2019

rtaylor added inline comments to D63494: [AMDGPU] Fix for branch offset hardware workaround.
Jun 19 2019, 11:16 AM · Restricted Project
rtaylor updated the diff for D63494: [AMDGPU] Fix for branch offset hardware workaround.

Changes per suggestions

Jun 19 2019, 10:29 AM · Restricted Project

Jun 18 2019

rtaylor added a comment to D63494: [AMDGPU] Fix for branch offset hardware workaround.

Can we have a disasm test? I want to see that we do not mess with decoding.

Something other than the -disassemble checks?

Ah, missed it. Thanks, this is sufficient.

Jun 18 2019, 12:20 PM · Restricted Project
rtaylor added a comment to D63494: [AMDGPU] Fix for branch offset hardware workaround.

Can we have a disasm test? I want to see that we do not mess with decoding.

Jun 18 2019, 12:06 PM · Restricted Project
rtaylor added inline comments to D63494: [AMDGPU] Fix for branch offset hardware workaround.
Jun 18 2019, 8:41 AM · Restricted Project
rtaylor added inline comments to D63494: [AMDGPU] Fix for branch offset hardware workaround.
Jun 18 2019, 8:16 AM · Restricted Project
rtaylor added reviewers for D63494: [AMDGPU] Fix for branch offset hardware workaround: dstuttard, tpr, nhaehnle, rampitec, arsenm.
Jun 18 2019, 7:23 AM · Restricted Project
rtaylor created D63494: [AMDGPU] Fix for branch offset hardware workaround.
Jun 18 2019, 7:19 AM · Restricted Project

May 15 2019

rtaylor committed rG29257eb76c8d: [AMDGPU] Increases available SGPR for Calling Convention (authored by rtaylor).
[AMDGPU] Increases available SGPR for Calling Convention
May 15 2019, 7:42 AM

May 10 2019

rtaylor updated the diff for D61261: [AMDGPU] Increases available SGPR for Calling Convention.

Added test for SGPR tuple

May 10 2019, 10:49 AM · Restricted Project

May 7 2019

rtaylor updated the diff for D60834: [AMDGPU] Uniform values being used outside loop marked non-divergent.

More detailed explanation of why LCSSA is needed

May 7 2019, 7:55 AM · Restricted Project

May 6 2019

rtaylor updated the diff for D60834: [AMDGPU] Uniform values being used outside loop marked non-divergent.

Added StackProtectorID and changed LCSSA to use it instead of StackProtector directly.

May 6 2019, 9:11 AM · Restricted Project

May 2 2019

rtaylor added inline comments to D60834: [AMDGPU] Uniform values being used outside loop marked non-divergent.
May 2 2019, 3:37 PM · Restricted Project
rtaylor added inline comments to D60834: [AMDGPU] Uniform values being used outside loop marked non-divergent.
May 2 2019, 11:24 AM · Restricted Project
rtaylor updated the diff for D61261: [AMDGPU] Increases available SGPR for Calling Convention.

Fixed 105 SGPR to 106 SGPR, increased limit count for allocateSGPRTuple

May 2 2019, 10:33 AM · Restricted Project
rtaylor added a reviewer for D60834: [AMDGPU] Uniform values being used outside loop marked non-divergent: chandlerc.
May 2 2019, 10:07 AM · Restricted Project
rtaylor updated the diff for D60834: [AMDGPU] Uniform values being used outside loop marked non-divergent.

Preserving StackProtector in LCSSA to avoid pass scheduling conflict
Removed explicit call of LCSSA in AMDGPUTargetMachine

May 2 2019, 10:01 AM · Restricted Project
rtaylor added a comment to D60834: [AMDGPU] Uniform values being used outside loop marked non-divergent.

Scratch that last commit, this is still broken.

May 2 2019, 8:17 AM · Restricted Project
rtaylor updated the diff for D60834: [AMDGPU] Uniform values being used outside loop marked non-divergent.

I was misunderstanding the dependency issues, this should fix it.

May 2 2019, 8:16 AM · Restricted Project

Apr 30 2019

rtaylor updated the diff for D61261: [AMDGPU] Increases available SGPR for Calling Convention.

[AMDGPU] Increased SGPR Count for Calling Convention

Apr 30 2019, 10:01 AM · Restricted Project

Apr 29 2019

rtaylor created D61261: [AMDGPU] Increases available SGPR for Calling Convention.
Apr 29 2019, 7:14 AM · Restricted Project
rtaylor added reviewers for D61261: [AMDGPU] Increases available SGPR for Calling Convention: arsenm, nhaehnle, dstuttard, tpr, mareko.
Apr 29 2019, 7:14 AM · Restricted Project

Apr 25 2019

rtaylor added a comment to D60834: [AMDGPU] Uniform values being used outside loop marked non-divergent.

Also needs a comment explaining why LCSSA is needed

Apr 25 2019, 8:04 AM · Restricted Project

Apr 23 2019

rtaylor updated the diff for D60834: [AMDGPU] Uniform values being used outside loop marked non-divergent.

Moved LCSSA call to after the sinking pass.

Apr 23 2019, 6:44 AM · Restricted Project

Apr 17 2019

rtaylor added a comment to D60834: [AMDGPU] Uniform values being used outside loop marked non-divergent.

It sort of intuitively makes sense to me that the control flow lowering would like LCSSA. However, this should not be handled by adding it directly to the pass pipeline. You can add this as a dependency, e.g. AU.addRequiredID(LCSSAID);

I would also like to see the an IR->IR testcase showing LCSSA was implicitly run

Actually, what really requires LCSSA? Is it DivergenceAnalysis or StructurizeCFG directly?

Apr 17 2019, 3:36 PM · Restricted Project
rtaylor added reviewers for D60834: [AMDGPU] Uniform values being used outside loop marked non-divergent: dstuttard, nhaehnle, tpr.
Apr 17 2019, 1:21 PM · Restricted Project
rtaylor added a comment to D60834: [AMDGPU] Uniform values being used outside loop marked non-divergent.

This is a workaround. The structurizer / annotator must be correct without relying on another pass to hide situations they don't handle correctly

Apr 17 2019, 1:21 PM · Restricted Project
rtaylor added a comment to D60834: [AMDGPU] Uniform values being used outside loop marked non-divergent.

We have a test case such that a value that is uniform in the loop is used outside the loop where threads might have diverged.

Apr 17 2019, 1:15 PM · Restricted Project
rtaylor created D60834: [AMDGPU] Uniform values being used outside loop marked non-divergent.
Apr 17 2019, 12:56 PM · Restricted Project

Mar 20 2019

rtaylor closed D42885: [AMDGPU] intrintrics for byte/short load/store.
Mar 20 2019, 7:12 AM · Restricted Project

Mar 19 2019

rtaylor committed rG00e063ab9234: [AMDGPU] Add buffer/load 8/16 bit overloaded intrinsics (authored by rtaylor).
[AMDGPU] Add buffer/load 8/16 bit overloaded intrinsics
Mar 19 2019, 9:10 AM

Mar 12 2019

rtaylor updated the diff for D42885: [AMDGPU] intrintrics for byte/short load/store.

Requested Changes

Mar 12 2019, 3:29 PM · Restricted Project
rtaylor updated the diff for D42885: [AMDGPU] intrintrics for byte/short load/store.

Add requested changes

Mar 12 2019, 9:50 AM · Restricted Project
rtaylor commandeered D42885: [AMDGPU] intrintrics for byte/short load/store.

Changing ownership

Mar 12 2019, 9:50 AM · Restricted Project