This is an archive of the discontinued LLVM Phabricator instance.

[AArch64][SVE] Asm: Support for contiguous LD1 (scalar+imm) load instructions
ClosedPublic

Authored by sdesmalen on Apr 13 2018, 4:38 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

sdesmalen created this revision.Apr 13 2018, 4:38 AM
rengolin accepted this revision.Apr 13 2018, 5:08 AM

LGTM, thanks!

lib/Target/AArch64/AArch64SVEInstrInfo.td
32 ↗(On Diff #142370)

Nit: keep the same order S/D :)

This revision is now accepted and ready to land.Apr 13 2018, 5:08 AM

LGTM, thanks!

Thanks for the quick review!

lib/Target/AArch64/AArch64SVEInstrInfo.td
32 ↗(On Diff #142370)

I actually did this on purpose because the SVE specification orders it by encoding (first column).

rengolin added inline comments.Apr 13 2018, 7:05 AM
lib/Target/AArch64/AArch64SVEInstrInfo.td
32 ↗(On Diff #142370)

makes sense. As good reason as any. :)

This revision was automatically updated to reflect the committed changes.