mask reductions
Needs ReviewPublic
Actions

Authored by timshen on Jan 8 2018, 4:46 PM.

Details

Reviewers

mclow.lists
EricWF

Summary

Implemented reduce using "identity_value", with the following requirement from the caller:

binary_op(x, identity_value) == binary_op(identity_value, x) == x, for all x.

Diff Detail

Build Status

Buildable 16235
Build 16235: arc lint + arc unit

Event Timeline

timshen created this revision.Jan 8 2018, 4:46 PM

Herald added a subscriber: sanjoy. · View Herald TranscriptJan 8 2018, 4:46 PM

timshen added a parent revision: D41843: [libcxx] implement <experimental/simd> where expressions..Jan 8 2018, 4:47 PM

timshen added a child revision: D41845: [libcxx] clean up and complete <experimental/simd>.

lichray added inline comments.Jan 18 2018, 4:29 PM

libcxx/include/experimental/simd
1665	Specified in terms of the transparent `plus<>`.

Rebase.

Herald added a subscriber: christof. · View Herald TranscriptMar 19 2018, 5:40 PM

Harbormaster completed remote builds in B16235: Diff 139044.Mar 19 2018, 5:41 PM

timshen edited the summary of this revision. (Show Details)Apr 5 2018, 11:48 AM

miyuki added a subscriber: miyuki.Jul 4 2018, 7:34 AM

Herald added subscribers: bixia, jlebar. · View Herald TranscriptJul 4 2018, 7:34 AM

grosser added a subscriber: grosser.Jul 15 2019, 11:03 PM

Revision Contents
Changeset List

			Path	Packages
M			libcxx/include/experimental/simd (97 lines)
M			libcxx/test/std/experimental/simd/simd.horizontal/hmax.pass.cpp (34 lines)
M			libcxx/test/std/experimental/simd/simd.horizontal/hmin.pass.cpp (27 lines)
M			libcxx/test/std/experimental/simd/simd.horizontal/reduce.pass.cpp (39 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	129004	5a45597		Jan 8 2018, 4:46 PM	★	★
Diff 2	139044	aa7c581	Rebase.	Mar 19 2018, 5:40 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
bd23cd78d66b	d2678472d04c	aa7c5811a9e7	Tim Shen	[libcxx] implement <experimental/simd> mask reductions (Show More…)	Jan 8 2018, 4:32 PM

Status	Author	Revision
Accepted	timshen	D44665 [libcxx] Update synopsis to P0214R9
Accepted	timshen	D44664 [libcxx] Add missing <experimental/simd> __simd_reference pieces based on R9.
Needs Review	timshen	D44663 [libcxx] Update <experimental/simd> with R9 changes
Needs Review	timshen	D44662 [libcxx] In <experimental/simd>, optimize masked div and rem.
Needs Review	timshen	D44661 [libcxx] optimize reduce(), hmin(), hmax() by reordering the operations.
Needs Review	timshen	D44660 [libcxx] unroll the loops in <experimental/simd> for Clang, until LLVM bugs are fixed
Needs Review	timshen	D44659 [libcxx] Optimize <experimental/simd> -O0 performance for operators
Needs Review	timshen	D44658 [libcxx] Implement <experimental/simd> aligned load and store when compiled with Clang.
Needs Review	timshen	D44657 [libcxx] fix a sanitizer-reported bug in <experimental/simd>
Needs Review	timshen	D44656 [libcxx] Add <experimental/simd> conversions between underlying non-portable types and simd/simd_mask types.
Accepted	timshen	D41845 [libcxx] clean up and complete <experimental/simd>
Needs Review	timshen	D41844 [libcxx] implement <experimental/simd> mask reductions
Needs Review	timshen	D41843 [libcxx] implement <experimental/simd> where expressions.
Needs Review	timshen	D41756 [libcxx] implement <experimental/simd> simd_mask<> casts and some horizontal operations.
Needs Review	timshen	D41747 [libcxx] implement <experimental/simd> simd_mask<> and operators.
Needs Review	timshen	D41422 [libcxx] implement <experimental/simd> operators and reduction.
Needs Review	timshen	D41415 [libcxx] implement <experimental/simd> casts.
Needs Review	timshen	D41412 [libcxx] implement <experimental/simd> concat() and split()
Closed	timshen	D41376 [libcxx] Implement <simd> ABI for Clang/GCC vector extension, constructors, copy_from and copy_to.
Closed	timshen	D41148 [libcxx] implement <experimental/simd> declarations based on P0214R7.