lichray (Zhihao Yuan)
Spy

Projects

User does not belong to any projects.

User Details

User Since
Oct 21 2017, 7:38 PM (55 w, 6 d)

Recent Activity

Thu, Nov 8

lichray accepted D49863: [istream] Fix error flags and exceptions propagated from input stream operations.
Thu, Nov 8, 11:22 AM

Sat, Nov 3

lichray retitled D44865: [libc++] Implement P0608R3 - A sane variant converting constructor from [libc++] Implement P0608R2 - A sane variant converting constructor to [libc++] Implement P0608R3 - A sane variant converting constructor.
Sat, Nov 3, 11:59 PM
lichray updated the diff for D44865: [libc++] Implement P0608R3 - A sane variant converting constructor.

Updated implementation for R3

Sat, Nov 3, 11:54 PM
lichray updated the diff for D51268: [libc++] Implement P0487R1 - Fixing operator>>(basic_istream&, CharT*).

Rebased

Sat, Nov 3, 11:55 AM

Sep 30 2018

lichray added a comment to D52401: Remove redundant null pointer check in operator delete.

__free_hook (defaults to NULL) is a user-supplied hook (https://www.gnu.org/software/libc/manual/html_node/Hooks-for-Malloc.html).

Sep 30 2018, 7:17 PM

Sep 28 2018

lichray added a comment to D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style).

In my case, the main requirement is to be able avoid a lambda in one line.

Sep 28 2018, 10:45 PM
lichray reopened D52401: Remove redundant null pointer check in operator delete.

LGTM as well, unless @mclow.lists can tell us some history like interactions with K&R libc :)

Sep 28 2018, 9:49 PM

Sep 22 2018

lichray committed rL342810: Document new symbols for __u64toa and __u32toa.
Document new symbols for __u64toa and __u32toa
Sep 22 2018, 11:07 AM
lichray committed rCXX342810: Document new symbols for __u64toa and __u32toa.
Document new symbols for __u64toa and __u32toa
Sep 22 2018, 11:07 AM
lichray closed D52391: Document new symbols for __u64toa and __u32toa.
Sep 22 2018, 11:06 AM
lichray created D52391: Document new symbols for __u64toa and __u32toa.
Sep 22 2018, 10:18 AM

Sep 21 2018

lichray added a comment to D52240: Partial Fix for PR#38964.
In D52240#1242536, @dim wrote:
Symbol added: __ZNSt3__16__itoa8__u32toaEjPc
    {'type': 'FUNC', 'is_defined': True, 'name': '__ZNSt3__16__itoa8__u32toaEjPc'}

Symbol added: __ZNSt3__16__itoa8__u64toaEyPc
    {'type': 'FUNC', 'is_defined': True, 'name': '__ZNSt3__16__itoa8__u64toaEyPc'}

So I assume the ABI is already broken in some way...

This appears to be a consequence of rL338479 by @lichray , but since it only *adds* two functions, it might be harmless...

Sep 21 2018, 2:00 PM

Aug 25 2018

lichray created D51268: [libc++] Implement P0487R1 - Fixing operator>>(basic_istream&, CharT*).
Aug 25 2018, 11:04 PM

Aug 9 2018

lichray added a comment to D50543: [libcxx] Mark charconv tests as failing for previous libcxx versions..

LGTM. @ldionne 's job to confirm.

Aug 9 2018, 6:06 PM

Jul 31 2018

lichray committed rL338486: [libc++] Fix build failures after merging <charconv>.
[libc++] Fix build failures after merging <charconv>
Jul 31 2018, 10:21 PM
lichray committed rCXX338486: [libc++] Fix build failures after merging <charconv>.
[libc++] Fix build failures after merging <charconv>
Jul 31 2018, 10:21 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Jul 31 2018, 10:21 PM
lichray created D50130: [libc++] Fix build failures after merging <charconv>.
Jul 31 2018, 10:20 PM
lichray committed rCXX338479: [libc++][C++17] Elementary string conversions for integral types.
[libc++][C++17] Elementary string conversions for integral types
Jul 31 2018, 7:40 PM
lichray committed rL338479: [libc++][C++17] Elementary string conversions for integral types.
[libc++][C++17] Elementary string conversions for integral types
Jul 31 2018, 7:40 PM
lichray closed D41458: [libc++][C++17] Elementary string conversions for integral types.
Jul 31 2018, 7:40 PM
lichray updated the diff for D41458: [libc++][C++17] Elementary string conversions for integral types.

Dropping a lambda

Jul 31 2018, 3:28 PM

Jul 30 2018

lichray added inline comments to D41458: [libc++][C++17] Elementary string conversions for integral types.
Jul 30 2018, 2:01 PM

Jul 20 2018

lichray added a comment to D41458: [libc++][C++17] Elementary string conversions for integral types.

Ping. Any more comments?

Jul 20 2018, 2:42 AM
lichray abandoned D39412: [Driver] Give LIBRARY_PATH precedence over native toolchains.
Jul 20 2018, 1:26 AM

Jul 18 2018

lichray updated the summary of D41458: [libc++][C++17] Elementary string conversions for integral types.
Jul 18 2018, 12:53 PM

Jul 16 2018

lichray added inline comments to D41458: [libc++][C++17] Elementary string conversions for integral types.
Jul 16 2018, 4:12 PM
lichray updated the diff for D41458: [libc++][C++17] Elementary string conversions for integral types.

Uglify all the names

Jul 16 2018, 4:03 PM
lichray added inline comments to D41458: [libc++][C++17] Elementary string conversions for integral types.
Jul 16 2018, 9:16 AM

Jul 10 2018

lichray updated the summary of D41458: [libc++][C++17] Elementary string conversions for integral types.
Jul 10 2018, 10:43 AM
lichray added inline comments to D41458: [libc++][C++17] Elementary string conversions for integral types.
Jul 10 2018, 10:41 AM
lichray updated the diff for D41458: [libc++][C++17] Elementary string conversions for integral types.

Dropping C++11 support.

Jul 10 2018, 10:38 AM
lichray added inline comments to D41458: [libc++][C++17] Elementary string conversions for integral types.
Jul 10 2018, 8:53 AM
lichray updated the diff for D41458: [libc++][C++17] Elementary string conversions for integral types.

Less trailing return types

Jul 10 2018, 8:38 AM
lichray updated the diff for D41458: [libc++][C++17] Elementary string conversions for integral types.

Respond to the 2nd round review

Jul 10 2018, 7:29 AM
lichray added inline comments to D41458: [libc++][C++17] Elementary string conversions for integral types.
Jul 10 2018, 7:28 AM

Jul 9 2018

lichray added inline comments to D41458: [libc++][C++17] Elementary string conversions for integral types.
Jul 9 2018, 2:27 PM

Jul 3 2018

lichray updated the diff for D41458: [libc++][C++17] Elementary string conversions for integral types.

Install the header file

Jul 3 2018, 3:06 AM
lichray added inline comments to D41458: [libc++][C++17] Elementary string conversions for integral types.
Jul 3 2018, 1:00 AM
lichray updated the diff for D41458: [libc++][C++17] Elementary string conversions for integral types.

A macro-free implementation

Jul 3 2018, 12:54 AM

Jul 2 2018

lichray committed rL336165: [libc++] Install the missing header __errc.
[libc++] Install the missing header __errc
Jul 2 2018, 9:06 PM
lichray committed rCXX336165: [libc++] Install the missing header __errc.
[libc++] Install the missing header __errc
Jul 2 2018, 9:06 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Jul 2 2018, 9:06 PM
lichray created D48864: [libc++] Install the missing header __errc.
Jul 2 2018, 9:05 PM
lichray committed rL336164: [libc++] Lift std::errc into a separated header.
[libc++] Lift std::errc into a separated header
Jul 2 2018, 8:30 PM
lichray committed rCXX336164: [libc++] Lift std::errc into a separated header.
[libc++] Lift std::errc into a separated header
Jul 2 2018, 8:30 PM
lichray closed D41347: [libc++] Lift std::errc into a separated header.
Jul 2 2018, 8:30 PM

Jun 4 2018

lichray updated the diff for D44865: [libc++] Implement P0608R3 - A sane variant converting constructor.

Refine coding style

Jun 4 2018, 12:11 PM
lichray updated the diff for D44865: [libc++] Implement P0608R3 - A sane variant converting constructor.

Preserve value category in narrowing test.

Jun 4 2018, 12:04 PM
lichray retitled D44865: [libc++] Implement P0608R3 - A sane variant converting constructor from [libc++] Implement P0608R1 - A sane variant converting constructor to [libc++] Implement P0608R2 - A sane variant converting constructor.
Jun 4 2018, 12:00 PM

May 22 2018

lichray added inline comments to D41458: [libc++][C++17] Elementary string conversions for integral types.
May 22 2018, 5:56 AM
lichray added a comment to D41347: [libc++] Lift std::errc into a separated header.

Sorry this took so long. Please update test/libcxx/double_include.sh.cpp and commit.

May 22 2018, 5:47 AM

Apr 5 2018

lichray updated the diff for D41458: [libc++][C++17] Elementary string conversions for integral types.

Update module map

Apr 5 2018, 12:06 AM
lichray updated the diff for D41347: [libc++] Lift std::errc into a separated header.

Update module map

Apr 5 2018, 12:03 AM

Mar 29 2018

lichray committed rL328797: [test] Fix an XRay test on FreeBSD.
[test] Fix an XRay test on FreeBSD
Mar 29 2018, 8:53 AM
lichray committed rC328797: [test] Fix an XRay test on FreeBSD.
[test] Fix an XRay test on FreeBSD
Mar 29 2018, 8:53 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Mar 29 2018, 8:53 AM
lichray retitled D45002: [test] Fix an XRay test on FreeBSD from [test] Fix a XRay test on FreeBSD to [test] Fix an XRay test on FreeBSD.
Mar 29 2018, 8:46 AM
lichray retitled D45002: [test] Fix an XRay test on FreeBSD from [test] Conservatively re-enable a FreeBSD/XRay test to [test] Fix a XRay test on FreeBSD.
Mar 29 2018, 8:46 AM

Mar 28 2018

lichray updated the diff for D44865: [libc++] Implement P0608R3 - A sane variant converting constructor.

More tests

Mar 28 2018, 9:50 PM
lichray added inline comments to D45002: [test] Fix an XRay test on FreeBSD.
Mar 28 2018, 4:32 PM
lichray created D45002: [test] Fix an XRay test on FreeBSD.
Mar 28 2018, 3:17 PM

Mar 27 2018

lichray updated the diff for D44865: [libc++] Implement P0608R3 - A sane variant converting constructor.

Macro-free

Mar 27 2018, 6:12 PM

Mar 26 2018

lichray added inline comments to D44865: [libc++] Implement P0608R3 - A sane variant converting constructor.
Mar 26 2018, 9:58 PM
lichray added inline comments to D44865: [libc++] Implement P0608R3 - A sane variant converting constructor.
Mar 26 2018, 8:34 PM
lichray updated the diff for D44865: [libc++] Implement P0608R3 - A sane variant converting constructor.

Keep changes small

Mar 26 2018, 8:31 PM
lichray added a comment to D44865: [libc++] Implement P0608R3 - A sane variant converting constructor.

Has this paper been adopted into the standard yet?

Mar 26 2018, 8:30 PM
lichray added inline comments to D44823: [libcxx] Improving std::vector<char> and std::deque<char> perfomance.
Mar 26 2018, 1:04 PM

Mar 25 2018

lichray accepted D44665: [libcxx] Update synopsis to P0214R9.
Mar 25 2018, 1:35 AM
lichray accepted D44664: [libcxx] Add missing <experimental/simd> __simd_reference pieces based on R9..
Mar 25 2018, 1:32 AM
lichray added inline comments to D44661: [libcxx] optimize reduce(), hmin(), hmax() by reordering the operations..
Mar 25 2018, 1:27 AM
lichray added inline comments to D44661: [libcxx] optimize reduce(), hmin(), hmax() by reordering the operations..
Mar 25 2018, 1:20 AM
lichray accepted D44823: [libcxx] Improving std::vector<char> and std::deque<char> perfomance.

Something std::byte couldn't help lol

Mar 25 2018, 12:22 AM

Mar 24 2018

lichray updated the diff for D44865: [libc++] Implement P0608R3 - A sane variant converting constructor.

Use less traits

Mar 24 2018, 2:17 AM
lichray created D44865: [libc++] Implement P0608R3 - A sane variant converting constructor.
Mar 24 2018, 1:24 AM

Mar 23 2018

lichray committed rL328409: [C++17] Fix class template argument deduction for default constructors without….
[C++17] Fix class template argument deduction for default constructors without…
Mar 23 2018, 9:35 PM
lichray committed rC328409: [C++17] Fix class template argument deduction for default constructors without….
[C++17] Fix class template argument deduction for default constructors without…
Mar 23 2018, 9:35 PM
lichray closed D38216: [C++17] Fix class template argument deduction for default constructors without an initializer.
Mar 23 2018, 9:35 PM · Restricted Project
lichray updated the summary of D38216: [C++17] Fix class template argument deduction for default constructors without an initializer.
Mar 23 2018, 7:47 PM · Restricted Project

Mar 22 2018

lichray updated the diff for D41458: [libc++][C++17] Elementary string conversions for integral types.

Reorganize files

Mar 22 2018, 3:01 AM
lichray added inline comments to D41458: [libc++][C++17] Elementary string conversions for integral types.
Mar 22 2018, 2:58 AM

Mar 18 2018

lichray accepted D38216: [C++17] Fix class template argument deduction for default constructors without an initializer.
Mar 18 2018, 10:21 PM · Restricted Project

Mar 17 2018

lichray updated the diff for D41458: [libc++][C++17] Elementary string conversions for integral types.

Keep patches split

Mar 17 2018, 10:07 PM
lichray updated the diff for D41458: [libc++][C++17] Elementary string conversions for integral types.

Addressing 'Done' comments

Mar 17 2018, 10:05 PM
lichray added inline comments to D41458: [libc++][C++17] Elementary string conversions for integral types.
Mar 17 2018, 10:04 PM
lichray added a comment to D38216: [C++17] Fix class template argument deduction for default constructors without an initializer.

LGTM

Mar 17 2018, 2:59 PM · Restricted Project
lichray committed rL327782: [C++17] Allow an empty expression in an if init statement.
[C++17] Allow an empty expression in an if init statement
Mar 17 2018, 2:45 PM
lichray committed rC327782: [C++17] Allow an empty expression in an if init statement.
[C++17] Allow an empty expression in an if init statement
Mar 17 2018, 2:45 PM
lichray closed D40445: [C++17] Allow an empty expression in an if init statement.
Mar 17 2018, 2:45 PM · Restricted Project
lichray updated the summary of D40445: [C++17] Allow an empty expression in an if init statement.
Mar 17 2018, 2:41 PM · Restricted Project
lichray committed rL327780: Fix codegen for structured binding binding in conditions.
Fix codegen for structured binding binding in conditions
Mar 17 2018, 2:04 PM
lichray committed rC327780: Fix codegen for structured binding binding in conditions.
Fix codegen for structured binding binding in conditions
Mar 17 2018, 2:04 PM
lichray closed D44534: Fix codegen for structured binding binding in conditions.
Mar 17 2018, 2:04 PM · Restricted Project
lichray updated the summary of D44534: Fix codegen for structured binding binding in conditions.
Mar 17 2018, 2:03 PM · Restricted Project
lichray accepted D44534: Fix codegen for structured binding binding in conditions.
Mar 17 2018, 2:02 PM · Restricted Project

Mar 11 2018

lichray added a comment to D41458: [libc++][C++17] Elementary string conversions for integral types.

Pending patch update due to poor network.

Mar 11 2018, 7:46 PM

Feb 9 2018

lichray added a comment to D41458: [libc++][C++17] Elementary string conversions for integral types.

I will pick up the changes later next week.

Feb 9 2018, 11:11 PM

Jan 18 2018

lichray added inline comments to D41843: [libcxx] implement <experimental/simd> where expressions..
Jan 18 2018, 4:43 PM
lichray added inline comments to D41844: [libcxx] implement <experimental/simd> mask reductions.
Jan 18 2018, 4:30 PM
lichray accepted D41845: [libcxx] clean up and complete <experimental/simd>.
Jan 18 2018, 4:16 PM