Sorry for missing tra's ping earlier, I get a lot of HIP email traffic that's 99% inactionable by me, so I didn't notice my username in tra's earlier email.

+tra in the hopes that perhaps he's comfortable reviewing this (sorry that I'm not).

I defer to the others here.

Just to check, the notion is that it's OK if I report a sm version less than what I end up running on?

I'm not confident that the GUIDS remain stable, either. I have no data to tell one way or another, though.

You don't want to pass in the GPU-deadbeef form from nvidia-smi -L so we don't have this problem?

Looks right to me (other than the missing constexpr in C++14 onwards). Though this is subtle enough that I suspect the only way to know for sure is to try it.

In D47757#1142886, @ahatanak wrote:

I mean ToT clang (without my patch applied) seems to select the non-sized host version 'T::operator delete(void*)'.

@jlebar, is the change I made to call-host-fn-from-device.cu correct?

@rsmith friendly ping on this one.

In D48151#1133954, @rsmith wrote:

LGTM

@rsmith friendly ping on this one.

@rsmith friendly ping on this review.

Thank you for the reviews, Sanjoy!

Sorry, bit of a phab phail, I meant to send out this revision differently.

In D48036#1131279, @tra wrote:

Ack.

Last comment in the bug pointed out that those overloads should be constexpr in c++14. Maybe in a separate patch, though.

Thank you for the reviews!

Fix all remaining tests.

What could possibly go wrong.

I can't think of any reason why we'd drop the flags in this case.

In D47113#1106541, @bixia wrote:

InstCombiner::visitShl performs similar narrowing without checking user count and can increase the total number to ZExt instructions.

Seems reasonable to me. I dunno if this solves @bixia's problem or not, but even if it doesn't, seems reasonable...

I defer to Art on this one.