Google developer working on CUDA for Clang. On IRC as jlebar.
User Details
- User Since
- Dec 8 2015, 10:33 AM (267 w, 5 d)
Fri, Jan 22
Sun, Jan 10
Hi, welcome! Thank you for the careful and well-motivated first commit. (I also see https://github.com/ccache/ccache/issues/772, hooray for noticing that...)
Dec 4 2020
Nov 29 2020
This looks reasonable to me (and I appreciate all the debugging in the Julia bug!), but I have never touched this code, so I don't 100% feel comfortable approving the change.
Nov 27 2020
Nov 22 2020
In case it's not used in PHI or SELECT and cannot ensure the result is also a pointer to the parameter space, we could skip alloca insertion.
I don't believe there's any exception to prove deduction [of the readonly attribute] wrong.
This looks really simple, which is awesome. I am enthusiastic. But I am worried it may not be correct.
Nov 19 2020
How fun. :)
Nov 17 2020
I am legit excited about this if we could figure out how to make it work, but I don't have anything to add beyond what tra said.
Nov 9 2020
The bottomline seems to be that the proposed formalism achieves the following: <snip>
Nov 3 2020
LGTM. I think the change would make sense for CUDA, too. @jlebar - WDYT?
Nov 1 2020
Man, phab doesn't make this easy, does it?
Oct 28 2020
Hi. :) A few people pinged me asking for my feedback here, since I touched the convergent attr way back in the day, for CUDA.
Oct 22 2020
LGTM modulo emankov's comment.
Oct 14 2020
Fix bug in test command line, and fix commit message.
It does not quite match what we do here.
Oct 13 2020
Oct 2 2020
Hey, I'm leaving on a vacation tomorrow and didn't have a chance to get to
this review today.
Oct 1 2020
It looks like 11.1 doesn't have a version.txt file
Sep 28 2020
It should. I did mention in a previous comment that > Looks like the const-ness check should not be there, either. I need to revise the patch.
OK, now I'm starting to I understand this change..
OK, backing up, what are the semantics of static on __constant__, __device__, and __shared__?
Sep 25 2020
wha... As you know, const doesn't mean anything, that can be const-casted away. And then you'll be able to observe that this nominally-static variable is just a normal variable.
Sep 24 2020
I know it comes in a separate change, but can we add a check to the test-suite?
Aug 5 2020
Aug 4 2020
LGTM, and can we write a test in the test-suite?
Jul 15 2020
tra and I talked offline and I...think this makes sense.
Mar 1 2020
@RKSimon and others, thank you for the review and comments. Sorry for my delay here; this has changed from being my day job to my weekend hobby, and that made a bigger difference in my responsiveness than I'd like or than I expected.
Update per comments.
Feb 23 2020
Feb 18 2020
Thank you for the comments!
Feb 12 2020
Submitted as a4384c756bd8a8190510. I'm working from my wife's machine and accidentally submitted with her name instead of mine. Oops. :)
Thank you for the reviews!
@RKSimon friendly ping
Do we have any nontrivially-long namespaces in LLVM?
Feb 11 2020
Thank you for the reviews!
Lint: Pre-merge checks
Rebase
Rebase
Rebase
Thank you for the review!
Thank you for the review!
Feb 10 2020
Such changes can be risky.
Since is_trivially_constructible<T>::type doesn't exist, wouldn't this always be a substitution failure?
Rebase to origin/master.
Undo overzealous re-clang-formatting.
Attempt to remove files that should have been ignored.
"How did this ever work?" Since is_trivially_constructible<T>::type doesn't exist, wouldn't this always be a substitution failure?
arc is not cooperating; I'm going to delete this and create a new review. Sorry for the noise.
Attempt to remove files which shouldn't be in here.
Hm, thank you, arc, for including files that were not in my commit...
Fix regressions and add vector test.
Feb 7 2020
Hi, thank you for looking at this!
Feb 6 2020
Thank you for the reviews, and I'm sorry I dropped off the face of the earth here! I was messing with my phab settings and I think I somehow disabled all emails. Oops.