Google developer working on CUDA for Clang. On IRC as jlebar.
- User Since
- Dec 8 2015, 10:33 AM (132 w, 1 d)
Fri, Jun 15
@rsmith friendly ping on this one.
@rsmith friendly ping on this review.
Thu, Jun 14
Thank you for the reviews, Sanjoy!
Wed, Jun 13
Sorry, bit of a phab phail, I meant to send out this revision differently.
Last comment in the bug pointed out that those overloads should be constexpr in c++14. Maybe in a separate patch, though.
Mon, Jun 11
Thank you for the reviews!
Fix all remaining tests.
Wed, Jun 6
Tue, Jun 5
What could possibly go wrong.
Mon, Jun 4
I can't think of any reason why we'd drop the flags in this case.
Wed, May 23
May 21 2018
May 20 2018
Seems reasonable to me. I dunno if this solves @bixia's problem or not, but even if it doesn't, seems reasonable...
May 18 2018
I defer to Art on this one.
May 17 2018
Thanks for the reviews, Art. Submitting with this change...
NVPTX/implicit-def.ll - this isn't testing what it intended to test, but I don't know how to do that...could just delete the file?
Thank you for the review, Richard. Submitting this with these changes...
Thank you for the review!
May 16 2018
Address Richard's review comments.
Thank you for the careful review, Richard.
May 11 2018
The plot thickens.
__shared__ int a; extern __shared__ int c;
Does this behave like a tentative definition?
I am a total ignoramus when it comes to linkage, so maybe this is a dumb question, but what does it mean for a static variable inside of a function inside of an anon ns to have external linkage?
May 10 2018
Apr 26 2018
Ben, are you comfortable reviewing this?