Page MenuHomePhabricator

jlebar (Justin Lebar)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 8 2015, 10:33 AM (250 w, 5 d)

Google developer working on CUDA for Clang. On IRC as jlebar.

Recent Activity

Fri, Sep 25

jlebar added a comment to D88345: [CUDA] Allow local `static const {__constant__, __device__}` variables..

wha... As you know, const doesn't mean anything, that can be const-casted away. And then you'll be able to observe that this nominally-static variable is just a normal variable.

Fri, Sep 25, 4:47 PM · Restricted Project

Thu, Sep 24

jlebar accepted D88255: [test-suite, CUDA] Compile-time test for builtin variables..
Thu, Sep 24, 1:03 PM
jlebar accepted D88250: [CUDA] Added dim3/uint3 conversion functions to builtin vars..

I know it comes in a separate change, but can we add a check to the test-suite?

Thu, Sep 24, 11:14 AM · Restricted Project

Aug 5 2020

jlebar accepted D85352: [CUDA, test-suite] More test cases for rint() and nearint().
Aug 5 2020, 12:59 PM
jlebar accepted D85349: [CUDA, test-suite] Prevent constant folding of the test inputs..
Aug 5 2020, 12:58 PM

Aug 4 2020

jlebar accepted D85236: [CUDA] Work around a bug in rint() caused by a broken implementation provided by CUDA..

LGTM, and can we write a test in the test-suite?

Aug 4 2020, 12:25 PM · Restricted Project

Jul 15 2020

jlebar added a comment to D83893: [CUDA][HIP] Always defer diagnostics for wrong-sided reference.

tra and I talked offline and I...think this makes sense.

Jul 15 2020, 4:33 PM · Restricted Project

Mar 1 2020

jlebar added a comment to D74165: [x86] [DAGCombine] Prefer shifts of constant widths..

@RKSimon and others, thank you for the review and comments. Sorry for my delay here; this has changed from being my day job to my weekend hobby, and that made a bigger difference in my responsiveness than I'd like or than I expected.

Mar 1 2020, 12:43 PM · Restricted Project
jlebar updated the diff for D74165: [x86] [DAGCombine] Prefer shifts of constant widths..

Update per comments.

Mar 1 2020, 12:40 PM · Restricted Project

Feb 23 2020

jlebar committed rG10a0ec62f671: Replace std::foo with std::foo_t in LLVM. (authored by jlebar).
Replace std::foo with std::foo_t in LLVM.
Feb 23 2020, 11:27 AM

Feb 18 2020

jlebar added inline comments to D74165: [x86] [DAGCombine] Prefer shifts of constant widths..
Feb 18 2020, 1:30 PM · Restricted Project
jlebar added inline comments to D74165: [x86] [DAGCombine] Prefer shifts of constant widths..
Feb 18 2020, 1:12 PM · Restricted Project
jlebar added a comment to D74165: [x86] [DAGCombine] Prefer shifts of constant widths..

Thank you for the comments!

Feb 18 2020, 1:03 PM · Restricted Project

Feb 12 2020

jlebar closed D74493: Replace std::foo with std::foo_t in LLVM..

Submitted as a4384c756bd8a8190510. I'm working from my wife's machine and accidentally submitted with her name instead of mine. Oops. :)

Feb 12 2020, 6:01 PM · Restricted Project
jlebar added a comment to D74493: Replace std::foo with std::foo_t in LLVM..

Thank you for the reviews!

Feb 12 2020, 4:22 PM · Restricted Project
jlebar abandoned D53414: Add instructions for migrating branches from one git repository to another..
Feb 12 2020, 4:22 PM · Restricted Project
jlebar added a comment to D74165: [x86] [DAGCombine] Prefer shifts of constant widths..

@RKSimon friendly ping

Feb 12 2020, 4:22 PM · Restricted Project
jlebar added a comment to D74515: Add coding standard recommending use of qualifiers in cpp files.

Do we have any nontrivially-long namespaces in LLVM?

Feb 12 2020, 4:04 PM · Restricted Project
jlebar created D74493: Replace std::foo with std::foo_t in LLVM..
Feb 12 2020, 9:10 AM · Restricted Project
jlebar committed rGbc316c21570b: Fix SFINAE in llvm::bit_cast. (authored by jlebar).
Fix SFINAE in llvm::bit_cast.
Feb 12 2020, 8:33 AM
jlebar committed rG17b774181211: Fix compilation of Any.h header. (authored by jlebar).
Fix compilation of Any.h header.
Feb 12 2020, 8:33 AM
jlebar closed D74380: Fix SFINAE in llvm::bit_cast..
Feb 12 2020, 8:33 AM · Restricted Project
jlebar added a comment to D74384: Use std::foo_t rather than std::foo in LLVM..

Looks like this broke building on windows with clang-cl as host compiler in some situations: http://45.33.8.238/win/8160/step_4.txt

Feb 12 2020, 8:14 AM · Restricted Project, Restricted Project

Feb 11 2020

jlebar added a comment to D74380: Fix SFINAE in llvm::bit_cast..

Thank you for the reviews!

Feb 11 2020, 11:21 PM · Restricted Project
jlebar committed rG1bd6123b7811: Use std::foo_t rather than std::foo in LLVM. (authored by jlebar).
Use std::foo_t rather than std::foo in LLVM.
Feb 11 2020, 3:17 PM
jlebar closed D74384: Use std::foo_t rather than std::foo in LLVM..
Feb 11 2020, 3:17 PM · Restricted Project, Restricted Project
jlebar committed rGac66c61bf946: Use C++14-style return type deduction in clang. (authored by jlebar).
Use C++14-style return type deduction in clang.
Feb 11 2020, 2:50 PM
jlebar closed D74423: Use C++14-style return type deduction in clang..
Feb 11 2020, 2:49 PM · Restricted Project
jlebar committed rG027eb71696f6: Use std::foo_t rather than std::foo in clang. (authored by jlebar).
Use std::foo_t rather than std::foo in clang.
Feb 11 2020, 10:42 AM
jlebar committed rGf0fd852fcd05: Fix SFINAE in CFG.cpp. (authored by jlebar).
Fix SFINAE in CFG.cpp.
Feb 11 2020, 10:42 AM
jlebar closed D74414: Use std::foo_t rather than std::foo in clang..
Feb 11 2020, 10:42 AM · Restricted Project
jlebar closed D74412: Fix SFINAE in CFG.cpp..
Feb 11 2020, 10:42 AM · Restricted Project
jlebar created D74423: Use C++14-style return type deduction in clang..
Feb 11 2020, 10:42 AM · Restricted Project
jlebar added a comment to D74380: Fix SFINAE in llvm::bit_cast..

Lint: Pre-merge checks

Feb 11 2020, 9:03 AM · Restricted Project
jlebar created D74414: Use std::foo_t rather than std::foo in clang..
Feb 11 2020, 7:50 AM · Restricted Project
jlebar updated the diff for D74412: Fix SFINAE in CFG.cpp..

Rebase

Feb 11 2020, 7:50 AM · Restricted Project
jlebar created D74412: Fix SFINAE in CFG.cpp..
Feb 11 2020, 7:50 AM · Restricted Project
jlebar updated the diff for D74384: Use std::foo_t rather than std::foo in LLVM..

Rebase

Feb 11 2020, 7:50 AM · Restricted Project, Restricted Project
jlebar updated the diff for D74380: Fix SFINAE in llvm::bit_cast..

Rebase

Feb 11 2020, 7:50 AM · Restricted Project
jlebar committed rGfb45968e6285: Use C++14-style return type deduction in LLVM. (authored by jlebar).
Use C++14-style return type deduction in LLVM.
Feb 11 2020, 7:41 AM
jlebar committed rGdd11c8fb0d07: Fix SFINAE in JSON.h constructor. (authored by jlebar).
Fix SFINAE in JSON.h constructor.
Feb 11 2020, 7:41 AM
jlebar closed D74383: Use C++14-style return type deduction in LLVM..
Feb 11 2020, 7:41 AM · Restricted Project
jlebar closed D74381: Fix SFINAE in JSON.h constructor..
Feb 11 2020, 7:41 AM · Restricted Project
jlebar added a comment to D74381: Fix SFINAE in JSON.h constructor..

Thank you for the review!

Feb 11 2020, 7:41 AM · Restricted Project
jlebar added a comment to D74383: Use C++14-style return type deduction in LLVM..

Thank you for the review!

Feb 11 2020, 7:41 AM · Restricted Project
jlebar abandoned D26943: [CodingStandards] Add style guide rule about "if" statements and loops..
Feb 11 2020, 7:32 AM · Restricted Project

Feb 10 2020

jlebar added a reviewer for D74381: Fix SFINAE in JSON.h constructor.: MaskRay.
Feb 10 2020, 11:24 PM · Restricted Project
jlebar added a reviewer for D74383: Use C++14-style return type deduction in LLVM.: MaskRay.
Feb 10 2020, 11:24 PM · Restricted Project
jlebar added a reviewer for D74380: Fix SFINAE in llvm::bit_cast.: MaskRay.
Feb 10 2020, 11:24 PM · Restricted Project
jlebar added a comment to D74384: Use std::foo_t rather than std::foo in LLVM..

Such changes can be risky.

Feb 10 2020, 11:24 PM · Restricted Project, Restricted Project
jlebar added a comment to D74380: Fix SFINAE in llvm::bit_cast..

Since is_trivially_constructible<T>::type doesn't exist, wouldn't this always be a substitution failure?

Feb 10 2020, 10:49 PM · Restricted Project
jlebar updated the diff for D74384: Use std::foo_t rather than std::foo in LLVM..

Rebase to origin/master.

Feb 10 2020, 10:37 PM · Restricted Project, Restricted Project
jlebar created D74384: Use std::foo_t rather than std::foo in LLVM..
Feb 10 2020, 10:23 PM · Restricted Project, Restricted Project
jlebar added a reviewer for D74383: Use C++14-style return type deduction in LLVM.: bkramer.
Feb 10 2020, 9:48 PM · Restricted Project
jlebar created D74383: Use C++14-style return type deduction in LLVM..
Feb 10 2020, 9:48 PM · Restricted Project
jlebar added a reviewer for D74380: Fix SFINAE in llvm::bit_cast.: jfb.
Feb 10 2020, 8:49 PM · Restricted Project
jlebar created D74381: Fix SFINAE in JSON.h constructor..
Feb 10 2020, 8:39 PM · Restricted Project
jlebar updated the diff for D74380: Fix SFINAE in llvm::bit_cast..

Undo overzealous re-clang-formatting.

Feb 10 2020, 8:37 PM · Restricted Project
jlebar updated the diff for D74380: Fix SFINAE in llvm::bit_cast..

Attempt to remove files that should have been ignored.

Feb 10 2020, 8:37 PM · Restricted Project
jlebar added a comment to D74380: Fix SFINAE in llvm::bit_cast..

"How did this ever work?" Since is_trivially_constructible<T>::type doesn't exist, wouldn't this always be a substitution failure?

Feb 10 2020, 8:37 PM · Restricted Project
jlebar created D74380: Fix SFINAE in llvm::bit_cast..
Feb 10 2020, 8:25 PM · Restricted Project
jlebar abandoned D74379: Fix SFINAE in llvm::bit_cast..

arc is not cooperating; I'm going to delete this and create a new review. Sorry for the noise.

Feb 10 2020, 8:25 PM · Restricted Project
jlebar updated the diff for D74379: Fix SFINAE in llvm::bit_cast..

Attempt to remove files which shouldn't be in here.

Feb 10 2020, 8:25 PM · Restricted Project
jlebar added a comment to D74379: Fix SFINAE in llvm::bit_cast..

Hm, thank you, arc, for including files that were not in my commit...

Feb 10 2020, 8:25 PM · Restricted Project
jlebar created D74379: Fix SFINAE in llvm::bit_cast..
Feb 10 2020, 8:25 PM · Restricted Project
jlebar added inline comments to D74165: [x86] [DAGCombine] Prefer shifts of constant widths..
Feb 10 2020, 10:57 AM · Restricted Project
jlebar updated the diff for D74165: [x86] [DAGCombine] Prefer shifts of constant widths..

Fix regressions and add vector test.

Feb 10 2020, 10:55 AM · Restricted Project

Feb 7 2020

jlebar added inline comments to D74165: [x86] [DAGCombine] Prefer shifts of constant widths..
Feb 7 2020, 10:45 AM · Restricted Project
jlebar added a comment to D74165: [x86] [DAGCombine] Prefer shifts of constant widths..

Hi, thank you for looking at this!

Feb 7 2020, 9:04 AM · Restricted Project

Feb 6 2020

jlebar committed rG6d007343deca: Clarify how llvm-mca detects att vs intel syntax. (authored by jlebar).
Clarify how llvm-mca detects att vs intel syntax.
Feb 6 2020, 7:40 PM
jlebar closed D72385: Clarify how llvm-mca detects att vs intel syntax..
Feb 6 2020, 7:40 PM · Restricted Project
jlebar abandoned D72357: Fix llvm-objcopy when directory contains "bar"..

Thank you for the reviews, and I'm sorry I dropped off the face of the earth here! I was messing with my phab settings and I think I somehow disabled all emails. Oops.

Feb 6 2020, 4:14 PM · Restricted Project
jlebar added a comment to D72385: Clarify how llvm-mca detects att vs intel syntax..

Thank you for the review, and I'm sorry for falling off the face of the earth for a few weeks. Somehow I misconfigured either phab or gmail so I wasn't receiving any review emails!

Feb 6 2020, 2:17 PM · Restricted Project
jlebar created D74165: [x86] [DAGCombine] Prefer shifts of constant widths..
Feb 6 2020, 1:57 PM · Restricted Project

Jan 7 2020

jlebar created D72385: Clarify how llvm-mca detects att vs intel syntax..
Jan 7 2020, 9:29 PM · Restricted Project
jlebar created D72357: Fix llvm-objcopy when directory contains "bar"..
Jan 7 2020, 12:10 PM · Restricted Project

Nov 8 2019

jlebar added a comment to D69878: Consoldiate internal denormal flushing controls.

AMDGPU wants a distinct control for f32 flushing from f16/f64, and as far as I can tell the same is true for NVPTX (based on the attribute name).

Nov 8 2019, 11:48 AM · Restricted Project

Oct 27 2019

jlebar added a comment to D69493: Add -fconvergent-functions flag.

I'm confused about "The CUDA builtin library is apparently compiled in C++ mode". By...whom, and for what purposes?

Oct 27 2019, 7:36 PM

Oct 25 2019

jlebar added a comment to D65967: [SeparateConstOffsetFromGEP][PowerPC] Fix: sext(a) + sext(b) -> sext(a + b) matches add and sub instructions with one another.

Hi, I am not familiar with this code but seeing as you're not getting reviews and this seems like a serious problem, I am willing to take a look (and maybe if I say something wrong here, Cunningham's Law will save us).

Oct 25 2019, 12:38 PM · Restricted Project

Oct 8 2019

jlebar added a comment to D62393: [OPENMP][NVPTX]Mark parallel level counter as volatile..

I spoke offline with tra@ about this; he was confused why I was coming down so hard here.

Oct 8 2019, 12:03 PM · Restricted Project
jlebar added a comment to D62393: [OPENMP][NVPTX]Mark parallel level counter as volatile..

So if we can drop cuda 8, great. If some of the maintainers have a customer that requires cuda 8 to continue working with a recent llvm - which is sad but plausible - we're better off supporting that use case in tree than forcing an out of tree fork.

Oct 8 2019, 8:54 AM · Restricted Project
jlebar accepted D68419: Conservatively add volatility and atomic checks in a few places.
Oct 8 2019, 7:38 AM · Restricted Project
jlebar requested changes to D62393: [OPENMP][NVPTX]Mark parallel level counter as volatile..

No, I don't try to add a workaround for the bug in LLVM since there are no problems in LLVM optimizations. The same code works correctly with Cuda9.2. But I would like to add it for cuda8 since we need to fully support it unless we drop the support for cuda8.

Oct 8 2019, 7:38 AM · Restricted Project
jlebar added a comment to D62393: [OPENMP][NVPTX]Mark parallel level counter as volatile..

Hi, jumping in here. I haven't read the whole bug, apologies.

Oct 8 2019, 7:01 AM · Restricted Project

May 8 2019

jlebar updated subscribers of D61399: [OpenMP][Clang] Support for target math functions.
May 8 2019, 8:56 AM · Restricted Project

May 3 2019

jlebar added a comment to D61458: [hip] Relax CUDA call restriction within `decltype` context..

At [nvcc] from CUDA 10, that's not acceptable as we are declaring two functions only differ from the return type. It seems CUDA attributes do not contribute to the function signature. clang is quite different here.

May 3 2019, 8:41 AM · Restricted Project

May 2 2019

jlebar updated subscribers of D61458: [hip] Relax CUDA call restriction within `decltype` context..

Here's one for you:

May 2 2019, 7:01 PM · Restricted Project
jlebar accepted D61470: [CUDA] Do not pass deprecated option fo fatbinary.
May 2 2019, 3:33 PM · Restricted Project

Mar 28 2019

jlebar added a comment to D59947: [NVPTX] Fix the codegen for llvm.round..

Does XLA:GPU built with this change pass the exhaustive test you added for kRound after we revert the change that made kRound call into libdevice?

Mar 28 2019, 10:24 AM · Restricted Project

Mar 27 2019

jlebar accepted D59837: Add "git llvm revert" subcommand.
Mar 27 2019, 5:05 PM · Restricted Project
jlebar added a comment to D59900: [Sema] Fix a crash when nonnull checking.

I uh... I also think this is an @rsmith question, I have no idea.

Mar 27 2019, 4:36 PM · Restricted Project, Restricted Project
jlebar added a comment to D59837: Add "git llvm revert" subcommand.

Looks great, one nit and one unfortunately substantial comment, sorry I didn't think about it earlier.

Mar 27 2019, 3:42 PM · Restricted Project

Mar 26 2019

jlebar added inline comments to D59837: Add "git llvm revert" subcommand.
Mar 26 2019, 3:21 PM · Restricted Project
jlebar added a comment to D59837: Add "git llvm revert" subcommand.

Thank you for the patch!

Mar 26 2019, 1:53 PM · Restricted Project

Mar 21 2019

jlebar added a comment to D59647: [CUDA][HIP] Warn shared var initialization.

By default it is still treated as error, therefore no behavior change of clang.

Mar 21 2019, 11:19 AM · Restricted Project
jlebar requested changes to D59647: [CUDA][HIP] Warn shared var initialization.

I agree with Art. The fact that nvcc allows this is broken.

Mar 21 2019, 11:17 AM · Restricted Project

Mar 18 2019

jlebar accepted D59375: Allow unordered loads to be considered invariant in CodeGen.

LGTM modulo jfb's outstanding comment.

Mar 18 2019, 2:57 PM · Restricted Project

Mar 14 2019

jlebar edited reviewers for D59393: [NVPTX] generate correct MMA instruction mnemonics with PTX63+., added: timshen; removed: jlebar.
Mar 14 2019, 4:18 PM · Restricted Project
jlebar edited reviewers for D59389: [NVPTX] Refactor generation of MMA intrinsics and instructions. NFC., added: timshen; removed: jlebar.
Mar 14 2019, 4:18 PM · Restricted Project

Mar 12 2019

jlebar accepted D59236: Fix git-llvm crashing when trying to remove directory while cleaning.

That is much less scary! Thanks.

Mar 12 2019, 12:21 AM · Restricted Project