Page MenuHomePhabricator

[libcxx] Update <experimental/simd> with R9 changes
Needs ReviewPublic

Authored by timshen on Mar 19 2018, 5:46 PM.

Details

Summary
  • change the uses of abi_for_size to simd_abi::deduce.
  • remove the const in const_where_expression's template.

Event Timeline

timshen created this revision.Mar 19 2018, 5:46 PM
miyuki added a subscriber: miyuki.Jul 4 2018, 7:34 AM

A few comments; more to come after the earlier patches land.

libcxx/include/experimental/simd
1429

Is this deliberately incomplete?
Comparing to N4755 - I see:

The member type shall be present if and only if:

  • T is a vectorizable type, and
  • simd_abi::fixed_size<N> is supported (see 9.2.1), and
  • every type in the Abis pack is an ABI tag.

Will a later patch fix this up?

1725

We don't need the comments any more that P0820 has been adopted.

1732

Isn't this now named split?