This patch completes the implementation of simd<> and related operations.
Details
Diff Detail
- Build Status
Buildable 16231 Build 16231: arc lint + arc unit
Event Timeline
A few nits, a bit of things moving underneath you, but this looks good.
Need to add more stuff to the tests ;-)
libcxx/include/experimental/simd | ||
---|---|---|
1421 | In the TS, hmin, hmax (and a bunch of others) are noexcept. This was added in P1110, in response to NB comments CH 30 and CH 33. Need to fix that here, and add ASSERT_NOEXCEPT to a bunch of tests. | |
1482 | We're going to need a lot of _LIBCPP_TYPE_VIS and other annotations. That can be a separate patch, though | |
1657 | I don't think that auto buys you anything here. simd is fine, and no longer. | |
libcxx/test/std/experimental/simd/simd.horizontal/hmax.pass.cpp | ||
23 | Check the return types here with ASSERT_SAME_TYPE |
In the TS, hmin, hmax (and a bunch of others) are noexcept. This was added in P1110, in response to NB comments CH 30 and CH 33.
Need to fix that here, and add ASSERT_NOEXCEPT to a bunch of tests.