[Polly] [Strided arrays, multidimensional indexing, fortran support] Teach Polly multidimensional strided array indexing. [WIP]
Needs ReviewPublic
Actions

Authored by bollu on Sep 15 2017, 7:06 AM.

Details

Reviewers

efriedma
Meinersbur
gareevroman
sebpop
• zinob
huihuiz
pollydev
grosser
singam-sanjay
philip.pfaffe
jdoerfert

Summary

Please do not try to review this patch, I'm putting it up so I can chip
away at this and remove all the hacks. Once that is done, I'll split it up
into managable patches.

This patch teaches:

Polly to interpret multidimensional index expressions.
ScopArrayInfo to use a ShapeInfo class to store info based on size / stride based representation.
PPCGCodeGen to codegen for these strided arrays.
IslNodeBuilder, IslExprBuilder, et. al about strided arrays.

Diff Detail

Build Status

Buildable 10282
Build 10282: arc lint + arc unit

Event Timeline

bollu created this revision.Sep 15 2017, 7:06 AM

Herald added subscribers: kbarton, nemanjai. · View Herald TranscriptSep 15 2017, 7:06 AM

Harbormaster completed remote builds in B10282: Diff 115404.Sep 15 2017, 7:06 AM

jdoerfert resigned from this revision.Jun 11 2019, 7:57 AM

Herald added subscribers: jsji, arphaman. · View Herald TranscriptJun 11 2019, 7:57 AM

Revision Contents
Changeset List

		Path
M		include/polly/CodeGen/IslExprBuilder.h (10 lines)
M		include/polly/CodeGen/IslNodeBuilder.h (12 lines)
M		include/polly/ScopBuilder.h (13 lines)
M		include/polly/ScopInfo.h (237 lines)
M		include/polly/Support/ScopHelper.h (6 lines)
M		lib/Analysis/ScopBuilder.cpp (224 lines)
M		lib/Analysis/ScopDetection.cpp (58 lines)
M		lib/Analysis/ScopInfo.cpp (314 lines)
M		lib/CodeGen/IslExprBuilder.cpp (173 lines)
M		lib/CodeGen/IslNodeBuilder.cpp (135 lines)
M		lib/CodeGen/PPCGCodeGeneration.cpp (284 lines)
M		lib/External/isl/isl_map.c (14 lines)
M		lib/Support/ScopHelper.cpp (71 lines)
M		lib/Transform/ForwardOpTree.cpp (6 lines)
A	M	test/GPGPU/09-12-failing-testcase-array-inv-load-hoist.ll (95 lines)
A	M	test/GPGPU/09-13-coe-th-referring-to-arg-in-another-fn.ll (105 lines)
A	M	test/GPGPU/09-13-unbounded-optimium.ll (82 lines)
A	M	test/GPGPU/abstract-index-function-simple.ll (103 lines)
A	M	test/ScopInfo/abstract-index-function-simple.ll (95 lines)
M		tools/GPURuntime/GPUJIT.c (16 lines)

Commit	Tree	Parents	Author	Summary	Date
b34748de9954	6b0999f51cf5	6241e18fbbff	Siddharth Bhat	[NFC] remove 1-test	Sep 15 2017, 6:59 AM
6241e18fbbff	6099e61199d4	63de450da81b	Siddharth Bhat	remove random crash code	Sep 15 2017, 6:16 AM
63de450da81b	b2fc0c6d68db	9f17e6de53a2	Siddharth Bhat	fix stride param name	Sep 15 2017, 5:59 AM
9f17e6de53a2	bf12dfefb84c	9a56f56849a1	Siddharth Bhat	[REMOVE DEBUG] remove debugging statements. [NFC]	Sep 15 2017, 5:49 AM
9a56f56849a1	8e2ab29c8a31	e4d1b7239b06	Siddharth Bhat	[ScopInfo] continue, not return from MemoryAccess::updateDimensionality if we… (Show More…)	Sep 15 2017, 5:31 AM
e4d1b7239b06	44a25b92ac22	d8f6ebcd982b	Siddharth Bhat	[HACK, CHECK WHY THIS WORKS] passed cuda-memcheck. Not sure why, my strides are… (Show More…)	Sep 15 2017, 2:12 AM
d8f6ebcd982b	31f8faebb743	f179cf931633	Siddharth Bhat	[STASH] fix parameters in S->getFullParamSpace to include strides	Sep 14 2017, 6:17 AM
f179cf931633	189159c75e2e	4e703fe50814	Siddharth Bhat	[Offset generation] Create a typecast for the offset to make sure sizes work out	Sep 14 2017, 1:39 AM
4e703fe50814	b36b586839f5	60c809a697f3	Siddharth Bhat	[AbstractFn] teach polly to always allow abstract function calls without… (Show More…)	Sep 14 2017, 1:39 AM
60c809a697f3	ee17cdb5113a	a3e605c3d26a	Siddharth Bhat	[HOLY SHIT] Yay, this generates correct code	Sep 13 2017, 2:25 PM
a3e605c3d26a	5e3712addabf	caa0aa95b5d1	Siddharth Bhat	[WIP] codegen offsets?	Sep 13 2017, 8:15 AM
caa0aa95b5d1	864374f76fd3	e25ab0a192bb	Siddharth Bhat	[HACK] run ADCE before verifyModule so that we eliminate the redundant copied… (Show More…)	Sep 13 2017, 7:01 AM
e25ab0a192bb	60a93c75931d	8f90697223ed	Siddharth Bhat	[BUG] add bug for coe_th	Sep 13 2017, 6:32 AM
8f90697223ed	bb8bf8ea7288	c6d919e5a164	Siddharth Bhat	[BUGFIX] add to pattern match to detect bitcast in the middle of a call to… (Show More…)	Sep 13 2017, 4:38 AM
c6d919e5a164	7ca6fd502855	771e7e1b2fe7	Siddharth Bhat	[TESTCASE] add testcase that fails with unbounded optimum	Sep 13 2017, 2:40 AM
771e7e1b2fe7	f4ee7efe9bbd	fee110ce14b7	Siddharth Bhat	Teach Codegen to send SCEV strides and offsets across kernels. To do this, we… (Show More…)	Sep 13 2017, 1:57 AM
fee110ce14b7	3390950bef0c	28089f78c15f	Siddharth Bhat	[NFC] remove debug prints	Sep 12 2017, 6:07 AM
28089f78c15f	8b9e4024e81c	635f169c6278	Siddharth Bhat	[BUGFIX] allow strides to overwrite shape info because we may detect stride… (Show More…)	Sep 11 2017, 6:50 AM
635f169c6278	3009ee00fe1a	0334fbe264e6	Siddharth Bhat	Delete test case because we don't generate code for it correctly in regular… (Show More…)	Sep 11 2017, 6:39 AM
0334fbe264e6	1730b3a5e665	877246b6358c	Siddharth Bhat	[IslNodeBuilder] teach IslNodeBuilder::preloadInvariantEquivClass about Strides	Sep 11 2017, 6:32 AM
877246b6358c	2e568c7e7220	487ac22f3fe1	Siddharth Bhat	add failing simple testcase	Sep 11 2017, 4:44 AM
487ac22f3fe1	9636e9af1f21	f796b29c7251	Siddharth Bhat	[NFC] cleanup tests so that we don't get false test crashes	Sep 11 2017, 4:37 AM
f796b29c7251	7e54bd24d9a8	465d6a9fa9f8	Siddharth Bhat	[BUGFIX] teach PPCGCodeGen to align params correctly, teach ScopInfo to ignore… (Show More…)	Sep 11 2017, 4:17 AM
465d6a9fa9f8	145d632f3fa4	a0f764866911	Siddharth Bhat	[BUGFIX] support more general GEPs of the form GEP <array> <0, 0… (Show More…)	Sep 11 2017, 2:05 AM
a0f764866911	1793b9c0f32e	2682d57b2ea5	Siddharth Bhat	[Bugfix] defend against undef in SCEV	Sep 10 2017, 2:15 PM
2682d57b2ea5	b3472dfaf506	00f735a7ba0a	Siddharth Bhat	[MultiDimAccess] teach polly that multi dim access is affine. Still need to fix… (Show More…)	Sep 10 2017, 1:58 PM
00f735a7ba0a	1f8a74527bf7	8d23d702fd7a	Siddharth Bhat	[BUGFIX] teach isCompatibleWith about ShapeInfo	Sep 10 2017, 9:07 AM
8d23d702fd7a	d3d8c84811f0	030f2314bb4e	Siddharth Bhat	[FIX] fix crash at PPCGCodeGen due to missing bitcast	Sep 10 2017, 8:31 AM
030f2314bb4e	06189c4c568b	6cc5f0da8de6	Siddharth Bhat	[BUGFIX] fix implicit uses of sizes()	Sep 10 2017, 7:54 AM
6cc5f0da8de6	1cbad8d5f007	d060e7d2a4e9	Siddharth Bhat	[NonAffine] allow polly to analyze index_ expressions without needing polly… (Show More…)	Sep 10 2017, 7:34 AM
d060e7d2a4e9	eeeb5335f388	1cdfb1ef5a10	Siddharth Bhat	[NFC] added test that fails	Sep 9 2017, 3:28 PM
1cdfb1ef5a10	030aff0ca634	368c5a1cf596	Siddharth Bhat	[NFC] remove excessive debug print, run through check-polly	Sep 9 2017, 9:02 AM
368c5a1cf596	41b1411b151c	d237d2cd2bc2	Siddharth Bhat	Fix host pointer creation	Sep 9 2017, 6:16 AM
d237d2cd2bc2	8ee9e0313e5f	3cc3e6d5c368	Siddharth Bhat	Enable back: [TRIAL] tried passing negative offset directly at PPCGCodeGen… (Show More…)	Sep 8 2017, 9:33 AM
3cc3e6d5c368	f06ed6a2fb47	107aa7afc5e7	Siddharth Bhat	Revert "[DOES NOT WORK] trying to pass offset into kernel, doesn't really work" (Show More…)	Sep 8 2017, 9:32 AM
107aa7afc5e7	74fc2d28a9c9	329a7d54820b	Siddharth Bhat	[DOES NOT WORK] trying to pass offset into kernel, doesn't really work	Sep 8 2017, 9:31 AM
329a7d54820b	f06ed6a2fb47	e1df5562c6e9	Siddharth Bhat	Revert "[TRIAL] tried passing negative offset directly at PPCGCodeGen, does not… (Show More…)	Sep 8 2017, 9:08 AM
e1df5562c6e9	8ee9e0313e5f	e55fb1411820	Siddharth Bhat	[TRIAL] tried passing negative offset directly at PPCGCodeGen, does not work. (Show More…)	Sep 8 2017, 9:08 AM
e55fb1411820	f06ed6a2fb47	6e19868ab851	Siddharth Bhat	[WIP] pass offset through the polly pipeline. Not sure if correct	Sep 8 2017, 8:39 AM
6e19868ab851	86c65ed49c6d	b946b5954341	Siddharth Bhat	[TEST FIX] fix test comment to ; from !	Sep 8 2017, 8:20 AM
b946b5954341	536ebb3d1245	cd654f7376c6	Siddharth Bhat	[FIX] enable code that is necessary for correct codegen	Sep 8 2017, 8:17 AM
cd654f7376c6	c140cbbad473	3c83c4d91017	Siddharth Bhat	[TEST] update tests for new type of codegen with offset.	Sep 8 2017, 8:03 AM
3c83c4d91017	5d4e47502ee7	b806e945e76d	Siddharth Bhat	[WIP] Fixing up polly to learn about offsets	Sep 8 2017, 7:48 AM
b806e945e76d	c4a19248412b	a09877759b7b	Siddharth Bhat	Remove debug prints. [NFC]	Sep 8 2017, 6:33 AM
a09877759b7b	9ed3e13fc915	daa811231c95	Siddharth Bhat	Fix errors pointed out by GCC. [NFC]	Sep 8 2017, 5:19 AM
daa811231c95	c07355cf80ff	a6c3a9f2e52e	Siddharth Bhat	[8/?] We generate correct looking code, but fail ISL checks. Pushing so I can… (Show More…)	Sep 8 2017, 3:53 AM
a6c3a9f2e52e	cb28289f58df	71eac1c6bae1	Siddharth Bhat	[WIP] Pass SAIs to ExprBuilder / Kernel module correctly with strides preserved. (Show More…)	Sep 8 2017, 2:32 AM
71eac1c6bae1	bec12e6c01f2	925cc0f9bb01	Siddharth Bhat	[7/?] Generate code from stride pw_affs. However, we use the strides as sizes… (Show More…)	Sep 8 2017, 1:47 AM
925cc0f9bb01	df3fc80954e0	6a74cc5afbff	Siddharth Bhat	[NFC] check-polly	Sep 8 2017, 1:39 AM
6a74cc5afbff	4ac4c286430d	e4fbd22873ea	Siddharth Bhat	[6/?] Generate pw_aff for ScopArrayInfo sizes even when there are strides. We… (Show More…)	Sep 8 2017, 1:38 AM
e4fbd22873ea	d2051547fcfc	2b43d2a27a88	Siddharth Bhat	check for a call to polly_array_index, not just the existence of the function… (Show More…)	Sep 8 2017, 1:26 AM
2b43d2a27a88	bfa9530ea9bc	86e0a683b233	Siddharth Bhat	Revert "[WIP] Tobias pointed out a glaring problem: We can't _really_ codegen" (Show More…)	Sep 8 2017, 1:21 AM
86e0a683b233	27092d1ca3c6	8c60ab83698e	Siddharth Bhat	Revert "[STASH] Stash commit." (Show More…)	Sep 8 2017, 1:21 AM
8c60ab83698e	b0cdfb46248d	35469c1daee1	Siddharth Bhat	[STASH] Stash commit.	Sep 8 2017, 12:46 AM
35469c1daee1	27092d1ca3c6	9372cd0e5c3a	Siddharth Bhat	[WIP] Tobias pointed out a glaring problem: We can't _really_ codegen the… (Show More…)	Sep 7 2017, 7:16 AM
9372cd0e5c3a	bfa9530ea9bc	df67ef3362c9	Siddharth Bhat	[WIP] we can now pass through PPCGCodeGen. No guarantees of corectness :)	Sep 7 2017, 6:36 AM
df67ef3362c9	33175158914c	6117fb022a73	Siddharth Bhat	[WIP] Teaching PPCGCodeGen to work with strides. Still crashes at… (Show More…)	Sep 7 2017, 4:31 AM
6117fb022a73	b05a9b8680ae	466a175eb072	Siddharth Bhat	[WIP] We now print out scops with strides correctly. Next step, codegen	Sep 7 2017, 2:00 AM
466a175eb072	ac7d75a1f581	6d8ba1c4e7bb	Siddharth Bhat	[WIP] We now fail further along, when we pass `Strides`. We succeed in building… (Show More…)	Sep 7 2017, 1:41 AM
6d8ba1c4e7bb	e8bcbf62207a	d34a26769ef5	Siddharth Bhat	[WIP] Perplexing crash. (Show More…)	Sep 7 2017, 1:29 AM
d34a26769ef5	5da55b49f1d1	77efbf2e17c0	Siddharth Bhat	[5/?] change getOrCreateScopArrayInfo to use ShapeInfo	Sep 7 2017, 12:57 AM
77efbf2e17c0	9d389244b28a	4904ac4458d2	Siddharth Bhat	[4/?] Teach ScopInfo to use Shape. TODO: Need to switch to Stride and see the… (Show More…)	Sep 6 2017, 3:29 PM
4904ac4458d2	6462b146dfe4	3b03171a3ca7	Siddharth Bhat	[3/?] Switch from using Sizes to Shape in MemoryAccess. NOTE: have not yet… (Show More…)	Sep 6 2017, 2:35 PM
3b03171a3ca7	fec86b074ca2	5d31619d481e	Siddharth Bhat	[2/?] [NFC] added the ShapeInfo class	Sep 6 2017, 2:07 PM
5d31619d481e	bc843ce2c240	d9974bc293b4	Siddharth Bhat	[1/?] First part done: We generate a scop with a call to polly_index	Sep 6 2017, 1:52 PM