Page MenuHomePhabricator

singam-sanjay (Singapuram Sanjay Srivallabh)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 1 2016, 8:22 AM (159 w, 4 d)

Recent Activity

Aug 27 2017

singam-sanjay added inline comments to D37135: [Polly] [PPCGCodeGeneration] Allow PPCGCodeGeneration to run without libdevice..
Aug 27 2017, 7:08 AM

Aug 22 2017

singam-sanjay added a comment to D33332: Possible typo in ProgrammersManual documentation.

The novice reader would associate shape with only two of the DerivedTypes: VectorType and ArrayType. How could a FunctionType or an IntegerType have a shape ?

Aug 22 2017, 10:08 AM
singam-sanjay added a comment to D36425: [ZoneAlgo] Allow two writes that write identical values into same array slot.

Could you suggest a paper I could read to get to know this Zone Algorithm ?

Aug 22 2017, 7:39 AM · Restricted Project
singam-sanjay added inline comments to D36852: [Polly] [ScopInliner] [WIP] Teach ScopInliner to inline not-fully-scop'd functions..
Aug 22 2017, 7:05 AM
singam-sanjay added inline comments to D35992: [Polly] [PPCGCodeGeneration] [NFC] [WIP] Add option to fail if a store to a scalar occursin a kernel..
Aug 22 2017, 6:32 AM

Aug 14 2017

singam-sanjay added a comment to D36513: [Polly] [ManagedMemoryRewrite] Introduce a new pass to rewrite modules to use managed memory..

Sorry about the delayed response.

Aug 14 2017, 9:36 AM

Aug 8 2017

singam-sanjay added inline comments to D36459: [Polly] [PPCGCodeGeneration] Compute element size in bytes for arrays correctly..
Aug 8 2017, 11:58 AM
singam-sanjay abandoned D32894: Stripping invalid debug information before verification can prevent code-generation.
Aug 8 2017, 5:29 AM · Restricted Project

Aug 3 2017

singam-sanjay added a comment to D35991: [Polly] [HACK] [WIP] Add functionality to GPUJIT to track unified memory..

This breaks my Julia build.

Aug 3 2017, 12:51 PM
singam-sanjay added a comment to D36001: [WIP] [Polly] [GPUNodeBuilder] Correct usage of llvm::Value with getLatestValue..

@bollu what is this patch about ?

Aug 3 2017, 3:12 AM

Aug 2 2017

singam-sanjay committed rL309845: Fix code format on r309826.
Fix code format on r309826
Aug 2 2017, 10:57 AM
singam-sanjay closed D36232: Fix code format on r309826 by committing rL309845: Fix code format on r309826.
Aug 2 2017, 10:57 AM · Restricted Project
singam-sanjay updated the summary of D36232: Fix code format on r309826.
Aug 2 2017, 10:53 AM · Restricted Project
singam-sanjay created D36232: Fix code format on r309826.
Aug 2 2017, 10:49 AM · Restricted Project
singam-sanjay added inline comments to D36161: Remove debug metadata from copied instruction to prevent GPUModule verification failure.
Aug 2 2017, 8:21 AM · Restricted Project
singam-sanjay committed rL309822: Remove debug metadata from copied instruction to prevent GPUModule verification….
Remove debug metadata from copied instruction to prevent GPUModule verification…
Aug 2 2017, 8:21 AM
singam-sanjay closed D36161: Remove debug metadata from copied instruction to prevent GPUModule verification failure by committing rL309822: Remove debug metadata from copied instruction to prevent GPUModule verification….
Aug 2 2017, 8:20 AM · Restricted Project

Aug 1 2017

singam-sanjay added inline comments to D36161: Remove debug metadata from copied instruction to prevent GPUModule verification failure.
Aug 1 2017, 9:11 PM · Restricted Project
singam-sanjay updated the diff for D36161: Remove debug metadata from copied instruction to prevent GPUModule verification failure.

Simpler check to determine the destination Module of the cloned instruction.

Aug 1 2017, 1:02 PM · Restricted Project
singam-sanjay created D36161: Remove debug metadata from copied instruction to prevent GPUModule verification failure.
Aug 1 2017, 10:11 AM · Restricted Project

Jul 31 2017

singam-sanjay added a comment to D36050: [release 5.0][Release Notes] Polly-ACC works with Julia.

@grosser I was able to commit it.

Jul 31 2017, 10:06 PM · Restricted Project
singam-sanjay committed rL309656: [release 5.0][Release Notes] Polly-ACC works with Julia.
[release 5.0][Release Notes] Polly-ACC works with Julia
Jul 31 2017, 10:03 PM
singam-sanjay closed D36050: [release 5.0][Release Notes] Polly-ACC works with Julia by committing rL309656: [release 5.0][Release Notes] Polly-ACC works with Julia.
Jul 31 2017, 10:03 PM · Restricted Project

Jul 30 2017

singam-sanjay added a comment to D36050: [release 5.0][Release Notes] Polly-ACC works with Julia.

I'm comitting on the release_50 branch only.

Jul 30 2017, 11:20 AM · Restricted Project
singam-sanjay added a comment to D36050: [release 5.0][Release Notes] Polly-ACC works with Julia.

I got the following output on git svn dcommit -n,

Jul 30 2017, 4:47 AM · Restricted Project

Jul 29 2017

singam-sanjay added a comment to D36050: [release 5.0][Release Notes] Polly-ACC works with Julia.

@grosser could you please approve ? Also

Jul 29 2017, 12:50 PM · Restricted Project
singam-sanjay updated the diff for D36050: [release 5.0][Release Notes] Polly-ACC works with Julia.

restrict to 80 columns.

Jul 29 2017, 12:03 PM · Restricted Project
singam-sanjay added a project to D36050: [release 5.0][Release Notes] Polly-ACC works with Julia: Restricted Project.
Jul 29 2017, 12:02 PM · Restricted Project
singam-sanjay added a comment to D36050: [release 5.0][Release Notes] Polly-ACC works with Julia.

I'm using git-svn. Would doing a arc patch D36050 on the release_50 branch followed by a merge and then git svn dcommit push it to llvm.org/git/polly.git ?

Jul 29 2017, 11:56 AM · Restricted Project
singam-sanjay created D36050: [release 5.0][Release Notes] Polly-ACC works with Julia.
Jul 29 2017, 11:51 AM · Restricted Project
singam-sanjay updated subscribers of D36050: [release 5.0][Release Notes] Polly-ACC works with Julia.
Jul 29 2017, 11:51 AM · Restricted Project
singam-sanjay added inline comments to rL306290: [PPCGCodeGeneration] Add flag to allow polly to fail in GPU kernel fails..
Jul 29 2017, 11:12 AM
singam-sanjay committed rL309490: Remove Debug metadata from copied instruction to prevent Module verification….
Remove Debug metadata from copied instruction to prevent Module verification…
Jul 29 2017, 11:06 AM
singam-sanjay closed D35630: Remove Debug metadata from copied instruction to prevent Module verification failure by committing rL309490: Remove Debug metadata from copied instruction to prevent Module verification….
Jul 29 2017, 11:06 AM · Restricted Project
singam-sanjay updated the diff for D35630: Remove Debug metadata from copied instruction to prevent Module verification failure.

remove the llvm.lifetime* declarations

Jul 29 2017, 10:54 AM · Restricted Project

Jul 24 2017

singam-sanjay added inline comments to D35703: [GPGPU] Add support for NVIDIA libdevice.
Jul 24 2017, 8:10 AM · Restricted Project
singam-sanjay added a comment to D35795: [Polly] [PPCGCodeGeneration] Skip arrays with empty extent..

How are invariant loads to pointers turned into scalar accesses ? Do we need -polly-invariant-load-hoisting for that ?

Jul 24 2017, 7:34 AM

Jul 23 2017

singam-sanjay added inline comments to D35728: [Polly] [NFC] [ScopDetection] Make `polly-only-func` perform regex scop name match..
Jul 23 2017, 8:43 AM
singam-sanjay added a comment to D35721: [Polly] [PPCGCodeGeneration] Handle 1-d pointers to scalars in array size..

@grosser How does solving 1. relate to D35630 ?

Jul 23 2017, 8:34 AM

Jul 22 2017

singam-sanjay updated the diff for D35630: Remove Debug metadata from copied instruction to prevent Module verification failure.

Simpler, Unoptimized and readable testcase.

Jul 22 2017, 12:58 PM · Restricted Project

Jul 21 2017

singam-sanjay added inline comments to D35630: Remove Debug metadata from copied instruction to prevent Module verification failure.
Jul 21 2017, 10:48 AM · Restricted Project
singam-sanjay updated the diff for D35630: Remove Debug metadata from copied instruction to prevent Module verification failure.

Added pseudo code to test case.

Jul 21 2017, 10:47 AM · Restricted Project
singam-sanjay accepted D35185: [Polly][GPGPU] Added SPIR Code Generation and Corresponding Runtime Support for Intel.
Jul 21 2017, 8:27 AM · Restricted Project
singam-sanjay added a comment to D35185: [Polly][GPGPU] Added SPIR Code Generation and Corresponding Runtime Support for Intel.

@PhilippSchaad Please go ahead.

Jul 21 2017, 8:27 AM · Restricted Project
singam-sanjay updated the diff for D35630: Remove Debug metadata from copied instruction to prevent Module verification failure.

Added test case.

Jul 21 2017, 12:32 AM · Restricted Project

Jul 20 2017

singam-sanjay added inline comments to D35653: [WIP] [Polly] [PPCG] Bump up PPCG to v0.07.
Jul 20 2017, 4:18 AM

Jul 19 2017

singam-sanjay added inline comments to D35653: [WIP] [Polly] [PPCG] Bump up PPCG to v0.07.
Jul 19 2017, 10:33 PM
singam-sanjay created D35630: Remove Debug metadata from copied instruction to prevent Module verification failure.
Jul 19 2017, 9:51 AM · Restricted Project

Jul 17 2017

singam-sanjay added inline comments to D35185: [Polly][GPGPU] Added SPIR Code Generation and Corresponding Runtime Support for Intel.
Jul 17 2017, 12:56 AM · Restricted Project

Jul 16 2017

singam-sanjay added a comment to D35185: [Polly][GPGPU] Added SPIR Code Generation and Corresponding Runtime Support for Intel.

@grosser Thanks for adding me as a reviewer ! It's helped me acquaint myself with the SPIR V codegen and understand GPUJIT better.

Jul 16 2017, 10:42 PM · Restricted Project

Jul 15 2017

singam-sanjay added a comment to D35185: [Polly][GPGPU] Added SPIR Code Generation and Corresponding Runtime Support for Intel.

Sure. Will do in sometime.

Jul 15 2017, 7:40 AM · Restricted Project

Jul 12 2017

singam-sanjay abandoned D34565: Make getNameStr return original name of the Scop.

Yes. I'll drop it.

Jul 12 2017, 9:34 PM · Restricted Project
singam-sanjay committed rL307814: [PPCGCodeGen] Differentiate kernels based on their parent Scop.
[PPCGCodeGen] Differentiate kernels based on their parent Scop
Jul 12 2017, 9:47 AM
singam-sanjay closed D35176: [PPCGCodeGen] Differentiate kernels based on their parent Scop by committing rL307814: [PPCGCodeGen] Differentiate kernels based on their parent Scop.
Jul 12 2017, 9:46 AM · Restricted Project
singam-sanjay updated the diff for D35176: [PPCGCodeGen] Differentiate kernels based on their parent Scop.
  1. Instructions and basic blocks of new test case have been named.
  2. Removed format error with unittests/ScopPassManager/PassManagerTest.cpp
Jul 12 2017, 9:43 AM · Restricted Project

Jul 9 2017

singam-sanjay added a comment to D35045: [Polly] [PPCGCodeGeneration] [WIP] Teach `must_kills` to kill scalars that are local the scop..

What do you mean by killing a scalar ?

Jul 9 2017, 6:14 AM
singam-sanjay created D35176: [PPCGCodeGen] Differentiate kernels based on their parent Scop.
Jul 9 2017, 6:14 AM · Restricted Project
singam-sanjay added a comment to D35176: [PPCGCodeGen] Differentiate kernels based on their parent Scop.

@grosser I tried what you suggessted,

Jul 9 2017, 6:14 AM · Restricted Project

Jul 5 2017

singam-sanjay committed rL307173: Prefix the name of the calling host function in the name of callee GPU kernel.
Prefix the name of the calling host function in the name of callee GPU kernel
Jul 5 2017, 9:49 AM
singam-sanjay closed D33985: Prefix the name of the calling host function in the name of callee GPU kernel by committing rL307173: Prefix the name of the calling host function in the name of callee GPU kernel.
Jul 5 2017, 9:49 AM · Restricted Project

Jul 4 2017

singam-sanjay retitled D33985: Prefix the name of the calling host function in the name of callee GPU kernel from Prefix the name of the calling host function and Scop in the name of callee GPU kernel to Prefix the name of the calling host function in the name of callee GPU kernel.
Jul 4 2017, 11:16 AM · Restricted Project
singam-sanjay updated the diff for D33985: Prefix the name of the calling host function in the name of callee GPU kernel.

Drop Scop name from ptx_kernel's name.

Jul 4 2017, 11:13 AM · Restricted Project

Jul 3 2017

singam-sanjay updated the diff for D33985: Prefix the name of the calling host function in the name of callee GPU kernel.
  1. Moved building the name into a routine.
  2. ScopNameofIR is const now.
  3. Rebased to trunk @ 306540.
Jul 3 2017, 6:41 PM · Restricted Project
singam-sanjay added a comment to D33985: Prefix the name of the calling host function in the name of callee GPU kernel.

@grosser ping

Jul 3 2017, 12:41 PM · Restricted Project
singam-sanjay added inline comments to rL306290: [PPCGCodeGeneration] Add flag to allow polly to fail in GPU kernel fails..
Jul 3 2017, 12:40 PM

Jul 1 2017

singam-sanjay added a comment to D33985: Prefix the name of the calling host function in the name of callee GPU kernel.

Hi Sanjay,

adding the scop's name is a not good idea. Specifically, the scop's name may differ between release and debug builds, as names are only carried over in debug builds.

The name of the Scop is built from the boundary basic blocks of the region in Scop::getNameStr. How does that depend on the build type ? Are extra basic blocks inserted in debug builds ?

Jul 1 2017, 9:27 PM · Restricted Project

Jun 30 2017

singam-sanjay added inline comments to D34811: [WIP] [Polly] [PPCGCodeGeneration] Initialize PPCGScop->independence.
Jun 30 2017, 12:49 PM
singam-sanjay committed rL306863: Introduce a hybrid target to generate code for either the GPU or CPU.
Introduce a hybrid target to generate code for either the GPU or CPU
Jun 30 2017, 12:42 PM
singam-sanjay closed D34054: Introduce a hybrid target to generate code for either the GPU or CPU by committing rL306863: Introduce a hybrid target to generate code for either the GPU or CPU.
Jun 30 2017, 12:42 PM · Restricted Project
singam-sanjay added inline comments to D34054: Introduce a hybrid target to generate code for either the GPU or CPU.
Jun 30 2017, 10:21 AM · Restricted Project

Jun 29 2017

singam-sanjay added inline comments to D33985: Prefix the name of the calling host function in the name of callee GPU kernel.
Jun 29 2017, 1:05 AM · Restricted Project
singam-sanjay updated subscribers of D31859: Initializing NVPTX backend within Polly.

@grosser @lattner I was able to commit this patch.

Jun 29 2017, 12:48 AM · Restricted Project
singam-sanjay committed rL306649: Initializing NVPTX backend within Polly.
Initializing NVPTX backend within Polly
Jun 29 2017, 12:43 AM
singam-sanjay closed D31859: Initializing NVPTX backend within Polly by committing rL306649: Initializing NVPTX backend within Polly.
Jun 29 2017, 12:43 AM · Restricted Project

Jun 28 2017

singam-sanjay updated the diff for D34054: Introduce a hybrid target to generate code for either the GPU or CPU.

Update diff to include changes till https://llvm.org/svn/llvm-project/polly/trunk@306540

Jun 28 2017, 9:37 PM · Restricted Project
singam-sanjay added inline comments to D34054: Introduce a hybrid target to generate code for either the GPU or CPU.
Jun 28 2017, 9:32 PM · Restricted Project
singam-sanjay added a comment to D34604: [Polly] [PPCGCodeGeneration] Enable GPU code generation with invariant loads..

Why wasn't it supported previously ?

Jun 28 2017, 11:15 AM

Jun 23 2017

singam-sanjay added a comment to D34565: Make getNameStr return original name of the Scop.

This patch corrects the semantics of the accessor methods of the Scop class.

Jun 23 2017, 12:12 PM · Restricted Project
singam-sanjay created D34565: Make getNameStr return original name of the Scop.
Jun 23 2017, 11:55 AM · Restricted Project
singam-sanjay added a comment to D33985: Prefix the name of the calling host function in the name of callee GPU kernel.
  1. Clearly mention the source FUNCtion and SCOP and KERNEL number.
  2. Changed name of SCOP prefixed to kernel to follow PTX identifier syntax acc. to http://docs.nvidia.com/cuda/parallel-thread-execution/index.html#identifiers (Raised by @philip.pfaffe )
Jun 23 2017, 11:46 AM · Restricted Project
singam-sanjay updated the diff for D33985: Prefix the name of the calling host function in the name of callee GPU kernel.
Jun 23 2017, 11:41 AM · Restricted Project

Jun 22 2017

singam-sanjay added a reviewer for D33985: Prefix the name of the calling host function in the name of callee GPU kernel: philip.pfaffe.
Jun 22 2017, 12:24 PM · Restricted Project

Jun 21 2017

singam-sanjay requested review of D33985: Prefix the name of the calling host function in the name of callee GPU kernel.

@grosser ping.

Jun 21 2017, 10:13 AM · Restricted Project
singam-sanjay updated the diff for D33985: Prefix the name of the calling host function in the name of callee GPU kernel.

Prefix SCoP name as well to uniquely identify a kernel, since a function can have more than one SCoP.

Jun 21 2017, 9:54 AM · Restricted Project

Jun 18 2017

singam-sanjay added a comment to D34145: [Polly] [PPCGCodeGeneration] Allow intrinsics within kernels..

Yes, we can handle the metadata problem in a different patch.

Jun 18 2017, 2:13 AM

Jun 17 2017

singam-sanjay added a comment to D34145: [Polly] [PPCGCodeGeneration] Allow intrinsics within kernels..

@bollu Please refer this comment on my patch. I observed a pattern with functions that produced the buggy metadata, simple copy kernels (A[i][j][k] = B[i][j][k]) didn't produce buggy metadata but kernels that had computation (A[i][j][k] +=/-=/*= B[i][j][k]) resulted in Modules that didn't list the DICompileUnit in llvm.dbg.cu.

Jun 17 2017, 11:16 PM

Jun 16 2017

singam-sanjay added inline comments to D34054: Introduce a hybrid target to generate code for either the GPU or CPU.
Jun 16 2017, 8:39 AM · Restricted Project
singam-sanjay added inline comments to D34054: Introduce a hybrid target to generate code for either the GPU or CPU.
Jun 16 2017, 5:15 AM · Restricted Project
singam-sanjay updated the diff for D34054: Introduce a hybrid target to generate code for either the GPU or CPU.
  1. Rename TARGET_Hybrid to TARGET_HYBRID
  2. Reduce code redundancy.
Jun 16 2017, 5:13 AM · Restricted Project

Jun 15 2017

singam-sanjay added a comment to D34145: [Polly] [PPCGCodeGeneration] Allow intrinsics within kernels..

@bollu The patch did prevent passing the address of the debug intrinsic to the kernel, but couldn't guard against buggy metadata,

Jun 15 2017, 3:05 PM

Jun 14 2017

singam-sanjay added inline comments to D34188: Don't check side effects for functions outside of SCoP.
Jun 14 2017, 2:01 PM · Restricted Project
singam-sanjay added inline comments to D34188: Don't check side effects for functions outside of SCoP.
Jun 14 2017, 8:42 AM · Restricted Project

Jun 13 2017

singam-sanjay added inline comments to D34188: Don't check side effects for functions outside of SCoP.
Jun 13 2017, 11:54 PM · Restricted Project
singam-sanjay added a reviewer for D34145: [Polly] [PPCGCodeGeneration] Allow intrinsics within kernels.: singam-sanjay.
Jun 13 2017, 11:28 AM

Jun 12 2017

singam-sanjay added inline comments to D33414: [Polly] [PPCGCodeGeneration] do not allow LLVM intrinsics to be tracked as Subtree Values..
Jun 12 2017, 12:43 PM
singam-sanjay updated the diff for D34054: Introduce a hybrid target to generate code for either the GPU or CPU.
  1. Punctuation consistency in comments.
  2. Align code to LLVM's C/C++ format.
  3. Initialized SkipScop at constructor like all other members.
  4. Include code for GPU targeting only when GPU_CODEGEN is defined.
Jun 12 2017, 8:30 AM · Restricted Project
singam-sanjay added inline comments to D34054: Introduce a hybrid target to generate code for either the GPU or CPU.
Jun 12 2017, 5:17 AM · Restricted Project
singam-sanjay added a comment to D34054: Introduce a hybrid target to generate code for either the GPU or CPU.

@singam-sanjay: nitpick: polly-update-format changes the format of the file in a couple of places. For next time, could you please update the diff after running ninja/make polly-update-format? I've made a couple of stylistic comments that are upto personal choice :)

Jun 12 2017, 4:26 AM · Restricted Project

Jun 10 2017

singam-sanjay added a comment to D34079: Typo in ImportJScop declaration.

I'm still waiting for my commit access 😁.

Jun 10 2017, 6:14 AM · Restricted Project
singam-sanjay created D34079: Typo in ImportJScop declaration.
Jun 10 2017, 6:09 AM · Restricted Project