Page MenuHomePhabricator

huihuiz (Huihui Zhang)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 9 2016, 6:44 PM (223 w, 3 d)

Recent Activity

Fri, Sep 18

huihuiz committed rG9ad6049736c5: [InstCombine][SVE] Skip scalable type for InstCombiner… (authored by huihuiz).
[InstCombine][SVE] Skip scalable type for InstCombiner…
Fri, Sep 18, 11:27 AM
huihuiz closed D87918: [InstCombine][SVE] Skip scalable type for InstCombiner::getFlippedStrictnessPredicateAndConstant..
Fri, Sep 18, 11:26 AM · Restricted Project
huihuiz added a comment to D87918: [InstCombine][SVE] Skip scalable type for InstCombiner::getFlippedStrictnessPredicateAndConstant..

Current upstream crash with test attached.

Fri, Sep 18, 10:48 AM · Restricted Project
huihuiz requested review of D87918: [InstCombine][SVE] Skip scalable type for InstCombiner::getFlippedStrictnessPredicateAndConstant..
Fri, Sep 18, 10:45 AM · Restricted Project

Tue, Sep 15

huihuiz committed rG3b7f5166bd11: [SLPVectorizer][SVE] Skip scalable-vector instructions before… (authored by huihuiz).
[SLPVectorizer][SVE] Skip scalable-vector instructions before…
Tue, Sep 15, 1:10 PM
huihuiz closed D87550: [SLPVectorizer][SVE] Skip scalable-vector instructions before vectorizeSimpleInstructions..
Tue, Sep 15, 1:10 PM · Restricted Project

Mon, Sep 14

huihuiz updated the diff for D87550: [SLPVectorizer][SVE] Skip scalable-vector instructions before vectorizeSimpleInstructions..

Thanks guys for the feedback!
Addressed review comments.

Mon, Sep 14, 1:54 PM · Restricted Project

Fri, Sep 11

huihuiz requested review of D87550: [SLPVectorizer][SVE] Skip scalable-vector instructions before vectorizeSimpleInstructions..
Fri, Sep 11, 3:32 PM · Restricted Project

Wed, Sep 2

huihuiz committed rGb4f04d713507: [VectorCombine][SVE] Do not fold bitcast shuffle for scalable type. (authored by huihuiz).
[VectorCombine][SVE] Do not fold bitcast shuffle for scalable type.
Wed, Sep 2, 3:02 PM
huihuiz closed D86995: [VectorCombine][SVE] Do not fold bitcast shuffle for scalable type..
Wed, Sep 2, 3:02 PM · Restricted Project
huihuiz updated the diff for D86995: [VectorCombine][SVE] Do not fold bitcast shuffle for scalable type..

Thanks Sanjay for the review!
Addressed review comments.

Wed, Sep 2, 11:08 AM · Restricted Project

Tue, Sep 1

huihuiz requested review of D86995: [VectorCombine][SVE] Do not fold bitcast shuffle for scalable type..
Tue, Sep 1, 5:56 PM · Restricted Project

Aug 10 2020

huihuiz accepted D85688: [InstSimplify][test] Remove unused parameter in vscale.ll.
Aug 10 2020, 2:47 PM · Restricted Project
huihuiz added a comment to D85688: [InstSimplify][test] Remove unused parameter in vscale.ll.

I don't think that's the intention of this specific test given the name insert_extract_element_same_vec_idx_2. And also the unused parameter %a.
This is failing due after a local change to instsimplify and I think the test maybe isn't testing what it wants to test?

Aug 10 2020, 2:16 PM · Restricted Project
huihuiz added a comment to D85688: [InstSimplify][test] Remove unused parameter in vscale.ll.

why do we need this change?
insert element into undef is common to construct a vector, being fixed or scalable.

Aug 10 2020, 2:06 PM · Restricted Project

Jul 31 2020

huihuiz added a comment to D85045: [AArch64][SVE] Allow vector of pointers as legal type for masked load/store..

Thanks @paulwalker-arm for the review!
I have moved the new tests into sve-masked-ldst-nonext.ll in the commit.

Jul 31 2020, 5:31 PM · Restricted Project
huihuiz committed rG01bfe2e49402: [AArch64][SVE] Allow vector of pointers as legal type for masked load/store. (authored by huihuiz).
[AArch64][SVE] Allow vector of pointers as legal type for masked load/store.
Jul 31 2020, 5:30 PM
huihuiz closed D85045: [AArch64][SVE] Allow vector of pointers as legal type for masked load/store..
Jul 31 2020, 5:30 PM · Restricted Project
huihuiz requested review of D85045: [AArch64][SVE] Allow vector of pointers as legal type for masked load/store..
Jul 31 2020, 2:36 PM · Restricted Project

Jun 25 2020

huihuiz added a comment to D77251: [llvm][CodeGen] Addressing modes for SVE ldN..

Hey @fpetrogalli @sdesmalen , any updates on this patch? This should be the last one to commit for structure load? Or are we using different approach?

Jun 25 2020, 2:11 PM · Restricted Project

Jun 17 2020

huihuiz committed rG9d8d0646d751: [NFC] Silence compiler warning [-Wmissing-braces]. (authored by huihuiz).
[NFC] Silence compiler warning [-Wmissing-braces].
Jun 17 2020, 1:30 PM

Jun 12 2020

huihuiz committed rGbf7961fadebb: [NFC] Silence compiler warning [-Wmissing-braces]. (authored by huihuiz).
[NFC] Silence compiler warning [-Wmissing-braces].
Jun 12 2020, 9:14 AM

Jun 4 2020

huihuiz committed rG42048ff97230: [NFC] Move test vscale-factor-out-constant.ll to AArch64 sub-directory. (authored by huihuiz).
[NFC] Move test vscale-factor-out-constant.ll to AArch64 sub-directory.
Jun 4 2020, 1:18 PM
huihuiz committed rGf7f1abdb8893: [NFC] Temporarily disable check for 'uglygep' while investigating some buildbot… (authored by huihuiz).
[NFC] Temporarily disable check for 'uglygep' while investigating some buildbot…
Jun 4 2020, 11:04 AM
huihuiz committed rGbd43f78c7663: [LSR][SCEVExpander] Avoid blind cast 'Factor' to SCEVConstant in… (authored by huihuiz).
[LSR][SCEVExpander] Avoid blind cast 'Factor' to SCEVConstant in…
Jun 4 2020, 11:02 AM
huihuiz closed D80973: [LSR][SCEVExpander] Avoid blind cast 'Factor' to SCEVConstant in FactorOutConstant..
Jun 4 2020, 11:01 AM · Restricted Project

Jun 3 2020

huihuiz updated the diff for D80973: [LSR][SCEVExpander] Avoid blind cast 'Factor' to SCEVConstant in FactorOutConstant..

Thanks Eli for pointing this out!

Jun 3 2020, 4:02 PM · Restricted Project

Jun 1 2020

huihuiz created D80973: [LSR][SCEVExpander] Avoid blind cast 'Factor' to SCEVConstant in FactorOutConstant..
Jun 1 2020, 9:05 PM · Restricted Project

May 13 2020

huihuiz committed rGfd842d362662: [CodeGen][NFC] Fix test/CodeGen/pr45476.cpp to specify target triple. (authored by huihuiz).
[CodeGen][NFC] Fix test/CodeGen/pr45476.cpp to specify target triple.
May 13 2020, 6:35 PM
huihuiz closed D79914: [CodeGen][NFC] Fix test/CodeGen/pr45476.cpp to specify target triple..
May 13 2020, 6:35 PM · Restricted Project, Restricted Project
huihuiz created D79914: [CodeGen][NFC] Fix test/CodeGen/pr45476.cpp to specify target triple..
May 13 2020, 4:57 PM · Restricted Project, Restricted Project

May 7 2020

huihuiz added a comment to D78267: [InstCombine][SVE] Fix visitExtractElementInst for scalable type..

Looks like this breaks check-llvm at least on Linux: http://45.33.8.238/linux/17186/step_12.txt

Can you take a look? If it takes a while to fix, please revert while you investigate.

May 7 2020, 2:08 PM · Restricted Project
huihuiz committed rGe8ea1eb4c1c6: [NFC] Adjust test check lines for D78267. (authored by huihuiz).
[NFC] Adjust test check lines for D78267.
May 7 2020, 1:36 PM
huihuiz committed rG1ec0cc0f0243: [InstCombine][SVE] Fix visitExtractElementInst for scalable type. (authored by huihuiz).
[InstCombine][SVE] Fix visitExtractElementInst for scalable type.
May 7 2020, 1:36 PM
huihuiz closed D78267: [InstCombine][SVE] Fix visitExtractElementInst for scalable type..
May 7 2020, 1:35 PM · Restricted Project
huihuiz committed rG08c9c13749ae: [InstCombine][SVE] Fix visitInsertElementInst for scalable type. (authored by huihuiz).
[InstCombine][SVE] Fix visitInsertElementInst for scalable type.
May 7 2020, 1:02 PM
huihuiz closed D78895: [InstCombine][SVE] Fix visitInsertElementInst for scalable type..
May 7 2020, 1:02 PM · Restricted Project
huihuiz added a comment to D78895: [InstCombine][SVE] Fix visitInsertElementInst for scalable type..

Thanks! Fixed in the committed patch.

May 7 2020, 1:02 PM · Restricted Project
huihuiz updated the diff for D78267: [InstCombine][SVE] Fix visitExtractElementInst for scalable type..

Address review comments.

May 7 2020, 11:20 AM · Restricted Project
huihuiz updated the diff for D78895: [InstCombine][SVE] Fix visitInsertElementInst for scalable type..

Address review comments.

May 7 2020, 10:47 AM · Restricted Project

Apr 29 2020

huihuiz updated the diff for D78267: [InstCombine][SVE] Fix visitExtractElementInst for scalable type..

Thanks Eli for the feedback!
Please let me know if the fixes related to shuffle vector make sense to you.

Apr 29 2020, 8:33 PM · Restricted Project
huihuiz added inline comments to D78267: [InstCombine][SVE] Fix visitExtractElementInst for scalable type..
Apr 29 2020, 8:33 PM · Restricted Project
huihuiz updated the diff for D78895: [InstCombine][SVE] Fix visitInsertElementInst for scalable type..

Rebase.

Apr 29 2020, 10:43 AM · Restricted Project

Apr 27 2020

huihuiz updated the diff for D78895: [InstCombine][SVE] Fix visitInsertElementInst for scalable type..

Thanks Sander for the feedback!

Apr 27 2020, 4:11 PM · Restricted Project

Apr 26 2020

huihuiz added a comment to D78895: [InstCombine][SVE] Fix visitInsertElementInst for scalable type..
  1. Current upstream crash at:

llvm::ShuffleVectorInst::ShuffleVectorInst(llvm::Value *, llvm::Value *, ArrayRef<int>, const llvm::Twine &, llvm::Instruction *): Assertion `isValidOperands(V1, V2, Mask) && "Invalid shuffle vector instruction operands!"' failed.
take test.ll , run opt -S -instcombine test.ll

Apr 26 2020, 10:19 PM · Restricted Project
huihuiz created D78895: [InstCombine][SVE] Fix visitInsertElementInst for scalable type..
Apr 26 2020, 9:46 PM · Restricted Project

Apr 22 2020

huihuiz accepted D78688: [ValueTracking] Handle shufflevector constants in ComputeNumSignBits.

Looks fine with me.

Apr 22 2020, 8:38 PM · Restricted Project

Apr 16 2020

huihuiz added a comment to D78267: [InstCombine][SVE] Fix visitExtractElementInst for scalable type..

I am also looking at the related issues of shufflevector created by "extractelement, insertelement" pair.
Currently working on InstCombiner::visitInsertElementInst.

Apr 16 2020, 1:55 PM · Restricted Project
huihuiz updated the diff for D76655: [InstSimplify] Fix SimplifyGEPInst when GEP index type is vector type..

Thanks Eli for the feedback!

Apr 16 2020, 11:41 AM · Restricted Project

Apr 15 2020

huihuiz added a comment to D78267: [InstCombine][SVE] Fix visitExtractElementInst for scalable type..

Current upstream crash at llvm/include/llvm/ADT/APInt.h:1437: void llvm::APInt::setBit(unsigned int): Assertion `BitPosition < BitWidth && "BitPosition out of range"' failed.

Apr 15 2020, 9:17 PM · Restricted Project
huihuiz created D78267: [InstCombine][SVE] Fix visitExtractElementInst for scalable type..
Apr 15 2020, 9:17 PM · Restricted Project
huihuiz committed rG25db295756be: [NFC] Silence compiler warning [-Wmissing-braces]. (authored by huihuiz).
[NFC] Silence compiler warning [-Wmissing-braces].
Apr 15 2020, 12:06 PM

Apr 14 2020

huihuiz updated the diff for D76655: [InstSimplify] Fix SimplifyGEPInst when GEP index type is vector type..

My initial thought was wrong.
Spent sometime look again, we are nearly impossible to generate incorrect result without the code fixes in this patch.
But comparing a scalable size with a fixed size still doesn't make sense.

Apr 14 2020, 3:45 PM · Restricted Project
huihuiz committed rG5c1d1a62e375: [InstCombine][SVE] Fix visitGetElementPtrInst for scalable type. (authored by huihuiz).
[InstCombine][SVE] Fix visitGetElementPtrInst for scalable type.
Apr 14 2020, 12:59 PM
huihuiz closed D78081: [InstCombine][SVE] Fix visitGetElementPtrInst for scalable type..
Apr 14 2020, 12:58 PM · Restricted Project
huihuiz updated the diff for D78081: [InstCombine][SVE] Fix visitGetElementPtrInst for scalable type..

Thanks Eli for the feedbacks!
Yes, it's valid to use scalable type mininal size for inbounds checking.

Apr 14 2020, 10:10 AM · Restricted Project

Apr 13 2020

huihuiz added a comment to D78081: [InstCombine][SVE] Fix visitGetElementPtrInst for scalable type..

Current upstream crash at llvm/lib/IR/Constants.cpp:1674: static llvm::Constant *llvm::ConstantExpr::getCast(unsigned int, llvm::Constant *, llvm::Type *, bool): Assertion `CastInst::castIsValid(opc, C, Ty) && "Invalid constantexpr cast!"' failed.

Apr 13 2020, 10:24 PM · Restricted Project
huihuiz created D78081: [InstCombine][SVE] Fix visitGetElementPtrInst for scalable type..
Apr 13 2020, 10:14 PM · Restricted Project

Apr 12 2020

huihuiz committed rG4bde7c5986ee: [NFC] Use VectorType::isScalable to align with ongoing VectorType refactor. (authored by huihuiz).
[NFC] Use VectorType::isScalable to align with ongoing VectorType refactor.
Apr 12 2020, 4:01 PM
huihuiz committed rG8e2daa0c7f27: [NFC] Silence compiler warning [-Wmissing-braces]. (authored by huihuiz).
[NFC] Silence compiler warning [-Wmissing-braces].
Apr 12 2020, 2:57 PM

Apr 10 2020

huihuiz committed rG6e7eeb44b305: [GVN] Fix VNCoercion for Scalable Vector. (authored by huihuiz).
[GVN] Fix VNCoercion for Scalable Vector.
Apr 10 2020, 5:49 PM
huihuiz closed D76944: [GVN] Fix VNCoercion for Scalable Vector..
Apr 10 2020, 5:49 PM · Restricted Project
huihuiz committed rG6c989d024862: [BasicAA] Fix aliasGEP/DecomposeGEPExpression for scalable type. (authored by huihuiz).
[BasicAA] Fix aliasGEP/DecomposeGEPExpression for scalable type.
Apr 10 2020, 5:15 PM
huihuiz closed D77828: [BasicAA] Fix aliasGEP/DecomposeGEPExpression for scalable type..
Apr 10 2020, 5:15 PM · Restricted Project
huihuiz added inline comments to D77828: [BasicAA] Fix aliasGEP/DecomposeGEPExpression for scalable type..
Apr 10 2020, 3:04 PM · Restricted Project
huihuiz updated the diff for D77828: [BasicAA] Fix aliasGEP/DecomposeGEPExpression for scalable type..

Address review comments.

Apr 10 2020, 3:04 PM · Restricted Project

Apr 9 2020

huihuiz added inline comments to D76944: [GVN] Fix VNCoercion for Scalable Vector..
Apr 9 2020, 4:53 PM · Restricted Project
huihuiz updated the diff for D76944: [GVN] Fix VNCoercion for Scalable Vector..

Address review comments.

Apr 9 2020, 4:53 PM · Restricted Project
huihuiz retitled D76944: [GVN] Fix VNCoercion for Scalable Vector. from [GVN] Fix VNCoercion/BasicAA for Scalable Vector. to [GVN] Fix VNCoercion for Scalable Vector..
Apr 9 2020, 4:53 PM · Restricted Project
huihuiz added a comment to D77828: [BasicAA] Fix aliasGEP/DecomposeGEPExpression for scalable type..

Current upstream is producing wrong AliasResult for scalable type.

Apr 9 2020, 2:24 PM · Restricted Project
huihuiz created D77828: [BasicAA] Fix aliasGEP/DecomposeGEPExpression for scalable type..
Apr 9 2020, 2:10 PM · Restricted Project

Mar 30 2020

huihuiz added inline comments to D76944: [GVN] Fix VNCoercion for Scalable Vector..
Mar 30 2020, 10:16 AM · Restricted Project

Mar 27 2020

huihuiz created D76944: [GVN] Fix VNCoercion for Scalable Vector..
Mar 27 2020, 12:01 PM · Restricted Project

Mar 23 2020

huihuiz added a comment to D76655: [InstSimplify] Fix SimplifyGEPInst when GEP index type is vector type..

Take test.ll, run opt -S -instsimplify -o -
Then you will get the compiler warning: Compiler has made implicit assumption that TypeSize is not scalable.

Mar 23 2020, 5:27 PM · Restricted Project
huihuiz created D76655: [InstSimplify] Fix SimplifyGEPInst when GEP index type is vector type..
Mar 23 2020, 5:26 PM · Restricted Project

Mar 20 2020

huihuiz committed rG4f5af9d70dcc: [ValueTracking] Fix usage of DataLayout::getTypeStoreSize() (authored by huihuiz).
[ValueTracking] Fix usage of DataLayout::getTypeStoreSize()
Mar 20 2020, 5:23 PM
huihuiz closed D76454: [ValueTracking] Fix usage of DataLayout::getTypeStoreSize().
Mar 20 2020, 5:23 PM · Restricted Project
huihuiz committed rG1993f95f2b1e: [ValueTracking][SVE] Fix getOffsetFromIndex for scalable vector. (authored by huihuiz).
[ValueTracking][SVE] Fix getOffsetFromIndex for scalable vector.
Mar 20 2020, 3:13 PM
huihuiz closed D76464: [ValueTracking][SVE] Fix getOffsetFromIndex for scalable vector..
Mar 20 2020, 3:13 PM · Restricted Project
huihuiz updated the diff for D76454: [ValueTracking] Fix usage of DataLayout::getTypeStoreSize().
Mar 20 2020, 3:12 PM · Restricted Project
huihuiz added inline comments to D76454: [ValueTracking] Fix usage of DataLayout::getTypeStoreSize().
Mar 20 2020, 2:40 PM · Restricted Project
huihuiz updated the diff for D76454: [ValueTracking] Fix usage of DataLayout::getTypeStoreSize().

Address review comments.

Mar 20 2020, 2:40 PM · Restricted Project
huihuiz added inline comments to D76464: [ValueTracking][SVE] Fix getOffsetFromIndex for scalable vector..
Mar 20 2020, 10:17 AM · Restricted Project
huihuiz updated the diff for D76464: [ValueTracking][SVE] Fix getOffsetFromIndex for scalable vector..

Address review comments.

Mar 20 2020, 10:17 AM · Restricted Project

Mar 19 2020

huihuiz created D76464: [ValueTracking][SVE] Fix getOffsetFromIndex for scalable vector..
Mar 19 2020, 5:00 PM · Restricted Project
huihuiz created D76454: [ValueTracking] Fix usage of DataLayout::getTypeStoreSize().
Mar 19 2020, 2:14 PM · Restricted Project

Mar 18 2020

huihuiz committed rG2ea5495759f6: [InstCombine][SVE] Fix InstCombiner::visitAllocaInst for scalable vector. (authored by huihuiz).
[InstCombine][SVE] Fix InstCombiner::visitAllocaInst for scalable vector.
Mar 18 2020, 9:10 PM
huihuiz closed D76386: [InstCombine][SVE] Fix InstCombiner::visitAllocaInst for scalable vector..
Mar 18 2020, 9:09 PM · Restricted Project
huihuiz added inline comments to D76386: [InstCombine][SVE] Fix InstCombiner::visitAllocaInst for scalable vector..
Mar 18 2020, 9:09 PM · Restricted Project
huihuiz created D76386: [InstCombine][SVE] Fix InstCombiner::visitAllocaInst for scalable vector..
Mar 18 2020, 2:40 PM · Restricted Project

Mar 17 2020

huihuiz committed rG1bf0c9937583: [ValueTracking][SVE] Fix isGEPKnownNonNull for scalable vector. (authored by huihuiz).
[ValueTracking][SVE] Fix isGEPKnownNonNull for scalable vector.
Mar 17 2020, 11:50 AM
huihuiz closed D76260: [ValueTracking][SVE] Fix isGEPKnownNonNull for scalable vector..
Mar 17 2020, 11:49 AM · Restricted Project

Mar 16 2020

huihuiz updated the diff for D76260: [ValueTracking][SVE] Fix isGEPKnownNonNull for scalable vector..
Mar 16 2020, 5:31 PM · Restricted Project
huihuiz updated the diff for D76260: [ValueTracking][SVE] Fix isGEPKnownNonNull for scalable vector..

minor update test name

Mar 16 2020, 4:57 PM · Restricted Project
huihuiz created D76260: [ValueTracking][SVE] Fix isGEPKnownNonNull for scalable vector..
Mar 16 2020, 4:57 PM · Restricted Project
huihuiz committed rG0616e9964b9e: [InstSimplify][SVE] Fix SimplifyGEPInst for scalable vector. (authored by huihuiz).
[InstSimplify][SVE] Fix SimplifyGEPInst for scalable vector.
Mar 16 2020, 12:02 PM
huihuiz closed D75892: [InstSimplify][SVE] Fix SimplifyGEPInst for scalable vector..
Mar 16 2020, 12:02 PM · Restricted Project
huihuiz added inline comments to D75892: [InstSimplify][SVE] Fix SimplifyGEPInst for scalable vector..
Mar 16 2020, 12:01 PM · Restricted Project

Mar 13 2020

huihuiz committed rGfc1f20574500: [SLPVectorizer][SVE] Bail out early for scalable vector. (authored by huihuiz).
[SLPVectorizer][SVE] Bail out early for scalable vector.
Mar 13 2020, 11:50 AM
huihuiz closed D76017: [SLPVectorizer][SVE] Bail out early for scalable vector..
Mar 13 2020, 11:50 AM · Restricted Project