Page MenuHomePhabricator

huihuiz (Huihui Zhang)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 9 2016, 6:44 PM (198 w, 4 d)

Recent Activity

Yesterday

huihuiz added inline comments to D76944: [GVN] Fix VNCoercion/BasicAA for Scalable Vector..
Mon, Mar 30, 10:16 AM · Restricted Project

Fri, Mar 27

huihuiz created D76944: [GVN] Fix VNCoercion/BasicAA for Scalable Vector..
Fri, Mar 27, 12:01 PM · Restricted Project

Mon, Mar 23

huihuiz added a comment to D76655: [InstSimplify][SVE] Minor fix SimplifyGEPInst for scalable vector..

Take test.ll, run opt -S -instsimplify -o -
Then you will get the compiler warning: Compiler has made implicit assumption that TypeSize is not scalable.

Mon, Mar 23, 5:27 PM · Restricted Project
huihuiz created D76655: [InstSimplify][SVE] Minor fix SimplifyGEPInst for scalable vector..
Mon, Mar 23, 5:26 PM · Restricted Project

Fri, Mar 20

huihuiz committed rG4f5af9d70dcc: [ValueTracking] Fix usage of DataLayout::getTypeStoreSize() (authored by huihuiz).
[ValueTracking] Fix usage of DataLayout::getTypeStoreSize()
Fri, Mar 20, 5:23 PM
huihuiz closed D76454: [ValueTracking] Fix usage of DataLayout::getTypeStoreSize().
Fri, Mar 20, 5:23 PM · Restricted Project
huihuiz committed rG1993f95f2b1e: [ValueTracking][SVE] Fix getOffsetFromIndex for scalable vector. (authored by huihuiz).
[ValueTracking][SVE] Fix getOffsetFromIndex for scalable vector.
Fri, Mar 20, 3:13 PM
huihuiz closed D76464: [ValueTracking][SVE] Fix getOffsetFromIndex for scalable vector..
Fri, Mar 20, 3:13 PM · Restricted Project
huihuiz updated the diff for D76454: [ValueTracking] Fix usage of DataLayout::getTypeStoreSize().
Fri, Mar 20, 3:12 PM · Restricted Project
huihuiz added inline comments to D76454: [ValueTracking] Fix usage of DataLayout::getTypeStoreSize().
Fri, Mar 20, 2:40 PM · Restricted Project
huihuiz updated the diff for D76454: [ValueTracking] Fix usage of DataLayout::getTypeStoreSize().

Address review comments.

Fri, Mar 20, 2:40 PM · Restricted Project
huihuiz added inline comments to D76464: [ValueTracking][SVE] Fix getOffsetFromIndex for scalable vector..
Fri, Mar 20, 10:17 AM · Restricted Project
huihuiz updated the diff for D76464: [ValueTracking][SVE] Fix getOffsetFromIndex for scalable vector..

Address review comments.

Fri, Mar 20, 10:17 AM · Restricted Project

Thu, Mar 19

huihuiz created D76464: [ValueTracking][SVE] Fix getOffsetFromIndex for scalable vector..
Thu, Mar 19, 5:00 PM · Restricted Project
huihuiz created D76454: [ValueTracking] Fix usage of DataLayout::getTypeStoreSize().
Thu, Mar 19, 2:14 PM · Restricted Project

Wed, Mar 18

huihuiz committed rG2ea5495759f6: [InstCombine][SVE] Fix InstCombiner::visitAllocaInst for scalable vector. (authored by huihuiz).
[InstCombine][SVE] Fix InstCombiner::visitAllocaInst for scalable vector.
Wed, Mar 18, 9:10 PM
huihuiz closed D76386: [InstCombine][SVE] Fix InstCombiner::visitAllocaInst for scalable vector..
Wed, Mar 18, 9:09 PM · Restricted Project
huihuiz added inline comments to D76386: [InstCombine][SVE] Fix InstCombiner::visitAllocaInst for scalable vector..
Wed, Mar 18, 9:09 PM · Restricted Project
huihuiz created D76386: [InstCombine][SVE] Fix InstCombiner::visitAllocaInst for scalable vector..
Wed, Mar 18, 2:40 PM · Restricted Project

Tue, Mar 17

huihuiz committed rG1bf0c9937583: [ValueTracking][SVE] Fix isGEPKnownNonNull for scalable vector. (authored by huihuiz).
[ValueTracking][SVE] Fix isGEPKnownNonNull for scalable vector.
Tue, Mar 17, 11:50 AM
huihuiz closed D76260: [ValueTracking][SVE] Fix isGEPKnownNonNull for scalable vector..
Tue, Mar 17, 11:49 AM · Restricted Project

Mon, Mar 16

huihuiz updated the diff for D76260: [ValueTracking][SVE] Fix isGEPKnownNonNull for scalable vector..
Mon, Mar 16, 5:31 PM · Restricted Project
huihuiz updated the diff for D76260: [ValueTracking][SVE] Fix isGEPKnownNonNull for scalable vector..

minor update test name

Mon, Mar 16, 4:57 PM · Restricted Project
huihuiz created D76260: [ValueTracking][SVE] Fix isGEPKnownNonNull for scalable vector..
Mon, Mar 16, 4:57 PM · Restricted Project
huihuiz committed rG0616e9964b9e: [InstSimplify][SVE] Fix SimplifyGEPInst for scalable vector. (authored by huihuiz).
[InstSimplify][SVE] Fix SimplifyGEPInst for scalable vector.
Mon, Mar 16, 12:02 PM
huihuiz closed D75892: [InstSimplify][SVE] Fix SimplifyGEPInst for scalable vector..
Mon, Mar 16, 12:02 PM · Restricted Project
huihuiz added inline comments to D75892: [InstSimplify][SVE] Fix SimplifyGEPInst for scalable vector..
Mon, Mar 16, 12:01 PM · Restricted Project

Fri, Mar 13

huihuiz committed rGfc1f20574500: [SLPVectorizer][SVE] Bail out early for scalable vector. (authored by huihuiz).
[SLPVectorizer][SVE] Bail out early for scalable vector.
Fri, Mar 13, 11:50 AM
huihuiz closed D76017: [SLPVectorizer][SVE] Bail out early for scalable vector..
Fri, Mar 13, 11:50 AM · Restricted Project

Thu, Mar 12

huihuiz committed rGf4f2706572b1: [ConstantFold][SVE] Fix constant folding for scalable vector compare… (authored by huihuiz).
[ConstantFold][SVE] Fix constant folding for scalable vector compare…
Thu, Mar 12, 4:18 PM
huihuiz closed D73753: [ConstantFold][SVE] Fix constant folding for scalable vector compare instruction..
Thu, Mar 12, 4:18 PM · Restricted Project
huihuiz updated the summary of D76017: [SLPVectorizer][SVE] Bail out early for scalable vector..
Thu, Mar 12, 3:45 PM · Restricted Project
huihuiz updated the diff for D76017: [SLPVectorizer][SVE] Bail out early for scalable vector..
Thu, Mar 12, 3:45 PM · Restricted Project
huihuiz added inline comments to D76017: [SLPVectorizer][SVE] Bail out early for scalable vector..
Thu, Mar 12, 3:45 PM · Restricted Project
huihuiz committed rG118abf201738: [SVE] Update API ConstantVector::getSplat() to use ElementCount. (authored by huihuiz).
[SVE] Update API ConstantVector::getSplat() to use ElementCount.
Thu, Mar 12, 1:35 PM
huihuiz closed D74386: [SVE] Update API ConstantVector::getSplat() to use ElementCount..
Thu, Mar 12, 1:34 PM · Restricted Project, Restricted Project
huihuiz added inline comments to D75892: [InstSimplify][SVE] Fix SimplifyGEPInst for scalable vector..
Thu, Mar 12, 1:34 PM · Restricted Project
huihuiz updated the diff for D75892: [InstSimplify][SVE] Fix SimplifyGEPInst for scalable vector..

Add more test to check the code path, as suggested.

Thu, Mar 12, 1:34 PM · Restricted Project
huihuiz added inline comments to D74386: [SVE] Update API ConstantVector::getSplat() to use ElementCount..
Thu, Mar 12, 11:56 AM · Restricted Project, Restricted Project
huihuiz updated the diff for D74386: [SVE] Update API ConstantVector::getSplat() to use ElementCount..

Addressed review comments.

Thu, Mar 12, 11:56 AM · Restricted Project, Restricted Project

Wed, Mar 11

huihuiz committed rG8f525739622d: [InstSimplify][SVE] Fix SimplifyInsert/ExtractElementInst for scalable vector. (authored by huihuiz).
[InstSimplify][SVE] Fix SimplifyInsert/ExtractElementInst for scalable vector.
Wed, Mar 11, 3:21 PM
huihuiz closed D75782: [InstSimplify][SVE] Fix SimplifyInsert/ExtractElementInst for scalable vector..
Wed, Mar 11, 3:21 PM · Restricted Project
huihuiz added a comment to D76017: [SLPVectorizer][SVE] Bail out early for scalable vector..

take test test/Transforms/SLPVectorizer/AArch64/scalable-vector.ll, run opt -slp-vectorizer

Wed, Mar 11, 11:52 AM · Restricted Project
huihuiz created D76017: [SLPVectorizer][SVE] Bail out early for scalable vector..
Wed, Mar 11, 11:52 AM · Restricted Project

Mon, Mar 9

huihuiz added a comment to D75892: [InstSimplify][SVE] Fix SimplifyGEPInst for scalable vector..

take test.ll, run: opt -S -instsimplify test.ll -o -

Mon, Mar 9, 10:38 PM · Restricted Project
huihuiz created D75892: [InstSimplify][SVE] Fix SimplifyGEPInst for scalable vector..
Mon, Mar 9, 10:38 PM · Restricted Project

Fri, Mar 6

huihuiz added a comment to D75782: [InstSimplify][SVE] Fix SimplifyInsert/ExtractElementInst for scalable vector..

Current upstream is doing wrong fold for scalable vectors.

Fri, Mar 6, 4:34 PM · Restricted Project
huihuiz created D75782: [InstSimplify][SVE] Fix SimplifyInsert/ExtractElementInst for scalable vector..
Fri, Mar 6, 4:34 PM · Restricted Project

Mon, Mar 2

huihuiz committed rG44fa47c9e7ea: [ARM][ConstantIslands] Fix stack mis-alignment caused by undoLRSpillRestore. (authored by huihuiz).
[ARM][ConstantIslands] Fix stack mis-alignment caused by undoLRSpillRestore.
Mon, Mar 2, 4:38 PM
huihuiz closed D75288: [ARM][ConstantIslands] Fix stack mis-alignment caused by undoLRSpillRestore..
Mon, Mar 2, 4:38 PM · Restricted Project

Feb 28 2020

huihuiz updated the diff for D75288: [ARM][ConstantIslands] Fix stack mis-alignment caused by undoLRSpillRestore..

Thank you so much Oliver Stannard for the review!

Feb 28 2020, 11:30 AM · Restricted Project

Feb 27 2020

huihuiz updated the diff for D75288: [ARM][ConstantIslands] Fix stack mis-alignment caused by undoLRSpillRestore..

reduce test a bit

Feb 27 2020, 2:41 PM · Restricted Project
huihuiz added a comment to D75288: [ARM][ConstantIslands] Fix stack mis-alignment caused by undoLRSpillRestore..

you can see the mis-alignment, the StackAlignment is 8 for this test

Feb 27 2020, 12:23 PM · Restricted Project
huihuiz added a reviewer for D75288: [ARM][ConstantIslands] Fix stack mis-alignment caused by undoLRSpillRestore.: samparker.
Feb 27 2020, 12:23 PM · Restricted Project
huihuiz created D75288: [ARM][ConstantIslands] Fix stack mis-alignment caused by undoLRSpillRestore..
Feb 27 2020, 12:23 PM · Restricted Project

Feb 18 2020

huihuiz committed rG8ee0e1dc0245: [NFC] Silence compiler warning [-Wmissing-braces]. (authored by huihuiz).
[NFC] Silence compiler warning [-Wmissing-braces].
Feb 18 2020, 10:44 AM

Feb 13 2020

huihuiz updated the diff for D74386: [SVE] Update API ConstantVector::getSplat() to use ElementCount..

Thanks Eli for the review!

Feb 13 2020, 4:22 PM · Restricted Project, Restricted Project

Feb 12 2020

huihuiz committed rG5350a48931d0: [ConstantFold][SVE] Fix constant fold for FoldReinterpretLoadFromConstPtr. (authored by huihuiz).
[ConstantFold][SVE] Fix constant fold for FoldReinterpretLoadFromConstPtr.
Feb 12 2020, 10:25 AM
huihuiz closed D74424: [ConstantFold][SVE] Fix constant fold for FoldReinterpretLoadFromConstPtr..
Feb 12 2020, 10:25 AM · Restricted Project

Feb 11 2020

huihuiz updated the summary of D74424: [ConstantFold][SVE] Fix constant fold for FoldReinterpretLoadFromConstPtr..
Feb 11 2020, 5:23 PM · Restricted Project
huihuiz updated the diff for D74424: [ConstantFold][SVE] Fix constant fold for FoldReinterpretLoadFromConstPtr..

Thanks Sander for the review!

Feb 11 2020, 5:23 PM · Restricted Project
huihuiz committed rGaedda89f656b: [NFC] Fix warning: comparison of integers of different signs. (authored by huihuiz).
[NFC] Fix warning: comparison of integers of different signs.
Feb 11 2020, 2:50 PM
huihuiz committed rG88de9338f26c: [ConstantFold][SVE] Fix constand fold for vector call. (authored by huihuiz).
[ConstantFold][SVE] Fix constand fold for vector call.
Feb 11 2020, 2:13 PM
huihuiz closed D74419: [ConstantFold][SVE] Fix constand fold for vector call..
Feb 11 2020, 2:13 PM · Restricted Project
huihuiz added a comment to D74424: [ConstantFold][SVE] Fix constant fold for FoldReinterpretLoadFromConstPtr..

Current upstream crash with : include/llvm/Support/TypeSize.h:126: uint64_t llvm::TypeSize::getFixedSize() const: Assertion `!IsScalable && "Request for a fixed size on a scalable object"' failed.

Feb 11 2020, 10:42 AM · Restricted Project
huihuiz created D74424: [ConstantFold][SVE] Fix constant fold for FoldReinterpretLoadFromConstPtr..
Feb 11 2020, 10:42 AM · Restricted Project
huihuiz added a comment to D74419: [ConstantFold][SVE] Fix constand fold for vector call..

Current upstream crash with: llvm/lib/IR/Value.cpp:408: void llvm::Value::doRAUW(llvm::Value *, llvm::Value::ReplaceMetadataUses): Assertion `New->getType() == getType() && "replaceAllUses of value with new value of different type!"' failed.

Feb 11 2020, 8:57 AM · Restricted Project
huihuiz created D74419: [ConstantFold][SVE] Fix constand fold for vector call..
Feb 11 2020, 8:54 AM · Restricted Project

Feb 10 2020

huihuiz added a child revision for D73753: [ConstantFold][SVE] Fix constant folding for scalable vector compare instruction.: D74386: [SVE] Update API ConstantVector::getSplat() to use ElementCount..
Feb 10 2020, 11:36 PM · Restricted Project
huihuiz added a parent revision for D74386: [SVE] Update API ConstantVector::getSplat() to use ElementCount.: D73753: [ConstantFold][SVE] Fix constant folding for scalable vector compare instruction..
Feb 10 2020, 11:36 PM · Restricted Project, Restricted Project
huihuiz updated the diff for D73753: [ConstantFold][SVE] Fix constant folding for scalable vector compare instruction..

Thanks Eli for the feedback!

Feb 10 2020, 11:36 PM · Restricted Project
huihuiz created D74386: [SVE] Update API ConstantVector::getSplat() to use ElementCount..
Feb 10 2020, 11:13 PM · Restricted Project, Restricted Project

Feb 7 2020

huihuiz committed rG6556c615f3c3: Reland "[AMDGPU] Fix data race on RegisterBank initialization." (authored by huihuiz).
Reland "[AMDGPU] Fix data race on RegisterBank initialization."
Feb 7 2020, 2:25 PM
huihuiz committed rGae39105466c4: Reland "[ARM] Fix data race on RegisterBank initialization." (authored by huihuiz).
Reland "[ARM] Fix data race on RegisterBank initialization."
Feb 7 2020, 2:07 PM
huihuiz abandoned D73931: [WIP]AArch64 fix race on RegisterBank.
Feb 7 2020, 2:07 PM · Restricted Project
huihuiz abandoned D73930: [WIP]ARM fix race on RegisterBank.
Feb 7 2020, 2:07 PM · Restricted Project
huihuiz committed rG2491fd0e6f61: Reland "[AArch64] Fix data race on RegisterBank initialization." (authored by huihuiz).
Reland "[AArch64] Fix data race on RegisterBank initialization."
Feb 7 2020, 1:30 PM

Feb 6 2020

huihuiz committed rGe0d1e83e2363: Revert "Reland "[AArch64] Fix data race on RegisterBank initialization."" (authored by huihuiz).
Revert "Reland "[AArch64] Fix data race on RegisterBank initialization.""
Feb 6 2020, 3:30 PM
huihuiz added a reverting change for rG8e1ca948ccfd: Reland "[AArch64] Fix data race on RegisterBank initialization.": rGe0d1e83e2363: Revert "Reland "[AArch64] Fix data race on RegisterBank initialization."".
Feb 6 2020, 3:29 PM
huihuiz committed rG8e1ca948ccfd: Reland "[AArch64] Fix data race on RegisterBank initialization." (authored by huihuiz).
Reland "[AArch64] Fix data race on RegisterBank initialization."
Feb 6 2020, 3:13 PM

Feb 5 2020

huihuiz committed rG5389ca7a1fb3: [ConstantFold][NFC] Move scalable vector unit tests under vscale.ll (authored by huihuiz).
[ConstantFold][NFC] Move scalable vector unit tests under vscale.ll
Feb 5 2020, 4:11 PM
huihuiz committed rG801857c59ea6: [ConstantFold][SVE] Fix constant folding for bitcast. (authored by huihuiz).
[ConstantFold][SVE] Fix constant folding for bitcast.
Feb 5 2020, 3:43 PM
huihuiz closed D71389: [ConstantFold][SVE] Fix constant folding for bitcast..
Feb 5 2020, 3:42 PM · Restricted Project
huihuiz added a child revision for D71389: [ConstantFold][SVE] Fix constant folding for bitcast.: D74095: [ConstantFold][SVE] Fold bitcast into splat value for splat vector..
Feb 5 2020, 3:39 PM · Restricted Project
huihuiz added a parent revision for D74095: [ConstantFold][SVE] Fold bitcast into splat value for splat vector.: D71389: [ConstantFold][SVE] Fix constant folding for bitcast..
Feb 5 2020, 3:39 PM · Restricted Project
huihuiz created D74095: [ConstantFold][SVE] Fold bitcast into splat value for splat vector..
Feb 5 2020, 3:39 PM · Restricted Project
huihuiz added a child revision for D71637: [PatternMatch] Add support for matching ConstantExpr.: D74095: [ConstantFold][SVE] Fold bitcast into splat value for splat vector..
Feb 5 2020, 3:39 PM · Restricted Project

Feb 3 2020

huihuiz committed rG9a40670a0a4e: Revert "Reland "[AArch64] Fix data race on RegisterBank initialization."" (authored by huihuiz).
Revert "Reland "[AArch64] Fix data race on RegisterBank initialization.""
Feb 3 2020, 5:09 PM
huihuiz added a reverting change for rG9c726e9d9058: Reland "[AArch64] Fix data race on RegisterBank initialization.": rG9a40670a0a4e: Revert "Reland "[AArch64] Fix data race on RegisterBank initialization."".
Feb 3 2020, 5:09 PM
huihuiz committed rG9c726e9d9058: Reland "[AArch64] Fix data race on RegisterBank initialization." (authored by huihuiz).
Reland "[AArch64] Fix data race on RegisterBank initialization."
Feb 3 2020, 4:50 PM
huihuiz created D73931: [WIP]AArch64 fix race on RegisterBank.
Feb 3 2020, 3:14 PM · Restricted Project
huihuiz created D73930: [WIP]ARM fix race on RegisterBank.
Feb 3 2020, 3:14 PM · Restricted Project

Jan 30 2020

huihuiz added a comment to D73753: [ConstantFold][SVE] Fix constant folding for scalable vector compare instruction..

current upstream crash at : llvm/lib/IR/Value.cpp:404: void llvm::Value::doRAUW(llvm::Value *, llvm::Value::ReplaceMetadataUses): Assertion `New->getType() == getType() && "replaceAllUses of value with new value of different type!"' failed.

Jan 30 2020, 4:50 PM · Restricted Project
huihuiz created D73753: [ConstantFold][SVE] Fix constant folding for scalable vector compare instruction..
Jan 30 2020, 4:50 PM · Restricted Project
huihuiz committed rGb0d25fff9b84: [ConstantFold][SVE][NFC] Add test for select instruction in scalable vector. (authored by huihuiz).
[ConstantFold][SVE][NFC] Add test for select instruction in scalable vector.
Jan 30 2020, 11:04 AM
huihuiz abandoned D73669: [ConstantFold][SVE] Do not iterate on scalable vector for ConstantFoldSelectInstruction..

Make sense, merge only the test case

Jan 30 2020, 11:03 AM · Restricted Project
huihuiz committed rG34e6552dcbb4: [ConstantFold][SVE] Fix constant folding for scalable vector unary operations. (authored by huihuiz).
[ConstantFold][SVE] Fix constant folding for scalable vector unary operations.
Jan 30 2020, 10:52 AM
huihuiz closed D73678: [ConstantFold][SVE] Fix constant folding for scalable vector unary operations..
Jan 30 2020, 10:52 AM · Restricted Project

Jan 29 2020

huihuiz added a comment to D73678: [ConstantFold][SVE] Fix constant folding for scalable vector unary operations..

current upstream crash with: llvm/lib/IR/Value.cpp:404: void llvm::Value::doRAUW(llvm::Value *, llvm::Value::ReplaceMetadataUses): Assertion `New->getType() == getType() && "replaceAllUses of value with new value of different type!"' failed.

Jan 29 2020, 5:54 PM · Restricted Project
huihuiz created D73678: [ConstantFold][SVE] Fix constant folding for scalable vector unary operations..
Jan 29 2020, 5:54 PM · Restricted Project