User Details
- User Since
- Jun 9 2016, 6:44 PM (241 w, 6 d)
Dec 8 2020
Dec 7 2020
Thanks for the feedback!
Test cases for vector splitting added. Also fix the warning message caused by extracting subvector.
Dec 3 2020
Oct 23 2020
Thanks @sdesmalen for the review!
Fixed in the commit patch.
Oct 21 2020
Oct 20 2020
Current upstream mis-compile, take t.ll , run "llc -mtriple=aarch64-linux-gnu -mattr=+sve < t.ll"
Sep 18 2020
Current upstream crash with test attached.
Sep 15 2020
Sep 14 2020
Thanks guys for the feedback!
Addressed review comments.
Sep 11 2020
Sep 2 2020
Thanks Sanjay for the review!
Addressed review comments.
Sep 1 2020
Aug 10 2020
I don't think that's the intention of this specific test given the name insert_extract_element_same_vec_idx_2. And also the unused parameter %a.
This is failing due after a local change to instsimplify and I think the test maybe isn't testing what it wants to test?
why do we need this change?
insert element into undef is common to construct a vector, being fixed or scalable.
Jul 31 2020
Thanks @paulwalker-arm for the review!
I have moved the new tests into sve-masked-ldst-nonext.ll in the commit.
Jun 25 2020
Hey @fpetrogalli @sdesmalen , any updates on this patch? This should be the last one to commit for structure load? Or are we using different approach?
Jun 17 2020
Jun 12 2020
Jun 4 2020
Jun 3 2020
Thanks Eli for pointing this out!
Jun 1 2020
May 13 2020
May 7 2020
Thanks! Fixed in the committed patch.
Address review comments.
Address review comments.
Apr 29 2020
Thanks Eli for the feedback!
Please let me know if the fixes related to shuffle vector make sense to you.
Rebase.
Apr 27 2020
Thanks Sander for the feedback!
Apr 26 2020
- Current upstream crash at:
llvm::ShuffleVectorInst::ShuffleVectorInst(llvm::Value *, llvm::Value *, ArrayRef<int>, const llvm::Twine &, llvm::Instruction *): Assertion `isValidOperands(V1, V2, Mask) && "Invalid shuffle vector instruction operands!"' failed.
take test.ll , run opt -S -instcombine test.ll
Apr 22 2020
Looks fine with me.
Apr 16 2020
I am also looking at the related issues of shufflevector created by "extractelement, insertelement" pair.
Currently working on InstCombiner::visitInsertElementInst.
Thanks Eli for the feedback!
Apr 15 2020
Current upstream crash at llvm/include/llvm/ADT/APInt.h:1437: void llvm::APInt::setBit(unsigned int): Assertion `BitPosition < BitWidth && "BitPosition out of range"' failed.
Apr 14 2020
My initial thought was wrong.
Spent sometime look again, we are nearly impossible to generate incorrect result without the code fixes in this patch.
But comparing a scalable size with a fixed size still doesn't make sense.
Thanks Eli for the feedbacks!
Yes, it's valid to use scalable type mininal size for inbounds checking.
Apr 13 2020
Current upstream crash at llvm/lib/IR/Constants.cpp:1674: static llvm::Constant *llvm::ConstantExpr::getCast(unsigned int, llvm::Constant *, llvm::Type *, bool): Assertion `CastInst::castIsValid(opc, C, Ty) && "Invalid constantexpr cast!"' failed.
Apr 12 2020
Apr 10 2020
Address review comments.
Apr 9 2020
Address review comments.
Current upstream is producing wrong AliasResult for scalable type.
Mar 30 2020
Mar 27 2020
Mar 23 2020
Take test.ll, run opt -S -instsimplify -o -
Then you will get the compiler warning: Compiler has made implicit assumption that TypeSize is not scalable.
Mar 20 2020
Address review comments.
Address review comments.