See Bug 33629: https://bugs.llvm.org//show_bug.cgi?id=33629
Known issues:
- V_INTERP_P2_F16 and V_INTERP_P2_LEGACY_F16 should be handled in a similar way. This depends on D35902 and will be added separately.
Paths
| Differential D36322
[AMDGPU][MC][GFX9] Added 16-bit renamed and "_legacy" VALU opcodes ClosedPublic Authored by dp on Aug 4 2017, 9:13 AM.
Details Summary See Bug 33629: https://bugs.llvm.org//show_bug.cgi?id=33629 Known issues:
Diff Detail Event TimelineHerald added subscribers: t-tye, tpr, dstuttard and 4 others. · View Herald TranscriptAug 4 2017, 9:13 AM Comment Actions I'm confused about what exactly is meant by a legacy instruction. This isn't the first set of instructions renamed to be _legacy, so I think the bit name needs to be more specific. What exactly is different about mad_legacy for example? Is there a new mad opcode with different behavior? Can we leave it as an MC emission quirk rather than changing codegen to have to be aware of the random instruction rename?
dp retitled this revision from [AMDGPU][MC][GFX9] Added 16-bit renamed and legacy VALU opcodes to [AMDGPU][MC][GFX9] Added 16-bit renamed and "_legacy" VALU opcodes. Comment ActionsUpdated and a bit simplified as suggested by Matt and Sam. This revision is now accepted and ready to land.Aug 7 2017, 8:52 AM Closed by commit rL310497: [AMDGPU][MC][GFX9] Added 16-bit renamed and "_legacy" VALU opcodes (authored by dpreobra). · Explain WhyAug 9 2017, 10:11 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 109882 lib/Target/AMDGPU/AMDGPUInstrInfo.cpp
lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp
lib/Target/AMDGPU/SIDefines.h
lib/Target/AMDGPU/SIInstrFormats.td
lib/Target/AMDGPU/SIInstrInfo.td
lib/Target/AMDGPU/VOP3Instructions.td
test/MC/AMDGPU/vop3-gfx9.s
test/MC/AMDGPU/vop3.s
test/MC/Disassembler/AMDGPU/vop3_gfx9.txt
test/MC/Disassembler/AMDGPU/vop3_vi.txt
|
The naming convention is the base instruction name is all caps, but the suffix is lowercase