Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

vpykhtin (Valery Pykhtin)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 28 2016, 8:30 AM (400 w, 4 d)

Recent Activity

Tue, Sep 12

vpykhtin added inline comments to D158167: [AMDGPU] Handle isUndef flag in LiveVariables::recomputeForSingleDefVirtReg.
Tue, Sep 12, 2:14 AM · Restricted Project, Restricted Project
vpykhtin added inline comments to D158167: [AMDGPU] Handle isUndef flag in LiveVariables::recomputeForSingleDefVirtReg.
Tue, Sep 12, 2:02 AM · Restricted Project, Restricted Project
vpykhtin committed rGaf2dcc3052a8: [AMDGPU] Handle inUndef flag in LiveVariables::recomputeForSingleDefVirtReg (authored by vpykhtin).
[AMDGPU] Handle inUndef flag in LiveVariables::recomputeForSingleDefVirtReg
Tue, Sep 12, 2:00 AM · Restricted Project, Restricted Project
vpykhtin closed D158167: [AMDGPU] Handle isUndef flag in LiveVariables::recomputeForSingleDefVirtReg.
Tue, Sep 12, 2:00 AM · Restricted Project, Restricted Project

Thu, Sep 7

vpykhtin added inline comments to D158167: [AMDGPU] Handle isUndef flag in LiveVariables::recomputeForSingleDefVirtReg.
Thu, Sep 7, 7:34 AM · Restricted Project, Restricted Project
vpykhtin updated the diff for D158167: [AMDGPU] Handle isUndef flag in LiveVariables::recomputeForSingleDefVirtReg.

Replaced MI.readsWritesVirtualRegister(Reg).first with readsVirtualRegister.

Thu, Sep 7, 7:33 AM · Restricted Project, Restricted Project

Tue, Sep 5

vpykhtin updated the diff for D158167: [AMDGPU] Handle isUndef flag in LiveVariables::recomputeForSingleDefVirtReg.
  • Rebased.
  • Added tests.
Tue, Sep 5, 1:16 PM · Restricted Project, Restricted Project

Aug 17 2023

vpykhtin retitled D158167: [AMDGPU] Handle isUndef flag in LiveVariables::recomputeForSingleDefVirtReg from [AMDGPU] Handle inUndef flag in LiveVariables::recomputeForSingleDefVirtReg to [AMDGPU] Handle isUndef flag in LiveVariables::recomputeForSingleDefVirtReg.
Aug 17 2023, 3:33 AM · Restricted Project, Restricted Project
vpykhtin requested review of D158167: [AMDGPU] Handle isUndef flag in LiveVariables::recomputeForSingleDefVirtReg.
Aug 17 2023, 3:31 AM · Restricted Project, Restricted Project

Jul 28 2023

vpykhtin added a comment to D156332: [AMDGPU] Enable GCNRewritePartialRegUses pass by default..

Got some test failure on graphics, fixing.

Jul 28 2023, 7:11 AM · Restricted Project, Restricted Project

Jul 27 2023

vpykhtin updated the diff for D156332: [AMDGPU] Enable GCNRewritePartialRegUses pass by default..

Update failed expensive checks llc-pipeline.ll test.

Jul 27 2023, 2:28 AM · Restricted Project, Restricted Project

Jul 26 2023

vpykhtin added a reviewer for D156332: [AMDGPU] Enable GCNRewritePartialRegUses pass by default.: Restricted Project.
Jul 26 2023, 7:11 AM · Restricted Project, Restricted Project
vpykhtin updated the diff for D156332: [AMDGPU] Enable GCNRewritePartialRegUses pass by default..

Disable pass for CodeGen/AMDGPU/dead-lane.mir test.

Jul 26 2023, 7:10 AM · Restricted Project, Restricted Project
vpykhtin requested review of D156332: [AMDGPU] Enable GCNRewritePartialRegUses pass by default..
Jul 26 2023, 7:03 AM · Restricted Project, Restricted Project

Jul 5 2023

vpykhtin committed rG98aa8439f5e0: [AMDGPU] Fix register class for a subreg in GCNRewritePartialRegUses. (authored by vpykhtin).
[AMDGPU] Fix register class for a subreg in GCNRewritePartialRegUses.
Jul 5 2023, 11:49 PM · Restricted Project, Restricted Project
vpykhtin closed D152832: [AMDGPU] Fix register class for a subreg in GCNRewritePartialRegUses..
Jul 5 2023, 11:49 PM · Restricted Project, Restricted Project
vpykhtin updated the diff for D152832: [AMDGPU] Fix register class for a subreg in GCNRewritePartialRegUses..

Rebase before landing.

Jul 5 2023, 10:49 PM · Restricted Project, Restricted Project

Jul 4 2023

vpykhtin added inline comments to D152832: [AMDGPU] Fix register class for a subreg in GCNRewritePartialRegUses..
Jul 4 2023, 3:09 PM · Restricted Project, Restricted Project
vpykhtin added inline comments to D152832: [AMDGPU] Fix register class for a subreg in GCNRewritePartialRegUses..
Jul 4 2023, 10:31 AM · Restricted Project, Restricted Project

Jun 22 2023

vpykhtin added a comment to D152832: [AMDGPU] Fix register class for a subreg in GCNRewritePartialRegUses..

ping.

Jun 22 2023, 12:23 PM · Restricted Project, Restricted Project

Jun 14 2023

vpykhtin added inline comments to D152832: [AMDGPU] Fix register class for a subreg in GCNRewritePartialRegUses..
Jun 14 2023, 2:54 AM · Restricted Project, Restricted Project
vpykhtin updated the diff for D152832: [AMDGPU] Fix register class for a subreg in GCNRewritePartialRegUses..

Improved function description.

Jun 14 2023, 2:32 AM · Restricted Project, Restricted Project

Jun 13 2023

vpykhtin updated the summary of D152832: [AMDGPU] Fix register class for a subreg in GCNRewritePartialRegUses..
Jun 13 2023, 9:52 AM · Restricted Project, Restricted Project
vpykhtin added a reviewer for D152832: [AMDGPU] Fix register class for a subreg in GCNRewritePartialRegUses.: Restricted Project.
Jun 13 2023, 9:50 AM · Restricted Project, Restricted Project
vpykhtin requested review of D152832: [AMDGPU] Fix register class for a subreg in GCNRewritePartialRegUses..
Jun 13 2023, 9:49 AM · Restricted Project, Restricted Project

Jun 7 2023

vpykhtin committed rG342acfc9bbc6: [AMDGPU] Turn off pass to rewrite partially used virtual superregisters after… (authored by vpykhtin).
[AMDGPU] Turn off pass to rewrite partially used virtual superregisters after…
Jun 7 2023, 3:06 AM · Restricted Project, Restricted Project
vpykhtin closed D152291: [AMDGPU] Turn off pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..
Jun 7 2023, 3:05 AM · Restricted Project, Restricted Project
vpykhtin updated the diff for D152291: [AMDGPU] Turn off pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..

Fixed llc-pipeline test, rebased.

Jun 7 2023, 1:31 AM · Restricted Project, Restricted Project

Jun 6 2023

vpykhtin added a reviewer for D152291: [AMDGPU] Turn off pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size.: Restricted Project.
Jun 6 2023, 11:11 AM · Restricted Project, Restricted Project
vpykhtin requested review of D152291: [AMDGPU] Turn off pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..
Jun 6 2023, 11:11 AM · Restricted Project, Restricted Project

May 26 2023

vpykhtin committed rG8d0412ce9d48: [AMDGPU] Add pass to rewrite partially used virtual superregisters after… (authored by vpykhtin).
[AMDGPU] Add pass to rewrite partially used virtual superregisters after…
May 26 2023, 12:06 AM · Restricted Project, Restricted Project
vpykhtin closed D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..
May 26 2023, 12:06 AM · Restricted Project, Restricted Project

May 24 2023

vpykhtin updated the diff for D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..

Rebase.

May 24 2023, 11:55 PM · Restricted Project, Restricted Project
vpykhtin updated the diff for D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..
  • Rebased.
  • Minor issues fixed.
May 24 2023, 5:45 AM · Restricted Project, Restricted Project
vpykhtin added inline comments to D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..
May 24 2023, 4:32 AM · Restricted Project, Restricted Project
vpykhtin added a comment to D149775: [AMDGPU] Reserve SGPR pair when long branches are present.

What if we always reserve a register for long jumps?

I think we still want the ability to not reserve them in cases where they might not actually be needed and would waste resources. The amdgpu-long-branch-factor initialized default has been reset higher so that we lean toward always reserving them now - if this value is 0 the long branch registers are never reserved. As this value grows the great chance the branch distance will fall within the threshold and the registers will be marked to be reserved.

May 24 2023, 4:21 AM · Restricted Project, Restricted Project, Restricted Project

May 12 2023

vpykhtin added a comment to D149775: [AMDGPU] Reserve SGPR pair when long branches are present.

What if we always reserve a register for long jumps?

May 12 2023, 10:04 AM · Restricted Project, Restricted Project, Restricted Project
vpykhtin added a comment to D149775: [AMDGPU] Reserve SGPR pair when long branches are present.

I'm not sure why but this review doesn't contain context (unchanged lines of code), may be it worth to try arc diff to generate review requests.

May 12 2023, 8:16 AM · Restricted Project, Restricted Project, Restricted Project
vpykhtin added inline comments to D149775: [AMDGPU] Reserve SGPR pair when long branches are present.
May 12 2023, 7:40 AM · Restricted Project, Restricted Project, Restricted Project

May 3 2023

vpykhtin added a comment to D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..

ping.

May 3 2023, 3:30 AM · Restricted Project, Restricted Project
vpykhtin accepted D147532: [MachineLateInstrsCleanup] Improve compile time for huge functions..

Ok, since this isn't critical I don't have strong preference to erase by the iterator, I'm fine with shorter and nicer version with make_early_inc_range :) Thank you :)

May 3 2023, 12:50 AM · Restricted Project, Restricted Project

Apr 29 2023

vpykhtin added inline comments to D147532: [MachineLateInstrsCleanup] Improve compile time for huge functions..
Apr 29 2023, 7:39 PM · Restricted Project, Restricted Project

Apr 25 2023

vpykhtin added inline comments to D147532: [MachineLateInstrsCleanup] Improve compile time for huge functions..
Apr 25 2023, 12:20 AM · Restricted Project, Restricted Project
vpykhtin added inline comments to D147532: [MachineLateInstrsCleanup] Improve compile time for huge functions..
Apr 25 2023, 12:12 AM · Restricted Project, Restricted Project

Apr 19 2023

vpykhtin added inline comments to D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..
Apr 19 2023, 12:02 PM · Restricted Project, Restricted Project
vpykhtin updated the diff for D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..
  • Rebased, updated tests.
  • Added debug operand processing with a TODO, added test.
Apr 19 2023, 12:01 PM · Restricted Project, Restricted Project

Apr 6 2023

vpykhtin accepted D147532: [MachineLateInstrsCleanup] Improve compile time for huge functions..

LGTM, thank you!

Apr 6 2023, 9:52 PM · Restricted Project, Restricted Project

Apr 5 2023

vpykhtin committed rGe09b33feec19: [CodeGen] Speedup stack slot sharing during stack coloring (interval… (authored by vpykhtin).
[CodeGen] Speedup stack slot sharing during stack coloring (interval…
Apr 5 2023, 10:24 PM · Restricted Project, Restricted Project
vpykhtin closed D146057: [CodeGen] Speedup stack slot sharing during stack coloring (interval overlapping test)..
Apr 5 2023, 10:24 PM · Restricted Project, Restricted Project
vpykhtin updated the diff for D146057: [CodeGen] Speedup stack slot sharing during stack coloring (interval overlapping test)..

Rebased before landing.

Apr 5 2023, 9:29 PM · Restricted Project, Restricted Project
vpykhtin added inline comments to D147532: [MachineLateInstrsCleanup] Improve compile time for huge functions..
Apr 5 2023, 9:27 AM · Restricted Project, Restricted Project

Apr 4 2023

vpykhtin abandoned D146810: [CodeGen] Compile-time improvement for Machine Late Instructions Cleanup Pass..

I tried this patch again a final time, this time passing the RegInfo pointer to removeRedundantDef() and further into clearKillsForDef(). My idea here is that this would only mean a single lookup for both the def and the kill. This was however also not any faster at all.

I also tried having a vector of RegInfo:s for each MBB - instead of a map. The idea was to make the lookup time linear, but this was much slower in small functions (while perhaps good idea in huge ones).

I have tried different map types before, so I don't think there is anything to gain from that.

I will post my patch as a separate review...

Apr 4 2023, 9:09 AM · Restricted Project, Restricted Project

Apr 1 2023

vpykhtin added inline comments to D146057: [CodeGen] Speedup stack slot sharing during stack coloring (interval overlapping test)..
Apr 1 2023, 12:13 AM · Restricted Project, Restricted Project

Mar 31 2023

vpykhtin added inline comments to D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..
Mar 31 2023, 8:41 AM · Restricted Project, Restricted Project
vpykhtin added inline comments to D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..
Mar 31 2023, 6:20 AM · Restricted Project, Restricted Project
vpykhtin updated the diff for D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..
  • Rebased, updated lit tests.
  • Per review issues partially done.
Mar 31 2023, 6:06 AM · Restricted Project, Restricted Project
vpykhtin added a comment to D146810: [CodeGen] Compile-time improvement for Machine Late Instructions Cleanup Pass..

If the map lookup time really matters, maybe it could be worth trying a vector of DefMI/KillMI pairs, so lookup time would be O(n) into the vector..?

I don't think it's that critical

Mar 31 2023, 4:09 AM · Restricted Project, Restricted Project

Mar 28 2023

vpykhtin added a comment to D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..

ping.

Mar 28 2023, 12:40 AM · Restricted Project, Restricted Project
vpykhtin updated the diff for D146057: [CodeGen] Speedup stack slot sharing during stack coloring (interval overlapping test)..
  • Rebased.
Mar 28 2023, 12:39 AM · Restricted Project, Restricted Project

Mar 25 2023

vpykhtin added a comment to D146810: [CodeGen] Compile-time improvement for Machine Late Instructions Cleanup Pass..

On SystemZ, the two versions show practically identical runtimes, so there is no winner. Is there any difference at all on your machine?

Not really :) Something barely measurable like 2.13 and 2.09 seconds on the huge testcase. I'm curious which cases you use to compare to the current, non-map version?

Mar 25 2023, 1:42 AM · Restricted Project, Restricted Project

Mar 24 2023

vpykhtin updated the diff for D146810: [CodeGen] Compile-time improvement for Machine Late Instructions Cleanup Pass..

Fixed debug build.

Mar 24 2023, 7:54 AM · Restricted Project, Restricted Project
vpykhtin added reviewers for D146810: [CodeGen] Compile-time improvement for Machine Late Instructions Cleanup Pass.: jonpa, foad.
Mar 24 2023, 7:05 AM · Restricted Project, Restricted Project
vpykhtin updated the diff for D146810: [CodeGen] Compile-time improvement for Machine Late Instructions Cleanup Pass..

Mine version of the patch.

Mar 24 2023, 7:04 AM · Restricted Project, Restricted Project
vpykhtin requested review of D146810: [CodeGen] Compile-time improvement for Machine Late Instructions Cleanup Pass..
Mar 24 2023, 7:02 AM · Restricted Project, Restricted Project

Mar 21 2023

vpykhtin added a comment to D119013: [ArgPromotion][AMDGPU] New MSSA-based function argument promotion pass with input/output argument support.

Going to reclaim this work

Mar 21 2023, 12:17 AM · Restricted Project, Restricted Project

Mar 20 2023

vpykhtin added inline comments to D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..
Mar 20 2023, 5:33 AM · Restricted Project, Restricted Project
vpykhtin updated the diff for D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..

Per review issues:

  • Improved comments.
  • More C++ structure bingind syntax used.
Mar 20 2023, 5:25 AM · Restricted Project, Restricted Project

Mar 19 2023

vpykhtin updated the diff for D146057: [CodeGen] Speedup stack slot sharing during stack coloring (interval overlapping test)..

Tried version with LiveIntervalUnion but it works slightly slower than first:

~4.2 vs ~3 seconds per pass on my testcase.
Mar 19 2023, 12:51 AM · Restricted Project, Restricted Project

Mar 16 2023

vpykhtin added inline comments to D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..
Mar 16 2023, 10:17 AM · Restricted Project, Restricted Project
vpykhtin updated the diff for D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..
  • Improved comments.
  • Rebased, updated tests.
Mar 16 2023, 10:15 AM · Restricted Project, Restricted Project

Mar 14 2023

vpykhtin added a comment to D146057: [CodeGen] Speedup stack slot sharing during stack coloring (interval overlapping test)..

Hmm the main RAGreedy allocator is using the LiveRegMatrix and within that the LiveIntervalUnion classes to keep things performant. Maybe we can use those here too? In principle they should have even better runtime behavior than merging here...

Mar 14 2023, 9:52 PM · Restricted Project, Restricted Project
vpykhtin updated the diff for D146057: [CodeGen] Speedup stack slot sharing during stack coloring (interval overlapping test)..
  • fixed typo, debug build, added comment.
Mar 14 2023, 9:49 AM · Restricted Project, Restricted Project
vpykhtin added inline comments to D146057: [CodeGen] Speedup stack slot sharing during stack coloring (interval overlapping test)..
Mar 14 2023, 9:17 AM · Restricted Project, Restricted Project
vpykhtin added inline comments to D146057: [CodeGen] Speedup stack slot sharing during stack coloring (interval overlapping test)..
Mar 14 2023, 9:09 AM · Restricted Project, Restricted Project
vpykhtin requested review of D146057: [CodeGen] Speedup stack slot sharing during stack coloring (interval overlapping test)..
Mar 14 2023, 8:51 AM · Restricted Project, Restricted Project
vpykhtin abandoned D145864: [CodeGen] Introduce threshold option to constrain stack slot sharing during stack coloring..

Unfortunatelly stack growed x180 times with slot sharing disabled, so this isn't an option.

Mar 14 2023, 3:13 AM · Restricted Project, Restricted Project
vpykhtin added a comment to D123394: [CodeGen] Late cleanup of redundant address/immediate definitions..

Hi Valery, thanks for the report! It would be nice if you posted your test case on github issues and assigned me (and/or yourself :)... I would think this could be fixed.

Mar 14 2023, 12:53 AM · Restricted Project, Restricted Project

Mar 13 2023

vpykhtin added a comment to D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..

ping

Mar 13 2023, 10:52 AM · Restricted Project, Restricted Project

Mar 12 2023

vpykhtin added a reviewer for D145864: [CodeGen] Introduce threshold option to constrain stack slot sharing during stack coloring.: bcahoon.
Mar 12 2023, 3:35 AM · Restricted Project, Restricted Project
vpykhtin requested review of D145864: [CodeGen] Introduce threshold option to constrain stack slot sharing during stack coloring..
Mar 12 2023, 3:33 AM · Restricted Project, Restricted Project

Mar 11 2023

vpykhtin added a comment to D123394: [CodeGen] Late cleanup of redundant address/immediate definitions..

Makes sense to me - I tried also earlier to store the kills in a map but I found (at least on SystemZ) that this backwards search was actually quicker than that, so I don't think it should be an issue in the normal case...

Mar 11 2023, 3:02 AM · Restricted Project, Restricted Project

Mar 9 2023

vpykhtin committed rG8f6c47b7a42c: [AMDGPU] Speedup GCNDownwardRPTracker::advanceBeforeNext (authored by vpykhtin).
[AMDGPU] Speedup GCNDownwardRPTracker::advanceBeforeNext
Mar 9 2023, 6:18 AM · Restricted Project, Restricted Project
vpykhtin closed D136267: [AMDGPU] Speedup GCNDownwardRPTracker::advanceBeforeNext.
Mar 9 2023, 6:18 AM · Restricted Project, Restricted Project
vpykhtin updated the diff for D136267: [AMDGPU] Speedup GCNDownwardRPTracker::advanceBeforeNext.
  • added generated checks.
Mar 9 2023, 5:20 AM · Restricted Project, Restricted Project
vpykhtin updated the diff for D136267: [AMDGPU] Speedup GCNDownwardRPTracker::advanceBeforeNext.
  • added regression test.
  • rebased after the fix a999669982d0: [AMDGPU] Scheduler: fix RP calculation for a MBB with one successor
Mar 9 2023, 4:33 AM · Restricted Project, Restricted Project

Mar 8 2023

vpykhtin committed rGa999669982d0: [AMDGPU] Scheduler: fix RP calculation for a MBB with one successor (authored by vpykhtin).
[AMDGPU] Scheduler: fix RP calculation for a MBB with one successor
Mar 8 2023, 3:20 AM · Restricted Project, Restricted Project
vpykhtin closed D136918: [AMDGPU] Scheduler: fix RP calculation for a MBB with one successor.
Mar 8 2023, 3:20 AM · Restricted Project, Restricted Project

Mar 7 2023

vpykhtin updated the diff for D136918: [AMDGPU] Scheduler: fix RP calculation for a MBB with one successor.
  • rebased.
  • added comment.
Mar 7 2023, 12:11 PM · Restricted Project, Restricted Project
vpykhtin added a comment to D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..

ping

Mar 7 2023, 12:35 AM · Restricted Project, Restricted Project

Mar 2 2023

vpykhtin reopened D136267: [AMDGPU] Speedup GCNDownwardRPTracker::advanceBeforeNext.

This patch depends on https://reviews.llvm.org/D136918 fix.

Mar 2 2023, 9:30 AM · Restricted Project, Restricted Project
vpykhtin reclaimed D136918: [AMDGPU] Scheduler: fix RP calculation for a MBB with one successor.

I would like to reclaim this but with different reasoning:

Mar 2 2023, 9:26 AM · Restricted Project, Restricted Project

Feb 28 2023

vpykhtin added a comment to D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..

Kindly pinging, this is ready to submit.

Feb 28 2023, 12:56 AM · Restricted Project, Restricted Project

Feb 23 2023

vpykhtin updated the diff for D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..
  • Rebased.
  • Improved interval updating code.
  • Passed internal testing.
Feb 23 2023, 7:25 AM · Restricted Project, Restricted Project

Jan 25 2023

vpykhtin updated the diff for D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..
  • Rebased.
  • Removed ad-hoc in-place interval modification, replaced with copy.
Jan 25 2023, 1:25 AM · Restricted Project, Restricted Project

Jan 19 2023

vpykhtin added inline comments to D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..
Jan 19 2023, 6:30 AM · Restricted Project, Restricted Project
vpykhtin updated the summary of D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..
Jan 19 2023, 6:29 AM · Restricted Project, Restricted Project

Jan 17 2023

vpykhtin added inline comments to D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..
Jan 17 2023, 9:19 PM · Restricted Project, Restricted Project
vpykhtin retitled D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size. from [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size (WIP) to [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..
Jan 17 2023, 11:51 AM · Restricted Project, Restricted Project
vpykhtin updated the diff for D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..
  • Rebased.
  • Passed internal testing.
Jan 17 2023, 11:51 AM · Restricted Project, Restricted Project

Jan 2 2023

vpykhtin updated the diff for D139732: [AMDGPU] Add pass to rewrite partially used virtual superregisters after RenameIndependentSubregs pass with registers of minimal size..

Forgot to remove disabled code, done.

Jan 2 2023, 2:20 AM · Restricted Project, Restricted Project