User Details
- User Since
- Jan 29 2016, 5:37 AM (374 w, 1 d)
Nov 30 2017
Stronger verification for UNUSED_PRESERVE
Nov 29 2017
Added verification for tied register for UNUSED_PRESERVE
Nov 24 2017
Nov 21 2017
Fix for VOP2b instructions was submitted in D40088.
Added SDWA dissassembler tests for VI.
Nov 17 2017
Nov 10 2017
Ping.
Matt, what do you think about latest changes in reivew?
Nov 2 2017
Fixed latests issues from arsenm
Oct 13 2017
Ping
Oct 5 2017
Removed SIMergeSDWAPreserve pass.
Use tied registers to achieve same results
Sep 14 2017
Resolved some issues
Sep 13 2017
Sep 8 2017
Aug 16 2017
LGTM with small issue.
Aug 14 2017
LGTM
Aug 7 2017
LGTM
Aug 5 2017
Aug 4 2017
Jul 31 2017
Jul 20 2017
LGTM
Jul 19 2017
Jul 14 2017
Added assembler tests
Jul 13 2017
Jul 6 2017
Re-used Opc
Jun 27 2017
Fix comments from Matt
Jun 26 2017
Jun 22 2017
This change should in fact fix problem, but it is only workaround.
Ultimately problem is that instruction V_CVT_U32_F32 allow omod operand (see SIInstrInfo.td:1435). In fact this operand shouldn't be allowed here.
This should work as quickfix for assert if you need this. But I think it is better to provide full fix.
Hi,
I have no access to bug report: https://bugs.freedesktop.org/show_bug.cgi?id=101561
Can you send me failing .ll?
Jun 21 2017
Removed changes from merge pseudo instrutions
Jun 20 2017
I agree, it's better to remove assert ,rather them commenting them out.
Otherwise, LGTM
Jun 15 2017
Ping
Jun 13 2017
Removed generation check from constant bus verification.
Jun 9 2017
Fixed issues in SIInstrInfo.cpp
Jun 8 2017
Jun 6 2017
Jun 3 2017
This is good change. I wanted to propose it myself:)
May 30 2017
May 25 2017
LGTM
I think it's better if you submit this change. I will close my review (https://reviews.llvm.org/D33556).
Fixed linux macros
May 23 2017
May 19 2017
Removed omod operand from pseudo instructions with integer dst
May 17 2017
Rebased on top of master.
Renamed VI9 tests to GFX89.
Added commentary for SDWA on GFX9.
May 16 2017
Simplified process. Got rid of PulledOut vector.
May 12 2017
May 11 2017
Small fix
May 10 2017
Got rid of shared_ptr
May 4 2017
Resolved some issues
May 3 2017
Apr 27 2017
Apr 25 2017
Apr 11 2017
Apr 7 2017
Fixed and resubmitted in r299654
Apr 5 2017
Apr 4 2017
Mar 31 2017
Submitted in r299202
Mar 29 2017
Changed isImm() to foldToImm() that return Optional<int64_t>
Mar 20 2017
Changes for latest comments
Mar 16 2017
Add check for single use of src sdwa operand.
Cleanup for remaining comments.
Mar 14 2017
I alredy either fixed or answered on comments to previous version. Currently I'm waiting for new comments or acceptance thats why I started working on new functionality.
Mar 13 2017
Introduced new sdwa patterns
Mar 9 2017
Fixed isSameBB
Mar 6 2017
Added support for subregs.
Fixed most of previous comments.
Feb 17 2017
Feb 16 2017
Jan 19 2017
Jan 17 2017
Jan 10 2017
Fixed issues
Dec 29 2016
Dec 26 2016
Ping