This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Switch aperture queries to use aperture registers instead of s_getreg_b32
AbandonedPublic

Authored by kzhuravl on Apr 9 2017, 11:18 PM.

Details

Reviewers
arsenm

Diff Detail

Event Timeline

kzhuravl created this revision.Apr 9 2017, 11:18 PM
arsenm added inline comments.Apr 10 2017, 10:56 AM
lib/Target/AMDGPU/SIISelLowering.cpp
2355–2356

It shouldn't be necessary to add these as live in, they should be reserved registers

2357–2358

You shouldn't emit a raw mov here, this should be a CopyFromReg

arsenm added inline comments.Apr 10 2017, 10:59 AM
lib/Target/AMDGPU/SIRegisterInfo.cpp
1039–1040

I would rather this assert on null than try to handle it

arsenm added inline comments.Apr 10 2017, 11:01 AM
lib/Target/AMDGPU/SIISelLowering.cpp
2357–2358

Also this is extracting the sub register when you can just directly copy from the sub register?

kzhuravl added inline comments.Apr 10 2017, 3:24 PM
lib/Target/AMDGPU/SIISelLowering.cpp
2357–2358

Did you mean copy directly from the sub register of src_*_base? If yes, then I do not think it is possible, as it is an 64 bit inline constant, and there are no inline constants for _lo and _hi parts. If no, can you elaborate?

Thanks.

arsenm added inline comments.Apr 10 2017, 3:37 PM
lib/Target/AMDGPU/SIISelLowering.cpp
2357–2358

I think it is possible for sub0, but maybe not sub1. These are still modeled as constant registers, so at least getRegister should work, although you probably need the separate extract still

kzhuravl planned changes to this revision.Apr 17 2017, 11:20 AM
kzhuravl abandoned this revision.Apr 2 2019, 12:43 PM
kzhuravl reclaimed this revision.Apr 2 2019, 12:47 PM
arsenm resigned from this revision.Dec 1 2022, 11:07 AM

This can be abandoned

Herald added a project: Restricted Project. · View Herald TranscriptDec 1 2022, 11:07 AM
kzhuravl abandoned this revision.May 5 2023, 12:31 PM