Page MenuHomePhabricator

[ARM] Do not test for CPUs, use SubtargetFeatures. Also remove 2 flags.
ClosedPublic

Authored by rovka on Jun 28 2016, 8:53 AM.

Details

Summary

This is a follow-up for r273544.

The end goal is to get rid of the isSwift / isCortexXY / isWhatever methods.

This commit also removes two command-line flags that weren't used in any of the
tests: widen-vmovs and swift-partial-update-clearance. The former may be easily
replaced with the mattr mechanism, but the latter may not (as it is a subtarget
property, and not a proper feature). If anyone needs to control that from the
command line, please speak now (and help me add a test).

Diff Detail

Repository
rL LLVM

Event Timeline

rovka updated this revision to Diff 62097.Jun 28 2016, 8:53 AM
rovka retitled this revision from to [ARM] Do not test for CPUs, use SubtargetFeatures. Also remove 2 flags..
rovka updated this object.
rovka added a subscriber: llvm-commits.
rengolin accepted this revision.Jul 6 2016, 1:59 AM
rengolin edited edge metadata.

I personally prefer "widenVMOVS" than "dontWidenVMOVS", but otherwise, LGTM. Thanks!

This revision is now accepted and ready to land.Jul 6 2016, 1:59 AM
rovka added a comment.Jul 6 2016, 2:19 AM

I personally prefer "widenVMOVS" than "dontWidenVMOVS", but otherwise, LGTM. Thanks!

Indeed, but widening seems to be the default across targets, so it would be unpleasant to add it everywhere (including for every new target). If we want to keep it on a positive tone, we could name it "KeepVMOVS" or "PreferVMOVS" (we already have a "PreferVMOVSR", I'm not sure if that makes things better or worse).

Indeed, but widening seems to be the default across targets, so it would be unpleasant to add it everywhere (including for every new target).

Good point. LGTM as it is.

This revision was automatically updated to reflect the committed changes.