Page MenuHomePhabricator

Pass the ABI in the triple when appropriate (currently for MIPS) for 'clang -cc1' and 'clang -cc1as'
Needs ReviewPublic

Authored by sdardis on Jun 7 2016, 5:54 AM.

Details

Summary

'clang -cc1' and 'clang -cc1as' will mutate the triple to account for
-target-abi if such a conversion is defined by Triple::getABIVariant().
Otherwise, the ABI will continue to be passed via MCTargetOptions::ABIName.

Additionally, 'clang -cc1as' now applies the effect of -target-abi. Previously
it was ignored.

Patch by: Daniel Sanders

Event Timeline

dsanders updated this revision to Diff 59875.Jun 7 2016, 5:54 AM
dsanders retitled this revision from to Pass the ABI in the triple when appropriate (currently for MIPS) for 'clang -cc1' and 'clang -cc1as'.
dsanders updated this object.
dsanders added a subscriber: cfe-commits.
dsanders updated this revision to Diff 63676.Jul 12 2016, 8:05 AM

Updated to match latest version of D21467.

At this point Mips is in the X86/everyone-else camp but there's a loose end to
tie up in LLVM in order to prove it. Once LLVM rejects non-empty ABIName's
for Mips, we have proven we're in the X86/everyone-else camp and can start
uniting the Mips/X86/everyone-else camp with the ARM/PowerPC camp.

dsanders updated this object.Jul 21 2016, 6:29 AM
dsanders updated this revision to Diff 64870.Jul 21 2016, 6:29 AM

Refresh and ping

dsanders updated this revision to Diff 65918.Jul 28 2016, 5:54 AM

Refresh and ping

One last ping since I need to either commit this series next week or hand over to a colleague to continue it.

sdardis commandeered this revision.Aug 23 2016, 6:41 AM
sdardis added a reviewer: dsanders.
sdardis added a subscriber: sdardis.

Taking over this patch series.

sdardis updated this object.Aug 23 2016, 7:59 AM
sdardis edited edge metadata.
sdardis updated this revision to Diff 76823.Nov 3 2016, 2:52 AM

Rebase and ping.

dsanders resigned from this revision.Jul 12 2019, 4:12 PM