- User Since
- Feb 17 2015, 11:01 AM (335 w, 4 d)
May 23 2017
Mar 8 2017
The testcase needs to be refreshed against -head. Otherwise, this is good.
Feb 22 2017
This looks good from here. I think it can be committed.
Feb 6 2017
hrm ... I guess I can't "approve" this patch or something.
Feb 3 2017
Looks good from here. Thanks!
Feb 1 2017
Jan 31 2017
Yep, this works for me on FreeBSD's kernel.
Jan 30 2017
Jan 27 2017
Hrm ... I think this one fell off the radar a bit.
Jan 24 2017
Retested and it looks good over here in FreeBSD land.
From a "does this work" perspective, FreeBSD compiles are better now with this in place.
FreeBSD is happy with this.
Jan 19 2017
Jan 18 2017
I shouldn't see errors like this right? I didn't see any change before/after this patch to resolve this:
Nov 22 2016
Looks good here at least form a user perspective.
Nov 21 2016
I get one reject with this review that I'm unsure how to resolve at the moment
Currently required to build the FreeBSD MALTA mips kernels. Thanks for working on this!
This is required to build libc on FreeBSD MIPS currently. Thanks for working on it!
Oct 24 2016
Just a bump to regenerate.
Oct 5 2016
Possibly. I'm not going to stress out about it and you're probably going to be committing this soonish?
This patch needs to be regenerated against the top of tree at the moment. I've had to manually modify the code for the following files recently to test this:
The code that is changing seems to apply fine, but three of the test files now fail to apply cleanly:
Oct 4 2016
Applies cleanly and still seems to DTRT.
Sep 28 2016
Hmmm ... did you get a chance to regenerate this?
Right, this seems to be required to link libc on FreeBSD. Thanks!
Sep 27 2016
Sep 26 2016
This looks like it needs to be refreshed against Trunk before its committed.
This looks like it needs to be refreshed to a more current Trunk if possible.
This looks like it needs to be refreshed to a more current trunk if possible before its committed.
This looks to have been committed in one form or another. Can we close this review?
This looks to have been committed already, this review should be closed IMO.
I suspect, due to age, that this review needs to be recreated completely? Or is it something that should be looked into further?
Can someone close this review as it has been committed in a different form?
This review *looks* like it has addressed all comment feedback. Does it need to be recreated against trunk?
This review seems to have aged out and needs the last comments addressed and a refresh to latest trunk.
This patch has aged a bit and doesn't apply cleanly to trunk any longer.
Sep 19 2016
I'm unsure if this is a patch/phabricator messing up or if this patch needs to be regenerated.
Sep 15 2016
~/clang/llvm % svn info . Path: . Working Copy Root Path: /home/sbruno/clang/llvm URL: http://llvm.org/svn/llvm-project/llvm/trunk Relative URL: ^/llvm/trunk Repository Root: http://llvm.org/svn/llvm-project Repository UUID: 91177308-0d34-0410-b5e6-96231b3b80d8 Revision: 281608 Node Kind: directory Schedule: normal Last Changed Author: sdardis Last Changed Rev: 281607 Last Changed Date: 2016-09-15 13:13:01 +0000 (Thu, 15 Sep 2016)
This seems to not cleanly apply and has a couple of rejects:
I seem to get one reject from this patch:
Sep 14 2016
Yep, thank you very much. This seems to do the right thing!
patch applied, rebuilding clang for testing.
Sep 12 2016
I'm content with this, do you want this to land?
Are you folks ready for this to land? It sure is a huge improvement from my perspective.
Aug 26 2016
Not sure if you want to change this at all. This is the first time I've been able to get a FreeBSD MALTA64 kernel to boot in QEMU. :-)
Aug 23 2016
For what its worth, this makes the clang enabled build of FreeBSD MIPS64 no longer require any of the fast-isel options that I have been using for the last few weeks.
Aug 22 2016
Hmmm ... FreeBSD builds for MIPS64 do *not* like this very much.
Aug 15 2016
In combination with other FreeBSD specific patches, this looks good to me.
I'll give this a spin today.
Aug 3 2016
Yep, this is one of my patches that I'm still carrying to build mips64.
May 10 2016
This does fix the errors I reported. Thanks!
Feb 17 2016
I'm assuming this should *just* be committed at this point right?
So, should FreeBSD run this as a local patch or should we commit this into LLVM as a workaround for our old and crufty LD?
Feb 11 2016
Dec 10 2015
Anything further I can do here?
Dec 8 2015
Nov 30 2015
Sep 21 2015
Tested on the mips3 target for FreeBSD mips64 and it works great. Thanks!
Sep 18 2015
This does the right thing over here in FreeBSD land. Commit and fire when ready.
Sep 16 2015
Seems to still apply (and FreeBSD needs it to build our mips/mips64 targets).
Aug 16 2015
Thanks for the work on this!
Thanks for the work on this!
Thanks for the work on this.
This needs to be updated due to code rot. It applies cleanly to head, however it does not compile tue to changes causing the following compile failures:
May 21 2015
I think this needs a regen against head as it fails to apply cleanly as of today.
Feb 17 2015
Functional commentary, not code. This does appear to allow freebsd to build farther and avoid failures related to its use of .cpsetup.