Page MenuHomePhabricator

seanbruno (Sean Bruno)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 17 2015, 11:01 AM (335 w, 4 d)

Recent Activity

May 23 2017

seanbruno resigned from D33053: [PowerPC] Implement vec_xxpermdi builtin..
May 23 2017, 12:04 PM

Mar 8 2017

seanbruno requested changes to D14700: [mips][freebsd] Explicitly select PC-relative Personality and LSDA encodings..

The testcase needs to be refreshed against -head. Otherwise, this is good.

Mar 8 2017, 12:11 PM
seanbruno added a reviewer for D14700: [mips][freebsd] Explicitly select PC-relative Personality and LSDA encodings.: seanbruno.
Mar 8 2017, 9:42 AM

Feb 22 2017

seanbruno added a comment to D29218: [mips][ias] Further relax operands of certain assembly instructions.

This looks good from here. I think it can be committed.

Feb 22 2017, 2:20 PM

Feb 6 2017

seanbruno added a comment to D16807: [mips] MUL macro variations.

hrm ... I guess I can't "approve" this patch or something.

Feb 6 2017, 6:15 AM

Feb 3 2017

seanbruno accepted D29328: [mips] dla expansion without the at register.

Looks good from here. Thanks!

Feb 3 2017, 4:35 PM

Feb 1 2017

seanbruno added a comment to D2808: Initial MIPS IV support. Separate out the is-MIPS64-ISA checks from is-64-bit-MIPS tests..

I'm not sure why this was left open, perhaps it was simply forgotten.

rL205530 , rL205968, rL206183, rL206185 contain these changes and various bits of follow on work.

Feb 1 2017, 8:19 AM
seanbruno added a reviewer for D2808: Initial MIPS IV support. Separate out the is-MIPS64-ISA checks from is-64-bit-MIPS tests.: sdardis.
Feb 1 2017, 7:46 AM
seanbruno added a reviewer for D5881: [mips] MIPS branch instructions offset fix in disassembler: sdardis.
Feb 1 2017, 7:46 AM
seanbruno added a reviewer for D5974: [mips] MIPS-I Branch on Coprocessor 0 Instructions: sdardis.
Feb 1 2017, 7:46 AM
seanbruno added a reviewer for D6014: [mips] MIPS Branch on Coprocessor 2 Instructions: sdardis.
Feb 1 2017, 7:33 AM
seanbruno added a reviewer for D6129: [mips] MIPS-I Branch on Coprocessor 3 Instructions: sdardis.
Feb 1 2017, 7:33 AM

Jan 31 2017

seanbruno accepted D29218: [mips][ias] Further relax operands of certain assembly instructions.

Yep, this works for me on FreeBSD's kernel.

Jan 31 2017, 2:37 PM

Jan 30 2017

seanbruno accepted D17040: [mips] Expansion of BEQL and BNEL with immediate operands.
Jan 30 2017, 2:59 PM
seanbruno accepted D16807: [mips] MUL macro variations.
Jan 30 2017, 2:59 PM

Jan 27 2017

seanbruno added a comment to D17040: [mips] Expansion of BEQL and BNEL with immediate operands.

Hrm ... I think this one fell off the radar a bit.

Jan 27 2017, 2:13 PM
seanbruno added a reviewer for D17040: [mips] Expansion of BEQL and BNEL with immediate operands: sdardis.
Jan 27 2017, 2:13 PM

Jan 24 2017

seanbruno added a comment to D23652: [mips] N64 static relocation model support.

Retested and it looks good over here in FreeBSD land.

Jan 24 2017, 6:30 AM
seanbruno accepted D29031: [mips] Add support for static model on N64.

From a "does this work" perspective, FreeBSD compiles are better now with this in place.

Jan 24 2017, 6:29 AM
seanbruno accepted D29032: [mips] Define macros related to -mabicalls in the preprocessor.

FreeBSD is happy with this.

Jan 24 2017, 6:27 AM

Jan 19 2017

seanbruno added a comment to D23652: [mips] N64 static relocation model support.

Are you seeing the warning message "warning: linking PIC files with non-PIC files" as well? I have a WIP clang patch that is probably required.

Jan 19 2017, 9:16 AM
seanbruno accepted D23652: [mips] N64 static relocation model support.

Are you seeing the warning message "warning: linking PIC files with non-PIC files" as well? I have a WIP clang patch that is probably required.

Jan 19 2017, 7:46 AM

Jan 18 2017

seanbruno added a comment to D23652: [mips] N64 static relocation model support.

I shouldn't see errors like this right? I didn't see any change before/after this patch to resolve this:

Jan 18 2017, 9:39 AM

Nov 22 2016

seanbruno accepted D24510: [mips] Correct c.cond.fmt instruction definition..

Looks good here at least form a user perspective.

Nov 22 2016, 7:41 AM

Nov 21 2016

seanbruno added a comment to D23652: [mips] N64 static relocation model support.

I get one reject with this review that I'm unsure how to resolve at the moment

Nov 21 2016, 1:36 PM
seanbruno accepted D24607: [mips] seq macro support .

Currently required to build the FreeBSD MALTA mips kernels. Thanks for working on this!

Nov 21 2016, 11:28 AM
seanbruno added a comment to D24722: [mips] Correct jal expansion for local symbols in .local directives..

This is required to build libc on FreeBSD MIPS currently. Thanks for working on it!

Nov 21 2016, 6:57 AM

Oct 24 2016

seanbruno added a comment to D24718: [mips] 'not' alias single operand form.

Just a bump to regenerate.

Oct 24 2016, 8:21 AM

Oct 5 2016

seanbruno added a comment to D24607: [mips] seq macro support .

Possibly. I'm not going to stress out about it and you're probably going to be committing this soonish?

Oct 5 2016, 7:52 AM
seanbruno added a comment to D24607: [mips] seq macro support .

This patch needs to be regenerated against the top of tree at the moment. I've had to manually modify the code for the following files recently to test this:

Oct 5 2016, 7:42 AM
seanbruno added a comment to D23652: [mips] N64 static relocation model support.

The code that is changing seems to apply fine, but three of the test files now fail to apply cleanly:

Oct 5 2016, 7:40 AM

Oct 4 2016

seanbruno accepted D24510: [mips] Correct c.cond.fmt instruction definition..

Applies cleanly and still seems to DTRT.

Oct 4 2016, 6:28 AM

Sep 28 2016

seanbruno added a comment to D24718: [mips] 'not' alias single operand form.

Hmmm ... did you get a chance to regenerate this?

Sep 28 2016, 3:53 PM
seanbruno updated subscribers of D24722: [mips] Correct jal expansion for local symbols in .local directives..
Sep 28 2016, 3:25 PM
seanbruno accepted D24722: [mips] Correct jal expansion for local symbols in .local directives..

Right, this seems to be required to link libc on FreeBSD. Thanks!

Sep 28 2016, 3:24 PM

Sep 27 2016

seanbruno added a comment to D24510: [mips] Correct c.cond.fmt instruction definition..

Hi Sean, is your intention to LGTM this patch by accepting it, or to convey that it's working fine for *BSDs?

Sep 27 2016, 6:48 AM

Sep 26 2016

seanbruno requested changes to D6129: [mips] MIPS-I Branch on Coprocessor 3 Instructions.

This looks like it needs to be refreshed against Trunk before its committed.

Sep 26 2016, 7:08 AM
seanbruno requested changes to D5974: [mips] MIPS-I Branch on Coprocessor 0 Instructions.

This looks like it needs to be refreshed to a more current Trunk if possible.

Sep 26 2016, 7:06 AM
seanbruno requested changes to D6014: [mips] MIPS Branch on Coprocessor 2 Instructions.

This looks like it needs to be refreshed to a more current trunk if possible before its committed.

Sep 26 2016, 7:05 AM
seanbruno added a comment to D5883: [mips] Some MIPS branch and likely instructions.

This looks to have been committed in one form or another. Can we close this review?

Sep 26 2016, 7:03 AM
seanbruno requested changes to D5881: [mips] MIPS branch instructions offset fix in disassembler.

This looks to have been committed already, this review should be closed IMO.

Sep 26 2016, 7:00 AM
seanbruno requested changes to D2808: Initial MIPS IV support. Separate out the is-MIPS64-ISA checks from is-64-bit-MIPS tests..

I suspect, due to age, that this review needs to be recreated completely? Or is it something that should be looked into further?

Sep 26 2016, 6:58 AM
seanbruno accepted D24510: [mips] Correct c.cond.fmt instruction definition..
Sep 26 2016, 6:57 AM
seanbruno requested changes to D5487: MIPS: Add comment to explain why PIC code gen is the default for MIPS.

Can someone close this review as it has been committed in a different form?

Sep 26 2016, 6:55 AM
seanbruno added a comment to D24332: [ESan] [MIPS] Fix workingset-signal-posix.cpp on MIPS.

This review *looks* like it has addressed all comment feedback. Does it need to be recreated against trunk?

Sep 26 2016, 6:54 AM · Restricted Project
seanbruno updated subscribers of D24332: [ESan] [MIPS] Fix workingset-signal-posix.cpp on MIPS.
Sep 26 2016, 6:53 AM · Restricted Project
seanbruno requested changes to D16807: [mips] MUL macro variations.

This review seems to have aged out and needs the last comments addressed and a refresh to latest trunk.

Sep 26 2016, 6:51 AM
seanbruno requested changes to D17040: [mips] Expansion of BEQL and BNEL with immediate operands.

This patch has aged a bit and doesn't apply cleanly to trunk any longer.

Sep 26 2016, 6:50 AM

Sep 19 2016

seanbruno requested changes to D24607: [mips] seq macro support .

I'm unsure if this is a patch/phabricator messing up or if this patch needs to be regenerated.

Sep 19 2016, 8:48 AM

Sep 15 2016

seanbruno added a comment to D24607: [mips] seq macro support .
~/clang/llvm %        svn info .
Path: .
Working Copy Root Path: /home/sbruno/clang/llvm
URL: http://llvm.org/svn/llvm-project/llvm/trunk
Relative URL: ^/llvm/trunk
Repository Root: http://llvm.org/svn/llvm-project
Repository UUID: 91177308-0d34-0410-b5e6-96231b3b80d8
Revision: 281608
Node Kind: directory
Schedule: normal
Last Changed Author: sdardis
Last Changed Rev: 281607
Last Changed Date: 2016-09-15 13:13:01 +0000 (Thu, 15 Sep 2016)
Sep 15 2016, 8:12 AM
seanbruno requested changes to D24607: [mips] seq macro support .

This seems to not cleanly apply and has a couple of rejects:

Sep 15 2016, 7:59 AM
seanbruno requested changes to D23652: [mips] N64 static relocation model support.

I seem to get one reject from this patch:

Sep 15 2016, 7:56 AM

Sep 14 2016

seanbruno accepted D24556: [mips] Macro expansion for ld, sd for O32.

Yep, thank you very much. This seems to do the right thing!

Sep 14 2016, 6:57 AM
seanbruno added a comment to D24556: [mips] Macro expansion for ld, sd for O32.

patch applied, rebuilding clang for testing.

Sep 14 2016, 6:23 AM

Sep 12 2016

seanbruno added a comment to D23497: [wip][mips] Correct jal expansion for local symbols in .local directives..

I'm content with this, do you want this to land?

Sep 12 2016, 12:15 PM
seanbruno added a comment to D23652: [mips] N64 static relocation model support.

Are you folks ready for this to land? It sure is a huge improvement from my perspective.

Sep 12 2016, 12:14 PM

Aug 26 2016

seanbruno accepted D23652: [mips] N64 static relocation model support.

Not sure if you want to change this at all. This is the first time I've been able to get a FreeBSD MALTA64 kernel to boot in QEMU. :-)

Aug 26 2016, 1:31 PM

Aug 23 2016

seanbruno accepted D23795: [mips] Tighten FastISel restrictions.

For what its worth, this makes the clang enabled build of FreeBSD MIPS64 no longer require any of the fast-isel options that I have been using for the last few weeks.

Aug 23 2016, 2:21 PM

Aug 22 2016

seanbruno added a comment to D23652: [mips] N64 static relocation model support.

Hmmm ... FreeBSD builds for MIPS64 do *not* like this very much.

Aug 22 2016, 7:32 AM

Aug 15 2016

seanbruno accepted D23497: [wip][mips] Correct jal expansion for local symbols in .local directives..

In combination with other FreeBSD specific patches, this looks good to me.

Aug 15 2016, 7:00 AM
seanbruno added a comment to D23497: [wip][mips] Correct jal expansion for local symbols in .local directives..

I'll give this a spin today.

Aug 15 2016, 2:07 AM

Aug 3 2016

seanbruno accepted D23113: [mips] Set Personality and LSDA encoding for FreeBSD.

Yep, this is one of my patches that I'm still carrying to build mips64.

Aug 3 2016, 12:06 PM

May 10 2016

seanbruno accepted D20093: [mips][ias] Fix N32 and N64 .cprestore directive when inside .set noat region..

This does fix the errors I reported. Thanks!

May 10 2016, 9:21 AM

Feb 17 2016

seanbruno added a comment to D15369: [mips] Make symbols an acceptable branch target when expanding compare-to-immediate-and-branch macros..

I'm assuming this should *just* be committed at this point right?

Feb 17 2016, 4:11 PM
seanbruno added a comment to D14700: [mips][freebsd] Explicitly select PC-relative Personality and LSDA encodings..

So, should FreeBSD run this as a local patch or should we commit this into LLVM as a workaround for our old and crufty LD?

Feb 17 2016, 4:10 PM

Feb 11 2016

seanbruno accepted D17033: Add FreeBSD clang builder.
Feb 11 2016, 5:55 AM

Dec 10 2015

seanbruno added a comment to D14700: [mips][freebsd] Explicitly select PC-relative Personality and LSDA encodings..

Anything further I can do here?

Dec 10 2015, 9:51 AM

Dec 8 2015

seanbruno added a comment to D15088: Eliminate custom typedefs in the FreeBSD case and include sys/types.h to define standard types. This is currently fixing a build failure on x86_64 FreeBSD..

Any blocker for this to be committed ?

Dec 8 2015, 9:07 AM

Nov 30 2015

seanbruno retitled D15088: Eliminate custom typedefs in the FreeBSD case and include sys/types.h to define standard types. This is currently fixing a build failure on x86_64 FreeBSD. from to Eliminate custom typedefs in the FreeBSD case and include sys/types.h to define standard types. This is currently fixing a build failure on x86_64 FreeBSD..
Nov 30 2015, 12:35 PM

Sep 21 2015

seanbruno added a comment to D13017: [mips][ias] Implement .cpreturn directive..

Tested on the mips3 target for FreeBSD mips64 and it works great. Thanks!

Sep 21 2015, 12:07 PM

Sep 18 2015

seanbruno added a comment to D12956: [mips] Allow constant expressions in second argument of .cpsetup..

This does the right thing over here in FreeBSD land. Commit and fire when ready.

Sep 18 2015, 9:57 AM

Sep 16 2015

seanbruno added a comment to D6267: [mips] Add assembler support for the .cprestore directive..

Seems to still apply (and FreeBSD needs it to build our mips/mips64 targets).

Sep 16 2015, 8:15 AM

Aug 16 2015

seanbruno accepted D6267: [mips] Add assembler support for the .cprestore directive..

Thanks for the work on this!

Aug 16 2015, 4:29 PM
seanbruno accepted D6231: [mips] Expand JAL instructions when PIC is enabled..

Thanks for the work on this!

Aug 16 2015, 4:29 PM
seanbruno accepted D5626: [mips] Make the MipsAsmParser capable of knowing whether PIC mode is enabled or not..

Thanks for the work on this.

Aug 16 2015, 4:29 PM
seanbruno requested changes to D9524: [mips] [IAS] Add support for the DLA pseudo-instruction and fix problems with DLI.

This needs to be updated due to code rot. It applies cleanly to head, however it does not compile tue to changes causing the following compile failures:

Aug 16 2015, 4:27 PM

May 21 2015

seanbruno added a comment to D6231: [mips] Expand JAL instructions when PIC is enabled..

I think this needs a regen against head as it fails to apply cleanly as of today.

May 21 2015, 2:38 PM
seanbruno updated subscribers of D9114: For FreeBSD on mips, pass -G options to the linker.
May 21 2015, 2:03 PM

Feb 17 2015

seanbruno added a comment to D7697: [mips] [IAS] Fix using .cpsetup with local labels (PR22518)..

Functional commentary, not code. This does appear to allow freebsd to build farther and avoid failures related to its use of .cpsetup.

Feb 17 2015, 11:02 AM