This is an archive of the discontinued LLVM Phabricator instance.

Differential D21069

[mips] Require that ABI's are passed in the triple within LLVM.
Needs ReviewPublic

Authored by sdardis on Jun 7 2016, 5:53 AM.

Details

Reviewers
vkalintiris
dsanders
Summary

This patch ties up a loose end so that we can prove that we pass ABI information in the same way as X86. After the buildbots settle, it will be safe to migrate to the method used by ARM/PowerPC.

Patch by: Daniel Sanders

Diff Detail

Event Timeline

dsanders updated this revision to Diff 59874.Jun 7 2016, 5:53 AM
dsanders retitled this revision from to [mips] Require that ABI's are passed in the triple within LLVM..
dsanders updated this object.
dsanders added a parent revision: D20916: [WIP][mips] Allow explicit ABI's in MIPS triples within LLVM..
dsanders added a subscriber: llvm-commits.
Herald added subscribers: sdardis, dsanders. · View Herald TranscriptJun 7 2016, 5:53 AM
dsanders added a child revision: D21070: Pass the ABI in the triple when appropriate (currently for MIPS) for 'clang -cc1' and 'clang -cc1as'.Jun 7 2016, 5:54 AM
dsanders added a child revision: D21292: [mips] Correct ELF format for N32..Jun 15 2016, 6:32 AM
dsanders edited parent revisions, added: D21467: [llc+llvm-mc] Prefer applying -mabi to the triple where possible and allow Mips to take ABI information in the triple.; removed: D20916: [WIP][mips] Allow explicit ABI's in MIPS triples within LLVM..Jun 17 2016, 5:59 AM
llvm-commits mentioned this in D21779: [LTO] Infer EKind/EMachine from Bitcode files.Jul 7 2016, 6:23 AM
dsanders mentioned this in D21467: [llc+llvm-mc] Prefer applying -mabi to the triple where possible and allow Mips to take ABI information in the triple..Jul 12 2016, 6:07 AM
dsanders removed a child revision: D21070: Pass the ABI in the triple when appropriate (currently for MIPS) for 'clang -cc1' and 'clang -cc1as'.Jul 12 2016, 8:11 AM
dsanders added a parent revision: D21070: Pass the ABI in the triple when appropriate (currently for MIPS) for 'clang -cc1' and 'clang -cc1as'.
dsanders updated this revision to Diff 63786.Jul 13 2016, 2:36 AM
dsanders added a parent revision: D20916: [WIP][mips] Allow explicit ABI's in MIPS triples within LLVM..

Refreshed patch.

At this point we're down to two (was three) camps of targets and can prove this
due to the addition of the assertion. Once the buildbots are cleared, it's safe
to further migrate to a single camp.

The remaining camps are:

  • Targets that pass ABI information in both the triple and MCTargetOptions (ARM/PowerPC)
  • Targets that pass ABI information in the triple only (Mips/X86/everyone-else).
dsanders updated this object.Jul 13 2016, 2:45 AM
dsanders added a child revision: D22301: Don't ignore MCTargetOptions::ABIName on targets that currently do so..Jul 13 2016, 5:53 AM
dsanders added a child revision: D22304: [mips] Allow ABI names from MCTargetOptions::ABIName but only if they agree with the triple..Jul 13 2016, 8:23 AM
dsanders updated this revision to Diff 64873.Jul 21 2016, 6:42 AM

Refresh and ping

Herald added a subscriber: aemerson. · View Herald TranscriptJul 21 2016, 6:42 AM
dsanders updated this revision to Diff 65920.Jul 28 2016, 6:21 AM

Refresh and ping

dsanders added a comment.Aug 5 2016, 2:26 AM

One last ping since I need to either commit this series next week or hand over to a colleague to continue it.

sdardis commandeered this revision.Aug 23 2016, 6:24 AM
sdardis added a reviewer: dsanders.

Taking over this patch series.

Herald added a reviewer: vkalintiris. · View Herald TranscriptAug 23 2016, 6:24 AM
sdardis updated this revision to Diff 68981.Aug 23 2016, 6:26 AM
sdardis updated this object.
sdardis edited edge metadata.

Rebase + ping.

sdardis added a comment.Sep 6 2016, 5:50 AM

Ping.

sdardis added a comment.Sep 15 2016, 3:22 AM

Ping.

sdardis added a comment.Sep 30 2016, 9:20 AM

Ping

sdardis updated this revision to Diff 76726.Nov 2 2016, 9:58 AM

Rebase and ping.

Herald edited edge metadata. · View Herald TranscriptNov 2 2016, 9:58 AM
dsanders resigned from this revision.Jul 18 2019, 6:49 PM
Herald added subscribers: atanasyan, kristof.beyls, arichardson, javed.absar. · View Herald TranscriptJul 18 2019, 6:49 PM

Revision Contents

PathSize
lib/
Target/
Mips/
MCTargetDesc/
11 lines

Diff 59874

lib/Target/Mips/MCTargetDesc/MipsABIInfo.cpp

Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Lines if (IsO32())
return CC != CallingConv::Fast ? 16 : 0; return CC != CallingConv::Fast ? 16 : 0;
if (IsN32() || IsN64()) if (IsN32() || IsN64())
return 0; return 0;
llvm_unreachable("Unhandled ABI"); llvm_unreachable("Unhandled ABI");
} }
MipsABIInfo MipsABIInfo::computeTargetABI(const Triple &TT, StringRef CPU, MipsABIInfo MipsABIInfo::computeTargetABI(const Triple &TT, StringRef CPU,
const MCTargetOptions &Options) { const MCTargetOptions &Options) {
if (Options.getABIName().startswith("o32")) if (!Options.getABIName().empty())
return MipsABIInfo::O32(); llvm_unreachable(
else if (Options.getABIName().startswith("n32")) "ABI name should be in triple. See Triple::getABIVariant()");
return MipsABIInfo::N32();
else if (Options.getABIName().startswith("n64"))
return MipsABIInfo::N64();
else if (!Options.getABIName().empty())
llvm_unreachable("Unknown ABI option for MIPS");
else if (TT.getEnvironment() == Triple::ABI32 || else if (TT.getEnvironment() == Triple::ABI32 ||
TT.getEnvironment() == Triple::GNUABI32) TT.getEnvironment() == Triple::GNUABI32)
return MipsABIInfo::O32(); return MipsABIInfo::O32();
else if (TT.getEnvironment() == Triple::ABIN32 || else if (TT.getEnvironment() == Triple::ABIN32 ||
TT.getEnvironment() == Triple::GNUABIN32) TT.getEnvironment() == Triple::GNUABIN32)
return MipsABIInfo::N32(); return MipsABIInfo::N32();
else if (TT.getEnvironment() == Triple::ABI64 || else if (TT.getEnvironment() == Triple::ABI64 ||
TT.getEnvironment() == Triple::GNUABI64) TT.getEnvironment() == Triple::GNUABI64)
▲ Show 20 Lines • Show All 58 Lines • Show Last 20 Lines