[lldb] Introduce OperatingSystem{,Python}Interface and make use it

[mib]

Summary

This patch aims to consolidate the OperatingSystem scripting affordance
by introducing a stable interface that conforms to the
Scripted{,Python}Interface.

This unifies the way we call into python methods from lldb while
also improving its capabilities by allowing us to pass lldb_private
objects are arguments.

Signed-off-by: Med Ismail Bennani <[e-mail]>

[bulbazord]

This change seems mostly red in that we're removing a lot of things. What are the replacements? I also see you're removing the API lock acquisition in a few places, where does that now occur?

lldb/bindings/python/python-wrapper.swig

266–279 ↗

(On Diff #555174)

Is there no way to check the types of the positional args? This seems like it might be a source of future subtle bugs or unexpected behavior.

lldb/source/Plugins/OperatingSystem/Python/OperatingSystemPython.cpp

153–155

nit: Remove commented out code.

side note, maybe OperatingSystemPython should have a static factory method so we can actually return a meaningful error like this? Since the constructor can fail, we might end up with a half-initialized object. Doesn't have to be in this change, I think it would make sense for a follow-up.

164–169

Same here

[mib]

Address @bulbazord comments.

[mib]

Since @bulbazord asked me offline, all the repeat it here: Everything that was deleted here was replaced by either a call to the existing ScriptedPythonInterface::Dispatch method or depends on the new way to create scripted plugin objects.

lldb/source/Plugins/OperatingSystem/Python/OperatingSystemPython.cpp

153–155

I added a // FIXME: and I'll do the error handling in a followup.

[bulbazord]

Ok, makes sense to me. Since this is a refactor, I assume that the current test suite should be enough to cover this change?

[mib]

In D159314#4655289, @bulbazord wrote:

Ok, makes sense to me. Since this is a refactor, I assume that the current test suite should be enough to cover this change?

@bulbazord yes!