This is an archive of the discontinued LLVM Phabricator instance.

[RISCV][llvm-mca] Fix getLMUL values
ClosedPublic

Authored by michaelmaitland on Aug 31 2023, 11:30 AM.

Details

Summary

These values come from RISCVInstrInfoVPseudos.td. MF8 and MF2 were
swapped by accident.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptAug 31 2023, 11:30 AM
michaelmaitland requested review of this revision.Aug 31 2023, 11:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 31 2023, 11:30 AM
wangpc retitled this revision from [RISCV][llvm-mca] Fix Fix getLMUL values to [RISCV][llvm-mca] Fix getLMUL values.Aug 31 2023, 7:43 PM
myhsu added a comment.Sep 1 2023, 2:23 PM

just double checked with the V-spec and this is correct. Could we add a simple test?

I've added a simple test. I plan on removing this test in the future with a set
of tests that shows behavior all instructions for all different LMUL and SEW
pairs.

myhsu accepted this revision.Sep 1 2023, 4:24 PM

I've added a simple test. I plan on removing this test in the future with a set
of tests that shows behavior all instructions for all different LMUL and SEW
pairs.

sounds good!
LGTM now

This revision is now accepted and ready to land.Sep 1 2023, 4:24 PM
This revision was automatically updated to reflect the committed changes.