[AsmPrinter][PGO] Adds optional dumping of branch probabilities for PGO metrics.

[red1bluelost]

Summary

[1/2] This is the first of two patches for branch accuracy metrics. Second at D158890.

This patch adds optional dumping of branch probabilities that can be used for collecting branch
accuracy metrics. Our metrics compare branch probabilities against execution traces. This patch is
for dumping those branch probabilities.

Testing:
New llvm test to verify branch probabilities are dumped as expected on x86_64.
Ran check-llvm with x86 enabled.
Probability dumping also testing using the scripts in the second patch of the series.

[wenlei]

We have something similar internally, but didn't upstream because we are not sure if the use case is too narrow to justify burdening the code base with all the related complexity. cc @hoy

[red1bluelost]

Rebased patch to fix buildkite.

[mtrofin]

This is great! Can you share what tracing methodology you use?

LGTM with some nits.

llvm/include/llvm/CodeGen/AsmPrinter.h

390

nit: init at declaration (both fields)

llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp

1657

why not just use EnableBranchProbabilityDumping?

llvm/test/Transforms/PGOProfile/asm_emit_branch_prob.ll

65

nit: line up the CHECK

[mtrofin]

llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp

1760

what about virtual calls?

[mtrofin]

BTW, have you considered using -mbb-profile-dump (defined in AsmPrinter.cpp) - same intention, just MBB frequencies, and dumping to a csv; also assumes compilation happened with -basic-block-sections=labels

[red1bluelost]

In D158889#4618718, @mtrofin wrote:

This is great! Can you share what tracing methodology you use?

We used Pin Tool to collect branch traces and a basic python script to process the data and generate CSVs
and stats. Those are in the second patch D158890. We've been able to use these metrics on x86 and
internally with a slightly modified script but it should be able to support other targets that can collect
branch traces.

In D158889#4619073, @mtrofin wrote:

BTW, have you considered using -mbb-profile-dump (defined in AsmPrinter.cpp) - same intention, just MBB frequencies, and dumping to a csv; also assumes compilation happened with -basic-block-sections=labels

We had not considered that. We mainly focused in on branch weights since it is a primary result of
SamplePGO. Definitely will look into if similar metrics can be done :)

[hoy]

In D158889#4618519, @wenlei wrote:

We have something similar internally, but didn't upstream because we are not sure if the use case is too narrow to justify burdening the code base with all the related complexity. cc @hoy

Yeah, we internally serialize machine block execution counts to the binary. Would it be helpful to write those counts into some bb section similar to the llvm_bb_addr_map section?

[red1bluelost]

Addresses nits.

[red1bluelost]

llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp

1657

Since we are reading from a global variable and the following loop it probably hot code, I thought it would be better to cache it outside the loop rather than keep referencing the global.

1760

I don't think MachineInstr has a notion of virtual calls. Unless you mean something else or I'm missing something.

[red1bluelost]

In D158889#4619737, @hoy wrote:

In D158889#4618519, @wenlei wrote:

We have something similar internally, but didn't upstream because we are not sure if the use case is too narrow to justify burdening the code base with all the related complexity. cc @hoy

Yeah, we internally serialize machine block execution counts to the binary. Would it be helpful to write those counts into some bb section similar to the llvm_bb_addr_map section?

This is interesting and similar but our metrics are only focusing on branch weights at the moment. We've focused on branch weights so far since they are a direct result of Profile Loading.

At least for the current state of the metrics here and consumed in D158890, there is not a use for block counts but it could be a future extension of the metrics.

[mtrofin]

llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp

1760

Correct, but (I mean this as brainstorming, not blocking this patch - which still lgtm) you could for instance record "there's an indirect call here, with <profile>" and correlate with your trace. I.e. "are we missing out on indirect call promotion opportunities".

[hoy]

In D158889#4621393, @red1bluelost wrote:

In D158889#4619737, @hoy wrote:

In D158889#4618519, @wenlei wrote:

We have something similar internally, but didn't upstream because we are not sure if the use case is too narrow to justify burdening the code base with all the related complexity. cc @hoy

Yeah, we internally serialize machine block execution counts to the binary. Would it be helpful to write those counts into some bb section similar to the llvm_bb_addr_map section?

This is interesting and similar but our metrics are only focusing on branch weights at the moment. We've focused on branch weights so far since they are a direct result of Profile Loading.

At least for the current state of the metrics here and consumed in D158890, there is not a use for block counts but it could be a future extension of the metrics.

Thanks for the information. Maybe we can look into encoding block counts metrics somewhere.

A bit more context about our use case: we use block counts to check if the compiler does a good job maintaining the input profile quality throughout its pipeline. Using branch weights would require an offline BFI computation to recover the block counts based on the branch weights, which may not give as accurate information as the profiler (such as the LBR profiler) gives.

[red1bluelost]

llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp

1760

That definitely sounds like a good idea. Our encoded reserved space just for this type of extra info. Agreed it'd fit in a later patch :)

[red1bluelost]

@mtrofin Would you be able to commit on my behalf? (Name: Micah Weston, Email: [e-mail])

[MaskRay]

llvm/lib/MC/MCObjectFileInfo.cpp

1225

This logic hasn't been thoroughly tested. We need comdat and !associated. Please see the log of the code you copied from.

[MaskRay]

llvm/test/Transforms/PGOProfile/asm_emit_branch_prob.ll

1

We likely need an explicit -mtriple=x86_64 for llc commands and use REQUIRES: x86-registered-target.

68

Please don't test the string before warning:. It's not reliable in some environments when the tool is a symlink to a real executable.

[red1bluelost]

Addresses two of the suggestions.

[red1bluelost]

llvm/lib/MC/MCObjectFileInfo.cpp

1225

Could you elaborate on this? I'm very confused as to what you are referring to or how to go about fixing it.

[red1bluelost]

Fixes formatting issue with git clang-format.

[wenlei]

In D158889#4621393, @red1bluelost wrote:

In D158889#4619737, @hoy wrote:

In D158889#4618519, @wenlei wrote:

We have something similar internally, but didn't upstream because we are not sure if the use case is too narrow to justify burdening the code base with all the related complexity. cc @hoy

Yeah, we internally serialize machine block execution counts to the binary. Would it be helpful to write those counts into some bb section similar to the llvm_bb_addr_map section?

This is interesting and similar but our metrics are only focusing on branch weights at the moment. We've focused on branch weights so far since they are a direct result of Profile Loading.

At least for the current state of the metrics here and consumed in D158890, there is not a use for block counts but it could be a future extension of the metrics.

We're probably among the few people that will actually benefit from something like this, but honestly I'm still a bit unsure whether the use case is common enough to justify built-in support like this.

However, if we make something like this part of llvm, I suggest we at least make it as general purpose as possible. A few comments related to that:

1. Try to incorporate block counts/frequencies as well. Most of the researches on profile quality use a block overlap metric which relies on block counts rather than branch probabilities. Our internal version also uses block counts, as branch weights cannot represent the profile for branchless code.

2. Instead of coupling this with a specific consumer, Pin tool in your case, and in the next patch, I suggest we build general support to decode such metadata section, so tools like llvm-objdump can be used to inspect its payload.

[mtrofin]

In D158889#4633333, @wenlei wrote:

In D158889#4621393, @red1bluelost wrote:

In D158889#4619737, @hoy wrote:

In D158889#4618519, @wenlei wrote:

We have something similar internally, but didn't upstream because we are not sure if the use case is too narrow to justify burdening the code base with all the related complexity. cc @hoy

Yeah, we internally serialize machine block execution counts to the binary. Would it be helpful to write those counts into some bb section similar to the llvm_bb_addr_map section?

This is interesting and similar but our metrics are only focusing on branch weights at the moment. We've focused on branch weights so far since they are a direct result of Profile Loading.

At least for the current state of the metrics here and consumed in D158890, there is not a use for block counts but it could be a future extension of the metrics.

We're probably among the few people that will actually benefit from something like this, but honestly I'm still a bit unsure whether the use case is common enough to justify built-in support like this.

Even if relatively few groups would build up on such information, arguably PGO (as a technique) is probably the most impactful tool we have for improving performance. Like I think we're all observing here, profiles aren't necessarily well maintained throughout passes - it's actually easy to write a pass that accidentally and silently drops it, or that corrupts it somehow. I think having primitives in llvm that can help anyone interested build validation tooling and detect and fix such bugs would end up helping the community way more than their cost.

Maybe we can even, eventually, have a layer of defense doing this on a build bot with e.g. llvm-test-suite benchmarks. (I have a rfc for doing some even simpler validation transparently as part of opt/llc, would send it after the long weekend)

However, if we make something like this part of llvm, I suggest we at least make it as general purpose as possible. A few comments related to that:

1. Try to incorporate block counts/frequencies as well. Most of the researches on profile quality use a block overlap metric which relies on block counts rather than branch probabilities. Our internal version also uses block counts, as branch weights cannot represent the profile for branchless code.

+1

2. Instead of coupling this with a specific consumer, Pin tool in your case, and in the next patch, I suggest we build general support to decode such metadata section, so tools like llvm-objdump can be used to inspect its payload.

+1!

Actually - @red1bluelost - sorry if this would creep up the scope of your work, but since we're talking design choices, would summarizing in a RFC be maybe a good step? Then we can discuss the motivation and design choices in the community, and since there is similar work (@wenlei's earlier remark), their experience will surely help!

[red1bluelost]

In D158889#4633333, @wenlei wrote:

We're probably among the few people that will actually benefit from something like this, but honestly I'm still a bit unsure whether the use case is common enough to justify built-in support like this.

Micrea makes a good point about it being easy for a pass to corrupt PGO information the same way it can corrupt debug information. Having a tool to track or debug PGO info like branch_weights, even if something different than this patch, seems beneficial for upstream.

In D158889#4633333, @wenlei wrote:

1. Try to incorporate block counts/frequencies as well. Most of the researches on profile quality use a block overlap metric which relies on block counts rather than branch probabilities. Our internal version also uses block counts, as branch weights cannot represent the profile for branchless code.

I'll try to look into this.

In D158889#4633333, @wenlei wrote:

2. Instead of coupling this with a specific consumer, Pin tool in your case, and in the next patch, I suggest we build general support to decode such metadata section, so tools like llvm-objdump can be used to inspect its payload.

For the metrics, we need an execution branch trace for comparison, Pin tool we've found works for x86 and we have an tool for one of our internal targets. We hope to keep the tracing part minimally coupled to the compiler metadata.

Makes sense to add general support for extracting the section info. I can try to look into it.

In D158889#4633353, @mtrofin wrote:

Even if relatively few groups would build up on such information, arguably PGO (as a technique) is probably the most impactful tool we have for improving performance. Like I think we're all observing here, profiles aren't necessarily well maintained throughout passes - it's actually easy to write a pass that accidentally and silently drops it, or that corrupts it somehow. I think having primitives in llvm that can help anyone interested build validation tooling and detect and fix such bugs would end up helping the community way more than their cost.

Agreed that it is easy to corrupt. The team I'm with at MediaTek has found cases in LLVM passes and our backend where branch weights are mishandled or not updated which was a driving factor to developing metrics for it.

In D158889#4633353, @mtrofin wrote:

Maybe we can even, eventually, have a layer of defense doing this on a build bot with e.g. llvm-test-suite benchmarks. (I have a rfc for doing some even simpler validation transparently as part of opt/llc, would send it after the long weekend)

Internally we are planning to track some of our benchmarks using these metrics since we've found its helpful for this source of change/regression tracking for our PGO data.

In D158889#4633353, @mtrofin wrote:

Actually - @red1bluelost - sorry if this would creep up the scope of your work, but since we're talking design choices, would summarizing in a RFC be maybe a good step? Then we can discuss the motivation and design choices in the community, and since there is similar work (@wenlei's earlier remark), their experience will surely help!

That makes sense. I can see about getting stuff written up. It will take some time. I'll also be giving a talk at the developer meeting in October on how we've been using the metrics and where we think it can help others.

[mtrofin]

[...]

In D158889#4633353, @mtrofin wrote:

Actually - @red1bluelost - sorry if this would creep up the scope of your work, but since we're talking design choices, would summarizing in a RFC be maybe a good step? Then we can discuss the motivation and design choices in the community, and since there is similar work (@wenlei's earlier remark), their experience will surely help!

That makes sense. I can see about getting stuff written up. It will take some time. I'll also be giving a talk at the developer meeting in October on how we've been using the metrics and where we think it can help others.

BTW, the "Practical Compiler Optimizations for Warehouse-Scale Applications" workshop at the conference would also be good to attend, the topic is very much in scope!

[wenlei]

In D158889#4635143, @red1bluelost wrote:

In D158889#4633333, @wenlei wrote:

We're probably among the few people that will actually benefit from something like this, but honestly I'm still a bit unsure whether the use case is common enough to justify built-in support like this.

Micrea makes a good point about it being easy for a pass to corrupt PGO information the same way it can corrupt debug information. Having a tool to track or debug PGO info like branch_weights, even if something different than this patch, seems beneficial for upstream.

In D158889#4633333, @wenlei wrote:

1. Try to incorporate block counts/frequencies as well. Most of the researches on profile quality use a block overlap metric which relies on block counts rather than branch probabilities. Our internal version also uses block counts, as branch weights cannot represent the profile for branchless code.

I'll try to look into this.

In D158889#4633333, @wenlei wrote:

2. Instead of coupling this with a specific consumer, Pin tool in your case, and in the next patch, I suggest we build general support to decode such metadata section, so tools like llvm-objdump can be used to inspect its payload.

For the metrics, we need an execution branch trace for comparison, Pin tool we've found works for x86 and we have an tool for one of our internal targets. We hope to keep the tracing part minimally coupled to the compiler metadata.

Makes sense to add general support for extracting the section info. I can try to look into it.

In D158889#4633353, @mtrofin wrote:

Even if relatively few groups would build up on such information, arguably PGO (as a technique) is probably the most impactful tool we have for improving performance. Like I think we're all observing here, profiles aren't necessarily well maintained throughout passes - it's actually easy to write a pass that accidentally and silently drops it, or that corrupts it somehow. I think having primitives in llvm that can help anyone interested build validation tooling and detect and fix such bugs would end up helping the community way more than their cost.

Agreed that it is easy to corrupt. The team I'm with at MediaTek has found cases in LLVM passes and our backend where branch weights are mishandled or not updated which was a driving factor to developing metrics for it.

In D158889#4633353, @mtrofin wrote:

Maybe we can even, eventually, have a layer of defense doing this on a build bot with e.g. llvm-test-suite benchmarks. (I have a rfc for doing some even simpler validation transparently as part of opt/llc, would send it after the long weekend)

Internally we are planning to track some of our benchmarks using these metrics since we've found its helpful for this source of change/regression tracking for our PGO data.

In D158889#4633353, @mtrofin wrote:

Actually - @red1bluelost - sorry if this would creep up the scope of your work, but since we're talking design choices, would summarizing in a RFC be maybe a good step? Then we can discuss the motivation and design choices in the community, and since there is similar work (@wenlei's earlier remark), their experience will surely help!

That makes sense. I can see about getting stuff written up. It will take some time. I'll also be giving a talk at the developer meeting in October on how we've been using the metrics and where we think it can help others.

Thanks. If we make this general enough, I agree that it'd be useful. Looking forward to RFC and related discussions.

LLVM generally doesn't do a good in profile maintenance (updating branch_weights throughout optimization pipeline), and a good step towards improving that would be having a way to quantify profile quality, which is something like this would help.

[red1bluelost]

Closing this review and the second (D158890) as I work on the RFC. By the time a second review iteration is up, it will be via GitHub PR. Hoping to get the RFC out in the next 2-3 weeks.

[red1bluelost]

Re-opening for RFC: https://discourse.llvm.org/t/rfc-pgo-accuracy-metrics-emitting-and-evaluating-branch-and-block-analysis/73902

llvm/include/llvm/CodeGen/AsmPrinter.h

 
   void emitPatchableFunctionEntries();
 
+  //===------------------------------------------------------------------===//
+  // Branch Probability Dumping Implementation
+  //===------------------------------------------------------------------===//
+
+  struct BranchProbEntry {
+    const MCSymbol *Sym = nullptr;
+    double Probability = 0.0;
+  };
+
+  // All the branch probabilities to be emitted.
+  std::vector<BranchProbEntry> BranchProbs;
+
+  void emitLabelAndRecordBranchProb(double Probability);
+
+  void emitBranchProbabilitySection();
+
   //===------------------------------------------------------------------===//
   // MachineFunctionPass Implementation.
   //===------------------------------------------------------------------===//

llvm/include/llvm/MC/MCObjectFileInfo.h

   MCSection *PseudoProbeSection = nullptr;
   MCSection *PseudoProbeDescSection = nullptr;
 
+  /// Section containing dumped branch probabilities
+  MCSection *BranchProbabilitySection = nullptr;
+
   // Section for metadata of llvm statistics.
   MCSection *LLVMStatsSection = nullptr;
 

 
   MCSection *getPseudoProbeDescSection(StringRef FuncName) const;
 
+  MCSection *getBranchProbabilitySection(const MCSection &TextSec) const;
+
   MCSection *getLLVMStatsSection() const;
 
   MCSection *getPCSection(StringRef Name, const MCSection *TextSec) const;

llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp

 #include "llvm/ADT/APInt.h"
 #include "llvm/ADT/DenseMap.h"
 #include "llvm/ADT/STLExtras.h"
+#include "llvm/ADT/ScopeExit.h"
 #include "llvm/ADT/SmallPtrSet.h"
 #include "llvm/ADT/SmallString.h"
 #include "llvm/ADT/SmallVector.h"

 #include "llvm/CodeGen/GCMetadataPrinter.h"
 #include "llvm/CodeGen/LazyMachineBlockFrequencyInfo.h"
 #include "llvm/CodeGen/MachineBasicBlock.h"
+#include "llvm/CodeGen/MachineBranchProbabilityInfo.h"
 #include "llvm/CodeGen/MachineConstantPool.h"
 #include "llvm/CodeGen/MachineDominators.h"
 #include "llvm/CodeGen/MachineFrameInfo.h"

 #include <algorithm>
 #include <cassert>
 #include <cinttypes>
+#include <cmath>
 #include <cstdint>
 #include <iterator>
 #include <memory>

              "performed with -basic-block-sections=labels. Enabling this "
              "flag during in-process ThinLTO is not supported."));
 
+static cl::opt<bool> EnableBranchProbabilityDumping(
+    "emit-asm-branch-probabilities", cl::init(false), cl::Hidden,
+    cl::desc("Dump branch probabilities during asm printing to debug section"));
+
 const char DWARFGroupName[] = "dwarf";
 const char DWARFGroupDescription[] = "DWARF Emission";
 const char DbgTimerName[] = "emit";

       classifyEHPersonality(MF.getFunction().getPersonalityFn()));
 }
 
+/// Calculates probability of taking the branch target if MBPI is available.
+static std::optional<double>
+getBranchProbForCondBr(const MachineInstr &MI,
+                       MachineBranchProbabilityInfo *MBPI) {
+  assert(MI.isConditionalBranch() && !MI.isCall());
+
+  const MachineBasicBlock *Parent = MI.getParent();
+  const TargetInstrInfo *TII =
+      Parent->getParent()->getSubtarget().getInstrInfo();
+  assert(TII);
+
+  const MachineBasicBlock *Target = TII->getBranchDestBlock(MI);
+  const auto TargetProb = MBPI->getEdgeProbability(Parent, Target);
+  const double Probability =
+      double(TargetProb.getNumerator()) / double(TargetProb.getDenominator());
+  return Probability;
+}
+
 /// EmitFunctionBody - This method emits the body and trailer for a
 /// function.
 void AsmPrinter::emitFunctionBody() {

   bool IsEHa = MMI->getModule()->getModuleFlag("eh-asynch");
 
   bool CanDoExtraAnalysis = ORE->allowExtraAnalysis(DEBUG_TYPE);
+  const bool CanDumpBranchProbs = EnableBranchProbabilityDumping;
   for (auto &MBB : *MF) {
     // Print a label for the basic block.
     emitBasicBlockStart(MBB);

         // purely meta information.
         break;
       default:
+        if (CanDumpBranchProbs && MI.isConditionalBranch() && !MI.isCall()) {
+          if (auto *MBPI =
+                  getAnalysisIfAvailable<MachineBranchProbabilityInfo>()) {
+            if (auto Prob = getBranchProbForCondBr(MI, MBPI))
+              emitLabelAndRecordBranchProb(*Prob);
+          }
+        }
         emitInstruction(&MI);
         if (CanDoExtraAnalysis) {
           MCInst MCI;

 
   emitPatchableFunctionEntries();
 
+  emitBranchProbabilitySection();
+
   if (isVerbose())
     OutStreamer->getCommentOS() << "-- End function\n";
 

   }
 }
 
+void AsmPrinter::emitLabelAndRecordBranchProb(const double Probability) {
+  assert(Probability >= 0.0 && Probability <= 1.0 &&
+         "branch probability should be in range [0.0,1.0]");
+
+  MCSymbol *Label = OutStreamer->getContext().createTempSymbol("branch_prob");
+  Label->setUsedInReloc();
+  OutStreamer->emitLabel(Label);
+
+  BranchProbs.push_back({Label, Probability});
+}
+
+void AsmPrinter::emitBranchProbabilitySection() {
+  if (BranchProbs.empty())
+    return;
+
+  MCSection* BranchProbSec =
+      getObjFileLowering().getBranchProbabilitySection(*getCurrentSection());
+  if (!BranchProbSec)
+    return;
+
+  unsigned WordSizeBytes = MAI->getCodePointerSize();
+
+  OutStreamer->pushSection();
+  auto OnExit = make_scope_exit([&] { OutStreamer->popSection(); });
+  OutStreamer->switchSection(BranchProbSec);
+
+  for (auto [Label, Prob] : BranchProbs) {
+    OutStreamer->emitSymbolValue(Label, WordSizeBytes);
+
+    // Encode all data within 4 bytes to support 32 and 64 bit targets.
+    // Convert branch probability to value 0 - 10000 using 14 bits.
+    const long Val = lround(Prob * 10000.0);
+    assert(Val >= 0 && Val <= 10000);
+    const uint32_t Encoded = static_cast<uint32_t>(Val & 0x3fff);
+    OutStreamer->emitInt32(Encoded);
+
+    // Pad for alignment and reserved for future use
+    OutStreamer->emitZeros(WordSizeBytes - sizeof(Encoded));
+  }
+}
+
 uint16_t AsmPrinter::getDwarfVersion() const {
   return OutStreamer->getContext().getDwarfVersion();
 }

llvm/lib/MC/MCObjectFileInfo.cpp

   PseudoProbeDescSection =
       Ctx->getELFSection(".pseudo_probe_desc", DebugSecType, 0);
 
+  BranchProbabilitySection =
+      Ctx->getELFSection(".branch_probabilities", DebugSecType, 0);
+
   LLVMStatsSection = Ctx->getELFSection(".llvm_stats", ELF::SHT_PROGBITS, 0);
 }
 

   return PseudoProbeDescSection;
 }
 
+MCSection *
+MCObjectFileInfo::getBranchProbabilitySection(const MCSection &TextSec) const {
+  if (Ctx->getObjectFileType() != MCContext::IsELF)
+    return BranchProbabilitySection;
+
+  const auto &ElfSec = static_cast<const MCSectionELF &>(TextSec);
+  unsigned Flags = ELF::SHF_LINK_ORDER;
+  StringRef GroupName;
+  if (const MCSymbol *Group = ElfSec.getGroup()) {
+    GroupName = Group->getName();
+    Flags |= ELF::SHF_GROUP;
+  }
+
+  return Ctx->getELFSection(BranchProbabilitySection->getName(),
+                            ELF::SHT_PROGBITS, Flags, 0, GroupName, true,
+                            ElfSec.getUniqueID(),
+                            cast<MCSymbolELF>(TextSec.getBeginSymbol()));
+}
+
 MCSection *MCObjectFileInfo::getLLVMStatsSection() const {
   return LLVMStatsSection;
 }

llvm/lib/Target/X86/X86InstrInfo.h

                      SmallVectorImpl<MachineOperand> &Cond,
                      bool AllowModify) const override;
 
+  MachineBasicBlock *getBranchDestBlock(const MachineInstr &MI) const override;
+
   int getJumpTableIndex(const MachineInstr &MI) const override;
 
   std::optional<ExtAddrMode>

llvm/lib/Target/X86/X86InstrInfo.cpp

   return AnalyzeBranchImpl(MBB, TBB, FBB, Cond, CondBranches, AllowModify);
 }
 
+MachineBasicBlock *
+X86InstrInfo::getBranchDestBlock(const MachineInstr &MI) const {
+  assert(MI.getDesc().isBranch() && !MI.getDesc().isIndirectBranch() &&
+         !MI.getDesc().isCall() && "Unexpected opcode!");
+  // direct jumps and direct conditional jumps have target in first operand
+  return MI.getOperand(0).getMBB();
+}
+
 static int getJumpTableIndexFromAddr(const MachineInstr &MI) {
   const MCInstrDesc &Desc = MI.getDesc();
   int MemRefBegin = X86II::getMemoryOperandNo(Desc.TSFlags);

llvm/test/Transforms/PGOProfile/asm_emit_branch_prob.ll

+; REQUIRES: x86_64-linux
+
+; RUN: llc < %s -O1 -filetype=obj -o %t -emit-asm-branch-probabilities
+; RUN: llvm-readelf --hex-dump=.branch_probabilities %t \
+; RUN:   | FileCheck %s --check-prefix=CHECK-BP-SEC
+
+; RUN: llc < %s -O1 -filetype=obj -o %t
+; RUN: llvm-readelf --hex-dump=.branch_probabilities %t 2>&1 \
+; RUN:   | FileCheck %s --check-prefix=CHECK-NO-BP-SEC
+
+; When enabled, the branch probabilities are dumped with the jump address and
+; the percent encoded as a char from 0 to 10000.
+
+; // Test original source code
+; void sink(int &);
+; int test(int a, int b, int c) {
+;   if (a > 100)
+;     sink(a);
+;   sink(c);
+;   if (b > 100)
+;     sink(b);
+;   return a + b + c;
+; }
+
+define dso_local noundef i32 @_Z4testiii(i32 noundef %0, i32 noundef %1, i32 noundef %2) local_unnamed_addr {
+  %4 = alloca i32, align 4
+  %5 = alloca i32, align 4
+  %6 = alloca i32, align 4
+  store i32 %0, ptr %4, align 4
+  store i32 %1, ptr %5, align 4
+  store i32 %2, ptr %6, align 4
+  %7 = icmp sgt i32 %0, 100
+  br i1 %7, label %8, label %9, !prof !0
+
+8:                                                ; preds = %3
+  call void @_Z4sinkRi(ptr noundef nonnull align 4 dereferenceable(4) %4)
+  br label %9
+
+9:                                                ; preds = %8, %3
+  call void @_Z4sinkRi(ptr noundef nonnull align 4 dereferenceable(4) %6)
+  %10 = icmp sgt i32 %1, 100
+  br i1 %10, label %11, label %13, !prof !1
+
+11:                                               ; preds = %9
+  call void @_Z4sinkRi(ptr noundef nonnull align 4 dereferenceable(4) %5)
+  %12 = load i32, ptr %5, align 4
+  br label %13
+
+13:                                               ; preds = %11, %9
+  %14 = phi i32 [ %12, %11 ], [ %1, %9 ]
+  %15 = load i32, ptr %4, align 4
+  %16 = add nsw i32 %14, %15
+  %17 = load i32, ptr %6, align 4
+  %18 = add nsw i32 %16, %17
+  ret i32 %18
+}
+
+declare void @_Z4sinkRi(ptr noundef nonnull align 4 dereferenceable(4)) local_unnamed_addr #1
+
+
+!0 = !{!"branch_weights", i32 1000, i32 3000}
+!1 = !{!"branch_weights", i32 3600, i32 400}
+
+; CHECK-BP-SEC     :Hex dump of section '.branch_probabilities':
+; CHECK-BP-SEC-NEXT:0x00000000 {{([[:xdigit:]]{8}) ([[:xdigit:]]{8})}} {{4c1d|c409}}0000 00000000 {{(.{16})}}
+; CHECK-BP-SEC-NEXT:0x00000010 {{([[:xdigit:]]{8}) ([[:xdigit:]]{8})}} {{2823|e803}}0000 00000000 {{(.{16})}}
+
+; CHECK-NO-BP-SEC:llvm-readelf: warning: '{{.*}}': could not find section '.branch_probabilities'