This is an archive of the discontinued LLVM Phabricator instance.

[AVR][BPF][Lanai][Xtensa] Replace OperandMatchResultTy with ParseStatus (NFC)
ClosedPublic

Authored by barannikov88 on Aug 18 2023, 6:18 AM.

Details

Summary

ParseStatus is slightly more convenient to use due to implicit
conversion from bool, which allows to do something like:

return Error(L, "msg");

when with MatchOperandResultTy it had to be:

Error(L, "msg");
return MatchOperand_ParseFail;

It also has more appropriate name since parse* methods are not only for
parsing operands.

Diff Detail

Event Timeline

barannikov88 created this revision.Aug 18 2023, 6:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 18 2023, 6:18 AM
barannikov88 requested review of this revision.Aug 18 2023, 6:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 18 2023, 6:18 AM
MaskRay accepted this revision.Aug 19 2023, 2:59 PM

Thanks!

This revision is now accepted and ready to land.Aug 19 2023, 2:59 PM