This is an archive of the discontinued LLVM Phabricator instance.

[Sparc] Replace OperandMatchResultTy with ParseStatus (NFC)
ClosedPublic

Authored by barannikov88 on Jul 2 2023, 9:50 PM.

Details

Summary

ParseStatus is slightly more convenient to use due to implicit
conversion from bool, which allows to do something like:

return Error(L, "msg");

when with MatchOperandResultTy it had to be:

Error(L, "msg");
return MatchOperand_ParseFail;

It also has more appropriate name since parse* methods are not only for
parsing operands.

Diff Detail

Event Timeline

barannikov88 created this revision.Jul 2 2023, 9:50 PM
barannikov88 requested review of this revision.Jul 2 2023, 9:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 2 2023, 9:50 PM

Seems OK here, at least.

Rebase & ping

brad accepted this revision.Sep 5 2023, 11:09 PM
This revision is now accepted and ready to land.Sep 5 2023, 11:09 PM