Page MenuHomePhabricator

dylanmckay (Dylan McKay)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 18 2015, 2:21 AM (353 w, 3 d)

Recent Activity

Dec 15 2021

dylanmckay added inline comments to D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2.
Dec 15 2021, 4:31 AM · Restricted Project, Restricted Project, Restricted Project
dylanmckay added inline comments to D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2.
Dec 15 2021, 4:27 AM · Restricted Project, Restricted Project, Restricted Project

Dec 1 2021

dylanmckay accepted D112113: [ObjC] type method metadata `_imp`, messenger routine at callsite with program address space.

LGTM, nice work.

Dec 1 2021, 3:50 AM · Restricted Project
dylanmckay accepted D111566: [SYCL] Fix function pointer address space.

By the way, as this has already been approved by one, and you rightly applied the "speak now or forever hold your peace" principle re. OpenCL, and this clearly works better from my point of view than the old code, I wouldn't want to prevent you from committing this. I have no objections to merging this in its current state. If you do merge it as-is though it would be nice if a follow up PR moves the logic into getTargetAddressSpace() where I think it better belongs

Dec 1 2021, 1:18 AM · Restricted Project
dylanmckay added a comment to D111566: [SYCL] Fix function pointer address space.

This will product correct code from an AVR perspective where (before this patch it would have failed codegen). It is consistent with how we construct function pointers in LLVM core as well.

Dec 1 2021, 1:04 AM · Restricted Project
dylanmckay committed rGec15b7307f54: Add 'LLVM_DEFAULT_TARGET_TRIPLE' to the documented list of CMake variables (authored by dylanmckay).
Add 'LLVM_DEFAULT_TARGET_TRIPLE' to the documented list of CMake variables
Dec 1 2021, 12:39 AM
dylanmckay closed D96014: Add 'LLVM_DEFAULT_TARGET_TRIPLE' to the documented list of CMake variables.
Dec 1 2021, 12:39 AM · Restricted Project

Nov 30 2021

dylanmckay added inline comments to D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2.
Nov 30 2021, 5:25 PM · Restricted Project, Restricted Project, Restricted Project

Nov 29 2021

dylanmckay added inline comments to D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2.
Nov 29 2021, 4:03 AM · Restricted Project, Restricted Project, Restricted Project
dylanmckay requested changes to D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2.

Hey @Patryk27, very nice patch, I would not have guessed it was your first LLVM PR.

Nov 29 2021, 4:02 AM · Restricted Project, Restricted Project, Restricted Project
dylanmckay abandoned D95664: [AVR] Fix the eliminateCallFramePseudos method so that it always expands STDWSPQRr and STDSPQRr.

I'm going to close this in favor of https://reviews.llvm.org/D114611 . I agree with Matt's comments about there being a bit of funny business going on in this PR, the concept is being generalized in core unnecessarily and does not strictly make sense in the place I put it. I think the approach in this other patch (thanks @Patryk27) is much more sensible.

Nov 29 2021, 3:27 AM · Restricted Project

Jun 29 2021

dylanmckay accepted D99467: [AVR] Fix a bug in prologue of ISR.
Jun 29 2021, 6:38 AM · Restricted Project

Jun 28 2021

dylanmckay accepted D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø.

Nope, thank you!

Jun 28 2021, 5:38 AM · Restricted Project, Restricted Project
dylanmckay accepted D97853: [AVR] Do not chain stores in call frame setup.
Jun 28 2021, 5:38 AM · Restricted Project
dylanmckay accepted D97745: [AVR] Set R31R30 as clobbered after ADJCALLSTACKUP.
Jun 28 2021, 5:30 AM · Restricted Project
dylanmckay accepted D97127: [AVR] Improve 8/16 bit atomic operations.
Jun 28 2021, 5:27 AM · Restricted Project
dylanmckay accepted D96957: [AVR] Fix rotate instructions.
Jun 28 2021, 5:24 AM · Restricted Project
dylanmckay accepted D96677: [AVR] Expand large shifts early in IR.

This looks good to me, and, it is especially nice to remove the dependency on the nonexistent runtime lib functions which has been a big issue. Nice work

Jun 28 2021, 5:19 AM · Restricted Project
dylanmckay accepted D99239: [AVR][test] Add a new test: functions with struct return type.
Jun 28 2021, 4:26 AM · Restricted Project
dylanmckay accepted D99237: [AVR][clang] Fix wrong calling convention in functions return struct type.
Jun 28 2021, 4:16 AM · Restricted Project

May 31 2021

dylanmckay accepted D48803: Place the BlockAddress type in the address space of the containing function.

Thanks for the clarification, makes sense. LGTM

May 31 2021, 9:41 AM · Restricted Project

May 30 2021

dylanmckay requested changes to D48803: Place the BlockAddress type in the address space of the containing function.

My apologies for the couple month latency, almost every time I've checked this patch in the last few years there isn't any new activity. It looks like there's one comment from Matt last month that still needs to be addressed (remove a piece of error handling). Once updated, I'd like to get this approved.

May 30 2021, 5:12 AM · Restricted Project
dylanmckay accepted D98335: [AVR] Refactor 8-bit & 16-bit shifts.

Very nice design and simplification, looks good to me. Thank you for the link to Ayke's very nice blog post, as well as the detailed summary about your design and the tradeoffs within. It was also helpful that you kept the refactor and the optimizations themselves in separate patches, making this a non-functional change.

May 30 2021, 4:47 AM · Restricted Project
dylanmckay added a comment to D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø.

Add these devices into the constant list at https://github.com/llvm/llvm-project/blob/main/clang/lib/Basic/Targets/AVR.cpp#L30 so that Clang can define the required mcu defines.

May 30 2021, 2:53 AM · Restricted Project, Restricted Project
dylanmckay accepted D97669: [clang][AVR] Add avr-libc/include to clang system include paths.

Looks good, nice and simple. Thanks @benshi001

May 30 2021, 2:50 AM · Restricted Project
dylanmckay accepted D96394: [AVR] Improve inline assembly.
May 30 2021, 2:37 AM · Restricted Project

May 12 2021

dylanmckay accepted D100701: [clang][AVR] Redefine some types to be compatible with avr-gcc.
May 12 2021, 4:56 AM · Restricted Project

Feb 9 2021

dylanmckay updated the diff for D95664: [AVR] Fix the eliminateCallFramePseudos method so that it always expands STDWSPQRr and STDSPQRr.

Fix an assertion error caused by attempting to get the frame size of non-frame instructions

Feb 9 2021, 5:44 AM · Restricted Project
dylanmckay planned changes to D95664: [AVR] Fix the eliminateCallFramePseudos method so that it always expands STDWSPQRr and STDSPQRr.

I've discovered an issue, this is not yet ready for review.

Feb 9 2021, 4:26 AM · Restricted Project
dylanmckay added a comment to D87631: [AVR] Fix global references to function symbols.

I have applied the code review suggestions and committed this to master in 2ccb941740e608a9cf70a7c5840497149654b0f6.

Feb 9 2021, 3:43 AM · Restricted Project
dylanmckay committed rG2ccb941740e6: [AVR] Fix global references to function symbols (authored by dylanmckay).
[AVR] Fix global references to function symbols
Feb 9 2021, 3:42 AM
dylanmckay closed D87631: [AVR] Fix global references to function symbols.
Feb 9 2021, 3:42 AM · Restricted Project

Feb 4 2021

dylanmckay added inline comments to D96014: Add 'LLVM_DEFAULT_TARGET_TRIPLE' to the documented list of CMake variables.
Feb 4 2021, 10:54 PM · Restricted Project
dylanmckay committed rGb10df8f7a594: [AVR] Fix up a few accidentally-regressed Generic CodeGen tests recently broken (authored by dylanmckay).
[AVR] Fix up a few accidentally-regressed Generic CodeGen tests recently broken
Feb 4 2021, 7:22 AM
dylanmckay committed rG0d890e4ce4f4: [AVR] Add 'XFAIL' to the remaining failing Generic CodeGen tests for AVR (authored by dylanmckay).
[AVR] Add 'XFAIL' to the remaining failing Generic CodeGen tests for AVR
Feb 4 2021, 7:03 AM
dylanmckay committed rG85e8e6246e0f: [AVR] Fix 14 Generic CodeGen tests by making address space explicit or optional (authored by dylanmckay).
[AVR] Fix 14 Generic CodeGen tests by making address space explicit or optional
Feb 4 2021, 7:03 AM
dylanmckay committed rG83e2710eb014: [AVR] Remove an assertion that causes generic CodeGen tests to fail (authored by dylanmckay).
[AVR] Remove an assertion that causes generic CodeGen tests to fail
Feb 4 2021, 5:06 AM
dylanmckay requested review of D96014: Add 'LLVM_DEFAULT_TARGET_TRIPLE' to the documented list of CMake variables.
Feb 4 2021, 4:23 AM · Restricted Project

Feb 1 2021

dylanmckay accepted D95529: [AVR][clang] Fix a bug in AVR toolchain search paths.
Feb 1 2021, 10:05 PM · Restricted Project

Jan 28 2021

dylanmckay requested review of D95664: [AVR] Fix the eliminateCallFramePseudos method so that it always expands STDWSPQRr and STDSPQRr.
Jan 28 2021, 10:35 PM · Restricted Project

Jan 27 2021

dylanmckay accepted D90092: [AVR] Optimize 16-bit int shift.

Looks good to me. Indeed, it is sad this could not be implemented at a higher level but even as is it is a great optimization.

Jan 27 2021, 3:36 AM · Restricted Project

Jan 23 2021

dylanmckay accepted D93976: [AVR] Optimize 16-bit comparison with constant.
Jan 23 2021, 1:52 AM · Restricted Project
dylanmckay accepted D93579: [clang][AVR] Improve avr-ld command line options.

Great patch!

Jan 23 2021, 1:19 AM · Restricted Project
dylanmckay accepted D90678: [AVR] Optimize 8-bit int shift.

Nice work, approved.

Jan 23 2021, 1:15 AM · Restricted Project
dylanmckay accepted D89047: [AVR] Optimize 8-bit logic left/right shifts.
Jan 23 2021, 1:03 AM · Restricted Project

Nov 18 2020

dylanmckay requested changes to D89047: [AVR] Optimize 8-bit logic left/right shifts.

Nice patch, cheers.

Nov 18 2020, 3:15 AM · Restricted Project

Nov 17 2020

dylanmckay accepted D70947: Add a default address space for globals to DataLayout.

@arichardson yup, this is good to go. Thanks for the persistence on this one.

Nov 17 2020, 2:23 AM · Restricted Project

Nov 16 2020

dylanmckay accepted D88658: [AVR] Optimize the 16-bit NEGW pseudo instruction.

Looks good to me, thanks for the patch!

Nov 16 2020, 10:37 PM · Restricted Project
dylanmckay accepted D88410: [clang][AVR] Improve avr-ld command line options.

Looks good to me, thanks for the patch @benshi001

Nov 16 2020, 10:11 PM · Restricted Project

Oct 28 2020

dylanmckay committed rG88b7b76a0b23: [AVR][clang] Pass the address of the data section to the linker for ATmega328 (authored by dylanmckay).
[AVR][clang] Pass the address of the data section to the linker for ATmega328
Oct 28 2020, 10:35 AM
dylanmckay closed D86629: [AVR][clang] Pass the address of the data section to the linker for ATmega328.
Oct 28 2020, 10:35 AM · Restricted Project
dylanmckay accepted D88352: [clang][AVR] Add more devices.

Approved, thanks!

Oct 28 2020, 9:54 AM · Restricted Project
dylanmckay accepted D87968: [AVR] Improve device list.

Approved, thanks for the patch!

Oct 28 2020, 9:54 AM · Restricted Project
dylanmckay added a comment to D86629: [AVR][clang] Pass the address of the data section to the linker for ATmega328.

Regarding TableGen; I would like to send an RFC to llvm-dev to come up with a proper API to expose backend-specific device-specific information and constants to LLVM frontends, as I can imagine that many backends could stand to benefit. I note that there is in general a lot of duplication in individual frontends defining information LLVM already knows about (off the top of my head, inline assembly constraints and registers is one of them but may not easily fit into the paradigm I have in mind).

Oct 28 2020, 9:49 AM · Restricted Project
dylanmckay added inline comments to D86629: [AVR][clang] Pass the address of the data section to the linker for ATmega328.
Oct 28 2020, 9:42 AM · Restricted Project

Oct 27 2020

dylanmckay requested changes to D48803: Place the BlockAddress type in the address space of the containing function.
Oct 27 2020, 4:29 AM · Restricted Project

Sep 30 2020

dylanmckay committed rG1fedd90cc7a8: [AVR] fix interrupt stack pointer restoration (authored by couchand).
[AVR] fix interrupt stack pointer restoration
Sep 30 2020, 10:52 PM
dylanmckay closed D87735: [AVR] fix interrupt stack pointer restoration.
Sep 30 2020, 10:52 PM · Restricted Project
dylanmckay added inline comments to D87631: [AVR] Fix global references to function symbols.
Sep 30 2020, 7:28 AM · Restricted Project
dylanmckay requested changes to D87631: [AVR] Fix global references to function symbols.

Good bugfix - thanks for the second patch!

Sep 30 2020, 7:22 AM · Restricted Project
dylanmckay requested changes to D87634: [AVR] Improve AVR disassembly.

The code is looking nice, thanks for the patch @amikhalev!

Sep 30 2020, 6:54 AM · Restricted Project
dylanmckay accepted D87735: [AVR] fix interrupt stack pointer restoration.

This is a great patch, thanks @couchand!

Sep 30 2020, 5:17 AM · Restricted Project

Sep 21 2020

dylanmckay added a comment to D86629: [AVR][clang] Pass the address of the data section to the linker for ATmega328.

Hey @aykevl, could you please confirm that this patch looks okay?

Sep 21 2020, 1:26 AM · Restricted Project

Aug 27 2020

dylanmckay added inline comments to D84345: [AMDGPU] Set the default globals address space to 1.
Aug 27 2020, 6:01 AM · Restricted Project, Restricted Project
dylanmckay added inline comments to D84345: [AMDGPU] Set the default globals address space to 1.
Aug 27 2020, 6:00 AM · Restricted Project, Restricted Project
dylanmckay requested changes to D78491: Avoid relying on address space zero default parameter in llvm/IR.
Aug 27 2020, 5:36 AM · Restricted Project, Restricted Project
dylanmckay added a comment to D78491: Avoid relying on address space zero default parameter in llvm/IR.

Note to the readers: A recent-ish llvm-dev discussion around this patch can be found in here whrein a consensus is found on the way forward on this patch.

Aug 27 2020, 5:36 AM · Restricted Project, Restricted Project

Aug 26 2020

dylanmckay added inline comments to D70947: Add a default address space for globals to DataLayout.
Aug 26 2020, 9:28 AM · Restricted Project
dylanmckay added a comment to D70947: Add a default address space for globals to DataLayout.

I've split the backwards compat tests and AMDGPU changes out to D84345. Is the DataLayout upgrade what you meant with bitcode compatibility tests or should I be adding additional tests?

Aug 26 2020, 9:26 AM · Restricted Project
dylanmckay accepted D86418: [AVR] Improve inline rotate/shift expansions.

Great patch

Aug 26 2020, 8:59 AM · Restricted Project
dylanmckay requested review of D86629: [AVR][clang] Pass the address of the data section to the linker for ATmega328.
Aug 26 2020, 8:28 AM · Restricted Project

Aug 24 2020

dylanmckay added a comment to D85589: Add support for AVR attiny441 and attiny841.

@ixoo committed in 0f0be3fb8ddeca4bbcffc7b22319254c360ca24b - thanks for the patch!

Aug 24 2020, 1:36 AM · Restricted Project
dylanmckay committed rG0f0be3fb8dde: Add support for AVR attiny441 and attiny841 (authored by ixoo).
Add support for AVR attiny441 and attiny841
Aug 24 2020, 1:36 AM
dylanmckay closed D85589: Add support for AVR attiny441 and attiny841.
Aug 24 2020, 1:36 AM · Restricted Project

Aug 11 2020

dylanmckay accepted D85589: Add support for AVR attiny441 and attiny841.

Looks good, thanks for the patch. Do you need someone to commit this for you @ixoo?

Aug 11 2020, 6:56 AM · Restricted Project
dylanmckay requested changes to D82684: AVR Backend: Add harvard program address space checker pass.
Aug 11 2020, 5:10 AM · Restricted Project
dylanmckay added a comment to D82684: AVR Backend: Add harvard program address space checker pass.

Patch is looking really good, only suggestions are the adding a test and a couple formatting nitpicks.

Aug 11 2020, 5:10 AM · Restricted Project

Jun 23 2020

dylanmckay added inline comments to rGede6005e7092: [AVR] Explicitly set the address of the data section when invoking the linker.
Jun 23 2020, 4:12 AM
dylanmckay committed rG15b9dc46c6d2: Revert "[AVR] Explicitly set the address of the data section when invoking the… (authored by dylanmckay).
Revert "[AVR] Explicitly set the address of the data section when invoking the…
Jun 23 2020, 3:40 AM
dylanmckay added a reverting change for rGede6005e7092: [AVR] Explicitly set the address of the data section when invoking the linker: rG15b9dc46c6d2: Revert "[AVR] Explicitly set the address of the data section when invoking the….
Jun 23 2020, 3:40 AM
dylanmckay added inline comments to rGede6005e7092: [AVR] Explicitly set the address of the data section when invoking the linker.
Jun 23 2020, 3:40 AM
dylanmckay added a comment to D68524: [AVR] Rewrite the function calling convention..

Thanks for the patch @rodrigorc, appreciate it!

Jun 23 2020, 3:08 AM · Restricted Project
dylanmckay added a comment to D68524: [AVR] Rewrite the function calling convention..

Committed in

Jun 23 2020, 3:08 AM · Restricted Project
dylanmckay committed rGb9c26a9cfe53: [AVR] Rewrite the function calling convention. (authored by dylanmckay).
[AVR] Rewrite the function calling convention.
Jun 23 2020, 2:37 AM
dylanmckay closed D68524: [AVR] Rewrite the function calling convention..
Jun 23 2020, 2:37 AM · Restricted Project

Jun 19 2020

dylanmckay added a comment to D68524: [AVR] Rewrite the function calling convention..

Rebased version with @Sh4rK's comments fixed.

Jun 19 2020, 9:44 AM · Restricted Project
dylanmckay added a comment to D68524: [AVR] Rewrite the function calling convention..

@Sh4rK your review is always welcome - I've updated the code with your comments, here's the delta containing just the fixes you've suggested.

Jun 19 2020, 9:44 AM · Restricted Project
dylanmckay added a comment to D68524: [AVR] Rewrite the function calling convention..

This conflicts with master now, he's a rebased patch

Jun 19 2020, 6:59 AM · Restricted Project

Jun 18 2020

dylanmckay committed rG01741d6dbec1: [AVR] Remove duplicate specification of lib directory (authored by dylanmckay).
[AVR] Remove duplicate specification of lib directory
Jun 18 2020, 10:52 PM
dylanmckay committed rGaeaa09ec10ee: Revert "[AVR] Remove duplicate specification of lib directory" (authored by dylanmckay).
Revert "[AVR] Remove duplicate specification of lib directory"
Jun 18 2020, 10:52 PM
dylanmckay added a reverting change for rG03b0831144a9: [AVR] Remove duplicate specification of lib directory: rGaeaa09ec10ee: Revert "[AVR] Remove duplicate specification of lib directory".
Jun 18 2020, 10:52 PM
dylanmckay committed rG03b0831144a9: [AVR] Remove duplicate specification of lib directory (authored by dylanmckay).
[AVR] Remove duplicate specification of lib directory
Jun 18 2020, 10:52 PM
dylanmckay closed D77334: [AVR] Remove duplicate specification of lib directory.
Jun 18 2020, 10:52 PM · Restricted Project
dylanmckay added a comment to D77334: [AVR] Remove duplicate specification of lib directory.

Sorry, I lost track of this. Committed in 01741d6dbec11c0a0c8e610f0033831735c78d1e

Jun 18 2020, 10:51 PM · Restricted Project
dylanmckay accepted D82088: [AVR] Disassemble instructions with fixed Z operand.

Note: I don't know whether the way I've made the Z register printable is the correct way. Maybe the register should be added to the MCInst instead.

Jun 18 2020, 10:51 PM · Restricted Project
dylanmckay accepted D82093: [AVR] Disassemble double register instructions.
Jun 18 2020, 10:20 PM · Restricted Project
dylanmckay accepted D81971: [AVR] Disassemble multiplication instructions.
Jun 18 2020, 10:20 PM · Restricted Project
dylanmckay accepted D81968: [AVR] Decode single register instructions.
Jun 18 2020, 10:20 PM · Restricted Project
dylanmckay accepted D78459: [AVR] Don't adjust for instruction size.
Jun 18 2020, 10:20 PM · Restricted Project
dylanmckay accepted D78439: [AVR] Fix miscompilation of zext + add.

Good reproduction, works exactly as expected and indeed this value is being miscalculated.

Jun 18 2020, 4:52 AM · Restricted Project