Page MenuHomePhabricator

dylanmckay (Dylan McKay)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 18 2015, 2:21 AM (191 w, 6 d)

Recent Activity

Feb 13 2019

dylanmckay committed rG8a56d10a2ff0: [AVR] Fix a typo - 's/analisys/analysis' (authored by dylanmckay).
[AVR] Fix a typo - 's/analisys/analysis'
Feb 13 2019, 2:32 PM
dylanmckay committed rL353987: [AVR] Fix a typo - 's/analisys/analysis'.
[AVR] Fix a typo - 's/analisys/analysis'
Feb 13 2019, 2:31 PM

Jan 20 2019

dylanmckay committed rL351721: [AVR] Insert unconditional branch when inserting MBBs between blocks with….
[AVR] Insert unconditional branch when inserting MBBs between blocks with…
Jan 20 2019, 8:32 PM
dylanmckay committed rL351720: [AVR] Enable emission of debug information.
[AVR] Enable emission of debug information
Jan 20 2019, 8:28 PM
dylanmckay committed rL351719: Revert "[AVR] Insert unconditional branch when inserting MBBs between blocks….
Revert "[AVR] Insert unconditional branch when inserting MBBs between blocks…
Jan 20 2019, 6:46 PM
dylanmckay committed rL351718: [AVR] Insert unconditional branch when inserting MBBs between blocks with….
[AVR] Insert unconditional branch when inserting MBBs between blocks with…
Jan 20 2019, 6:45 PM
dylanmckay committed rL351679: [AVR] Remove unneeded XFAILs from the Generic CodeGen tests.
[AVR] Remove unneeded XFAILs from the Generic CodeGen tests
Jan 20 2019, 3:18 AM
dylanmckay committed rL351678: [AVR] Allow AVR to be explicitly set as the default target triple.
[AVR] Allow AVR to be explicitly set as the default target triple
Jan 20 2019, 3:13 AM

Jan 19 2019

dylanmckay committed rL351674: [AVR] Replace two references to ARM's 't2_so_imm' type comments.
[AVR] Replace two references to ARM's 't2_so_imm' type comments
Jan 19 2019, 7:46 PM
dylanmckay committed rL351673: [AVR] Fix codegen bug in 16-bit loads.
[AVR] Fix codegen bug in 16-bit loads
Jan 19 2019, 7:42 PM
dylanmckay committed rL351672: Revert "[AVR] Fix codegen bug in 16-bit loads".
Revert "[AVR] Fix codegen bug in 16-bit loads"
Jan 19 2019, 7:42 PM

Jan 18 2019

dylanmckay committed rL351544: [AVR] Fix codegen bug in 16-bit loads.
[AVR] Fix codegen bug in 16-bit loads
Jan 18 2019, 3:31 AM
dylanmckay committed rL351539: [AVR] Fix the inst-cbr test.
[AVR] Fix the inst-cbr test
Jan 18 2019, 2:17 AM

Jan 17 2019

dylanmckay committed rL351526: [AVR] Rewrite the CBRRdK instruction as an alias of ANDIRdK.
[AVR] Rewrite the CBRRdK instruction as an alias of ANDIRdK
Jan 17 2019, 11:35 PM
dylanmckay committed rL351523: [AVR] Expand 8/16-bit multiplication to libcalls on MCUs that don't have….
[AVR] Expand 8/16-bit multiplication to libcalls on MCUs that don't have…
Jan 17 2019, 10:15 PM

Dec 19 2018

dylanmckay added a comment to D54334: [AVR] Automatically link CRT and libgcc from the system avr-gcc.

I'm not certain if it will be possible to devise test cases for the two diagnostics I pointed out or not

Dec 19 2018, 1:42 AM
dylanmckay added reviewers for D54334: [AVR] Automatically link CRT and libgcc from the system avr-gcc: brucehoult, TimNN.
Dec 19 2018, 1:41 AM

Dec 18 2018

dylanmckay committed rL349469: [IPO][AVR] Create new Functions in the default address space specified in the….
[IPO][AVR] Create new Functions in the default address space specified in the…
Dec 18 2018, 1:56 AM

Nov 16 2018

dylanmckay added inline comments to D54334: [AVR] Automatically link CRT and libgcc from the system avr-gcc.
Nov 16 2018, 6:00 AM
dylanmckay updated the diff for D54334: [AVR] Automatically link CRT and libgcc from the system avr-gcc.

Run clang-format on the whole patch

Nov 16 2018, 6:00 AM
dylanmckay updated the diff for D54334: [AVR] Automatically link CRT and libgcc from the system avr-gcc.
  • Remove link to BugZilla in diagnostic
  • Use StringRef for a static string array rather than std::string
  • Elide braces
  • Dereference an Optional in-place rather than persisting it for one use
  • Use llvm::None rather than explicit Optional() constructor
Nov 16 2018, 5:52 AM

Nov 15 2018

dylanmckay requested changes to D48803: Place the BlockAddress type in the program address space.
Nov 15 2018, 11:06 PM
dylanmckay added a comment to D48803: Place the BlockAddress type in the program address space.

Nice patch, this looks useful!

Nov 15 2018, 11:01 PM
dylanmckay added a comment to D54334: [AVR] Automatically link CRT and libgcc from the system avr-gcc.

I'd like feedback on the new AVR-specific warnings, and the new warning group. I have not added a warning or error to clang before, but this seems consistent with how the other targets implement it.

Nov 15 2018, 9:16 PM

Nov 12 2018

dylanmckay updated the diff for D54334: [AVR] Automatically link CRT and libgcc from the system avr-gcc.

Add the search path that Ubuntu installs libc to.

Nov 12 2018, 11:19 AM

Nov 9 2018

dylanmckay committed rL346565: [AVR] Reorder the CHECK lines in directmem.ll to match current trunk.
[AVR] Reorder the CHECK lines in directmem.ll to match current trunk
Nov 9 2018, 3:20 PM
dylanmckay committed rC346548: Use the correct address space when bitcasting func pointer to int pointer.
Use the correct address space when bitcasting func pointer to int pointer
Nov 9 2018, 11:44 AM
dylanmckay committed rL346548: Use the correct address space when bitcasting func pointer to int pointer.
Use the correct address space when bitcasting func pointer to int pointer
Nov 9 2018, 11:44 AM
dylanmckay created D54334: [AVR] Automatically link CRT and libgcc from the system avr-gcc.
Nov 9 2018, 10:59 AM
dylanmckay committed rC346520: Use the correct address space when emitting the ctor function list.
Use the correct address space when emitting the ctor function list
Nov 9 2018, 9:17 AM
dylanmckay committed rL346520: Use the correct address space when emitting the ctor function list.
Use the correct address space when emitting the ctor function list
Nov 9 2018, 9:17 AM

Nov 4 2018

dylanmckay committed rL346117: [AVR] Fix a backend bug that left extraneous operands after expansion.
[AVR] Fix a backend bug that left extraneous operands after expansion
Nov 4 2018, 9:51 PM
dylanmckay committed rL346114: [AVR] Disallow the LDDWRdPtrQ instruction with Z as the destination.
[AVR] Disallow the LDDWRdPtrQ instruction with Z as the destination
Nov 4 2018, 9:04 PM

Nov 1 2018

dylanmckay accepted D53425: Fix modules build of AVRAsmParser.cpp.

Hey @arichardson, sorry for the delay, exam period!

Nov 1 2018, 10:09 PM

Oct 11 2018

dylanmckay committed rL344243: Generalize an IR verifier check to work with non-zero program address spaces.
Generalize an IR verifier check to work with non-zero program address spaces
Oct 11 2018, 5:51 AM

Oct 9 2018

dylanmckay committed rL344111: [AVR] Fix the 'call.ll' CodeGen test.
[AVR] Fix the 'call.ll' CodeGen test
Oct 9 2018, 8:23 PM

Sep 1 2018

dylanmckay committed rL341278: [AVR] Redefine the 'LSL' instruction as an alias of 'ADD'.
[AVR] Redefine the 'LSL' instruction as an alias of 'ADD'
Sep 1 2018, 5:24 AM
dylanmckay committed rL341277: [AVR] Redefine the 'SBR' instruction as an alias.
[AVR] Redefine the 'SBR' instruction as an alias
Sep 1 2018, 5:24 AM
dylanmckay committed rL341276: [AVR] Define the TST instruction as an alias of AND.
[AVR] Define the TST instruction as an alias of AND
Sep 1 2018, 5:23 AM
dylanmckay committed rL341275: [AVR] Define the ROL instruction as an alias of ADC.
[AVR] Define the ROL instruction as an alias of ADC
Sep 1 2018, 5:23 AM

Jul 29 2018

dylanmckay committed rL338212: [AVR] Re-enable expansion of ADDE/ADDC/SUBE/SUBC in ISel.
[AVR] Re-enable expansion of ADDE/ADDC/SUBE/SUBC in ISel
Jul 29 2018, 4:38 AM

Jul 15 2018

dylanmckay committed rL337122: [AVR] Document some public functions.
[AVR] Document some public functions
Jul 15 2018, 12:29 AM

Jul 14 2018

dylanmckay added a comment to D37054: Require address space to be specified when creating functions (2/3).

Ignore the review-related comments, they were leftover draft messages from a while back.

Jul 14 2018, 8:59 AM
dylanmckay abandoned D37054: Require address space to be specified when creating functions (2/3).
Jul 14 2018, 8:56 AM
dylanmckay abandoned D37057: [clang] Require address space to be specified when creating functions (3/3).

Superseded by D47541

Jul 14 2018, 8:55 AM

Jun 11 2018

dylanmckay committed rL334409: [AVR] Set trackLivenessAfterRegAlloc.
[AVR] Set trackLivenessAfterRegAlloc
Jun 11 2018, 7:51 AM

Mar 20 2018

dylanmckay committed rL327967: [AVR] Add a regression test for struct return lowering.
[AVR] Add a regression test for struct return lowering
Mar 20 2018, 4:26 AM

Mar 18 2018

dylanmckay committed rL327814: [AVR] Lower i128 divisions to runtime library calls.
[AVR] Lower i128 divisions to runtime library calls
Mar 18 2018, 6:00 PM

Mar 6 2018

dylanmckay committed rL326774: [AVR] Remove the earlyclobber flag from LDDWRdYQ.
[AVR] Remove the earlyclobber flag from LDDWRdYQ
Mar 6 2018, 3:22 AM

Mar 5 2018

dylanmckay committed rL326742: [AVR] Fix the test suite after r326500..
[AVR] Fix the test suite after r326500.
Mar 5 2018, 12:58 PM

Mar 2 2018

dylanmckay updated the diff for D37057: [clang] Require address space to be specified when creating functions (3/3).

Rebase

Mar 2 2018, 6:27 AM
dylanmckay updated the diff for D37054: Require address space to be specified when creating functions (2/3).

Rebase and remove cherry-picked function now in trunk

Mar 2 2018, 6:27 AM

Feb 27 2018

dylanmckay accepted D43645: Make the LLParser accept call instructions of variables in the program AS.
Feb 27 2018, 2:20 AM
dylanmckay updated the diff for D37057: [clang] Require address space to be specified when creating functions (3/3).

Gentle rebase

Feb 27 2018, 1:48 AM
dylanmckay updated the diff for D37054: Require address space to be specified when creating functions (2/3).

Gentle rebase

Feb 27 2018, 1:40 AM
dylanmckay added a comment to D37054: Require address space to be specified when creating functions (2/3).

There are no testcases included here with ll-files including calls/bitcasts etc with non-zero addrspace, so it is a little bit tricky to understand how far I'm supposed to get by only using your set of patches.

Feb 27 2018, 1:01 AM

Feb 19 2018

dylanmckay committed rL325483: [AVR] Set the program address space in the data layout.
[AVR] Set the program address space in the data layout
Feb 19 2018, 2:48 AM
dylanmckay committed rC325483: [AVR] Set the program address space in the data layout.
[AVR] Set the program address space in the data layout
Feb 19 2018, 2:48 AM
dylanmckay committed rL325481: [AVR] Set the program address space in the data layout.
[AVR] Set the program address space in the data layout
Feb 19 2018, 2:43 AM
dylanmckay committed rL325479: Add default address space for functions to the data layout (1/3).
Add default address space for functions to the data layout (1/3)
Feb 19 2018, 1:59 AM
dylanmckay closed D37052: Add default address space for functions to the data layout (1/3).
Feb 19 2018, 1:59 AM
dylanmckay added inline comments to D37052: Add default address space for functions to the data layout (1/3).
Feb 19 2018, 1:59 AM
dylanmckay updated the diff for D37052: Add default address space for functions to the data layout (1/3).

Rebase and typo fix from @arichardson

Feb 19 2018, 1:55 AM
dylanmckay committed rL325474: [AVR] Fix a lowering bug in AVRISelLowering.cpp.
[AVR] Fix a lowering bug in AVRISelLowering.cpp
Feb 19 2018, 12:30 AM

Feb 8 2018

dylanmckay added a comment to D37052: Add default address space for functions to the data layout (1/3).

Ping

Feb 8 2018, 3:01 AM
dylanmckay committed rL324583: [AVR] Fix the testsuite after '%' changed to '$' in MIR.
[AVR] Fix the testsuite after '%' changed to '$' in MIR
Feb 8 2018, 1:21 AM

Dec 22 2017

dylanmckay added a comment to D40830: [RISCV] Implement support for the BranchRelaxation pass.

LGTM with minor nitpick

Dec 22 2017, 12:56 PM

Dec 21 2017

dylanmckay added a comment to D41493: [zorg] Set up a buildslave to build the experimental RISCV target.

FYI @asb, I could never get email notifications working from the staging buildmaster.

Dec 21 2017, 1:20 PM

Dec 14 2017

dylanmckay added a reviewer for D40830: [RISCV] Implement support for the BranchRelaxation pass: dylanmckay.
Dec 14 2017, 2:50 AM

Dec 11 2017

dylanmckay committed rL320348: [AVR] Implement some missing code paths.
[AVR] Implement some missing code paths
Dec 11 2017, 3:02 AM
dylanmckay committed rL320347: [AVR] Fix incorrectly-calculated AVRMCExpr evaluations.
[AVR] Fix incorrectly-calculated AVRMCExpr evaluations
Dec 11 2017, 3:02 AM

Dec 9 2017

dylanmckay added inline comments to D37052: Add default address space for functions to the data layout (1/3).
Dec 9 2017, 1:13 AM
dylanmckay updated the diff for D37057: [clang] Require address space to be specified when creating functions (3/3).

Rebase on trunk

Dec 9 2017, 1:12 AM
dylanmckay updated the diff for D37054: Require address space to be specified when creating functions (2/3).

Move GlobalValue::getAddressSpace() from previous patch into here

Dec 9 2017, 1:11 AM
dylanmckay updated the diff for D37052: Add default address space for functions to the data layout (1/3).
  • Move GlobalValue::getAddressSpace() to next patch
  • Add ProgramAddressSpace to DataLayout::operator==
Dec 9 2017, 1:10 AM
dylanmckay committed rL320247: Revert and accidentally committed revert commit.
Revert and accidentally committed revert commit
Dec 9 2017, 12:02 AM

Dec 8 2017

dylanmckay committed rL320246: [AVR] Fix two CodeGen tests.
[AVR] Fix two CodeGen tests
Dec 8 2017, 11:52 PM
dylanmckay committed rL320245: Revert "[AVR] Override ParseDirective".
Revert "[AVR] Override ParseDirective"
Dec 8 2017, 11:52 PM
dylanmckay committed rL320243: Relax unaligned access assertion when type is byte aligned.
Relax unaligned access assertion when type is byte aligned
Dec 8 2017, 10:46 PM
dylanmckay closed D39946: Relax unaligned access assertion when type is byte aligned by committing rL320243: Relax unaligned access assertion when type is byte aligned.
Dec 8 2017, 10:46 PM

Dec 7 2017

dylanmckay updated the diff for D39946: Relax unaligned access assertion when type is byte aligned.

Remove unneeded modifications to the diff left from the last update

Dec 7 2017, 1:49 AM
dylanmckay updated the diff for D39946: Relax unaligned access assertion when type is byte aligned.
  • Prefer explicitly-enabled TLI options rather than making assumptions based on data layout
  • Remove misplaced functions on DataLayout
Dec 7 2017, 1:43 AM

Dec 6 2017

dylanmckay accepted D38029: [AVR] Override ParseDirective.

Patch is looking great, thanks Leslie!

Dec 6 2017, 10:33 PM
dylanmckay added inline comments to D37052: Add default address space for functions to the data layout (1/3).
Dec 6 2017, 10:25 PM
dylanmckay updated the diff for D37052: Add default address space for functions to the data layout (1/3).

Remove switch table from the docs

Dec 6 2017, 10:24 PM
dylanmckay retitled D37057: [clang] Require address space to be specified when creating functions (3/3) from [clang] Require address space to be specified when creating functions (4/4) to [clang] Require address space to be specified when creating functions (3/3).
Dec 6 2017, 10:15 PM
dylanmckay updated the diff for D37057: [clang] Require address space to be specified when creating functions (3/3).
  • Remove the switch table stuff for a later patch
  • Rebased on top of trunk
Dec 6 2017, 10:14 PM
dylanmckay retitled D37054: Require address space to be specified when creating functions (2/3) from Require address space to be specified when creating functions (3/4) to Require address space to be specified when creating functions (2/3).
Dec 6 2017, 10:12 PM
dylanmckay retitled D37052: Add default address space for functions to the data layout (1/3) from Add default address space for functions to the data layout (1/4) to Add default address space for functions to the data layout (1/3).
Dec 6 2017, 10:12 PM
dylanmckay updated the summary of D37052: Add default address space for functions to the data layout (1/3).
Dec 6 2017, 10:12 PM
dylanmckay updated the diff for D37054: Require address space to be specified when creating functions (2/3).
  • Remove the switch table stuff for a later patch
  • Rebased on top of trunk
Dec 6 2017, 10:11 PM
dylanmckay updated the diff for D37052: Add default address space for functions to the data layout (1/3).
  • Remove the switch table stuff for a later patch
  • Rebased on top of trunk
Dec 6 2017, 10:09 PM

Dec 1 2017

dylanmckay abandoned D37053: Insert switch tables into the program memory address space (2/4).

I will focus on setting address space on Functions - later on I will look at switch tables

Dec 1 2017, 3:13 PM
dylanmckay requested changes to D38029: [AVR] Override ParseDirective.

@xiangzhai once the new comments are addressed, this should be good to commit

Dec 1 2017, 1:42 PM
dylanmckay resigned from D37615: [ELF] Implement the relocations of AVR for LLD.
Dec 1 2017, 1:37 PM

Nov 24 2017

dylanmckay committed rL318954: [AVR] Use the short form of 'clr <reg>'.
[AVR] Use the short form of 'clr <reg>'
Nov 24 2017, 7:37 AM
dylanmckay requested changes to D38029: [AVR] Override ParseDirective.
Nov 24 2017, 6:52 AM
dylanmckay added a comment to D38029: [AVR] Override ParseDirective.

Have finished an initial review - change looks pretty good, it should be good to go once my comments are fixed

Nov 24 2017, 6:51 AM

Nov 13 2017

dylanmckay committed rL318134: [AVR] Remove the select-mbb-placement-bug.ll test.
[AVR] Remove the select-mbb-placement-bug.ll test
Nov 13 2017, 8:35 PM

Nov 12 2017

dylanmckay updated the summary of D39946: Relax unaligned access assertion when type is byte aligned.
Nov 12 2017, 9:36 PM