Page MenuHomePhabricator

dylanmckay (Dylan McKay)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 18 2015, 2:21 AM (294 w, 5 d)

Recent Activity

Feb 9 2021

dylanmckay updated the diff for D95664: [AVR] Fix the eliminateCallFramePseudos method so that it always expands STDWSPQRr and STDSPQRr.

Fix an assertion error caused by attempting to get the frame size of non-frame instructions

Feb 9 2021, 5:44 AM · Restricted Project
dylanmckay planned changes to D95664: [AVR] Fix the eliminateCallFramePseudos method so that it always expands STDWSPQRr and STDSPQRr.

I've discovered an issue, this is not yet ready for review.

Feb 9 2021, 4:26 AM · Restricted Project
dylanmckay added a comment to D87631: [AVR] Fix global references to function symbols.

I have applied the code review suggestions and committed this to master in 2ccb941740e608a9cf70a7c5840497149654b0f6.

Feb 9 2021, 3:43 AM · Restricted Project
dylanmckay committed rG2ccb941740e6: [AVR] Fix global references to function symbols (authored by dylanmckay).
[AVR] Fix global references to function symbols
Feb 9 2021, 3:42 AM
dylanmckay closed D87631: [AVR] Fix global references to function symbols.
Feb 9 2021, 3:42 AM · Restricted Project

Feb 4 2021

dylanmckay added inline comments to D96014: Add 'LLVM_DEFAULT_TARGET_TRIPLE' to the documented list of CMake variables.
Feb 4 2021, 10:54 PM · Restricted Project
dylanmckay committed rGb10df8f7a594: [AVR] Fix up a few accidentally-regressed Generic CodeGen tests recently broken (authored by dylanmckay).
[AVR] Fix up a few accidentally-regressed Generic CodeGen tests recently broken
Feb 4 2021, 7:22 AM
dylanmckay committed rG0d890e4ce4f4: [AVR] Add 'XFAIL' to the remaining failing Generic CodeGen tests for AVR (authored by dylanmckay).
[AVR] Add 'XFAIL' to the remaining failing Generic CodeGen tests for AVR
Feb 4 2021, 7:03 AM
dylanmckay committed rG85e8e6246e0f: [AVR] Fix 14 Generic CodeGen tests by making address space explicit or optional (authored by dylanmckay).
[AVR] Fix 14 Generic CodeGen tests by making address space explicit or optional
Feb 4 2021, 7:03 AM
dylanmckay committed rG83e2710eb014: [AVR] Remove an assertion that causes generic CodeGen tests to fail (authored by dylanmckay).
[AVR] Remove an assertion that causes generic CodeGen tests to fail
Feb 4 2021, 5:06 AM
dylanmckay requested review of D96014: Add 'LLVM_DEFAULT_TARGET_TRIPLE' to the documented list of CMake variables.
Feb 4 2021, 4:23 AM · Restricted Project

Feb 1 2021

dylanmckay accepted D95529: [AVR][clang] Fix a bug in AVR toolchain search paths.
Feb 1 2021, 10:05 PM · Restricted Project

Jan 28 2021

dylanmckay requested review of D95664: [AVR] Fix the eliminateCallFramePseudos method so that it always expands STDWSPQRr and STDSPQRr.
Jan 28 2021, 10:35 PM · Restricted Project

Jan 27 2021

dylanmckay accepted D90092: [AVR] Optimize 16-bit int shift.

Looks good to me. Indeed, it is sad this could not be implemented at a higher level but even as is it is a great optimization.

Jan 27 2021, 3:36 AM · Restricted Project

Jan 23 2021

dylanmckay accepted D93976: [AVR] Optimize 16-bit comparison with constant.
Jan 23 2021, 1:52 AM · Restricted Project
dylanmckay accepted D93579: [clang][AVR] Improve avr-ld command line options.

Great patch!

Jan 23 2021, 1:19 AM · Restricted Project
dylanmckay accepted D90678: [AVR] Optimize 8-bit int shift.

Nice work, approved.

Jan 23 2021, 1:15 AM · Restricted Project
dylanmckay accepted D89047: [AVR] Optimize 8-bit logic left/right shifts.
Jan 23 2021, 1:03 AM · Restricted Project

Nov 18 2020

dylanmckay requested changes to D89047: [AVR] Optimize 8-bit logic left/right shifts.

Nice patch, cheers.

Nov 18 2020, 3:15 AM · Restricted Project

Nov 17 2020

dylanmckay accepted D70947: Add a default address space for globals to DataLayout.

@arichardson yup, this is good to go. Thanks for the persistence on this one.

Nov 17 2020, 2:23 AM · Restricted Project

Nov 16 2020

dylanmckay accepted D88658: [AVR] Optimize the 16-bit NEGW pseudo instruction.

Looks good to me, thanks for the patch!

Nov 16 2020, 10:37 PM · Restricted Project
dylanmckay accepted D88410: [clang][AVR] Improve avr-ld command line options.

Looks good to me, thanks for the patch @benshi001

Nov 16 2020, 10:11 PM · Restricted Project

Oct 28 2020

dylanmckay committed rG88b7b76a0b23: [AVR][clang] Pass the address of the data section to the linker for ATmega328 (authored by dylanmckay).
[AVR][clang] Pass the address of the data section to the linker for ATmega328
Oct 28 2020, 10:35 AM
dylanmckay closed D86629: [AVR][clang] Pass the address of the data section to the linker for ATmega328.
Oct 28 2020, 10:35 AM · Restricted Project
dylanmckay accepted D88352: [clang][AVR] Add more devices.

Approved, thanks!

Oct 28 2020, 9:54 AM · Restricted Project
dylanmckay accepted D87968: [AVR] Improve device list.

Approved, thanks for the patch!

Oct 28 2020, 9:54 AM · Restricted Project
dylanmckay added a comment to D86629: [AVR][clang] Pass the address of the data section to the linker for ATmega328.

Regarding TableGen; I would like to send an RFC to llvm-dev to come up with a proper API to expose backend-specific device-specific information and constants to LLVM frontends, as I can imagine that many backends could stand to benefit. I note that there is in general a lot of duplication in individual frontends defining information LLVM already knows about (off the top of my head, inline assembly constraints and registers is one of them but may not easily fit into the paradigm I have in mind).

Oct 28 2020, 9:49 AM · Restricted Project
dylanmckay added inline comments to D86629: [AVR][clang] Pass the address of the data section to the linker for ATmega328.
Oct 28 2020, 9:42 AM · Restricted Project

Oct 27 2020

dylanmckay requested changes to D48803: Place the BlockAddress type in the address space of the containing function.
Oct 27 2020, 4:29 AM · Restricted Project

Sep 30 2020

dylanmckay committed rG1fedd90cc7a8: [AVR] fix interrupt stack pointer restoration (authored by couchand).
[AVR] fix interrupt stack pointer restoration
Sep 30 2020, 10:52 PM
dylanmckay closed D87735: [AVR] fix interrupt stack pointer restoration.
Sep 30 2020, 10:52 PM · Restricted Project
dylanmckay added inline comments to D87631: [AVR] Fix global references to function symbols.
Sep 30 2020, 7:28 AM · Restricted Project
dylanmckay requested changes to D87631: [AVR] Fix global references to function symbols.

Good bugfix - thanks for the second patch!

Sep 30 2020, 7:22 AM · Restricted Project
dylanmckay requested changes to D87634: [AVR] Improve AVR disassembly.

The code is looking nice, thanks for the patch @amikhalev!

Sep 30 2020, 6:54 AM · Restricted Project
dylanmckay accepted D87735: [AVR] fix interrupt stack pointer restoration.

This is a great patch, thanks @couchand!

Sep 30 2020, 5:17 AM · Restricted Project

Sep 21 2020

dylanmckay added a comment to D86629: [AVR][clang] Pass the address of the data section to the linker for ATmega328.

Hey @aykevl, could you please confirm that this patch looks okay?

Sep 21 2020, 1:26 AM · Restricted Project

Aug 27 2020

dylanmckay added inline comments to D84345: [AMDGPU] Set the default globals address space to 1.
Aug 27 2020, 6:01 AM · Restricted Project, Restricted Project
dylanmckay added inline comments to D84345: [AMDGPU] Set the default globals address space to 1.
Aug 27 2020, 6:00 AM · Restricted Project, Restricted Project
dylanmckay requested changes to D78491: Avoid relying on address space zero default parameter in llvm/IR.
Aug 27 2020, 5:36 AM · Restricted Project, Restricted Project
dylanmckay added a comment to D78491: Avoid relying on address space zero default parameter in llvm/IR.

Note to the readers: A recent-ish llvm-dev discussion around this patch can be found in here whrein a consensus is found on the way forward on this patch.

Aug 27 2020, 5:36 AM · Restricted Project, Restricted Project

Aug 26 2020

dylanmckay added inline comments to D70947: Add a default address space for globals to DataLayout.
Aug 26 2020, 9:28 AM · Restricted Project
dylanmckay added a comment to D70947: Add a default address space for globals to DataLayout.

I've split the backwards compat tests and AMDGPU changes out to D84345. Is the DataLayout upgrade what you meant with bitcode compatibility tests or should I be adding additional tests?

Aug 26 2020, 9:26 AM · Restricted Project
dylanmckay accepted D86418: [AVR] Improve inline rotate/shift expansions.

Great patch

Aug 26 2020, 8:59 AM · Restricted Project
dylanmckay requested review of D86629: [AVR][clang] Pass the address of the data section to the linker for ATmega328.
Aug 26 2020, 8:28 AM · Restricted Project

Aug 24 2020

dylanmckay added a comment to D85589: Add support for AVR attiny441 and attiny841.

@ixoo committed in 0f0be3fb8ddeca4bbcffc7b22319254c360ca24b - thanks for the patch!

Aug 24 2020, 1:36 AM · Restricted Project
dylanmckay committed rG0f0be3fb8dde: Add support for AVR attiny441 and attiny841 (authored by ixoo).
Add support for AVR attiny441 and attiny841
Aug 24 2020, 1:36 AM
dylanmckay closed D85589: Add support for AVR attiny441 and attiny841.
Aug 24 2020, 1:36 AM · Restricted Project

Aug 11 2020

dylanmckay accepted D85589: Add support for AVR attiny441 and attiny841.

Looks good, thanks for the patch. Do you need someone to commit this for you @ixoo?

Aug 11 2020, 6:56 AM · Restricted Project
dylanmckay requested changes to D82684: AVR Backend: Add harvard program address space checker pass.
Aug 11 2020, 5:10 AM · Restricted Project
dylanmckay added a comment to D82684: AVR Backend: Add harvard program address space checker pass.

Patch is looking really good, only suggestions are the adding a test and a couple formatting nitpicks.

Aug 11 2020, 5:10 AM · Restricted Project

Jun 23 2020

dylanmckay added inline comments to rGede6005e7092: [AVR] Explicitly set the address of the data section when invoking the linker.
Jun 23 2020, 4:12 AM
dylanmckay committed rG15b9dc46c6d2: Revert "[AVR] Explicitly set the address of the data section when invoking the… (authored by dylanmckay).
Revert "[AVR] Explicitly set the address of the data section when invoking the…
Jun 23 2020, 3:40 AM
dylanmckay added a reverting change for rGede6005e7092: [AVR] Explicitly set the address of the data section when invoking the linker: rG15b9dc46c6d2: Revert "[AVR] Explicitly set the address of the data section when invoking the….
Jun 23 2020, 3:40 AM
dylanmckay added inline comments to rGede6005e7092: [AVR] Explicitly set the address of the data section when invoking the linker.
Jun 23 2020, 3:40 AM
dylanmckay added a comment to D68524: [AVR] Rewrite the function calling convention..

Thanks for the patch @rodrigorc, appreciate it!

Jun 23 2020, 3:08 AM · Restricted Project
dylanmckay added a comment to D68524: [AVR] Rewrite the function calling convention..

Committed in

Jun 23 2020, 3:08 AM · Restricted Project
dylanmckay committed rGb9c26a9cfe53: [AVR] Rewrite the function calling convention. (authored by dylanmckay).
[AVR] Rewrite the function calling convention.
Jun 23 2020, 2:37 AM
dylanmckay closed D68524: [AVR] Rewrite the function calling convention..
Jun 23 2020, 2:37 AM · Restricted Project

Jun 19 2020

dylanmckay added a comment to D68524: [AVR] Rewrite the function calling convention..

Rebased version with @Sh4rK's comments fixed.

Jun 19 2020, 9:44 AM · Restricted Project
dylanmckay added a comment to D68524: [AVR] Rewrite the function calling convention..

@Sh4rK your review is always welcome - I've updated the code with your comments, here's the delta containing just the fixes you've suggested.

Jun 19 2020, 9:44 AM · Restricted Project
dylanmckay added a comment to D68524: [AVR] Rewrite the function calling convention..

This conflicts with master now, he's a rebased patch

Jun 19 2020, 6:59 AM · Restricted Project

Jun 18 2020

dylanmckay committed rG01741d6dbec1: [AVR] Remove duplicate specification of lib directory (authored by dylanmckay).
[AVR] Remove duplicate specification of lib directory
Jun 18 2020, 10:52 PM
dylanmckay committed rGaeaa09ec10ee: Revert "[AVR] Remove duplicate specification of lib directory" (authored by dylanmckay).
Revert "[AVR] Remove duplicate specification of lib directory"
Jun 18 2020, 10:52 PM
dylanmckay added a reverting change for rG03b0831144a9: [AVR] Remove duplicate specification of lib directory: rGaeaa09ec10ee: Revert "[AVR] Remove duplicate specification of lib directory".
Jun 18 2020, 10:52 PM
dylanmckay committed rG03b0831144a9: [AVR] Remove duplicate specification of lib directory (authored by dylanmckay).
[AVR] Remove duplicate specification of lib directory
Jun 18 2020, 10:52 PM
dylanmckay closed D77334: [AVR] Remove duplicate specification of lib directory.
Jun 18 2020, 10:52 PM · Restricted Project
dylanmckay added a comment to D77334: [AVR] Remove duplicate specification of lib directory.

Sorry, I lost track of this. Committed in 01741d6dbec11c0a0c8e610f0033831735c78d1e

Jun 18 2020, 10:51 PM · Restricted Project
dylanmckay accepted D82088: [AVR] Disassemble instructions with fixed Z operand.

Note: I don't know whether the way I've made the Z register printable is the correct way. Maybe the register should be added to the MCInst instead.

Jun 18 2020, 10:51 PM · Restricted Project
dylanmckay accepted D82093: [AVR] Disassemble double register instructions.
Jun 18 2020, 10:20 PM · Restricted Project
dylanmckay accepted D81971: [AVR] Disassemble multiplication instructions.
Jun 18 2020, 10:20 PM · Restricted Project
dylanmckay accepted D81968: [AVR] Decode single register instructions.
Jun 18 2020, 10:20 PM · Restricted Project
dylanmckay accepted D78459: [AVR] Don't adjust for instruction size.
Jun 18 2020, 10:20 PM · Restricted Project
dylanmckay accepted D78439: [AVR] Fix miscompilation of zext + add.

Good reproduction, works exactly as expected and indeed this value is being miscalculated.

Jun 18 2020, 4:52 AM · Restricted Project

Jun 17 2020

dylanmckay requested changes to D81968: [AVR] Decode single register instructions.
Jun 17 2020, 11:11 PM · Restricted Project
dylanmckay requested changes to D81971: [AVR] Disassemble multiplication instructions.

Couple of nitpicks, otherwise good to go.

Jun 17 2020, 11:11 PM · Restricted Project
dylanmckay accepted D81961: [AVR] Implement disassembly of 32-bit instructions.
Jun 17 2020, 11:11 PM · Restricted Project

Jun 16 2020

dylanmckay accepted D78581: [AVR] Remove faulty stack pushing behavior.

This is good, this is good. Nice work @aykevl, approved.

Jun 16 2020, 4:58 AM · Restricted Project
dylanmckay accepted D78579: [AVR] Fix stack size in functions with a frame pointer.

Added an integration test case

Jun 16 2020, 4:23 AM · Restricted Project

Jun 14 2020

dylanmckay added a comment to D78459: [AVR] Don't adjust for instruction size.

Also, you may already know about it but if not, the LLVM bugpoint tool can usually heavily reduce testcase size. I usually get 99% cutdown from some of the larger IR files. If the file must be large though, it must be large (as some tests are) so let's add it anyway.

Jun 14 2020, 4:17 AM · Restricted Project
dylanmckay added a comment to D78459: [AVR] Don't adjust for instruction size.

Ok, I can add the test case (need to recompile LLVM first). It just seems a bit large to me (over 1000 lines).

Jun 14 2020, 4:17 AM · Restricted Project

Jun 8 2020

dylanmckay accepted D81099: [AVR][test] Remove test for naked function containing a return..
Jun 8 2020, 11:25 PM · Restricted Project

May 31 2020

dylanmckay requested changes to D78741: [LLD][ELF][AVR] Implement the missing relocation types.
May 31 2020, 5:19 AM · Restricted Project, lld
dylanmckay added a comment to D78741: [LLD][ELF][AVR] Implement the missing relocation types.

I've checked over all of the relocation logic, cross referenced with both the AVR ISA manual and the AVR LLVM fixture implementations in AVRAsmBackend.cpp - everything looks consistent to me.

May 31 2020, 5:19 AM · Restricted Project, lld
dylanmckay requested changes to D78459: [AVR] Don't adjust for instruction size.
May 31 2020, 4:47 AM · Restricted Project
dylanmckay requested changes to D70947: Add a default address space for globals to DataLayout.
May 31 2020, 4:47 AM · Restricted Project
dylanmckay added a comment to D78459: [AVR] Don't adjust for instruction size.

Are you planning on adding these integration tests to the LLVM buildbot or something more manual?

May 31 2020, 4:47 AM · Restricted Project
dylanmckay added a comment to D78459: [AVR] Don't adjust for instruction size.

Added an integration test for this and verified that the test does indeed miscompile and crash the AVR simulator before the patch, but work correctly afterwards. The testcase output is also consistent with AVR-GCC.

May 31 2020, 4:47 AM · Restricted Project

May 30 2020

dylanmckay added inline comments to D78459: [AVR] Don't adjust for instruction size.
May 30 2020, 7:05 PM · Restricted Project

May 17 2020

dylanmckay committed rGede6005e7092: [AVR] Explicitly set the address of the data section when invoking the linker (authored by dylanmckay).
[AVR] Explicitly set the address of the data section when invoking the linker
May 17 2020, 7:27 AM
dylanmckay committed rG1420f4efbe7c: [AVR] Fix I/O instructions on XMEGA (authored by dylanmckay).
[AVR] Fix I/O instructions on XMEGA
May 17 2020, 1:01 AM
dylanmckay committed rG1335737ee119: [LLVM][AVR] Support for R_AVR_6 fixup (authored by dylanmckay).
[LLVM][AVR] Support for R_AVR_6 fixup
May 17 2020, 1:01 AM
dylanmckay closed D78721: [LLVM][AVR] Support for R_AVR_6 fixup.
May 17 2020, 1:01 AM · Restricted Project
dylanmckay closed D77207: [AVR] Fix I/O instructions on XMEGA.
May 17 2020, 1:01 AM · Restricted Project
dylanmckay added a comment to D78721: [LLVM][AVR] Support for R_AVR_6 fixup.

@LemonBoy merged in into master in 1335737ee119b59bc25ee6d1bb200cf3b975e196

May 17 2020, 1:01 AM · Restricted Project
dylanmckay added a comment to D77207: [AVR] Fix I/O instructions on XMEGA.

@vlastik Merged into master in 1420f4efbe7ca34355b2dd85d396197d92cd5e3f.

May 17 2020, 1:01 AM · Restricted Project

May 16 2020

dylanmckay added a comment to D77221: [AVR] Rework MCU family detection to support more AVR MCUs.

A thought: should the AVR family be included in the target triple? Like avr5-unknown-unknown (similar to armv6m-none-eabi, armv7m-none-eabi, etc).
The different variations do sometimes change the architecture in incompatible ways, such as with the call instruction which pushes a return address of two or three bytes depending on the architecture variant (and thus makes it impossible to pass parameters on the stack reliably).

May 16 2020, 9:44 PM · Restricted Project, Restricted Project
dylanmckay added a comment to D78741: [LLD][ELF][AVR] Implement the missing relocation types.

Good question, I wasn't able to find any document online.
All the info I've used come from this ISA manual and by feeding some asm into ld to see if the result matched my expectations.

May 16 2020, 8:40 PM · Restricted Project, lld
dylanmckay requested changes to D78491: Avoid relying on address space zero default parameter in llvm/IR.
May 16 2020, 8:40 PM · Restricted Project, Restricted Project
Herald added a project to D78491: Avoid relying on address space zero default parameter in llvm/IR: Restricted Project.

I really like the idea behind this patch, but I suspect there is a better way to go about it.

May 16 2020, 8:40 PM · Restricted Project, Restricted Project
dylanmckay added a comment to D78459: [AVR] Don't adjust for instruction size.

Hey @aykevl, I like this patch, it definitely removes a special cases that intuitively feels like it should not need to be there. Nice work

May 16 2020, 8:08 PM · Restricted Project