[MC][COFF][AArch64] Fix the storage class for private linkage symbols.

[hjyamauchi]

Summary

Use IMAGE_SYM_CLASS_STATIC like X86.

[MaskRay]

CodeGen tests usually go to test/CodeGen/

-filetype=asm is the default output for llc and is usually omitted.

[hjyamauchi]

Moved the test to test/CodeGen and removed the -filetype=asm flag.

PTAL.

[compnerd]

Thank you for fixing this!

llvm/lib/Target/AArch64/AArch64AsmPrinter.cpp

public:
 
   bool runOnMachineFunction(MachineFunction &MF) override {
     AArch64FI = MF.getInfo<AArch64FunctionInfo>();
     STI = &MF.getSubtarget<AArch64Subtarget>();
 
     SetupMachineFunction(MF);
 
     if (STI->isTargetCOFF()) {
-      bool Internal = MF.getFunction().hasInternalLinkage();
-      COFF::SymbolStorageClass Scl = Internal ? COFF::IMAGE_SYM_CLASS_STATIC
-                                              : COFF::IMAGE_SYM_CLASS_EXTERNAL;
+      bool Local = MF.getFunction().hasLocalLinkage();
+      COFF::SymbolStorageClass Scl = Local ? COFF::IMAGE_SYM_CLASS_STATIC
       int Type =
         COFF::IMAGE_SYM_DTYPE_FUNCTION << COFF::SCT_COMPLEX_TYPE_SHIFT;
 
       OutStreamer->beginCOFFSymbolDef(CurrentFnSym);
       OutStreamer->emitCOFFSymbolStorageClass(Scl);
       OutStreamer->emitCOFFSymbolType(Type);
       OutStreamer->endCOFFSymbolDef();
     }

llvm/test/MC/COFF/local-sym-storage-class.ll

+; RUN: llc -mtriple aarch64-unknown-windows-msvc -filetype=asm %s -o - | FileCheck %s
+; RUN: llc -mtriple x86_64-unknown-windows-msvc -filetype=asm %s -o - | FileCheck %s
+
+define void @main() {
+  call void @internal()
+  call void @private()
+  ret void
+}
+
+define internal void @internal() {
+  ret void
+}
+
+define private void @private() {
+  ret void
+}
+
+; Check that the internal and private linkage symbols have IMAGE_SYM_CLASS_STATIC (3).
+; CHECK: .def    internal;
+; CHECK: .scl    3;
+; CHECK: .def    .Lprivate;
+; CHECK: .scl    3;