This is an archive of the discontinued LLVM Phabricator instance.

[Libomptarget] Disable deadlocking bug49334.cpp test on AMDGPU
ClosedPublic

Authored by jhuber6 on Aug 16 2023, 7:12 AM.

Diff Detail

Event Timeline

jhuber6 created this revision.Aug 16 2023, 7:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 16 2023, 7:12 AM
jhuber6 requested review of this revision.Aug 16 2023, 7:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 16 2023, 7:12 AM
This revision is now accepted and ready to land.Aug 16 2023, 7:22 AM

Hmm, I remember this test was disabled before right?

Hmm, I remember this test was disabled before right?

I believe Johannes re-enabled it last month and people forgot about this one deadlocking ocassionally.

arsenm added a subscriber: arsenm.Aug 16 2023, 7:50 AM
arsenm added inline comments.
openmp/libomptarget/test/offloading/bug49334.cpp
8–15

So where does it work? Might as well just make it universally unsupported?

jhuber6 added inline comments.Aug 16 2023, 7:50 AM
openmp/libomptarget/test/offloading/bug49334.cpp
8–15

Supposedly it works on Nvidia, but the state of the Nvidia tests is questionable right now due to no bots in production.

jhuber6 updated this revision to Diff 550766.Aug 16 2023, 8:17 AM

Apparently these don't work on Nvidia either, so just turn it off for everything.