This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Replace fabs and copysign libcalls with intrinsics
ClosedPublic

Authored by arsenm on Aug 14 2023, 7:45 AM.

Details

Reviewers
rampitec
foad
jmmartinez
cdevadas
Pierre-vh
Group Reviewers
Restricted Project
Summary

Preserves flags and metadata like the other cases.

Diff Detail

Event Timeline

arsenm created this revision.Aug 14 2023, 7:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 14 2023, 7:45 AM
arsenm requested review of this revision.Aug 14 2023, 7:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 14 2023, 7:46 AM
Herald added a subscriber: wdng. · View Herald Transcript

Why does it need strict-fp? Isn't it defined as just a bit operation?

Why does it need strict-fp? Isn't it defined as just a bit operation?

It doesn't, that's why it's allowed here unlike the other cases

rampitec accepted this revision.Aug 14 2023, 10:51 AM

Why does it need strict-fp? Isn't it defined as just a bit operation?

It doesn't, that's why it's allowed here unlike the other cases

Ough, I see. LGTM.

This revision is now accepted and ready to land.Aug 14 2023, 10:51 AM