This is an archive of the discontinued LLVM Phabricator instance.

[BOLT][DWARF] Always use new low_pc for call_site
ClosedPublic

Authored by ayermolo on Aug 7 2023, 8:33 PM.

Details

Summary

Changed to creating a new index all the time. This code was legacy of when we
couldn't change the size of .debug_info, and led to subtle bugs where index for
new entries was pointing to a wrong address.

Diff Detail

Event Timeline

ayermolo created this revision.Aug 7 2023, 8:33 PM
Herald added a reviewer: Amir. · View Herald Transcript
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
ayermolo requested review of this revision.Aug 7 2023, 8:33 PM
Herald added a project: Restricted Project. · View Herald Transcript
Amir accepted this revision.Aug 8 2023, 2:45 PM

Looks sane/safe.

This revision is now accepted and ready to land.Aug 8 2023, 2:45 PM
This revision was automatically updated to reflect the committed changes.