This is an archive of the discontinued LLVM Phabricator instance.

[benchmark] Refresh `benchmark` from upstream
Needs ReviewPublic

Authored by mtrofin on Aug 4 2023, 7:58 AM.

Details

Summary

This is a complete pull from upstream using the third-party/update_benchmark.sh script.

Main motivation is addressing #64417. The requirements.txt file has
been moved to third-party/benchmark/tools/requirements.txt, and is
reduced to:

numpy == 1.25
scipy == 1.10.0

achieving the desired effect - bumping the numpy and scipy versions. The
pandas dependency was removed.

cherrypicked a31e2859a8229af3574ab2e931624b7c15551fb8

Diff Detail

Event Timeline

mtrofin created this revision.Aug 4 2023, 7:58 AM
mtrofin requested review of this revision.Aug 4 2023, 7:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2023, 7:58 AM

@aaron.ballman could your MSVC codecvt be committed upstream in benchmark?

@Ericson2314, FYI - I realize your CMAKE_INSTALL_LIBDIR change was reverted, but could it have been made in upstream?

@thieta - probably the python reformat should exclude third_party?

Thanks for upgrading the Google benchmark library!

Unfortunately, I cannot help reviewing this.
But on a high-level, I second your proposals: I think third-party code should be excluded from formatting and patches should be upstreamed as much as possible

@aaron.ballman could your MSVC codecvt be committed upstream in benchmark?

I have no issues if someone wants to lift it into upstream, but I don't know that I'll have the bandwidth to do it myself (I see that the project requires a CLA which means I have to get lawyers involved, so it's not a quick thing for me to work on).

third-party/benchmark/src/reporter.cc