This is an archive of the discontinued LLVM Phabricator instance.

[Clang] Fix Offloading related tests after D156363
ClosedPublic

Authored by jhuber6 on Aug 2 2023, 11:39 AM.

Details

Summary

This patch fixes failing tests after checking the return code from the
driver. This is mostly due to the ROCm libraries not being present
during most compilations. Passing -nogpuinc should allow us to compile
without it for tests that require it. Additionally, some old tests set
the architecture of Nvidia tests to sm_35 which is officially
unsupported in CUDA 12+ so it prints an error. We just increase in this
case.

Diff Detail

Event Timeline

jhuber6 created this revision.Aug 2 2023, 11:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 2 2023, 11:39 AM
jhuber6 requested review of this revision.Aug 2 2023, 11:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 2 2023, 11:39 AM
MaskRay accepted this revision.Aug 2 2023, 12:00 PM

Thanks! I guess --rocm-path= can be used in some places, but -nogpulib -nogpuinc is good as well.

This revision is now accepted and ready to land.Aug 2 2023, 12:00 PM
yaxunl accepted this revision.Aug 2 2023, 12:01 PM

LGTM. Thanks.

This revision was landed with ongoing or failed builds.Aug 2 2023, 12:35 PM
This revision was automatically updated to reflect the committed changes.