This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Change OpenMP default version in documentation and help text for -fopenmp-version
ClosedPublic

Authored by AntonRydahl on Aug 2 2023, 7:41 AM.

Details

Summary

As discussed on the weekly OpenMP meeting on the second of August 2023, the default version
in the OpenMP documentation shoud be changed from OpenMP 5.0 to 5.1.

Diff Detail

Event Timeline

AntonRydahl created this revision.Aug 2 2023, 7:41 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
AntonRydahl requested review of this revision.Aug 2 2023, 7:41 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 2 2023, 7:41 AM
tianshilei1992 added inline comments.
flang/test/Driver/driver-help.f90
55

Does Flang also switch to 5.1 by default?

I was a bit too fast. I changed OpenMPSupport.rst to point to both the OpenMP 5.0 and OpenMP 5.1 implementation status.

AntonRydahl added inline comments.Aug 2 2023, 7:57 AM
flang/test/Driver/driver-help.f90
55

As far as I know, flang is still OpenMP 1.1 by default but still depends on the same command line options as clang.

AntonRydahl retitled this revision from [OpenMP] Change OpenMP default version in documentation and help text for --fopenmp-version to [OpenMP] Change OpenMP default version in documentation and help text for -fopenmp-version.Aug 2 2023, 7:59 AM
clementval added inline comments.
flang/test/Driver/driver-help.f90
55

flang does not differentiate between versions.

tianshilei1992 added inline comments.Aug 2 2023, 12:45 PM
flang/test/Driver/driver-help.f90
55

I see.

jdoerfert added inline comments.Aug 2 2023, 2:47 PM
flang/test/Driver/driver-help.f90
55

I would remove the flang part of the wording for now.

clementval added inline comments.Aug 2 2023, 2:50 PM
flang/test/Driver/driver-help.f90
55

+1

Removing information about Flang default version of OpenMP.

The unit test that fails, flang/test/Driver/omp-driver-offload.f90, also fails on main. I don't see that it should be related to this patch.

flang/test/Driver/driver-help.f90
55

Thanks a lot for pointing this out. Is the new hep text fine?

Removed whitespace that caused CI tests to fail.

Rebased on main.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 28 2023, 7:09 PM
This revision was automatically updated to reflect the committed changes.