This is an archive of the discontinued LLVM Phabricator instance.

[CUDA][HIP] Reorganize options for documentation
ClosedPublic

Authored by yaxunl on Aug 2 2023, 6:21 AM.

Details

Summary

Reorganize options and group them as "Common Offloading flags", "CUDA flags" and "HIP flags", so that they will be grouped together like "OpenCL flags" and "SYCL flags" in https://clang.llvm.org/docs/ClangCommandLineReference.html

Diff Detail

Event Timeline

yaxunl created this revision.Aug 2 2023, 6:21 AM
yaxunl requested review of this revision.Aug 2 2023, 6:21 AM
jhuber6 accepted this revision.Aug 2 2023, 6:23 AM

I think this is good, there's been some confusion around which ones goes to what.

clang/include/clang/Driver/Options.td
1021

Can you fix this copy paste error while you're here?

This revision is now accepted and ready to land.Aug 2 2023, 6:23 AM
MaskRay accepted this revision.Aug 2 2023, 8:26 AM
MaskRay added inline comments.
clang/include/clang/Driver/Options.td
155

The existing flags uses are misnomer (Flag does not accept values). Perhaps use options for new option groups.

yaxunl marked 2 inline comments as done.Aug 4 2023, 2:11 PM
yaxunl added inline comments.
clang/include/clang/Driver/Options.td
155

will do

1021

It has been fixed in the trunk.

This revision was landed with ongoing or failed builds.Aug 4 2023, 2:24 PM
This revision was automatically updated to reflect the committed changes.
yaxunl marked 2 inline comments as done.
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2023, 2:24 PM