The target should not have to construct MachineIRBuilders during
RegBankSelect (we should perhaps hide the constructors for it). The
pass should own the builder setup with the desired CSE configuration
(although currently the pass does not use the CSE builder, which is
what I want to fix).
Details
Details
Diff Detail
Diff Detail
Unit Tests
Unit Tests
Time | Test | |
---|---|---|
260 ms | x64 debian > LLVM.CodeGen/RISCV::attributes.ll |
Event Timeline
llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.h | ||
---|---|---|
56–58 | Could we make the builder a member of the class? |
llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.h | ||
---|---|---|
56–58 | This is owned by the subtarget and shouldn’t be stateful. All the methods should be const |
llvm/include/llvm/CodeGen/GlobalISel/LegalizerHelper.h | ||
---|---|---|
25 ↗ | (On Diff #544895) | This include shouldn't be necessary |
Could we make the builder a member of the class?