This is an archive of the discontinued LLVM Phabricator instance.

ValueTracking: Fix computeKnownFPClass canonicalize handling
ClosedPublic

Authored by arsenm on Jul 17 2023, 4:01 AM.

Details

Summary

This mostly manifested as broken constant folding. This was
mishandling the dynamic denormal mode. It was also mishandling literal
signaling nans as always poison.

Diff Detail

Event Timeline

arsenm created this revision.Jul 17 2023, 4:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 17 2023, 4:01 AM
arsenm requested review of this revision.Jul 17 2023, 4:01 AM
Herald added a reviewer: sstefan1. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: wdng. · View Herald Transcript
foad added a comment.Jul 18 2023, 12:14 AM

It was also mishandling literal signaling nans as always poison.

I don't see anything in this patch related to constants or poison.

foad accepted this revision.Jul 18 2023, 12:22 AM

Code LGTM.

This revision is now accepted and ready to land.Jul 18 2023, 12:22 AM

It was also mishandling literal signaling nans as always poison.

I don't see anything in this patch related to constants or poison.

Constants were just demonstrating the issue, with output that could only be poison since the returned constant violated the reported class