This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Add test for vmerge combine that should be prevented
ClosedPublic

Authored by luke on Jul 11 2023, 9:24 AM.

Details

Summary

The fadd in these test cases is constrained and may set fflags differently
depending on the active elements (the nofpexcept flag isn't set on the node).
Therefore to preserve semantics we shouldn't change its mask.

Diff Detail

Event Timeline

luke created this revision.Jul 11 2023, 9:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2023, 9:24 AM
luke requested review of this revision.Jul 11 2023, 9:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2023, 9:24 AM
reames accepted this revision.Jul 12 2023, 5:18 PM

LGTM w/comment.

llvm/test/CodeGen/RISCV/rvv/rvv-peephole-vmerge-vops.ll
382

Add a bit to the comment to emphasize that suppressing exceptions is also disallowed by "fpexcept.strict". Removing exceptions is fine under both ignore and maytrap, so it's good to emphasize that bit of the semantic.

This revision is now accepted and ready to land.Jul 12 2023, 5:18 PM
This revision was automatically updated to reflect the committed changes.