This is an archive of the discontinued LLVM Phabricator instance.

Differential D154859

[OpenMP] Fix note section type notation for AArch64
ClosedPublic

Authored by cseo on Jul 10 2023, 9:30 AM.

Details

Reviewers
jdoerfert
tianshilei1992
Commits
rGd9a2b83dcd93: [OpenMP] Fix note section type notation for AArch64
Summary

Like Arm, AArch64 also uses "%" instead of "@" for note section types.

Diff Detail

Event Timeline

cseo created this revision.Jul 10 2023, 9:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 10 2023, 9:30 AM
Herald added subscribers: sunshaoce, guansong, kristof.beyls, yaxunl. · View Herald Transcript
cseo requested review of this revision.Jul 10 2023, 9:30 AM
Herald added a reviewer: jdoerfert. · View Herald TranscriptJul 10 2023, 9:30 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: openmp-commits, jplehr, sstefan1. · View Herald Transcript
tianshilei1992 accepted this revision.Jul 10 2023, 9:32 AM
This revision is now accepted and ready to land.Jul 10 2023, 9:32 AM
Harbormaster completed remote builds in B244184: Diff 538697.Jul 10 2023, 9:33 AM
Closed by commit rGd9a2b83dcd93: [OpenMP] Fix note section type notation for AArch64 (authored by cseo). · Explain WhyJul 10 2023, 10:22 AM
This revision was automatically updated to reflect the committed changes.
cseo added a commit: rGd9a2b83dcd93: [OpenMP] Fix note section type notation for AArch64.

Revision Contents

PathSize
openmp/
runtime/
src/
2 lines

Diff 538720

openmp/runtime/src/z_Linux_asm.S

Show First 20 Lines • Show All 2,085 Lines • ▼ Show 20 LinesKMP_PREFIX_UNDERSCORE(__kmp_unnamed_critical_addr):
.8byte .gomp_critical_user_ .8byte .gomp_critical_user_
#ifdef __ELF__ #ifdef __ELF__
.size KMP_PREFIX_UNDERSCORE(__kmp_unnamed_critical_addr),8 .size KMP_PREFIX_UNDERSCORE(__kmp_unnamed_critical_addr),8
#endif #endif
#endif /* KMP_ARCH_PPC64 || KMP_ARCH_AARCH64 || KMP_ARCH_MIPS64 || #endif /* KMP_ARCH_PPC64 || KMP_ARCH_AARCH64 || KMP_ARCH_MIPS64 ||
KMP_ARCH_RISCV64 || KMP_ARCH_LOONGARCH64 */ KMP_ARCH_RISCV64 || KMP_ARCH_LOONGARCH64 */
#if KMP_OS_LINUX #if KMP_OS_LINUX
# if KMP_ARCH_ARM # if KMP_ARCH_ARM || KMP_ARCH_AARCH64
.section .note.GNU-stack,"",%progbits .section .note.GNU-stack,"",%progbits
# else # else
.section .note.GNU-stack,"",@progbits .section .note.GNU-stack,"",@progbits
# endif # endif
#endif #endif