Details
Diff Detail
- Repository
- rZORG LLVM Github Zorg
- Build Status
Buildable 242922 Build 377101: arc lint + arc unit
Event Timeline
buildbot/osuosl/master/config/builders.py | ||
---|---|---|
859 | Something smells off, but this is not my area of expertise so I could be wrong. We're not checking out compiler-rt, but below we have: |
buildbot/osuosl/master/config/builders.py | ||
---|---|---|
859 | It does look strange, although the same configuration works well under linux builder. Let us modify one line and run the test? what do you think? |
buildbot/osuosl/master/config/builders.py | ||
---|---|---|
859 | I think you should try changing checkout_compiler_rt= to True and see if the full test suite still passes for you. |
buildbot/osuosl/master/config/builders.py | ||
---|---|---|
860 | I think this still needs to be set to True so that we check out the latest compiler-rt, since we're enabling the runtime for it below. |
buildbot/osuosl/master/config/builders.py | ||
---|---|---|
860 | In our email thread we agree that “compiler-rt“ should be removed from the LLVM_ENABLE_PROJECTS option. So check_compiler_rt has to be False. Otherwise, "compiler-t" will be added to LLVM_ENABLE_PROJECTS option. |
buildbot/osuosl/master/config/builders.py | ||
---|---|---|
860 |
Huh, that seems surprising to me. My understanding is that compiler-rt should never be added to LLVM_ENABLE_PROJECTS, it should only be added to LLVM_ENABLE_RUNTIMES to enable it. And if we're enabling it, we should be checking out the latest version so it's in step with changes to Clang. CC @phosek for additional insights on the CMake incantations. |
Hi Yin,
I'm confused. There are multiple reviews for the same patch or very similar patches. Some already have been reviewed. Could you mark abandoned those you do not need any more and have a single one for the review, please?
I tried different ways to revert the patch to last good commit, 540863.
But not wure why it still bring up huge difference within the patch.
So this one should be closed and I will submit a new one later.
Very sorry for inconvenient due to my experience on arc related commands.
Something smells off, but this is not my area of expertise so I could be wrong. We're not checking out compiler-rt, but below we have:
"-DLLVM_ENABLE_RUNTIMES=compiler-rt", which seems like a conflict.