This is an archive of the discontinued LLVM Phabricator instance.

Support Windows test
Needs ReviewPublic

Authored by yinyangsx on Jul 3 2023, 7:44 PM.

Event Timeline

yinyangsx created this revision.Jul 3 2023, 7:44 PM
Herald added a project: Restricted Project. · View Herald Transcript
yinyangsx requested review of this revision.Jul 3 2023, 7:44 PM
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added inline comments.
buildbot/osuosl/master/config/builders.py
859

Something smells off, but this is not my area of expertise so I could be wrong. We're not checking out compiler-rt, but below we have:
"-DLLVM_ENABLE_RUNTIMES=compiler-rt", which seems like a conflict.

yinyangsx added inline comments.Jul 6 2023, 11:34 PM
buildbot/osuosl/master/config/builders.py
859

It does look strange, although the same configuration works well under linux builder. Let us modify one line and run the test? what do you think?

aaron.ballman added inline comments.Jul 7 2023, 4:38 AM
buildbot/osuosl/master/config/builders.py
859

I think you should try changing checkout_compiler_rt= to True and see if the full test suite still passes for you.

Support Windows test

aaron.ballman added inline comments.Jul 17 2023, 10:51 AM
buildbot/osuosl/master/config/builders.py
860

I think this still needs to be set to True so that we check out the latest compiler-rt, since we're enabling the runtime for it below.

yinyangsx added inline comments.Jul 17 2023, 6:29 PM
buildbot/osuosl/master/config/builders.py
860

In our email thread we agree that “compiler-rt“ should be removed from the LLVM_ENABLE_PROJECTS option. So check_compiler_rt has to be False. Otherwise, "compiler-t" will be added to LLVM_ENABLE_PROJECTS option.

aaron.ballman added inline comments.
buildbot/osuosl/master/config/builders.py
860

In our email thread we agree that “compiler-rt“ should be removed from the LLVM_ENABLE_PROJECTS option. So check_compiler_rt has to be False. Otherwise, "compiler-t" will be added to LLVM_ENABLE_PROJECTS option.

Huh, that seems surprising to me. My understanding is that compiler-rt should never be added to LLVM_ENABLE_PROJECTS, it should only be added to LLVM_ENABLE_RUNTIMES to enable it. And if we're enabling it, we should be checking out the latest version so it's in step with changes to Clang.

CC @phosek for additional insights on the CMake incantations.

Hi Yin,

I'm confused. There are multiple reviews for the same patch or very similar patches. Some already have been reviewed. Could you mark abandoned those you do not need any more and have a single one for the review, please?

DoyleLi updated this revision to Diff 551000.Aug 16 2023, 10:35 PM
  • Resolve issues for missing files lib/clang/18/lib/windows/liborc_rt-x86_64.a
DoyleLi updated this revision to Diff 551002.Aug 16 2023, 10:42 PM

Revert the head commit of D154406

DoyleLi updated this revision to Diff 551005.Aug 16 2023, 11:05 PM

Revert to last good commit.

I tried different ways to revert the patch to last good commit, 540863.
But not wure why it still bring up huge difference within the patch.
So this one should be closed and I will submit a new one later.
Very sorry for inconvenient due to my experience on arc related commands.

DoyleLi updated this revision to Diff 551010.Aug 16 2023, 11:23 PM

Try to rever to last good commit, 540863

zorg/jenkins/jobs/jobs/lldb-cmake-matrix